Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package kfilemetadata5 for openSUSE:Factory checked in at 2021-06-16 20:33:53 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kfilemetadata5 (Old) and /work/SRC/openSUSE:Factory/.kfilemetadata5.new.32437 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kfilemetadata5" Wed Jun 16 20:33:53 2021 rev:97 rq:899733 version:5.83.0 Changes: -------- --- /work/SRC/openSUSE:Factory/kfilemetadata5/kfilemetadata5.changes 2021-05-10 15:37:04.818109788 +0200 +++ /work/SRC/openSUSE:Factory/.kfilemetadata5.new.32437/kfilemetadata5.changes 2021-06-16 20:35:26.723182071 +0200 @@ -1,0 +2,18 @@ +Sat Jun 5 11:58:47 UTC 2021 - Christophe Giboudeaux <christo...@krop.fr> + +- Update to 5.83.0 + * New feature release + * For more details please see: + * https://kde.org/announcements/frameworks/5/5.83.0 +- Changes since 5.82.0: + * Bump required CMake version to 3.16 + * Call ki18n_install() unconditionally + * [ExtractionResult] Remove automatic mimetype determination + * [ExternalWriter] Test property serialization + * [ExternalExtractor/Writer] Avoid unnecessary map value lookup from key + * [ExternalWriter] Fix infinite loop when serializing properties + * Avoid leaking a QObject in ExternalWriter + * [TaglibExtractor] Rename ASF test case to WMA + * [TaglibWriter] Fix memory leak when updating Cover images in ASF (WMA) + +------------------------------------------------------------------- Old: ---- kfilemetadata-5.82.0.tar.xz kfilemetadata-5.82.0.tar.xz.sig New: ---- kfilemetadata-5.83.0.tar.xz kfilemetadata-5.83.0.tar.xz.sig ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kfilemetadata5.spec ++++++ --- /var/tmp/diff_new_pack.iI3px3/_old 2021-06-16 20:35:27.223182924 +0200 +++ /var/tmp/diff_new_pack.iI3px3/_new 2021-06-16 20:35:27.227182931 +0200 @@ -16,7 +16,7 @@ # -%define _tar_path 5.82 +%define _tar_path 5.83 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) @@ -24,7 +24,7 @@ %bcond_without ffmpeg %bcond_without lang Name: kfilemetadata5 -Version: 5.82.0 +Version: 5.83.0 Release: 0 Summary: Library for extracting Metadata License: GPL-2.0-or-later AND LGPL-2.1-or-later AND LGPL-3.0-only ++++++ kfilemetadata-5.82.0.tar.xz -> kfilemetadata-5.83.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.82.0/.gitignore new/kfilemetadata-5.83.0/.gitignore --- old/kfilemetadata-5.82.0/.gitignore 2021-05-01 14:33:36.000000000 +0200 +++ new/kfilemetadata-5.83.0/.gitignore 2021-06-05 11:17:35.000000000 +0200 @@ -26,3 +26,4 @@ .clangd .idea /cmake-build* +.cache diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.82.0/CMakeLists.txt new/kfilemetadata-5.83.0/CMakeLists.txt --- old/kfilemetadata-5.82.0/CMakeLists.txt 2021-05-01 14:33:36.000000000 +0200 +++ new/kfilemetadata-5.83.0/CMakeLists.txt 2021-06-05 11:17:35.000000000 +0200 @@ -1,11 +1,11 @@ -cmake_minimum_required(VERSION 3.5) +cmake_minimum_required(VERSION 3.16) -set(KF_VERSION "5.82.0") # handled by release scripts -set(KF_DEP_VERSION "5.82.0") # handled by release scripts +set(KF_VERSION "5.83.0") # handled by release scripts +set(KF_DEP_VERSION "5.83.0") # handled by release scripts project(KFileMetaData VERSION ${KF_VERSION}) include(FeatureSummary) -find_package(ECM 5.82.0 NO_MODULE) +find_package(ECM 5.83.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://commits.kde.org/extra-cmake-modules";) feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) @@ -119,7 +119,6 @@ add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050e00) # TODO look into the QMap::insertMulti usage add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x055100) add_definitions(-DTRANSLATION_DOMAIN=\"kfilemetadata5\") -add_definitions(-DQT_NO_FOREACH) add_subdirectory(src) if (BUILD_TESTING) add_subdirectory(autotests) @@ -129,9 +128,7 @@ # Config files set(CMAKECONFIG_INSTALL_DIR "${KDE_INSTALL_CMAKEPACKAGEDIR}/KF5FileMetaData") -if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po") - ki18n_install(po) -endif() +ki18n_install(po) if (BUILD_QCH) ecm_install_qch_export( diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.82.0/autotests/externalwritertest.cpp new/kfilemetadata-5.83.0/autotests/externalwritertest.cpp --- old/kfilemetadata-5.82.0/autotests/externalwritertest.cpp 2021-05-01 14:33:36.000000000 +0200 +++ new/kfilemetadata-5.83.0/autotests/externalwritertest.cpp 2021-06-05 11:17:35.000000000 +0200 @@ -24,11 +24,24 @@ { QTemporaryFile file; ExternalWriter plugin{testFilePath("testexternalwriter")}; - file.open(); + QVERIFY(file.open()); WriteData data(file.fileName(), "application/text"); plugin.write(data); QCOMPARE(QString(file.readAll()), QStringLiteral("{}")); } +void ExternalWriterTest::testProperties() +{ + QTemporaryFile file; + ExternalWriter plugin{testFilePath("testexternalwriter")}; + QVERIFY(file.open()); + WriteData data(file.fileName(), "application/text"); + data.add(Property::Author, QStringLiteral("Name")); + plugin.write(data); + + auto expected = QStringLiteral("{\"author\": \"Name\"}"); + QCOMPARE(QString(file.readAll()), expected); +} + QTEST_GUILESS_MAIN(ExternalWriterTest) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.82.0/autotests/externalwritertest.h new/kfilemetadata-5.83.0/autotests/externalwritertest.h --- old/kfilemetadata-5.82.0/autotests/externalwritertest.h 2021-05-01 14:33:36.000000000 +0200 +++ new/kfilemetadata-5.83.0/autotests/externalwritertest.h 2021-06-05 11:17:35.000000000 +0200 @@ -18,6 +18,7 @@ private Q_SLOTS: void test(); + void testProperties(); }; #endif // EXTERNALWRITERTEST_H diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.82.0/autotests/taglibextractortest.cpp new/kfilemetadata-5.83.0/autotests/taglibextractortest.cpp --- old/kfilemetadata-5.82.0/autotests/taglibextractortest.cpp 2021-05-01 14:33:36.000000000 +0200 +++ new/kfilemetadata-5.83.0/autotests/taglibextractortest.cpp 2021-06-05 11:17:35.000000000 +0200 @@ -430,9 +430,8 @@ { QTest::addColumn<QString>("fileType"); - QTest::addRow("asf") - << QStringLiteral("wma") - ; + // ASF container format, used by WMA + QTest::addRow("wma") << QStringLiteral("wma"); } void TagLibExtractorTest::testId3Rating_data() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.82.0/po/zh_CN/kfilemetadata5.po new/kfilemetadata-5.83.0/po/zh_CN/kfilemetadata5.po --- old/kfilemetadata-5.82.0/po/zh_CN/kfilemetadata5.po 2021-05-01 14:33:36.000000000 +0200 +++ new/kfilemetadata-5.83.0/po/zh_CN/kfilemetadata5.po 2021-06-05 11:17:35.000000000 +0200 @@ -10,7 +10,7 @@ "Project-Id-Version: kdeorg\n" "Report-Msgid-Bugs-To: https://bugs.kde.org\n"; "POT-Creation-Date: 2020-06-09 02:02+0200\n" -"PO-Revision-Date: 2021-04-24 15:42\n" +"PO-Revision-Date: 2021-06-03 16:05\n" "Last-Translator: \n" "Language-Team: Chinese Simplified\n" "Language: zh_CN\n" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.82.0/src/CMakeLists.txt new/kfilemetadata-5.83.0/src/CMakeLists.txt --- old/kfilemetadata-5.82.0/src/CMakeLists.txt 2021-05-01 14:33:36.000000000 +0200 +++ new/kfilemetadata-5.83.0/src/CMakeLists.txt 2021-06-05 11:17:35.000000000 +0200 @@ -53,7 +53,7 @@ ) set_target_properties(KF5FileMetaData PROPERTIES - VERSION ${KFILEMETADATA_VERSION_STRING} + VERSION ${KFILEMETADATA_VERSION} SOVERSION ${KFILEMETADATA_SOVERSION} EXPORT_NAME FileMetaData ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.82.0/src/externalextractor.cpp new/kfilemetadata-5.83.0/src/externalextractor.cpp --- old/kfilemetadata-5.82.0/src/externalextractor.cpp 2021-05-01 14:33:36.000000000 +0200 +++ new/kfilemetadata-5.83.0/src/externalextractor.cpp 2021-06-05 11:17:35.000000000 +0200 @@ -135,14 +135,14 @@ auto i = propertiesObject.constBegin(); for (; i != propertiesObjectEnd; ++i) { if (i.key() == QStringLiteral("typeInfo")) { - TypeInfo info = TypeInfo::fromName(propertiesObject.value(i.key()).toString()); + TypeInfo info = TypeInfo::fromName(i.value().toString()); result->addType(info.type()); continue; } // for plaintext extraction if (i.key() == QStringLiteral("text")) { - result->append(propertiesObject.value(i.key()).toString(QStringLiteral(""))); + result->append(i.value().toString()); continue; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.82.0/src/externalwriter.cpp new/kfilemetadata-5.83.0/src/externalwriter.cpp --- old/kfilemetadata-5.82.0/src/externalwriter.cpp 2021-05-01 14:33:36.000000000 +0200 +++ new/kfilemetadata-5.83.0/src/externalwriter.cpp 2021-06-05 11:17:35.000000000 +0200 @@ -41,7 +41,7 @@ } ExternalWriter::ExternalWriter(const QString& pluginPath) - : WriterPlugin(new QObject()), + : WriterPlugin(nullptr), d_ptr(new ExternalWriterPrivate) { Q_D(ExternalWriter); @@ -91,10 +91,9 @@ const QMap<Property::Property, QVariant> properties = data.getAllProperties(); - QMap<Property::Property, QVariant>::const_iterator i = properties.constBegin(); - while (i != properties.constEnd()) { + for (auto i = properties.constBegin(); i != properties.constEnd(); ++i) { PropertyInfo propertyInfo(i.key()); - propertiesObject[propertyInfo.name()] = QJsonValue::fromVariant(properties[i.key()]); + propertiesObject[propertyInfo.name()] = QJsonValue::fromVariant(i.value()); } rootObject[QStringLiteral("path")] = QJsonValue(data.inputUrl()); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.82.0/src/extractionresult.cpp new/kfilemetadata-5.83.0/src/extractionresult.cpp --- old/kfilemetadata-5.82.0/src/extractionresult.cpp 2021-05-01 14:33:36.000000000 +0200 +++ new/kfilemetadata-5.83.0/src/extractionresult.cpp 2021-06-05 11:17:35.000000000 +0200 @@ -6,8 +6,6 @@ #include "extractionresult.h" -#include <QMimeDatabase> - using namespace KFileMetaData; class Q_DECL_HIDDEN ExtractionResult::Private @@ -24,9 +22,6 @@ { d->url = url; d->mimetype = mimetype; - if (mimetype.isEmpty()) { - d->mimetype = QMimeDatabase().mimeTypeForFile(url).name(); - } d->flags = flags; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kfilemetadata-5.82.0/src/writers/taglibwriter.cpp new/kfilemetadata-5.83.0/src/writers/taglibwriter.cpp --- old/kfilemetadata-5.82.0/src/writers/taglibwriter.cpp 2021-05-01 14:33:36.000000000 +0200 +++ new/kfilemetadata-5.83.0/src/writers/taglibwriter.cpp 2021-06-05 11:17:35.000000000 +0200 @@ -159,6 +159,7 @@ int rating = newProperties.value(Property::Rating).toInt(); if (rating >= 0 && rating <= 10) { id3Tags->removeFrames("POPM"); + // ID3v2::Tag::addFrame takes ownership auto ratingFrame = new TagLib::ID3v2::PopularimeterFrame; ratingFrame->setEmail("org.kde.kfilemetadata"); ratingFrame->setRating(id3v2RatingTranslation[rating]); @@ -207,6 +208,7 @@ for (const auto type : allImageTypes<PictureFrame>) { const auto kfmType = mapTaglibType<PictureFrame::Type>(type); if (kfmType & wantedTypes) { + // ID3v2::Tag::addFrame takes ownership auto* coverFrame = new PictureFrame; coverFrame->setType(type); updateFrame(coverFrame, kfmType); @@ -257,6 +259,7 @@ for (const auto type : allImageTypes<PictureFrame>) { const auto kfmType = mapTaglibType<PictureFrame::Type>(type); if (kfmType & wantedTypes) { + // FLAC::File::addPicture takes ownership (dito XiphComment) auto* coverFrame = new PictureFrame; coverFrame->setType(type); updateFrame(coverFrame, kfmType); @@ -371,10 +374,10 @@ for (const auto type : allImageTypes<PictureFrame>) { const auto kfmType = mapTaglibType<PictureFrame::Type>(type); if (kfmType & wantedTypes) { - auto* coverFrame = new PictureFrame; - updateFrame(coverFrame, kfmType); - coverFrame->setType(type); - lstPic.append(*coverFrame); + PictureFrame coverFrame; + updateFrame(&coverFrame, kfmType); + coverFrame.setType(type); + lstPic.append(coverFrame); } } asfTags->setAttribute("WM/Picture", lstPic);
