Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package chromium for openSUSE:Factory checked in at 2021-06-25 15:00:34 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/chromium (Old) and /work/SRC/openSUSE:Factory/.chromium.new.2625 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "chromium" Fri Jun 25 15:00:34 2021 rev:297 rq:901249 version:91.0.4472.114 Changes: -------- --- /work/SRC/openSUSE:Factory/chromium/chromium.changes 2021-06-21 20:35:37.662619552 +0200 +++ /work/SRC/openSUSE:Factory/.chromium.new.2625/chromium.changes 2021-06-25 15:00:53.772119246 +0200 @@ -1,0 +2,6 @@ +Mon Jun 21 18:29:12 UTC 2021 - Andreas Stieger <andreas.stie...@gmx.de> + +- fix crash upon exit boo#1186948 + add chromium-91-1190561-boo1186948.patch + +------------------------------------------------------------------- New: ---- chromium-91-1190561-boo1186948.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ chromium.spec ++++++ --- /var/tmp/diff_new_pack.6OcXiT/_old 2021-06-25 15:00:57.260123500 +0200 +++ /var/tmp/diff_new_pack.6OcXiT/_new 2021-06-25 15:00:57.264123505 +0200 @@ -103,6 +103,7 @@ Patch41: chromium-91-GCC_fix_vector_types_in_pcscan.patch Patch42: chromium-91-system-icu.patch Patch44: chromium-91-libyuv-aarch64.patch +Patch45: chromium-91-1190561-boo1186948.patch # Google seem not too keen on merging this but GPU accel is quite important # https://chromium-review.googlesource.com/c/chromium/src/+/532294 # https://github.com/saiarcot895/chromium-ubuntu-build/tree/master/debian/patches ++++++ chromium-91-1190561-boo1186948.patch ++++++ >From c2d0133f47afb59b4ce64e42215d1d053f15250a Mon Sep 17 00:00:00 2001 From: Stephan Hartmann <sth...@googlemail.com> Date: Tue, 13 Apr 2021 23:21:42 +0000 Subject: [PATCH] fix crash in ThemeService ThemeSyncableService and ThemeService are owned by each other. On destruction of ThemeService, ThemeSyncableService gets destructed as well, but calls RemoveObserver of partly destructed ThemeService object. To avoid already destructed |observers_| list, move it before |theme_syncable_service_| definition. Bug: 1190561 Change-Id: I4dc2c990d589071d97b7fa737afef54463c84751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2821311 Commit-Queue: Peter Kasting <pkast...@chromium.org> Reviewed-by: Peter Kasting <pkast...@chromium.org> Cr-Commit-Position: refs/heads/master@{#872164} --- chrome/browser/themes/theme_service.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/chrome/browser/themes/theme_service.h b/chrome/browser/themes/theme_service.h index 592d40ae9de0f..337dfac9a040f 100644 --- a/chrome/browser/themes/theme_service.h +++ b/chrome/browser/themes/theme_service.h @@ -299,6 +299,10 @@ class ThemeService : public KeyedService, // The number of infobars currently displayed. int number_of_reinstallers_ = 0; + // Declared before |theme_syncable_service_|, because ThemeSyncableService + // removes itself from the |observers_| list on destruction. + base::ObserverList<ThemeServiceObserver> observers_; + std::unique_ptr<ThemeSyncableService> theme_syncable_service_; #if BUILDFLAG(ENABLE_EXTENSIONS) @@ -320,8 +324,6 @@ class ThemeService : public KeyedService, ScopedObserver<ui::NativeTheme, ui::NativeThemeObserver> native_theme_observer_{this}; - base::ObserverList<ThemeServiceObserver> observers_; - base::WeakPtrFactory<ThemeService> weak_ptr_factory_{this}; DISALLOW_COPY_AND_ASSIGN(ThemeService);
