Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package yast2 for openSUSE:Factory checked in at 2021-07-01 07:05:28 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2 (Old) and /work/SRC/openSUSE:Factory/.yast2.new.2625 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2" Thu Jul 1 07:05:28 2021 rev:513 rq:903112 version:4.4.14 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2/yast2.changes 2021-06-05 23:31:56.324480392 +0200 +++ /work/SRC/openSUSE:Factory/.yast2.new.2625/yast2.changes 2021-07-01 07:05:33.591512040 +0200 @@ -1,0 +2,38 @@ +Wed Jun 23 13:24:04 UTC 2021 - Ancor Gonzalez Sosa <an...@suse.com> + +- Y2Issues::Issue: renamed severity "fatal" to "error", to be more + consistent with other parts of (Auto)YaST +- Added options to configure the behavior of Y2Issues.report + (related to jsc#PM-2620 and bsc#1166743) +- 4.4.14 + +------------------------------------------------------------------- +Mon Jun 21 20:51:57 UTC 2021 - Josef Reidinger <jreidin...@suse.com> + +- Y2Issues::List: Add methods size and concat (related to + bsc#1181295). +- 4.4.13 + +------------------------------------------------------------------- +Thu Jun 17 06:15:02 UTC 2021 - Dirk M??ller <dmuel...@suse.com> + +- add riscv64 architecture helper (jsc#PM-2612) +- 4.4.12 + +------------------------------------------------------------------- +Fri Jun 11 15:45:21 UTC 2021 - Josef Reidinger <jreidin...@suse.com> + +- Yast2::AutoClient.run: Ensure that Reset, Read, and SetModified + return nil regardless of their implementation, to prevent + a crash in the component system (bsc#1187233) +- 4.4.11 + +------------------------------------------------------------------- +Tue Jun 8 08:26:13 UTC 2021 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Ignore sysctl configuration files that do not have the .conf + extension. The only exception are kernel files + (/boot/sysctl.conf-*) (bsc#1187018). +- 4.4.10 + +------------------------------------------------------------------- Old: ---- yast2-4.4.9.tar.bz2 New: ---- yast2-4.4.14.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2.spec ++++++ --- /var/tmp/diff_new_pack.2yjbab/_old 2021-07-01 07:05:34.191507353 +0200 +++ /var/tmp/diff_new_pack.2yjbab/_new 2021-07-01 07:05:34.195507321 +0200 @@ -17,13 +17,12 @@ Name: yast2 -Version: 4.4.9 +Version: 4.4.14 Release: 0 Summary: YaST2 Main Package License: GPL-2.0-only Group: System/YaST URL: https://github.com/yast/yast-yast2 - Source0: %{name}-%{version}.tar.bz2 Source1: yast2-rpmlintrc ++++++ yast2-4.4.9.tar.bz2 -> yast2-4.4.14.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/README.md new/yast2-4.4.14/README.md --- old/yast2-4.4.9/README.md 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/README.md 2021-06-29 18:19:30.000000000 +0200 @@ -47,4 +47,4 @@ If you have any question, feel free to ask at the [development mailing list](http://lists.opensuse.org/yast-devel/) or at the -[#yast](https://webchat.freenode.net/?channels=%23yast) IRC channel on freenode. +[#yast](https://web.libera.chat/#yast) IRC channel on libera.chat. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/doc/README_Template.md new/yast2-4.4.14/doc/README_Template.md --- old/yast2-4.4.9/doc/README_Template.md 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/doc/README_Template.md 2021-06-29 18:19:30.000000000 +0200 @@ -104,4 +104,4 @@ If you have any question, feel free to ask at the [development mailing list](http://lists.opensuse.org/yast-devel/) or at the -[#yast](https://webchat.freenode.net/?channels=%23yast) IRC channel on freenode. +[#yast](https://web.libera.chat/#yast) IRC channel on libera.chat. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/src/lib/cfa/sysctl_config.rb new/yast2-4.4.14/library/general/src/lib/cfa/sysctl_config.rb --- old/yast2-4.4.9/library/general/src/lib/cfa/sysctl_config.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/src/lib/cfa/sysctl_config.rb 2021-06-29 18:19:30.000000000 +0200 @@ -157,7 +157,9 @@ if Yast::FileUtils.IsFile(path) [path] elsif Yast::FileUtils.IsDirectory(path) - Yast::SCR.Read(Yast::Path.new(".target.dir"), path).map { |file| File.join(path, file) } + Yast::SCR.Read(Yast::Path.new(".target.dir"), path) + .select { |f| f.end_with?(".conf") } # according to 'sysctl.conf' manpage, only .conf files are considered + .map { |f| File.join(path, f) } else log.debug("Ignoring not valid path: #{path}") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/src/lib/installation/auto_client.rb new/yast2-4.4.14/library/general/src/lib/installation/auto_client.rb --- old/yast2-4.4.9/library/general/src/lib/installation/auto_client.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/src/lib/installation/auto_client.rb 2021-06-29 18:19:30.000000000 +0200 @@ -69,6 +69,7 @@ summary when "Reset" reset + nil # return type is ignored, so always return nil to avoid issues with ycp component system when "Change" change when "Write" @@ -77,10 +78,12 @@ packages when "Read" read + nil # return type is ignored, so always return nil to avoid issues with ycp component system when "GetModified" modified? when "SetModified" modified + nil # return type is ignored, so always return nil to avoid issues with ycp component system else raise ArgumentError, "Invalid action for auto client '#{func.inspect}'" end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/src/lib/installation/autoinst_issues/missing_value.rb new/yast2-4.4.14/library/general/src/lib/installation/autoinst_issues/missing_value.rb --- old/yast2-4.4.9/library/general/src/lib/installation/autoinst_issues/missing_value.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/src/lib/installation/autoinst_issues/missing_value.rb 2021-06-29 18:19:30.000000000 +0200 @@ -32,7 +32,7 @@ # @param section [String] Section where it was detected # @param attribute [String] Name of the missing attribute # @param description [String] additional explanation; optional - # @param severity [Symbol] :warn, :fatal = abort the installation ; optional + # @param severity [Symbol] :warn, :error = abort the installation ; optional def initialize(section, attr, description = "", severity = :warn) textdomain "base" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/src/lib/y2issues/issue.rb new/yast2-4.4.14/library/general/src/lib/y2issues/issue.rb --- old/yast2-4.4.9/library/general/src/lib/y2issues/issue.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/src/lib/y2issues/issue.rb 2021-06-29 18:19:30.000000000 +0200 @@ -27,7 +27,7 @@ # specific information. See {InvalidValue} as an example. # # @example Create a new error - # Issue.new("Could not read network configuration", severity: :fatal) + # Issue.new("Could not read network configuration", severity: :error) # # @example Create an error from an specific location # Issue.new( @@ -42,25 +42,27 @@ attr_reader :location # @return [String] Error message attr_reader :message - # @return [Symbol] Error severity (:warn, :fatal) + # @return [Symbol] Error severity (:warn, :error) attr_reader :severity # @param message [String] User-oriented message describing the problem # @param location [String,nil] Where the error is located. Use a URI or # a string to represent the error location. Use 'nil' if it # does not exist an specific location. - # @param severity [Symbol] warning (:warn) or fatal (:fatal) + # @param severity [Symbol] warning (:warn) or error (:error) def initialize(message, location: nil, severity: :warn) @message = message @location = location.is_a?(String) ? Location.parse(location) : location @severity = severity end - # Determines whether the error is fatal or not + # Determines whether the issue is an error # # @return [Boolean] - def fatal? - @severity == :fatal + def error? + @severity == :error end + + alias_method :fatal?, :error? end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/src/lib/y2issues/list.rb new/yast2-4.4.14/library/general/src/lib/y2issues/list.rb --- old/yast2-4.4.9/library/general/src/lib/y2issues/list.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/src/lib/y2issues/list.rb 2021-06-29 18:19:30.000000000 +0200 @@ -25,7 +25,7 @@ include Enumerable extend Forwardable - def_delegators :@items, :each, :empty?, :<< + def_delegators :@items, :each, :empty?, :<<, :size # Constructor # @@ -34,18 +34,31 @@ @items = issues end - # Determine whether any of the problem on the list is fatal + # Determine whether any of the issues on the list is an error # - # @return [Boolean] true if any of them is a fatal problem - def fatal? - any?(&:fatal?) + # @return [Boolean] + def error? + any?(&:error?) end + alias_method :fatal?, :error? + # Returns an array containing registered problems # # @return [Array<Issue>] List of problems def to_a @items end + + # concats issues + # @param args [Array[List]] args to concat. see Array#concat + # + # @note also self is modified + # @return [List] + def concat(*args) + @items.concat(*args.map(&:to_a)) + + self + end end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/src/lib/y2issues/presenter.rb new/yast2-4.4.14/library/general/src/lib/y2issues/presenter.rb --- old/yast2-4.4.9/library/general/src/lib/y2issues/presenter.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/src/lib/y2issues/presenter.rb 2021-06-29 18:19:30.000000000 +0200 @@ -48,10 +48,10 @@ # # @return [String] HTML representing the list of issues def to_html - fatal, non_fatal = issues.partition(&:fatal?) + errors, warnings = issues.partition(&:error?) parts = [] - parts << error_text(fatal) unless fatal.empty? - parts << warning_text(non_fatal) unless non_fatal.empty? + parts << error_text(errors) unless errors.empty? + parts << warning_text(warnings) unless warnings.empty? parts.join end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/src/lib/y2issues/reporter.rb new/yast2-4.4.14/library/general/src/lib/y2issues/reporter.rb --- old/yast2-4.4.9/library/general/src/lib/y2issues/reporter.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/src/lib/y2issues/reporter.rb 2021-06-29 18:19:30.000000000 +0200 @@ -22,6 +22,7 @@ Yast.import "Label" Yast.import "Report" +Yast.import "HTML" module Y2Issues # This class provides a mechanism to report YaST2 issues @@ -37,45 +38,101 @@ def initialize(issues, report_settings: Yast::Report.Export) textdomain "base" @presenter = Presenter.new(issues) - @level = issues.fatal? ? :error : :warn + @level = issues.error? ? :error : :warn @log, @show, @timeout = find_settings(report_settings, @level) end # Reports the issues to the user # # Depending on the given report settings, it may display a pop-up, and/or log the error. - def report + # + # In case of displaying the pop-up, the way to present the information and the possible return + # values are determined by the severity of the issues and the value of `warn` and `error`. + # + # If the value specified for the corresponding level is :abort, the pop-up contains the + # information and a single button to abort, the method returns false. + # + # If the value is :ask, the information is presented and the user is asked whether they want to + # continue or abort. The returned value depends on the answer. + # + # In the value is :continue (or any other symbol), the information is displayed with a button to + # simply close the pop-up and the method always returns true. + # + # @param warn [Symbol] what to do if the list of issues only contains warnings + # @param error [Symbol] what to do if the list of issues contains some error + # @return [Boolean] whether the process may continue, false means aborting + def report(warn: :ask, error: :abort) log_issues if @log - show_issues if @show + return true unless @show + + show_issues(warn, error) end private - attr_reader :level, :presenter + # Severity of the set of issues + # + # @return [Symbol] :warn if all the issues are just warnings, :error if any + # of the issues is an error + attr_reader :level + + # @return [Presenter] + attr_reader :presenter # Displays a pop-up containing the issues # - # It can behave in two different ways depending if a fatal issue was found: - # - # * Ask the user if she/he wants to continue or abort the installation. - # * Display a message and only offer an 'Abort' button. - def show_issues - if level == :error - headline = :error - buttons = { abort: Yast::Label.AbortButton } - question = _("Please, correct these problems and try again.") - timeout = 0 + # @return [Boolean] see {#report} + def show_issues(warn, error) + action = (level == :error) ? error : warn + case action + when :abort + show_issues_abort + when :ask + show_issues_ask else - headline = :warning - buttons = :yes_no - question = _("Do you want to continue?") - timeout = @timeout + show_issues_continue end + end + + # @see #show_issues + # + # @return [Boolean] see {#report}, always false in this case + def show_issues_abort + buttons = { abort: Yast::Label.AbortButton } + question = _("Please, correct these problems and try again.") + popup(question, buttons, with_timeout: false) + + false + end + + # @see #show_issues + # + # @return [Boolean] see {#report} + def show_issues_ask + popup(_("Do you want to continue?"), :yes_no) == :yes + end + + # @see #show_issues + # + # @return [Boolean] see {#report}, always true in this case + def show_issues_continue + popup("", :ok) + true + end + + # Displays pop-up with information about the issues + def popup(footer, btns, with_timeout: true) + text = presenter.to_html + text += Yast::HTML.Para(footer) if footer && !footer.empty? + time = with_timeout ? @timeout : 0 + Yast2::Popup.show(text, richtext: true, headline: header, buttons: btns, timeout: time) + end + + # @see #popup + def header + return :error if level == :error - content = presenter.to_html + Yast::HTML.Para(question) - Yast2::Popup.show( - content, richtext: true, headline: headline, buttons: buttons, timeout: timeout - ) + :warning end # Writes the issues diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/src/lib/y2issues.rb new/yast2-4.4.14/library/general/src/lib/y2issues.rb --- old/yast2-4.4.9/library/general/src/lib/y2issues.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/src/lib/y2issues.rb 2021-06-29 18:19:30.000000000 +0200 @@ -28,17 +28,20 @@ # # @example Registering an error # list = Y2Issues::List.new -# list << Y2Issues::Issue.new("Could not read network configuration", severity: :fatal) +# list << Y2Issues::Issue.new("Could not read network configuration", severity: :error) module Y2Issues # Reports the errors to the user # # This is a helper method that offers an stable API on top of {Reporter}. Depending on # Yast::Report settings, it may show a pop-up with the found issues and log them. # - # @param [List] Issues list + # @param issues [List] Issues list + # @param warn [Symbol] what to do if the list of issues only contains warnings + # @param error [Symbol] what to do if the list of issues contains some error + # @return [Boolean] whether the process may continue, false means YaST is expected to abort # @see Y2Issues::Reporter - def self.report(issues) - Reporter.new(issues).report + def self.report(issues, warn: :ask, error: :abort) + Reporter.new(issues).report(warn: warn, error: error) end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/src/modules/Arch.rb new/yast2-4.4.14/library/general/src/modules/Arch.rb --- old/yast2-4.4.9/library/general/src/modules/Arch.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/src/modules/Arch.rb 2021-06-29 18:19:30.000000000 +0200 @@ -63,7 +63,8 @@ # ************************************************************ # system architecture - # Returns full architecture type (one of i386, sparc, sparc64, ppc, ppc64, alpha, s390_32, s390_64, ia64, x86_64, arm, aarch64) + # Returns full architecture type + # (one of i386, sparc, sparc64, ppc, ppc64, alpha, s390_32, s390_64, ia64, x86_64, arm, aarch64, risv64) # # @return [String] architecture def architecture @@ -169,6 +170,11 @@ architecture == "aarch64" end + # true for all riscv64 (RISC-V 64-bit) architectures + def riscv64 + architecture == "riscv64" + end + # Returns general architecture type (one of sparc, ppc, s390, i386, alpha, ia64, x86_64, arm, aarch64) # # @return [String] arch_short @@ -521,6 +527,7 @@ publish function: :x86_64, type: "boolean ()" publish function: :arm, type: "boolean ()" publish function: :aarch64, type: "boolean ()" + publish function: :riscv64, type: "boolean ()" publish function: :arch_short, type: "string ()" publish function: :board_mac, type: "boolean ()" publish function: :board_mac_new, type: "boolean ()" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/test/auto_client_test.rb new/yast2-4.4.14/library/general/test/auto_client_test.rb --- old/yast2-4.4.9/library/general/test/auto_client_test.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/test/auto_client_test.rb 2021-06-29 18:19:30.000000000 +0200 @@ -105,7 +105,13 @@ end it "dispatch call to abstract method reset" do - expect(subject.run).to eq "reset" + expect_any_instance_of(subject).to receive(:reset) + + subject.run + end + + it "always return nil" do + expect(subject.run).to eq nil end it "raise NotImplementedError exception if abstract method not defined" do @@ -147,7 +153,13 @@ end it "dispatch call to abstract method read" do - expect(subject.run).to eq "read" + expect_any_instance_of(subject).to receive(:read) + + subject.run + end + + it "always return nil" do + expect(subject.run).to eq nil end it "raise NotImplementedError exception if abstract method not defined" do @@ -175,7 +187,13 @@ end it "dispatch call to abstract method modified" do - expect(subject.run).to eq "modified" + expect_any_instance_of(subject).to receive(:modified) + + subject.run + end + + it "always return nil" do + expect(subject.run).to eq nil end it "raise NotImplementedError exception if abstract method not defined" do diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/test/y2issues/issue_test.rb new/yast2-4.4.14/library/general/test/y2issues/issue_test.rb --- old/yast2-4.4.9/library/general/test/y2issues/issue_test.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/test/y2issues/issue_test.rb 2021-06-29 18:19:30.000000000 +0200 @@ -27,14 +27,14 @@ described_class.new( "Something went wrong", location: Y2Issues::Location.parse("file:/etc/hosts"), - severity: :fatal + severity: :error ) end it "creates an issue" do expect(issue.message).to eq("Something went wrong") expect(issue.location).to eq(Y2Issues::Location.parse("file:/etc/hosts")) - expect(issue.severity).to eq(:fatal) + expect(issue.severity).to eq(:error) end context "when location is given as a string" do @@ -59,20 +59,20 @@ end end - describe "#fatal?" do - context "when severity is :fatal" do - subject(:issue) { described_class.new("Something went wrong", severity: :fatal) } + describe "#error?" do + context "when severity is :error" do + subject(:issue) { described_class.new("Something went wrong", severity: :error) } it "returns true" do - expect(issue.fatal?).to eq(true) + expect(issue.error?).to eq(true) end end - context "when severity is :fatal" do + context "when severity is :error" do subject(:issue) { described_class.new("Something went wrong", severity: :warn) } it "returns false" do - expect(issue.fatal?).to eq(false) + expect(issue.error?).to eq(false) end end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/test/y2issues/list_test.rb new/yast2-4.4.14/library/general/test/y2issues/list_test.rb --- old/yast2-4.4.9/library/general/test/y2issues/list_test.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/test/y2issues/list_test.rb 2021-06-29 18:19:30.000000000 +0200 @@ -56,20 +56,33 @@ end end - describe "#fatal?" do - context "when contains some fatal error" do - let(:issue) { Y2Issues::Issue.new("Something went wrong", severity: :fatal) } + describe "#error?" do + context "when contains some error" do + let(:issue) { Y2Issues::Issue.new("Something went wrong", severity: :error) } it "returns true" do - expect(list.fatal?).to eq(true) + expect(list.error?).to eq(true) end end - context "when does not contain any fatal error" do + context "when does not contain any error error" do it "returns false" do - expect(list.fatal?).to eq(false) + expect(list.error?).to eq(false) end end end + + describe "#concat" do + it "concats all passed Lists" do + issue1 = Y2Issues::Issue.new("Something went wrong", severity: :fatal) + issue2 = Y2Issues::Issue.new("Something went wrong2") + issue3 = Y2Issues::Issue.new("Something went wrong3") + expect(described_class.new([issue1]).concat( + described_class.new([issue2]), described_class.new([issue3]) + ).to_a).to eq( + described_class.new([issue1, issue2, issue3]).to_a + ) + end + end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/test/y2issues/presenter_test.rb new/yast2-4.4.14/library/general/test/y2issues/presenter_test.rb --- old/yast2-4.4.9/library/general/test/y2issues/presenter_test.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/test/y2issues/presenter_test.rb 2021-06-29 18:19:30.000000000 +0200 @@ -26,9 +26,9 @@ let(:list) { Y2Issues::List.new } describe "#to_html" do - context "when a fatal issue was found" do + context "when an error was found" do before do - list << Y2Issues::Issue.new("Something is invalid", severity: :fatal) + list << Y2Issues::Issue.new("Something is invalid", severity: :error) end it "includes issues messages" do @@ -36,12 +36,12 @@ expect(presenter.to_html.to_s).to include "<li>#{issue.message}</li>" end - it "includes an introduction to fatal issues qlist" do + it "includes an introduction to the errors list" do expect(presenter.to_html.to_s).to include "Important issues" end end - context "when a non fatal issue was found" do + context "when a warning was found" do before do list << Y2Issues::Issue.new("Something is missing", severity: :warn) end @@ -51,7 +51,7 @@ expect(presenter.to_html.to_s).to include "<li>#{issue.message}</li>" end - it "includes an introduction to non fatal issues list" do + it "includes an introduction to the warnings list" do expect(presenter.to_html.to_s).to include "<p>Minor issues" end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/library/general/test/y2issues/reporter_test.rb new/yast2-4.4.14/library/general/test/y2issues/reporter_test.rb --- old/yast2-4.4.9/library/general/test/y2issues/reporter_test.rb 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/library/general/test/y2issues/reporter_test.rb 2021-06-29 18:19:30.000000000 +0200 @@ -39,7 +39,7 @@ let(:errors_settings) do { "log" => true, "show" => true, "timeout" => 15 } end - let(:level) { :fatal } + let(:level) { :error } describe "#report" do before do @@ -51,15 +51,25 @@ reporter.report end - context "when there is a fatal error" do - let(:level) { :fatal } + context "when there is an error" do + let(:level) { :error } - it "displays issues as errors with no timeout" do - expect(Yast2::Popup).to receive(:show) .with( + it "displays issues as errors with the proper timeout and buttons" do + expect(Yast2::Popup).to receive(:show).with( /Important issues/, headline: :error, richtext: true, timeout: 0, buttons: a_hash_including(abort: String) ) - reporter.report + reporter.report(error: :abort) + + expect(Yast2::Popup).to receive(:show).with( + /Important issues/, headline: :error, richtext: true, timeout: 15, buttons: :yes_no + ) + reporter.report(error: :ask) + + expect(Yast2::Popup).to receive(:show).with( + /Important issues/, headline: :error, richtext: true, timeout: 15, buttons: :ok + ) + reporter.report(error: :continue) end it "logs the issues" do @@ -84,39 +94,49 @@ reporter.report end end + end - context "when there are just warnings" do - let(:level) { :warn } + context "when there are just warnings" do + let(:level) { :warn } - it "displays issues as errors with no timeout" do - expect(Yast2::Popup).to receive(:show) .with( - /Minor issues/, headline: :warning, richtext: true, timeout: 10, - buttons: :yes_no - ) - reporter.report - end + it "displays issues as warning with the proper timeout and buttons" do + expect(Yast2::Popup).to receive(:show).with( + /Minor issues/, headline: :warning, richtext: true, timeout: 0, + buttons: a_hash_including(abort: String) + ) + reporter.report(warn: :abort) - it "logs the issues" do - expect(reporter.log).to receive(:warn).with(/Minor issues/) - reporter.report - end + expect(Yast2::Popup).to receive(:show).with( + /Minor issues/, headline: :warning, richtext: true, timeout: 10, buttons: :yes_no + ) + reporter.report(warn: :ask) - context "if showing warnings is disabled" do - let(:warnings_settings) { { "show" => false, "log" => true } } + expect(Yast2::Popup).to receive(:show).with( + /Minor issues/, headline: :warning, richtext: true, timeout: 10, buttons: :ok + ) + reporter.report(warn: :continue) + end + + it "logs the issues" do + expect(reporter.log).to receive(:warn).with(/Minor issues/) + reporter.report + end - it "does not display the issues" do - expect(Yast2::Popup).to_not receive(:show) - reporter.report - end + context "if showing warnings is disabled" do + let(:warnings_settings) { { "show" => false, "log" => true } } + + it "does not display the issues" do + expect(Yast2::Popup).to_not receive(:show) + reporter.report end + end - context "if loggin warnings is disabled" do - let(:warnings_settings) { { "show" => true, "log" => false } } + context "if loggin warnings is disabled" do + let(:warnings_settings) { { "show" => true, "log" => false } } - it "does not log the warning" do - expect(reporter.log).to_not receive(:warn) - reporter.report - end + it "does not log the warning" do + expect(reporter.log).to_not receive(:warn) + reporter.report end end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/package/yast2.changes new/yast2-4.4.14/package/yast2.changes --- old/yast2-4.4.9/package/yast2.changes 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/package/yast2.changes 2021-06-29 18:19:30.000000000 +0200 @@ -1,4 +1,42 @@ ------------------------------------------------------------------- +Wed Jun 23 13:24:04 UTC 2021 - Ancor Gonzalez Sosa <an...@suse.com> + +- Y2Issues::Issue: renamed severity "fatal" to "error", to be more + consistent with other parts of (Auto)YaST +- Added options to configure the behavior of Y2Issues.report + (related to jsc#PM-2620 and bsc#1166743) +- 4.4.14 + +------------------------------------------------------------------- +Mon Jun 21 20:51:57 UTC 2021 - Josef Reidinger <jreidin...@suse.com> + +- Y2Issues::List: Add methods size and concat (related to + bsc#1181295). +- 4.4.13 + +------------------------------------------------------------------- +Thu Jun 17 06:15:02 UTC 2021 - Dirk M??ller <dmuel...@suse.com> + +- add riscv64 architecture helper (jsc#PM-2612) +- 4.4.12 + +------------------------------------------------------------------- +Fri Jun 11 15:45:21 UTC 2021 - Josef Reidinger <jreidin...@suse.com> + +- Yast2::AutoClient.run: Ensure that Reset, Read, and SetModified + return nil regardless of their implementation, to prevent + a crash in the component system (bsc#1187233) +- 4.4.11 + +------------------------------------------------------------------- +Tue Jun 8 08:26:13 UTC 2021 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Ignore sysctl configuration files that do not have the .conf + extension. The only exception are kernel files + (/boot/sysctl.conf-*) (bsc#1187018). +- 4.4.10 + +------------------------------------------------------------------- Thu Jun 3 15:40:30 UTC 2021 - Jos?? Iv??n L??pez Gonz??lez <jlo...@suse.com> - AutoYaST: SectionWithAttributes allows to indicate whether an diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.4.9/package/yast2.spec new/yast2-4.4.14/package/yast2.spec --- old/yast2-4.4.9/package/yast2.spec 2021-06-04 10:57:39.000000000 +0200 +++ new/yast2-4.4.14/package/yast2.spec 2021-06-29 18:19:30.000000000 +0200 @@ -17,13 +17,12 @@ Name: yast2 -Version: 4.4.9 +Version: 4.4.14 Release: 0 Summary: YaST2 Main Package License: GPL-2.0-only Group: System/YaST -Url: https://github.com/yast/yast-yast2 - +URL: https://github.com/yast/yast-yast2 Source0: %{name}-%{version}.tar.bz2 Source1: yast2-rpmlintrc
