Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package gdb for openSUSE:Factory checked in 
at 2021-07-22 22:42:47
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/gdb (Old)
 and      /work/SRC/openSUSE:Factory/.gdb.new.1899 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "gdb"

Thu Jul 22 22:42:47 2021 rev:154 rq:907328 version:10.1

Changes:
--------
--- /work/SRC/openSUSE:Factory/gdb/gdb.changes  2021-06-25 15:01:40.680176465 
+0200
+++ /work/SRC/openSUSE:Factory/.gdb.new.1899/gdb.changes        2021-07-22 
22:43:11.119213499 +0200
@@ -1,0 +2,6 @@
+Tue Jul 20 13:46:59 UTC 2021 - Andreas Schwab <sch...@suse.de>
+
+- amd64-linux-siginfo-include-order.patch: Adjust include order to avoid
+  gnulib error
+
+-------------------------------------------------------------------

New:
----
  amd64-linux-siginfo-include-order.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ gdb.spec ++++++
--- /var/tmp/diff_new_pack.b6TFAD/_old  2021-07-22 22:43:12.919211153 +0200
+++ /var/tmp/diff_new_pack.b6TFAD/_new  2021-07-22 22:43:12.923211147 +0200
@@ -1,5 +1,5 @@
 #
-# spec file for package gdb-testresults
+# spec file
 #
 # Copyright (c) 2021 SUSE LLC
 # Copyright (c) 2012 RedHat
@@ -321,6 +321,7 @@
 Patch2021:      
gdb-save-restore-file-offset-while-reading-notes-in-core-file.patch
 Patch2022:      
gdb-symtab-fix-infinite-recursion-in-dwarf2_cu-get_builder-again.patch
 Patch2023:      gdb-support-dw-lle-start-end.patch
+Patch2024:      amd64-linux-siginfo-include-order.patch
 
 # Testsuite patches
 
@@ -758,6 +759,7 @@
 %patch2021 -p1
 %patch2022 -p1
 %patch2023 -p1
+%patch2024 -p1
 
 %patch2500 -p1
 %if 0%{?suse_version} > 1500

++++++ amd64-linux-siginfo-include-order.patch ++++++
>From 8488c357ce4fc309d49c7b0224cf9574b68e8116 Mon Sep 17 00:00:00 2001
From: Kevin Buettner <kev...@redhat.com>
Date: Thu, 18 Feb 2021 22:46:58 -0700
Subject: [PATCH] amd64-linux-siginfo.c: Adjust include order to avoid gnulib
 error

On Fedora rawhide, after updating to glibc-2.33, I'm seeing the
following build failure:

  CXX    nat/amd64-linux-siginfo.o
In file included from /usr/include/bits/sigstksz.h:24,
                 from /usr/include/signal.h:315,
                 from ../gnulib/import/signal.h:52,
                 from 
/ironwood1/sourceware-git/rawhide-gnulib/bld/../../worktree-gnulib/gdbserver/../gdb/nat/amd64-linux-siginfo.c:20:
../gnulib/import/unistd.h:663:3: error: #error "Please include config.h first."
  663 |  #error "Please include config.h first."
      |   ^~~~~

glibc-2.33 has changed signal.h to now include <bits/sigstksz.h> which,
in turn, includes <unistd.h>. For a gdb build, this causes the gnulib
version of unistd.h to be pulled in first.  The build failure shown
above happens because gnulib's config.h has not been included before
the include of <signal.h>.

The fix is simple - we just rearrange the order of the header file
includes to make sure that gdbsupport/commondefs.h is included before
attempting to include signal.h.  Note that gdbsupport/commondefs.h
includes <gnulib/config.h>.

Build and regression tested on Fedora 33.  On Fedora rawhide, GDB
builds again.

gdb/ChangeLog:

        * nat/amd64-linux-siginfo.c: Include "gdbsupport/common-defs.h"
        (which in turn includes <gnulib/config.h>) before include
        of <signal.h>.
---
 gdb/ChangeLog                 | 6 ++++++
 gdb/nat/amd64-linux-siginfo.c | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/gdb/nat/amd64-linux-siginfo.c b/gdb/nat/amd64-linux-siginfo.c
index 0c932814ec8..e2d2db6e112 100644
--- a/gdb/nat/amd64-linux-siginfo.c
+++ b/gdb/nat/amd64-linux-siginfo.c
@@ -17,8 +17,8 @@
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
-#include <signal.h>
 #include "gdbsupport/common-defs.h"
+#include <signal.h>
 #include "amd64-linux-siginfo.h"
 
 #define GDB_SI_SIZE 128
-- 
2.32.0

Reply via email to