Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package kmod for openSUSE:Factory checked in 
at 2021-08-25 20:55:58
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/kmod (Old)
 and      /work/SRC/openSUSE:Factory/.kmod.new.1899 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "kmod"

Wed Aug 25 20:55:58 2021 rev:64 rq:913049 version:29

Changes:
--------
--- /work/SRC/openSUSE:Factory/kmod/kmod.changes        2021-06-09 
21:55:02.950768529 +0200
+++ /work/SRC/openSUSE:Factory/.kmod.new.1899/kmod.changes      2021-08-25 
20:56:07.605325148 +0200
@@ -1,0 +2,7 @@
+Wed Aug 18 10:55:57 UTC 2021 - Michal Suchanek <msucha...@suse.de>
+
+- Display module information even for modules built into the running kernel
+  (bsc#1189537).
+   + libkmod-Provide-info-even-for-modules-built-into-the.patch
+
+-------------------------------------------------------------------

New:
----
  libkmod-Provide-info-even-for-modules-built-into-the.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ kmod-testsuite.spec ++++++
--- /var/tmp/diff_new_pack.YX9q3R/_old  2021-08-25 20:56:08.297324240 +0200
+++ /var/tmp/diff_new_pack.YX9q3R/_new  2021-08-25 20:56:08.301324235 +0200
@@ -37,6 +37,7 @@
 Patch6:         0012-modprobe-print-unsupported-status.patch
 Patch7:         usr-lib-modprobe.patch
 Patch8:         no-stylesheet-download.patch
+Patch9:         libkmod-Provide-info-even-for-modules-built-into-the.patch
 BuildRequires:  autoconf
 BuildRequires:  automake
 BuildRequires:  docbook5-xsl-stylesheets

++++++ kmod.spec ++++++
--- /var/tmp/diff_new_pack.YX9q3R/_old  2021-08-25 20:56:08.329324198 +0200
+++ /var/tmp/diff_new_pack.YX9q3R/_new  2021-08-25 20:56:08.333324193 +0200
@@ -37,6 +37,7 @@
 Patch6:         0012-modprobe-print-unsupported-status.patch
 Patch7:         usr-lib-modprobe.patch
 Patch8:         no-stylesheet-download.patch
+Patch9:         libkmod-Provide-info-even-for-modules-built-into-the.patch
 BuildRequires:  autoconf
 BuildRequires:  automake
 BuildRequires:  docbook5-xsl-stylesheets


++++++ libkmod-Provide-info-even-for-modules-built-into-the.patch ++++++
>From lucas.demar...@intel.com Wed Aug 18 23:25:03 2021
To: linux-modules <linux-modu...@vger.kernel.org>
Subject: [PATCH v2] libkmod: Set builtin to no when module is created from path.
Date: Wed, 18 Aug 2021 14:24:39 -0700
Message-Id: <20210818212440.2224127-1-lucas.demar...@intel.com>
From: Michal Suchanek <msucha...@suse.de>

A recent bug report showed that modinfo doesn't give the signature
information for certain modules, and it turned out to happen only on
the modules that are built-in on the running kernel; then modinfo
skips the signature check, as if the target module file never exists.
The behavior is, however, inconsistent when modinfo is performed for
external modules (no matter which kernel version is) and the module
file path is explicitly given by a command-line argument, which
guarantees the presence of the module file itself.

Fixes: e7e2cb61fa9f ("modinfo: Show information about built-in modules")
Link: 
https://lore.kernel.org/linux-modules/CAKi4VAJVvY3=jdszm-gd1hjqycpyayz-jbj_reey5bakvb6...@mail.gmail.com/
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1189537
Suggested-by: Lucas De Marchi <lucas.de.mar...@gmail.com>
Signed-off-by: Michal Suchanek <msucha...@suse.de>
---
 libkmod/libkmod-module.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c
index 6e0ff1a..6f7747c 100644
--- a/libkmod/libkmod-module.c
+++ b/libkmod/libkmod-module.c
@@ -431,17 +431,18 @@ KMOD_EXPORT int kmod_module_new_from_path(struct kmod_ctx 
*ctx,
                        return -EEXIST;
                }
 
-               *mod = kmod_module_ref(m);
-               return 0;
-       }
+               kmod_module_ref(m);
+       } else {
+               err = kmod_module_new(ctx, name, name, namelen, NULL, 0, &m);
+               if (err < 0) {
+                       free(abspath);
+                       return err;
+               }
 
-       err = kmod_module_new(ctx, name, name, namelen, NULL, 0, &m);
-       if (err < 0) {
-               free(abspath);
-               return err;
+               m->path = abspath;
        }
 
-       m->path = abspath;
+       m->builtin = KMOD_MODULE_BUILTIN_NO;
        *mod = m;
 
        return 0;
-- 
2.31.1

Reply via email to