Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package gns3-gui for openSUSE:Factory checked in at 2021-10-18 21:59:17 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gns3-gui (Old) and /work/SRC/openSUSE:Factory/.gns3-gui.new.1890 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gns3-gui" Mon Oct 18 21:59:17 2021 rev:12 rq:925831 version:2.2.26 Changes: -------- --- /work/SRC/openSUSE:Factory/gns3-gui/gns3-gui.changes 2021-08-27 21:45:02.150049713 +0200 +++ /work/SRC/openSUSE:Factory/.gns3-gui.new.1890/gns3-gui.changes 2021-10-18 22:02:08.534091404 +0200 @@ -1,0 +2,20 @@ +Wed Oct 13 20:12:49 UTC 2021 - Martin Hauke <mar...@gmx.de> + +- Update to version 2.2.26 + * Open "template configuration" dialog with double click on + template name in "Preferences". + * Only show "virtio" network adapter when legacy node is enabled. + * Double-click on a template opens "template configuration" + dialog. + * Fix "Custom symbols" can't be unfolded after using "Filter" + field. +- Update to version 2.2.25 + * Change method to display the recent files menu. + * Fix bug when using empty port names for custom adapters. + * Fix mouse zoom-in/out step value is two times bigger than + keyboard one. + * Fix issue with custom adapters at the node level. + * Explicitly require setuptools, utils/get_resource.py imports + pkg_resources + +------------------------------------------------------------------- Old: ---- gns3-gui-2.2.24.tar.gz New: ---- gns3-gui-2.2.26.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gns3-gui.spec ++++++ --- /var/tmp/diff_new_pack.2csADO/_old 2021-10-18 22:02:09.042091772 +0200 +++ /var/tmp/diff_new_pack.2csADO/_new 2021-10-18 22:02:09.046091775 +0200 @@ -17,7 +17,7 @@ Name: gns3-gui -Version: 2.2.24 +Version: 2.2.26 Release: 0 Summary: GNS3 graphical interface for the GNS3 server License: GPL-3.0-or-later ++++++ gns3-gui-2.2.24.tar.gz -> gns3-gui-2.2.26.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/CHANGELOG new/gns3-gui-2.2.26/CHANGELOG --- old/gns3-gui-2.2.24/CHANGELOG 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/CHANGELOG 2021-10-08 12:32:04.000000000 +0200 @@ -1,5 +1,26 @@ # Change Log +## 2.2.26 08/10/2021 + +* Upgrade embedded Python to version 3.7 in Windows package +* Upgrade Visual C++ Redistributable for Visual Studio 2019 in Windows package +* Fix SSL support in Windows package +* Open "template configuration" dialog with double click on template name in "Preferences". Fixes #3239 +* Only show "virtio" network adapter when legacy node is enabled. Fixes https://github.com/GNS3/gns3-gui/issues/1969 +* Double-click on a template opens "template configuration" dialog. Fixes #3236 +* Fix "Custom symbols" can't be unfolded after using "Filter" field. Fixes #3231 + +## 2.2.25 14/09/2021 + +* Fix menu disabled for modal dialogs on macOS. Fixes #3007 +* Change method to display the recent files menu. Fixes #3007 +* Fix bug when using empty port names for custom adapters. Fixes #3228 +* Upgrade Qt to version 5.15.4 on macOS +* Fix mouse zoom-in/out step value is two times bigger than keyboard one. Fixes #3226 +* Upgrade to Qt 5.15.4 on Windows. Ref #3210 +* Fix issue with custom adapters at the node level. Fixes #3223 +* Explicitly require setuptools, utils/get_resource.py imports pkg_resources + ## 2.2.24 25/08/2021 * Fix incorrect Qemu binary selected when importing template. Fixes https://github.com/GNS3/gns3-gui/issues/3216 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/crash_report.py new/gns3-gui-2.2.26/gns3/crash_report.py --- old/gns3-gui-2.2.24/gns3/crash_report.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/crash_report.py 2021-10-08 12:32:04.000000000 +0200 @@ -51,7 +51,7 @@ Report crash to a third party service """ - DSN = "https://2ec08a0f8d314572b17dd2eba910a401:83d32ce66b444d0a81dd25170b4bf...@o19455.ingest.sentry.io/38506" + DSN = "https://803fefdf04db46ee9f4f245a53e58e70:91e2e200ee32481a976937182357e...@o19455.ingest.sentry.io/38506" _instance = None def __init__(self): diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/dialogs/custom_adapters_configuration_dialog.py new/gns3-gui-2.2.26/gns3/dialogs/custom_adapters_configuration_dialog.py --- old/gns3-gui-2.2.24/gns3/dialogs/custom_adapters_configuration_dialog.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/dialogs/custom_adapters_configuration_dialog.py 2021-10-08 12:32:04.000000000 +0200 @@ -169,6 +169,9 @@ adapter_number = item.data(0, QtCore.Qt.UserRole) custom_adapter_settings["adapter_number"] = adapter_number original_port_name = item.data(1, QtCore.Qt.UserRole) + if not port_name: + QtWidgets.QMessageBox.critical(self, "Port name", "Port name cannot be empty for adapter {}".format(adapter_number)) + return False if original_port_name != port_name: custom_adapter_settings["port_name"] = port_name if self._default_adapter_type and self._adapter_types: @@ -180,13 +183,14 @@ if mac_address and mac_address != ":::::": if not re.search(r"""^([0-9a-fA-F]{2}[:]){5}[0-9a-fA-F]{2}$""", mac_address): QtWidgets.QMessageBox.critical(self, "MAC address", "Invalid MAC address (format required: hh:hh:hh:hh:hh:hh)") - return + return False default_mac_address = self._IntegerToMac(self._MacToInteger(self._base_mac_address) + adapter_number) if mac_address != default_mac_address: custom_adapter_settings["mac_address"] = mac_address if len(custom_adapter_settings) > 1: # only save if there is more than the adapter_number key self._custom_adapters.append(custom_adapter_settings.copy()) + return True def done(self, result): """ @@ -196,5 +200,6 @@ """ if result: - self._updateCustomAdapters() + if not self._updateCustomAdapters(): + return super().done(result) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/dialogs/project_dialog.py new/gns3-gui-2.2.26/gns3/dialogs/project_dialog.py --- old/gns3-gui-2.2.24/gns3/dialogs/project_dialog.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/dialogs/project_dialog.py 2021-10-08 12:32:04.000000000 +0200 @@ -53,7 +53,7 @@ if show_open_options: self.uiOpenProjectPushButton.clicked.connect(self._openProjectActionSlot) - self.uiRecentProjectsPushButton.clicked.connect(self._showRecentProjectsSlot) + self._addRecentFilesMenu() else: self.uiOpenProjectGroupBox.hide() self.uiProjectTabWidget.removeTab(1) @@ -231,12 +231,12 @@ self._main_window.openProjectActionSlot() self.reject() - def _showRecentProjectsSlot(self): + def _addRecentFilesMenu(self): """ - lot to show all the recent projects in a menu. + Add recent projects in a menu. """ - menu = QtWidgets.QMenu() + menu = QtWidgets.QMenu(parent=self) if Controller.instance().isRemote(): for action in self._main_window.recent_project_actions: menu.addAction(action) @@ -244,7 +244,7 @@ for action in self._main_window.recent_file_actions: menu.addAction(action) menu.triggered.connect(self._menuTriggeredSlot) - menu.exec_(QtGui.QCursor.pos()) + self.uiRecentProjectsPushButton.setMenu(menu) def _overwriteProjectCallback(self, result, error=False, **kwargs): if error: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/dialogs/symbol_selection_dialog.py new/gns3-gui-2.2.26/gns3/dialogs/symbol_selection_dialog.py --- old/gns3-gui-2.2.24/gns3/dialogs/symbol_selection_dialog.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/dialogs/symbol_selection_dialog.py 2021-10-08 12:32:04.000000000 +0200 @@ -119,13 +119,13 @@ """ text = self.uiSearchLineEdit.text() for item in self._symbol_items: - if not item.data(0, QtCore.Qt.UserRole).builtin(): - item.setHidden(True) + # if not item.data(0, QtCore.Qt.UserRole).builtin(): + # item.setHidden(True) + # else: + if not text.strip() or text.strip().lower() in item.text(0).lower(): + item.setHidden(False) else: - if len(text.strip()) == 0 or text.strip().lower() in item.text(0).lower(): - item.setHidden(False) - else: - item.setHidden(True) + item.setHidden(True) def _customSymbolToggledSlot(self, checked): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/graphics_view.py new/gns3-gui-2.2.26/gns3/graphics_view.py --- old/gns3-gui-2.2.24/gns3/graphics_view.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/graphics_view.py 2021-10-08 12:32:04.000000000 +0200 @@ -577,7 +577,7 @@ delta = event.angleDelta() if delta is not None and delta.x() == 0: # CTRL is pressed then use the mouse wheel to zoom in or out. - self.scaleView(pow(2.0, delta.y() / 240.0)) + self.scaleView(pow(2.0, (delta.y()/2) / 240.0)) self._topology.project().setZoom(round(self.transform().m11() * 100)) self._topology.project().update() else: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/modules/builtin/pages/cloud_preferences_page.py new/gns3-gui-2.2.26/gns3/modules/builtin/pages/cloud_preferences_page.py --- old/gns3-gui-2.2.24/gns3/modules/builtin/pages/cloud_preferences_page.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/modules/builtin/pages/cloud_preferences_page.py 2021-10-08 12:32:04.000000000 +0200 @@ -52,6 +52,7 @@ self.uiEditCloudNodePushButton.clicked.connect(self._editCloudNodeSlot) self.uiDeleteCloudNodePushButton.clicked.connect(self._deleteCloudNodeSlot) self.uiCloudNodesTreeWidget.itemSelectionChanged.connect(self._cloudNodeChangedSlot) + self.uiCloudNodesTreeWidget.itemDoubleClicked.connect(self._editCloudNodeSlot) def _createSectionItem(self, name): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/modules/builtin/pages/ethernet_hub_preferences_page.py new/gns3-gui-2.2.26/gns3/modules/builtin/pages/ethernet_hub_preferences_page.py --- old/gns3-gui-2.2.24/gns3/modules/builtin/pages/ethernet_hub_preferences_page.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/modules/builtin/pages/ethernet_hub_preferences_page.py 2021-10-08 12:32:04.000000000 +0200 @@ -53,6 +53,8 @@ self.uiEditEthernetHubPushButton.clicked.connect(self._editEthernetHubSlot) self.uiDeleteEthernetHubPushButton.clicked.connect(self._deleteEthernetHubSlot) self.uiEthernetHubsTreeWidget.itemSelectionChanged.connect(self._ethernetHubChangedSlot) + self.uiEthernetHubsTreeWidget.itemDoubleClicked.connect(self._editEthernetHubSlot) + def _createSectionItem(self, name): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/modules/builtin/pages/ethernet_switch_preferences_page.py new/gns3-gui-2.2.26/gns3/modules/builtin/pages/ethernet_switch_preferences_page.py --- old/gns3-gui-2.2.24/gns3/modules/builtin/pages/ethernet_switch_preferences_page.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/modules/builtin/pages/ethernet_switch_preferences_page.py 2021-10-08 12:32:04.000000000 +0200 @@ -53,6 +53,7 @@ self.uiEditEthernetSwitchPushButton.clicked.connect(self._editEthernetSwitchSlot) self.uiDeleteEthernetSwitchPushButton.clicked.connect(self._deleteEthernetSwitchSlot) self.uiEthernetSwitchesTreeWidget.itemSelectionChanged.connect(self._ethernetSwitchChangedSlot) + self.uiEthernetSwitchesTreeWidget.itemDoubleClicked.connect(self._editEthernetSwitchSlot) def _createSectionItem(self, name): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/modules/docker/pages/docker_vm_preferences_page.py new/gns3-gui-2.2.26/gns3/modules/docker/pages/docker_vm_preferences_page.py --- old/gns3-gui-2.2.24/gns3/modules/docker/pages/docker_vm_preferences_page.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/modules/docker/pages/docker_vm_preferences_page.py 2021-10-08 12:32:04.000000000 +0200 @@ -52,6 +52,7 @@ self.uiEditDockerVMPushButton.clicked.connect(self._dockerImageEditSlot) self.uiDeleteDockerVMPushButton.clicked.connect(self._dockerImageDeleteSlot) self.uiDockerVMsTreeWidget.itemSelectionChanged.connect(self._dockerImageChangedSlot) + self.uiDockerVMsTreeWidget.itemDoubleClicked.connect(self._dockerImageEditSlot) def _createSectionItem(self, name): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/modules/dynamips/pages/ios_router_preferences_page.py new/gns3-gui-2.2.26/gns3/modules/dynamips/pages/ios_router_preferences_page.py --- old/gns3-gui-2.2.24/gns3/modules/dynamips/pages/ios_router_preferences_page.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/modules/dynamips/pages/ios_router_preferences_page.py 2021-10-08 12:32:04.000000000 +0200 @@ -70,6 +70,7 @@ self.uiDeleteIOSRouterPushButton.clicked.connect(self._iosRouterDeleteSlot) self.uiIOSRoutersTreeWidget.itemSelectionChanged.connect(self._iosRouterChangedSlot) self.uiDecompressIOSPushButton.clicked.connect(self._decompressIOSSlot) + self.uiIOSRoutersTreeWidget.itemDoubleClicked.connect(self._iosRouterEditSlot) def _iosRouterChangedSlot(self): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/modules/iou/pages/iou_device_preferences_page.py new/gns3-gui-2.2.26/gns3/modules/iou/pages/iou_device_preferences_page.py --- old/gns3-gui-2.2.24/gns3/modules/iou/pages/iou_device_preferences_page.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/modules/iou/pages/iou_device_preferences_page.py 2021-10-08 12:32:04.000000000 +0200 @@ -59,6 +59,7 @@ self.uiEditIOUDevicePushButton.clicked.connect(self._iouDeviceEditSlot) self.uiDeleteIOUDevicePushButton.clicked.connect(self._iouDeviceDeleteSlot) self.uiIOUDevicesTreeWidget.itemSelectionChanged.connect(self._iouDeviceChangedSlot) + self.uiIOUDevicesTreeWidget.itemDoubleClicked.connect(self._iouDeviceEditSlot) def _createSectionItem(self, name): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/modules/qemu/pages/qemu_vm_configuration_page.py new/gns3-gui-2.2.26/gns3/modules/qemu/pages/qemu_vm_configuration_page.py --- old/gns3-gui-2.2.24/gns3/modules/qemu/pages/qemu_vm_configuration_page.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/modules/qemu/pages/qemu_vm_configuration_page.py 2021-10-08 12:32:04.000000000 +0200 @@ -102,6 +102,7 @@ # Supported NIC models: e1000, e1000-82544gc, e1000-82545em, e1000e, i82550, i82551, i82557a, i82557b, i82557c, i82558a # i82558b, i82559a, i82559b, i82559c, i82559er, i82562, i82801, ne2k_pci, pcnet, rocker, rtl8139, virtio-net-pci, vmxnet3 + # This list can be retrieved using "qemu-system-x86_64 -nic model=?" or "qemu-system-x86_64 -device help" self._legacy_devices = ("e1000", "i82551", "i82557b", "i82559er", "ne2k_pci", "pcnet", "rtl8139", "virtio") self._qemu_network_devices = OrderedDict([("e1000", "Intel Gigabit Ethernet"), ("e1000-82544gc", "Intel 82544GC Gigabit Ethernet"), @@ -154,6 +155,9 @@ for device_name, device_description in self._qemu_network_devices.items(): if legacy_networking and device_name not in self._legacy_devices: continue + # special case for virtio legacy networking + if not legacy_networking and device_name == "virtio": + continue self.uiAdapterTypesComboBox.addItem("{} ({})".format(device_description, device_name), device_name) @staticmethod @@ -421,7 +425,9 @@ if nic in self._legacy_devices: network_devices[nic] = desc else: - network_devices = self._qemu_network_devices + network_devices = self._qemu_network_devices.copy() + # special case for virtio legacy networking + network_devices.pop("virtio") dialog = CustomAdaptersConfigurationDialog(ports, self._custom_adapters, default_adapter, network_devices, base_mac_address, parent=self) dialog.show() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/modules/qemu/pages/qemu_vm_preferences_page.py new/gns3-gui-2.2.26/gns3/modules/qemu/pages/qemu_vm_preferences_page.py --- old/gns3-gui-2.2.24/gns3/modules/qemu/pages/qemu_vm_preferences_page.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/modules/qemu/pages/qemu_vm_preferences_page.py 2021-10-08 12:32:04.000000000 +0200 @@ -54,6 +54,7 @@ self.uiEditQemuVMPushButton.clicked.connect(self._qemuVMEditSlot) self.uiDeleteQemuVMPushButton.clicked.connect(self._qemuVMDeleteSlot) self.uiQemuVMsTreeWidget.itemSelectionChanged.connect(self._qemuVMChangedSlot) + self.uiQemuVMsTreeWidget.itemDoubleClicked.connect(self._qemuVMEditSlot) def _createSectionItem(self, name): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/modules/virtualbox/pages/virtualbox_vm_preferences_page.py new/gns3-gui-2.2.26/gns3/modules/virtualbox/pages/virtualbox_vm_preferences_page.py --- old/gns3-gui-2.2.24/gns3/modules/virtualbox/pages/virtualbox_vm_preferences_page.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/modules/virtualbox/pages/virtualbox_vm_preferences_page.py 2021-10-08 12:32:04.000000000 +0200 @@ -54,6 +54,7 @@ self.uiEditVirtualBoxVMPushButton.clicked.connect(self._vboxVMEditSlot) self.uiDeleteVirtualBoxVMPushButton.clicked.connect(self._vboxVMDeleteSlot) self.uiVirtualBoxVMsTreeWidget.itemSelectionChanged.connect(self._vboxVMChangedSlot) + self.uiVirtualBoxVMsTreeWidget.itemDoubleClicked.connect(self._vboxVMEditSlot) def _createSectionItem(self, name): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/modules/vmware/pages/vmware_vm_preferences_page.py new/gns3-gui-2.2.26/gns3/modules/vmware/pages/vmware_vm_preferences_page.py --- old/gns3-gui-2.2.24/gns3/modules/vmware/pages/vmware_vm_preferences_page.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/modules/vmware/pages/vmware_vm_preferences_page.py 2021-10-08 12:32:04.000000000 +0200 @@ -53,6 +53,7 @@ self.uiEditVMwareVMPushButton.clicked.connect(self._vmwareVMEditSlot) self.uiDeleteVMwareVMPushButton.clicked.connect(self._vmwareVMDeleteSlot) self.uiVMwareVMsTreeWidget.itemSelectionChanged.connect(self._vmwareVMChangedSlot) + self.uiVMwareVMsTreeWidget.itemDoubleClicked.connect(self._vmwareVMEditSlot) def _createSectionItem(self, name): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/modules/vpcs/pages/vpcs_node_preferences_page.py new/gns3-gui-2.2.26/gns3/modules/vpcs/pages/vpcs_node_preferences_page.py --- old/gns3-gui-2.2.24/gns3/modules/vpcs/pages/vpcs_node_preferences_page.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/modules/vpcs/pages/vpcs_node_preferences_page.py 2021-10-08 12:32:04.000000000 +0200 @@ -53,6 +53,7 @@ self.uiEditVPCSPushButton.clicked.connect(self._editVPCSSlot) self.uiDeleteVPCSPushButton.clicked.connect(self._deleteVPCSSlot) self.uiVPCSTreeWidget.itemSelectionChanged.connect(self._vpcsChangedSlot) + self.uiVPCSTreeWidget.itemDoubleClicked.connect(self._editVPCSSlot) def _createSectionItem(self, name): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/node.py new/gns3-gui-2.2.26/gns3/node.py --- old/gns3-gui-2.2.24/gns3/node.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/node.py 2021-10-08 12:32:04.000000000 +0200 @@ -558,7 +558,7 @@ del result["properties"] # Update common element of all nodes - for key in ["x", "y", "z", "locked", "symbol", "label", "console_host", "console", "console_type", "console_auto_start", "custom_adapters"]: + for key in ["x", "y", "z", "locked", "symbol", "label", "console_host", "console", "console_type", "console_auto_start", "custom_adapters", "first_port_name", "port_name_format", "port_segment_size"]: if key in result: self._settings[key] = result[key] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/nodes_view.py new/gns3-gui-2.2.26/gns3/nodes_view.py --- old/gns3-gui-2.2.24/gns3/nodes_view.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/nodes_view.py 2021-10-08 12:32:04.000000000 +0200 @@ -151,6 +151,22 @@ self._showContextualMenu(event.globalPos()) + def mouseDoubleClickEvent(self, event): + """ + Handles all mouse double click events. + + :param event: QMouseEvent instance + """ + + item = self.itemAt(event.pos()) + if item: + template = TemplateManager.instance().getTemplate(item.data(0, QtCore.Qt.UserRole)) + if template: + configuration_page = TEMPLATE_TYPE_TO_CONFIGURATION_PAGE.get(template.template_type()) + if not template.builtin() and configuration_page: + self._configurationSlot(template, configuration_page) + super().mouseDoubleClickEvent(event) + def mouseMoveEvent(self, event): """ Handles all mouse move events. @@ -204,14 +220,14 @@ menu.exec_(pos) - def _configurationSlot(self, template, configuration_page, source): + def _configurationSlot(self, template, configuration_page, source=None): dialog = ConfigurationDialog(template.name(), template.settings(), configuration_page(), parent=self) dialog.show() if dialog.exec_(): TemplateManager.instance().updateTemplate(template) - def _deleteSlot(self, template, source): + def _deleteSlot(self, template, source=None): reply = QtWidgets.QMessageBox.question(self, "Template", "Delete {} template?".format(template.name()), QtWidgets.QMessageBox.Yes, QtWidgets.QMessageBox.No) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/gns3/version.py new/gns3-gui-2.2.26/gns3/version.py --- old/gns3-gui-2.2.24/gns3/version.py 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/gns3/version.py 2021-10-08 12:32:04.000000000 +0200 @@ -23,8 +23,8 @@ # or negative for a release candidate or beta (after the base version # number has been incremented) -__version__ = "2.2.24" -__version_info__ = (2, 2, 24, 0) +__version__ = "2.2.26" +__version_info__ = (2, 2, 26, 0) if "dev" in __version__: try: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/mac-requirements.txt new/gns3-gui-2.2.26/mac-requirements.txt --- old/gns3-gui-2.2.24/mac-requirements.txt 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/mac-requirements.txt 2021-10-08 12:32:04.000000000 +0200 @@ -1,3 +1,3 @@ -rrequirements.txt -PyQt5==5.12.3 +PyQt5==5.15.4 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/requirements.txt new/gns3-gui-2.2.26/requirements.txt --- old/gns3-gui-2.2.24/requirements.txt 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/requirements.txt 2021-10-08 12:32:04.000000000 +0200 @@ -2,3 +2,4 @@ sentry-sdk==1.3.1 psutil==5.8.0 distro==1.6.0 +setuptools diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gns3-gui-2.2.24/win-requirements.txt new/gns3-gui-2.2.26/win-requirements.txt --- old/gns3-gui-2.2.24/win-requirements.txt 2021-08-25 13:01:26.000000000 +0200 +++ new/gns3-gui-2.2.26/win-requirements.txt 2021-10-08 12:32:04.000000000 +0200 @@ -1,4 +1,4 @@ -rrequirements.txt -PyQt5==5.12.3 # pyup: ignore +PyQt5==5.15.4 # pyup: ignore pywin32==301 # pyup: ignore