Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package autoyast2 for openSUSE:Factory checked in at 2021-10-29 22:33:49 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/autoyast2 (Old) and /work/SRC/openSUSE:Factory/.autoyast2.new.1890 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "autoyast2" Fri Oct 29 22:33:49 2021 rev:307 rq:927504 version:4.4.19 Changes: -------- --- /work/SRC/openSUSE:Factory/autoyast2/autoyast2.changes 2021-09-26 21:48:07.322736023 +0200 +++ /work/SRC/openSUSE:Factory/.autoyast2.new.1890/autoyast2.changes 2021-10-29 22:34:45.255693928 +0200 @@ -1,0 +2,23 @@ +Tue Oct 26 12:25:01 UTC 2021 - Jos?? Iv??n L??pez Gonz??lez <jlo...@suse.com> + +- Avoid internal error when checking signature (bsc#1192022). +- 4.4.19 + +------------------------------------------------------------------- +Tue Oct 26 07:40:25 UTC 2021 - Knut Anderssen <kanders...@suse.com> + +- Add the "keep_unknown_lv" element to the partitioning schema + (bsc#1191968). +- 4.4.18 + +------------------------------------------------------------------- +Mon Oct 25 13:15:23 UTC 2021 - Knut Anderssen <kanders...@suse.com> + +- bsc#1191695 + - Consider the environment attribute when importing the script + section. + - Do not report feedback when running a script and the log + content is empty. +- 4.4.17 + +------------------------------------------------------------------- Old: ---- autoyast2-4.4.16.tar.bz2 New: ---- autoyast2-4.4.19.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ autoyast2.spec ++++++ --- /var/tmp/diff_new_pack.zKcYzp/_old 2021-10-29 22:34:45.787694129 +0200 +++ /var/tmp/diff_new_pack.zKcYzp/_new 2021-10-29 22:34:45.795694132 +0200 @@ -22,7 +22,7 @@ %endif Name: autoyast2 -Version: 4.4.16 +Version: 4.4.19 Release: 0 Summary: YaST2 - Automated Installation License: GPL-2.0-only ++++++ autoyast2-4.4.16.tar.bz2 -> autoyast2-4.4.19.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.16/.github/workflows/ci.yml new/autoyast2-4.4.19/.github/workflows/ci.yml --- old/autoyast2-4.4.16/.github/workflows/ci.yml 2021-09-21 18:06:19.000000000 +0200 +++ new/autoyast2-4.4.19/.github/workflows/ci.yml 2021-10-26 14:33:02.000000000 +0200 @@ -8,7 +8,9 @@ jobs: Tests: runs-on: ubuntu-latest - container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + container: + image: registry.opensuse.org/yast/head/containers/yast-ruby:latest + options: --privileged steps: @@ -33,7 +35,9 @@ Rubocop: runs-on: ubuntu-latest - container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + container: + image: registry.opensuse.org/yast/head/containers/yast-ruby:latest + options: --privileged steps: @@ -45,7 +49,9 @@ Package: runs-on: ubuntu-latest - container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + container: + image: registry.opensuse.org/yast/head/containers/yast-ruby:latest + options: --privileged steps: @@ -57,7 +63,9 @@ Yardoc: runs-on: ubuntu-latest - container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + container: + image: registry.opensuse.org/yast/head/containers/yast-ruby:latest + options: --privileged steps: @@ -71,7 +79,9 @@ # checks into one job avoids that overhead Checks: runs-on: ubuntu-latest - container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + container: + image: registry.opensuse.org/yast/head/containers/yast-ruby:latest + options: --privileged steps: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.16/package/autoyast2.changes new/autoyast2-4.4.19/package/autoyast2.changes --- old/autoyast2-4.4.16/package/autoyast2.changes 2021-09-21 18:06:19.000000000 +0200 +++ new/autoyast2-4.4.19/package/autoyast2.changes 2021-10-26 14:33:02.000000000 +0200 @@ -1,4 +1,27 @@ ------------------------------------------------------------------- +Tue Oct 26 12:25:01 UTC 2021 - Jos?? Iv??n L??pez Gonz??lez <jlo...@suse.com> + +- Avoid internal error when checking signature (bsc#1192022). +- 4.4.19 + +------------------------------------------------------------------- +Tue Oct 26 07:40:25 UTC 2021 - Knut Anderssen <kanders...@suse.com> + +- Add the "keep_unknown_lv" element to the partitioning schema + (bsc#1191968). +- 4.4.18 + +------------------------------------------------------------------- +Mon Oct 25 13:15:23 UTC 2021 - Knut Anderssen <kanders...@suse.com> + +- bsc#1191695 + - Consider the environment attribute when importing the script + section. + - Do not report feedback when running a script and the log + content is empty. +- 4.4.17 + +------------------------------------------------------------------- Tue Sep 21 11:13:59 UTC 2021 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> - Add the "hostname" element to the rules schema (bsc#1190696). diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.16/package/autoyast2.spec new/autoyast2-4.4.19/package/autoyast2.spec --- old/autoyast2-4.4.16/package/autoyast2.spec 2021-09-21 18:06:19.000000000 +0200 +++ new/autoyast2-4.4.19/package/autoyast2.spec 2021-10-26 14:33:02.000000000 +0200 @@ -22,7 +22,7 @@ %endif Name: autoyast2 -Version: 4.4.16 +Version: 4.4.19 Release: 0 Summary: YaST2 - Automated Installation License: GPL-2.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.16/src/autoyast-rnc/partitioning.rnc new/autoyast2-4.4.19/src/autoyast-rnc/partitioning.rnc --- old/autoyast2-4.4.16/src/autoyast-rnc/partitioning.rnc 2021-09-21 18:06:19.000000000 +0200 +++ new/autoyast2-4.4.19/src/autoyast-rnc/partitioning.rnc 2021-10-26 14:33:02.000000000 +0200 @@ -17,6 +17,7 @@ element initialize { BOOLEAN }? & element is_lvm_vg { BOOLEAN }? & element lvm2 { BOOLEAN }? & + element keep_unknown_lv { BOOLEAN }? & element pesize { STRING }? & element type { SYMBOL }? & element use { STRING }? & diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.16/src/lib/autoinstall/autoinst_profile/script_section.rb new/autoyast2-4.4.19/src/lib/autoinstall/autoinst_profile/script_section.rb --- old/autoyast2-4.4.16/src/lib/autoinstall/autoinst_profile/script_section.rb 2021-09-21 18:06:19.000000000 +0200 +++ new/autoyast2-4.4.19/src/lib/autoinstall/autoinst_profile/script_section.rb 2021-10-26 14:33:02.000000000 +0200 @@ -29,6 +29,7 @@ def self.attributes [ { name: :chrooted }, + { name: :environment }, { name: :filename }, { name: :interpreter }, { name: :location }, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.16/src/lib/autoinstall/pkg_gpg_check_handler.rb new/autoyast2-4.4.19/src/lib/autoinstall/pkg_gpg_check_handler.rb --- old/autoyast2-4.4.16/src/lib/autoinstall/pkg_gpg_check_handler.rb 2021-09-21 18:06:19.000000000 +0200 +++ new/autoyast2-4.4.19/src/lib/autoinstall/pkg_gpg_check_handler.rb 2021-10-26 14:33:02.000000000 +0200 @@ -147,9 +147,9 @@ # @param [String] url Repository URL # @return [Yast::ProfileHash] Signature handling settings for the given add-on. def get_addon_config(profile, url) - addon_config = - addons_config(profile).find { |c| c["media_url"] == url } || - Yast::ProfileHash.new + config = addons_config(profile).find { |c| c["media_url"] == url } + addon_config = Yast::ProfileHash.new(config || {}) + general_config = profile.fetch_as_hash("general") general_config.fetch_as_hash("signature-handling") .merge(addon_config.fetch_as_hash("signature-handling")) @@ -161,7 +161,7 @@ # of an AutoYaST profile. # # @param [Yast::ProfileHash] profile AutoYaST profile. - # @return [Yast::ProfileHash] Add-ons section from profile. + # @return [Array<Hash>] Add-ons section from profile. def addons_config(profile) profile.fetch_as_hash("add-on").fetch_as_array("add_on_products") end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.16/src/lib/autoinstall/script_runner.rb new/autoyast2-4.4.19/src/lib/autoinstall/script_runner.rb --- old/autoyast2-4.4.16/src/lib/autoinstall/script_runner.rb 2021-09-21 18:06:19.000000000 +0200 +++ new/autoyast2-4.4.19/src/lib/autoinstall/script_runner.rb 2021-10-26 14:33:02.000000000 +0200 @@ -70,6 +70,7 @@ return if script.feedback.value == :no feedback = Yast::SCR.Read(Yast::Path.new(".target.string"), script.log_path) + return if feedback.to_s.strip.empty? case script.feedback.value when :popup diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.16/test/lib/autoinstall/ask/script_section_test.rb new/autoyast2-4.4.19/test/lib/autoinstall/ask/script_section_test.rb --- old/autoyast2-4.4.16/test/lib/autoinstall/ask/script_section_test.rb 2021-09-21 18:06:19.000000000 +0200 +++ new/autoyast2-4.4.19/test/lib/autoinstall/ask/script_section_test.rb 2021-10-26 14:33:02.000000000 +0200 @@ -23,13 +23,15 @@ describe Y2Autoinstall::AutoinstProfile::ScriptSection do describe ".new_from_hashes" do let(:hash) do - { "filename" => "script.sh" } + { "filename" => "script.sh", + "environment" => true } end it "returns an ScriptSection with the given attributes" do section = described_class.new_from_hashes(hash) expect(section.filename).to eq("script.sh") + expect(section.environment).to eq(true) end end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.16/test/lib/autoinstall/script_runner_test.rb new/autoyast2-4.4.19/test/lib/autoinstall/script_runner_test.rb --- old/autoyast2-4.4.16/test/lib/autoinstall/script_runner_test.rb 2021-09-21 18:06:19.000000000 +0200 +++ new/autoyast2-4.4.19/test/lib/autoinstall/script_runner_test.rb 2021-10-26 14:33:02.000000000 +0200 @@ -28,10 +28,12 @@ let(:spec) { { "filename" => "test.sh" } } describe "#run" do + let(:logs_content) { "logs content" } + before do allow(Yast::SCR).to receive(:Read) .with(Yast::Path.new(".target.string"), script.log_path) - .and_return("logs content") + .and_return(logs_content) allow(script).to receive(:execute).and_return(true) end @@ -76,12 +78,23 @@ end end - context "when feedback is enabled but the type is not set" do - let(:spec) { { "feedback" => true } } + context "when feedback is enabled" do + context "but the type is not set" do + let(:spec) { { "feedback" => true } } - it "displays the logs in a pop-up" do - expect(Yast::Popup).to receive(:LongText) - runner.run(script) + it "displays the logs in a pop-up" do + expect(Yast::Popup).to receive(:LongText) + runner.run(script) + end + end + + context "but the log is empty" do + let(:logs_content) { "" } + + it "does not report or display anything" do + expect(Yast::Popup).to_not receive(:ShowFeedback) + runner.run(script) + end end end @@ -91,7 +104,7 @@ end it "displays the logs as a regular message" do - expect(Yast::Report).to receive(:Message).with("logs content") + expect(Yast::Report).to receive(:Message).with(logs_content) runner.run(script) end end @@ -102,7 +115,7 @@ end it "displays the logs as a warning" do - expect(Yast::Report).to receive(:Warning).with("logs content") + expect(Yast::Report).to receive(:Warning).with(logs_content) runner.run(script) end end @@ -113,7 +126,7 @@ end it "displays the logs as a error" do - expect(Yast::Report).to receive(:Error).with("logs content") + expect(Yast::Report).to receive(:Error).with(logs_content) runner.run(script) end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.16/test/lib/clients/clone_system_test.rb new/autoyast2-4.4.19/test/lib/clients/clone_system_test.rb --- old/autoyast2-4.4.16/test/lib/clients/clone_system_test.rb 2021-09-21 18:06:19.000000000 +0200 +++ new/autoyast2-4.4.19/test/lib/clients/clone_system_test.rb 2021-10-26 14:33:02.000000000 +0200 @@ -35,6 +35,7 @@ let(:normal?) { true } let(:package_installed?) { true } let(:tmp_dir) { Dir.mktmpdir("YaST-") } + let(:profile) { {} } let(:profile_path) { File.join(tmp_dir, "autoinst.xml") } let(:profile_exists?) { false } @@ -54,6 +55,10 @@ ) end + before do + allow(Yast::Profile).to receive(:current).and_return(profile) + end + around(:each) do |example| example.run ensure @@ -87,10 +92,6 @@ let(:args) { ["modules"] } let(:profile) { { "general" => { "mode" => { "confirm" => true } } } } - before do - allow(Yast::Profile).to receive(:current).and_return(profile) - end - context "when the target file already exists" do let(:profile_exists?) { true } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.16/test/lib/pkg_gpg_check_handler_test.rb new/autoyast2-4.4.19/test/lib/pkg_gpg_check_handler_test.rb --- old/autoyast2-4.4.16/test/lib/pkg_gpg_check_handler_test.rb 2021-09-21 18:06:19.000000000 +0200 +++ new/autoyast2-4.4.19/test/lib/pkg_gpg_check_handler_test.rb 2021-10-26 14:33:02.000000000 +0200 @@ -280,11 +280,11 @@ }, "add-on" => { "add_on_products" => [ - Yast::ProfileHash.new( + { "media_url" => "http://dl.opensuse.org/repos/YaST:/Head", "name" => "yast_head", "signature-handling" => { "accept_unsigned_file" => false } - ) + } ] } )