Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package otpclient for openSUSE:Factory
checked in at 2021-11-20 02:39:25
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/otpclient (Old)
and /work/SRC/openSUSE:Factory/.otpclient.new.1895 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "otpclient"
Sat Nov 20 02:39:25 2021 rev:10 rq:932559 version:2.4.7
Changes:
--------
--- /work/SRC/openSUSE:Factory/otpclient/otpclient.changes 2021-11-17
01:14:45.546183474 +0100
+++ /work/SRC/openSUSE:Factory/.otpclient.new.1895/otpclient.changes
2021-11-20 02:40:39.160480704 +0100
@@ -1,0 +2,8 @@
+Fri Nov 19 15:43:40 UTC 2021 - Paolo Stivanin <i...@paolostivanin.com>
+
+- Update to 2.4.7:
+ * do not use strlen in for loop
+ * do not use strlen to check for empty string
+ * update CMakeLists.txt with the correct version
+
+-------------------------------------------------------------------
Old:
----
v2.4.6.tar.gz
v2.4.6.tar.gz.asc
New:
----
v2.4.7.tar.gz
v2.4.7.tar.gz.asc
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ otpclient.spec ++++++
--- /var/tmp/diff_new_pack.amMr1X/_old 2021-11-20 02:40:39.668479028 +0100
+++ /var/tmp/diff_new_pack.amMr1X/_new 2021-11-20 02:40:39.672479014 +0100
@@ -18,7 +18,7 @@
%define uclname OTPClient
Name: otpclient
-Version: 2.4.6
+Version: 2.4.7
Release: 0
Summary: Simple GTK+ client for managing TOTP and HOTP
License: GPL-3.0-or-later
++++++ v2.4.6.tar.gz -> v2.4.7.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.6/.gitignore
new/OTPClient-2.4.7/.gitignore
--- old/OTPClient-2.4.6/.gitignore 2021-11-15 14:34:24.000000000 +0100
+++ new/OTPClient-2.4.7/.gitignore 2021-11-16 20:22:50.000000000 +0100
@@ -5,6 +5,7 @@
flatpak/repo/
TODO*
.idea/
+.PVS-Studio/
# Object files
*.o
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.6/CMakeLists.txt
new/OTPClient-2.4.7/CMakeLists.txt
--- old/OTPClient-2.4.6/CMakeLists.txt 2021-11-15 14:34:24.000000000 +0100
+++ new/OTPClient-2.4.7/CMakeLists.txt 2021-11-16 20:22:50.000000000 +0100
@@ -1,5 +1,5 @@
cmake_minimum_required(VERSION 3.5)
-project(OTPClient VERSION "2.4.4" LANGUAGES "C")
+project(OTPClient VERSION "2.4.7" LANGUAGES "C")
configure_file("src/common/version.h.in" "version.h")
include_directories(${PROJECT_BINARY_DIR})
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/OTPClient-2.4.6/data/com.github.paolostivanin.OTPClient.appdata.xml
new/OTPClient-2.4.7/data/com.github.paolostivanin.OTPClient.appdata.xml
--- old/OTPClient-2.4.6/data/com.github.paolostivanin.OTPClient.appdata.xml
2021-11-15 14:34:24.000000000 +0100
+++ new/OTPClient-2.4.7/data/com.github.paolostivanin.OTPClient.appdata.xml
2021-11-16 20:22:50.000000000 +0100
@@ -83,6 +83,26 @@
</content_rating>
<releases>
+ <release version="2.4.7" date="2021-11-16">
+ <description>
+ <p>OTPClient 2.4.7 implements some small code optimization</p>
+ <ul>
+ <li>do not use strlen in for loop</li>
+ <li>do not use strlen to check for empty string</li>
+ </ul>
+ </description>
+ </release>
+ <release version="2.4.6" date="2021-11-15">
+ <description>
+ <p>OTPClient 2.4.6 fixes some small issues</p>
+ <ul>
+ <li>check for NULL when comparing account and issuer</li>
+ <li>use secure_strdup when trimming the account key</li>
+ <li>fix account/issuer when importing andOTP db (tested with latest
available version)</li>
+ <li>use g_memdup2 when available</li>
+ </ul>
+ </description>
+ </release>
<release version="2.4.4" date="2021-03-30">
<description>
<p>OTPClient 2.4.4 disabled a broken feature</p>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/OTPClient-2.4.6/flatpak/com.github.paolostivanin.OTPClient.yaml
new/OTPClient-2.4.7/flatpak/com.github.paolostivanin.OTPClient.yaml
--- old/OTPClient-2.4.6/flatpak/com.github.paolostivanin.OTPClient.yaml
2021-11-15 14:34:24.000000000 +0100
+++ new/OTPClient-2.4.7/flatpak/com.github.paolostivanin.OTPClient.yaml
2021-11-16 20:22:50.000000000 +0100
@@ -1,6 +1,6 @@
app-id: com.github.paolostivanin.OTPClient
runtime: org.gnome.Platform
-runtime-version: '3.38'
+runtime-version: '41'
sdk: org.gnome.Sdk
command: otpclient
finish-args:
@@ -36,8 +36,8 @@
- "/lib/*.la"
sources:
- type: archive
- url: https://libzip.org/download/libzip-1.7.3.tar.xz
- sha256: a60473ffdb7b4260c08bfa19c2ccea0438edac11193c3afbbb1f17fbcf6c6132
+ url: https://libzip.org/download/libzip-1.8.0.tar.xz
+ sha256: f0763bda24ba947e80430be787c4b068d8b6aa6027a26a19923f0acfa3dac97e
- name: jansson
cleanup:
- "/include"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.6/src/add-common.c
new/OTPClient-2.4.7/src/add-common.c
--- old/OTPClient-2.4.6/src/add-common.c 2021-11-15 14:34:24.000000000
+0100
+++ new/OTPClient-2.4.7/src/add-common.c 2021-11-16 20:22:50.000000000
+0100
@@ -40,7 +40,7 @@
return g_strdup ("Label can not be empty, otp not imported");
}
- if (strlen (otp->secret) == 0) {
+ if (otp->secret[0] == '\0') {
return g_strdup ("Secret can not be empty, otp not imported");
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.6/src/parse-data.c
new/OTPClient-2.4.7/src/parse-data.c
--- old/OTPClient-2.4.6/src/parse-data.c 2021-11-15 14:34:24.000000000
+0100
+++ new/OTPClient-2.4.7/src/parse-data.c 2021-11-16 20:22:50.000000000
+0100
@@ -124,7 +124,8 @@
static gboolean
str_is_only_num_or_alpha (const gchar *string)
{
- for (gint i = 0; i < strlen (string); i++) {
+ size_t s_len = strlen (string);
+ for (gint i = 0; i < s_len; i++) {
if (!g_ascii_isalnum (string[i])) {
return FALSE;
}
@@ -136,7 +137,8 @@
static gboolean
str_is_only_num (const gchar *string)
{
- for (gint i = 0; i < strlen (string); i++) {
+ size_t s_len = strlen (string);
+ for (gint i = 0; i < s_len; i++) {
if (!g_ascii_isdigit (string[i])) {
return FALSE;
}
