Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-users for openSUSE:Factory
checked in at 2021-12-03 20:35:28
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-users (Old)
and /work/SRC/openSUSE:Factory/.yast2-users.new.31177 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-users"
Fri Dec 3 20:35:28 2021 rev:249 rq:935235 version:4.4.9
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-users/yast2-users.changes 2021-11-13
22:48:47.873262476 +0100
+++ /work/SRC/openSUSE:Factory/.yast2-users.new.31177/yast2-users.changes
2021-12-03 20:35:42.308155894 +0100
@@ -1,0 +2,7 @@
+Tue Nov 30 20:40:58 UTC 2021 - David Diaz <dgonza...@suse.com>
+
+- AutoYaST: do not warning about deprecated <group_password>
+ when it is empty, "x", "!", or "*" (related to jsc#SLE-20592).
+- 4.4.9
+
+-------------------------------------------------------------------
Old:
----
yast2-users-4.4.8.tar.bz2
New:
----
yast2-users-4.4.9.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-users.spec ++++++
--- /var/tmp/diff_new_pack.pRThQO/_old 2021-12-03 20:35:42.800154096 +0100
+++ /var/tmp/diff_new_pack.pRThQO/_new 2021-12-03 20:35:42.800154096 +0100
@@ -17,7 +17,7 @@
Name: yast2-users
-Version: 4.4.8
+Version: 4.4.9
Release: 0
Summary: YaST2 - User and Group Configuration
License: GPL-2.0-only
++++++ yast2-users-4.4.8.tar.bz2 -> yast2-users-4.4.9.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-users-4.4.8/package/yast2-users.changes
new/yast2-users-4.4.9/package/yast2-users.changes
--- old/yast2-users-4.4.8/package/yast2-users.changes 2021-11-12
16:05:52.000000000 +0100
+++ new/yast2-users-4.4.9/package/yast2-users.changes 2021-12-01
10:29:25.000000000 +0100
@@ -1,4 +1,11 @@
-------------------------------------------------------------------
+Tue Nov 30 20:40:58 UTC 2021 - David Diaz <dgonza...@suse.com>
+
+- AutoYaST: do not warning about deprecated <group_password>
+ when it is empty, "x", "!", or "*" (related to jsc#SLE-20592).
+- 4.4.9
+
+-------------------------------------------------------------------
Tue Oct 19 10:36:08 UTC 2021 - Jos?? Iv??n L??pez Gonz??lez <jlo...@suse.com>
- Users client uses the shadow tools to write changes into the
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-users-4.4.8/package/yast2-users.spec
new/yast2-users-4.4.9/package/yast2-users.spec
--- old/yast2-users-4.4.8/package/yast2-users.spec 2021-11-12
16:05:52.000000000 +0100
+++ new/yast2-users-4.4.9/package/yast2-users.spec 2021-12-01
10:29:25.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2-users
-Version: 4.4.8
+Version: 4.4.9
Release: 0
Summary: YaST2 - User and Group Configuration
License: GPL-2.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-users-4.4.8/src/lib/y2users/autoinst/reader.rb
new/yast2-users-4.4.9/src/lib/y2users/autoinst/reader.rb
--- old/yast2-users-4.4.8/src/lib/y2users/autoinst/reader.rb 2021-11-12
16:05:52.000000000 +0100
+++ new/yast2-users-4.4.9/src/lib/y2users/autoinst/reader.rb 2021-12-01
10:29:25.000000000 +0100
@@ -107,6 +107,16 @@
private
+ # Group password values that actually means "no password".
+ #
+ # Although YaST does not support group passwords anymore and ignores
them when importing the
+ # profile, the user receives a warning about it ONLY when found a
`<group_password>` with none
+ # of these values, which means *no password*.
+ #
+ # @see #check_group_password
+ BLANK_GROUP_PASSWORD = ["", "x", "*", "!"].freeze
+ private_constant :BLANK_GROUP_PASSWORD
+
# Profile section describing the users
#
# @return [AutoinstProfile::UsersSection]
@@ -232,18 +242,14 @@
false
end
- # Check if given group contains a group password for warning about
- # ignoring it
- #
- # @note empty or "x" password actually means no password and the user
- # will be not warned about it.
+ # Check if given group contains a group password for warning about
ignoring it
#
# @param group_section [Installation::AutoinstProfile::GroupSection]
# @param issues [Y2Issues::List] Issues list
def check_group_password(group_section, issues)
group_password = group_section.group_password.to_s
- return if group_password.empty? || group_password == "x"
+ return if BLANK_GROUP_PASSWORD.include?(group_password)
issues << Y2Issues::Issue.new(
_("Attribute no longer supported by YaST. Ignoring it."),
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-users-4.4.8/test/lib/y2users/autoinst/reader_test.rb
new/yast2-users-4.4.9/test/lib/y2users/autoinst/reader_test.rb
--- old/yast2-users-4.4.8/test/lib/y2users/autoinst/reader_test.rb
2021-11-12 16:05:52.000000000 +0100
+++ new/yast2-users-4.4.9/test/lib/y2users/autoinst/reader_test.rb
2021-12-01 10:29:25.000000000 +0100
@@ -548,6 +548,24 @@
expect(result.issues).to be_empty
end
end
+
+ context "but it is '!' (which means no password)" do
+ let(:group_password) { "!" }
+
+ it "does not register an issue" do
+ result = subject.read
+ expect(result.issues).to be_empty
+ end
+ end
+
+ context "but it is '*' (which means no password)" do
+ let(:group_password) { "*" }
+
+ it "does not register an issue" do
+ result = subject.read
+ expect(result.issues).to be_empty
+ end
+ end
end
end
end
