Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package mpg123 for openSUSE:Factory checked in at 2021-12-13 20:41:52 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/mpg123 (Old) and /work/SRC/openSUSE:Factory/.mpg123.new.2520 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "mpg123" Mon Dec 13 20:41:52 2021 rev:27 rq:940075 version:1.29.3 Changes: -------- --- /work/SRC/openSUSE:Factory/mpg123/mpg123.changes 2021-10-26 20:13:35.706006679 +0200 +++ /work/SRC/openSUSE:Factory/.mpg123.new.2520/mpg123.changes 2021-12-13 20:46:34.908501141 +0100 @@ -1,0 +2,17 @@ +Sun Dec 12 11:48:03 UTC 2021 - Luigi Baldoni <aloi...@gmx.com> + +- Update to version 1.29.3 + libmpg123: + * Catch more NULL pointer arguments in LFS wrappers + (most prominently: mpg123_feedseek(), bug 328). + mpg123: + * Fix regression that did _not_ enable --remote-err on -s + anymore. + * Fix typos in man page (thanks to Naglis Jonaitis). + * Drop mixed-up value limits on remote control SEQ command. It + is up to you if you want to distort your sound. + * Add note about equalizer frequency bands to man page. + build: + * add BUILD_PROGRAMS option to ports/cmake + +------------------------------------------------------------------- Old: ---- mpg123-1.29.2.tar.bz2 mpg123-1.29.2.tar.bz2.sig New: ---- mpg123-1.29.3.tar.bz2 mpg123-1.29.3.tar.bz2.sig ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ mpg123.spec ++++++ --- /var/tmp/diff_new_pack.Jf4wMl/_old 2021-12-13 20:46:35.644501231 +0100 +++ /var/tmp/diff_new_pack.Jf4wMl/_new 2021-12-13 20:46:35.648501232 +0100 @@ -18,7 +18,7 @@ %define sover 0 Name: mpg123 -Version: 1.29.2 +Version: 1.29.3 Release: 0 Summary: Console MPEG audio player and decoder library License: LGPL-2.1-only ++++++ mpg123-1.29.2.tar.bz2 -> mpg123-1.29.3.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.29.2/NEWS new/mpg123-1.29.3/NEWS --- old/mpg123-1.29.2/NEWS 2021-10-23 12:51:19.000000000 +0200 +++ new/mpg123-1.29.3/NEWS 2021-12-10 08:00:58.000000000 +0100 @@ -1,3 +1,15 @@ +1.29.3 +------ +- libmpg123: Catch more NULL pointer arguments in LFS wrappers + (most prominently: mpg123_feedseek(), bug 328). +- mpg123: +-- Fix regression that did _not_ enable --remote-err on -s anymore. +-- Fix typos in man page (thanks to Naglis Jonaitis). +-- Drop mixed-up value limits on remote control SEQ command. It is up to you + if you want to distort your sound. +-- Add note about equalizer frequency bands to man page. +- build: add BUILD_PROGRAMS option to ports/cmake + 1.29.2 ------ - libmpg123: Fix non-live-decoder safeguard for mpg123_framebyframe_decode() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.29.2/configure new/mpg123-1.29.3/configure --- old/mpg123-1.29.2/configure 2021-10-23 12:52:49.000000000 +0200 +++ new/mpg123-1.29.3/configure 2021-12-10 08:02:07.000000000 +0100 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for mpg123 1.29.2. +# Generated by GNU Autoconf 2.69 for mpg123 1.29.3. # # Report bugs to <maintai...@mpg123.org>. # @@ -590,8 +590,8 @@ # Identity of this package. PACKAGE_NAME='mpg123' PACKAGE_TARNAME='mpg123' -PACKAGE_VERSION='1.29.2' -PACKAGE_STRING='mpg123 1.29.2' +PACKAGE_VERSION='1.29.3' +PACKAGE_STRING='mpg123 1.29.3' PACKAGE_BUGREPORT='maintai...@mpg123.org' PACKAGE_URL='' @@ -1668,7 +1668,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures mpg123 1.29.2 to adapt to many kinds of systems. +\`configure' configures mpg123 1.29.3 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1739,7 +1739,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of mpg123 1.29.2:";; + short | recursive ) echo "Configuration of mpg123 1.29.3:";; esac cat <<\_ACEOF @@ -1970,7 +1970,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -mpg123 configure 1.29.2 +mpg123 configure 1.29.3 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -2576,7 +2576,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by mpg123 $as_me 1.29.2, which was +It was created by mpg123 $as_me 1.29.3, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -2926,7 +2926,7 @@ API_VERSION=46 -LIB_PATCHLEVEL=6 +LIB_PATCHLEVEL=7 OUTAPI_VERSION=4 OUTLIB_PATCHLEVEL=3 @@ -3535,7 +3535,7 @@ # Define the identity of the package. PACKAGE='mpg123' - VERSION='1.29.2' + VERSION='1.29.3' cat >>confdefs.h <<_ACEOF @@ -20420,7 +20420,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by mpg123 $as_me 1.29.2, which was +This file was extended by mpg123 $as_me 1.29.3, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -20486,7 +20486,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -mpg123 config.status 1.29.2 +mpg123 config.status 1.29.3 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.29.2/configure.ac new/mpg123-1.29.3/configure.ac --- old/mpg123-1.29.2/configure.ac 2021-10-23 12:51:19.000000000 +0200 +++ new/mpg123-1.29.3/configure.ac 2021-12-10 08:00:58.000000000 +0100 @@ -9,12 +9,12 @@ AC_PREREQ([2.69]) dnl ############# Initialisation -AC_INIT([mpg123], [1.29.2], [maintai...@mpg123.org]) +AC_INIT([mpg123], [1.29.3], [maintai...@mpg123.org]) dnl Increment API_VERSION when the API gets changes (new functions). dnl libmpg123 API_VERSION=46 -LIB_PATCHLEVEL=6 +LIB_PATCHLEVEL=7 dnl libout123 OUTAPI_VERSION=4 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.29.2/man1/mpg123.1 new/mpg123-1.29.3/man1/mpg123.1 --- old/mpg123-1.29.2/man1/mpg123.1 2021-10-23 12:51:19.000000000 +0200 +++ new/mpg123-1.29.3/man1/mpg123.1 2021-12-10 08:00:58.000000000 +0100 @@ -59,7 +59,7 @@ tries to keep the playback alive at all costs, including skipping invalid material and searching new header when something goes wrong. With this switch you can make it bail out on data errors (and perhaps spare your ears a bad time). Note that this switch has been renamed from \-\-resync. -The old name still works, but is not advertised or recommened to use (subject to removal in future). +The old name still works, but is not advertised or recommended to use (subject to removal in future). .TP .BR \-F ", " \-\^\-no\-frankenstein Disable support for Frankenstein streams. Normally, mpg123 stays true to the concept of MPEG audio being @@ -90,7 +90,7 @@ ``HTTP SUPPORT'' section. .TP \fB\-u \fIauth\fR, \fB\-\^\-auth \fIauth -HTTP authentication to use when recieving files via HTTP. +HTTP authentication to use when receiving files via HTTP. The format used is user:password. .TP \fB\-\^\-ignore\-mime @@ -131,7 +131,7 @@ \fB\-l \fIn\fR, \fB\-\^\-listentry \fIn Of the playlist, play specified entry only. .I n -is the number of entry starting at 1. A value of 0 is the default and means playling the whole list, a negative value means showing of the list of titles with their numbers... +is the number of entry starting at 1. A value of 0 is the default and means playing the whole list, a negative value means showing of the list of titles with their numbers... .TP \fB\-\^\-continue Enable playlist continuation mode. This changes frame skipping to apply only to the first track and also continues to play following tracks in playlist after the selected one. Also, the option to play a number of frames only applies to the whole playlist. Basically, this tries to treat the playlist more like one big stream (like, an audio book). @@ -229,7 +229,7 @@ .BR \-\-cpu\ \fIdecoder\-type Selects a certain decoder (optimized for specific CPU), for example i586 or MMX. The list of available decoders can vary; depending on the build and what your CPU supports. -This options is only availabe when the build actually includes several optimized decoders. +This option is only available when the build actually includes several optimized decoders. .TP .BR \-\-test\-cpu Tests your CPU and prints a list of possible choices for \-\-cpu. @@ -335,6 +335,10 @@ a certain frequency band, respectively. The first line corresponds to the lowest, the 32nd to the highest frequency band. Note that you can control the equalizer interactively with the generic control interface. +Also note that these are the 32 bands of the MPEG codec, not spaced like you +would see for a usual graphic equalizer. The upside is that there is zero computational +cost in addition to decoding. The downside is that you roughly have bass in band 0, +(upper) mids in band 1, treble in all others. .TP \fB\-\^\-gapless Enable code that cuts (junk) samples at beginning and end of tracks, enabling gapless transitions between MPEG files when encoder padding and codec delays would prevent it. @@ -431,9 +435,7 @@ .TP .BR \-\^\-remote\-err Print responses for generic control mode to standard error, not standard out. -This is automatically triggered when using -.B -s -N. +This is automatically triggered when using \fB-s\fR. .TP \fB\-\-fifo \fIpath Create a fifo / named pipe on the given path and use that for reading commands instead of standard input. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.29.2/mpg123.spec new/mpg123-1.29.3/mpg123.spec --- old/mpg123-1.29.2/mpg123.spec 2021-10-23 12:55:33.000000000 +0200 +++ new/mpg123-1.29.3/mpg123.spec 2021-12-10 08:02:50.000000000 +0100 @@ -3,7 +3,7 @@ # - devel packages for alsa, sdl, etc... to build the respective output modules. Summary: The fast console mpeg audio decoder/player. Name: mpg123 -Version: 1.29.2 +Version: 1.29.3 Release: 1 URL: http://www.mpg123.org/ License: GPL diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.29.2/ports/cmake/src/CMakeLists.txt new/mpg123-1.29.3/ports/cmake/src/CMakeLists.txt --- old/mpg123-1.29.2/ports/cmake/src/CMakeLists.txt 2021-10-23 12:51:19.000000000 +0200 +++ new/mpg123-1.29.3/ports/cmake/src/CMakeLists.txt 2021-12-10 08:00:58.000000000 +0100 @@ -373,67 +373,71 @@ add_subdirectory("libsyn123") if(UNIX) - add_subdirectory("tests") + option(BUILD_PROGRAMS "Build programs" ON) - if(BUILD_LIBOUT123) - add_executable(${PROJECT_NAME} - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/audio.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/common.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/sysutil.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/control_generic.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/equalizer.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/getlopt.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/httpget.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/resolver.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/genre.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/mpg123.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/metaprint.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/local.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/playlist.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/streamdump.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/term.c") - target_link_libraries(${PROJECT_NAME} PRIVATE - compat - lib${PROJECT_NAME} - libout123 - libsyn123 - ${GETHOSTBYNAME_LIB} - ${SOCKET_LIB} - $<$<BOOL:${HAVE_M}>:m>) - - add_executable(out123 - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/sysutil.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/getlopt.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/filters.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/local.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/out123.c") - target_link_libraries(out123 PRIVATE + if(BUILD_PROGRAMS) + add_subdirectory("tests") + + if(BUILD_LIBOUT123) + add_executable(${PROJECT_NAME} + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/audio.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/common.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/sysutil.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/control_generic.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/equalizer.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/getlopt.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/httpget.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/resolver.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/genre.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/mpg123.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/metaprint.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/local.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/playlist.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/streamdump.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/term.c") + target_link_libraries(${PROJECT_NAME} PRIVATE + compat + lib${PROJECT_NAME} + libout123 + libsyn123 + ${GETHOSTBYNAME_LIB} + ${SOCKET_LIB} + $<$<BOOL:${HAVE_M}>:m>) + + add_executable(out123 + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/sysutil.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/getlopt.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/filters.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/local.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/out123.c") + target_link_libraries(out123 PRIVATE + lib${PROJECT_NAME} + libout123 + libsyn123) + install(TARGETS ${PROJECT_NAME} out123 + EXPORT targets + ARCHIVE DESTINATION "${CMAKE_INSTALL_LIBDIR}/" + LIBRARY DESTINATION "${CMAKE_INSTALL_LIBDIR}/" + RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}/") + endif() + + add_executable(${PROJECT_NAME}-id3dump + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/mpg123-id3dump.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/getlopt.c") + target_link_libraries(${PROJECT_NAME}-id3dump PRIVATE + lib${PROJECT_NAME}) + + add_executable(${PROJECT_NAME}-strip + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/mpg123-strip.c" + "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/getlopt.c") + target_link_libraries(${PROJECT_NAME}-strip PRIVATE lib${PROJECT_NAME} - libout123 libsyn123) - install(TARGETS ${PROJECT_NAME} out123 + + install(TARGETS ${PROJECT_NAME}-id3dump ${PROJECT_NAME}-strip EXPORT targets ARCHIVE DESTINATION "${CMAKE_INSTALL_LIBDIR}/" LIBRARY DESTINATION "${CMAKE_INSTALL_LIBDIR}/" RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}/") endif() - - add_executable(${PROJECT_NAME}-id3dump - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/mpg123-id3dump.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/getlopt.c") - target_link_libraries(${PROJECT_NAME}-id3dump PRIVATE - lib${PROJECT_NAME}) - - add_executable(${PROJECT_NAME}-strip - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/mpg123-strip.c" - "${CMAKE_CURRENT_SOURCE_DIR}/../../../src/getlopt.c") - target_link_libraries(${PROJECT_NAME}-strip PRIVATE - lib${PROJECT_NAME} - libsyn123) - - install(TARGETS ${PROJECT_NAME}-id3dump ${PROJECT_NAME}-strip - EXPORT targets - ARCHIVE DESTINATION "${CMAKE_INSTALL_LIBDIR}/" - LIBRARY DESTINATION "${CMAKE_INSTALL_LIBDIR}/" - RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}/") endif() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.29.2/src/control_generic.c new/mpg123-1.29.3/src/control_generic.c --- old/mpg123-1.29.2/src/control_generic.c 2021-10-23 12:51:19.000000000 +0200 +++ new/mpg123-1.29.3/src/control_generic.c 2021-12-10 08:00:58.000000000 +0100 @@ -741,13 +741,10 @@ if(sscanf(arg, "%lf %lf %lf", &b, &m, &t) == 3) { /* Consider adding mpg123_seq()... but also, on could define a nicer courve for that. */ - if ((t >= 0) && (t <= 3)) for(cn=0; cn < 1; ++cn) mpg123_eq(fr, MPG123_LEFT|MPG123_RIGHT, cn, b); - if ((m >= 0) && (m <= 3)) for(cn=1; cn < 2; ++cn) mpg123_eq(fr, MPG123_LEFT|MPG123_RIGHT, cn, m); - if ((b >= 0) && (b <= 3)) for(cn=2; cn < 32; ++cn) mpg123_eq(fr, MPG123_LEFT|MPG123_RIGHT, cn, t); generic_sendmsg("bass: %f mid: %f treble: %f", b, m, t); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.29.2/src/libmpg123/lfs_wrap.c new/mpg123-1.29.3/src/libmpg123/lfs_wrap.c --- old/mpg123-1.29.2/src/libmpg123/lfs_wrap.c 2021-10-23 12:51:19.000000000 +0200 +++ new/mpg123-1.29.3/src/libmpg123/lfs_wrap.c 2021-12-10 08:00:58.000000000 +0100 @@ -293,6 +293,11 @@ long val; off_t largeioff; off_t largeval; + if(input_offset == NULL) + { + mh->err = MPG123_NULL_POINTER; + return MPG123_ERR; + } largeval = MPG123_LARGENAME(mpg123_feedseek)(mh, sampleoff, whence, &largeioff); /* Error/message codes are small... */ @@ -355,6 +360,12 @@ off_t largestep; off_t *largeoffsets; struct wrap_data *whd; + if(mh == NULL) return MPG123_BAD_HANDLE; + if(offsets == NULL || step == NULL || fill == NULL) + { + mh->err = MPG123_BAD_INDEX_PAR; + return MPG123_ERR; + } whd = wrap_get(mh); if(whd == NULL) return MPG123_ERR; @@ -409,6 +420,7 @@ size_t i; struct wrap_data *whd; off_t *indextmp; + if(mh == NULL) return MPG123_BAD_HANDLE; whd = wrap_get(mh); if(whd == NULL) return MPG123_ERR; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.29.2/src/mpg123.c new/mpg123-1.29.3/src/mpg123.c --- old/mpg123-1.29.2/src/mpg123.c 2021-10-23 12:51:19.000000000 +0200 +++ new/mpg123-1.29.3/src/mpg123.c 2021-12-10 08:00:58.000000000 +0100 @@ -449,6 +449,7 @@ static void set_out_stdout(char *arg, topt *opts) { + param.remote_err = TRUE; param.output_module = "raw"; getlopt_set_char(opts, "audiodevice", NULL); }