Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package container-build-checks for openSUSE:Factory checked in at 2021-12-16 21:18:49 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/container-build-checks (Old) and /work/SRC/openSUSE:Factory/.container-build-checks.new.2520 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "container-build-checks" Thu Dec 16 21:18:49 2021 rev:3 rq:940495 version:1639489705.a4c5a3a Changes: -------- --- /work/SRC/openSUSE:Factory/container-build-checks/container-build-checks.changes 2021-06-15 16:38:14.981788327 +0200 +++ /work/SRC/openSUSE:Factory/.container-build-checks.new.2520/container-build-checks.changes 2021-12-16 21:19:11.986518671 +0100 @@ -1,0 +2,7 @@ +Tue Dec 14 13:49:12 UTC 2021 - fv...@suse.com + +- Update to version 1639489705.a4c5a3ab2a75: + * Don't error out when the release field is empty + * Add simple gitpod configuration + +------------------------------------------------------------------- Old: ---- container-build-checks-1622209785.4616f4f.obscpio New: ---- container-build-checks-1639489705.a4c5a3a.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ container-build-checks.spec ++++++ --- /var/tmp/diff_new_pack.FOYiEb/_old 2021-12-16 21:19:12.694518940 +0100 +++ /var/tmp/diff_new_pack.FOYiEb/_new 2021-12-16 21:19:12.698518941 +0100 @@ -17,7 +17,7 @@ Name: container-build-checks -Version: 1622209785.4616f4f +Version: 1639489705.a4c5a3a Release: 0 Summary: Scripts to validate built container images License: GPL-2.0-or-later ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.FOYiEb/_old 2021-12-16 21:19:12.746518960 +0100 +++ /var/tmp/diff_new_pack.FOYiEb/_new 2021-12-16 21:19:12.750518962 +0100 @@ -1,6 +1,6 @@ <servicedata> <service name="tar_scm"> <param name="url">https://github.com/openSUSE/container-build-checks.git</param> - <param name="changesrevision">4616f4f91f8fe7589e80e8ec2df0ae1aaff4c132</param></service></servicedata> + <param name="changesrevision">ab3168138438a62b7b7636cc627904e7ec92f180</param></service></servicedata> (No newline at EOF) ++++++ container-build-checks-1622209785.4616f4f.obscpio -> container-build-checks-1639489705.a4c5a3a.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/container-build-checks-1622209785.4616f4f/.gitignore new/container-build-checks-1639489705.a4c5a3a/.gitignore --- old/container-build-checks-1622209785.4616f4f/.gitignore 1970-01-01 01:00:00.000000000 +0100 +++ new/container-build-checks-1639489705.a4c5a3a/.gitignore 2021-12-14 14:48:25.000000000 +0100 @@ -0,0 +1,3 @@ +tests/*/built +tests/*/checks.new +tests/*/*.tar diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/container-build-checks-1622209785.4616f4f/.gitpod.yml new/container-build-checks-1639489705.a4c5a3a/.gitpod.yml --- old/container-build-checks-1622209785.4616f4f/.gitpod.yml 1970-01-01 01:00:00.000000000 +0100 +++ new/container-build-checks-1639489705.a4c5a3a/.gitpod.yml 2021-12-14 14:48:25.000000000 +0100 @@ -0,0 +1,8 @@ +--- +image: + file: Dockerfile +vscode: + extensions: + - ms-azuretools.vscode-docker + - ms-python.python + - ms-vscode.makefile-tools diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/container-build-checks-1622209785.4616f4f/Dockerfile new/container-build-checks-1639489705.a4c5a3a/Dockerfile --- old/container-build-checks-1622209785.4616f4f/Dockerfile 1970-01-01 01:00:00.000000000 +0100 +++ new/container-build-checks-1639489705.a4c5a3a/Dockerfile 2021-12-14 14:48:25.000000000 +0100 @@ -0,0 +1,29 @@ +FROM registry.opensuse.org/opensuse/tumbleweed:latest + +SHELL ["/bin/bash", "-o", "pipefail", "-c"] + +# hadolint ignore=DL3004 +RUN zypper -n in system-group-wheel sudo make podman git jq sed python3 && zypper -n clean + +### Gitpod user ### +# '-l': see https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#user + +# hadolint ignore=DL3004 +RUN groupadd -g 33333 gitpod && \ + useradd -l -u 33333 -g 33333 -G wheel -md /home/gitpod -s /bin/bash -p gitpod gitpod && \ + # passwordless sudo for users in the 'wheel' group + echo "%wheel ALL=(ALL) NOPASSWD: ALL" | tee -a /etc/sudoers.d/00-wheel-group-nopasswd + +ENV HOME=/home/gitpod +WORKDIR $HOME +USER gitpod +# custom Bash prompt +RUN { echo && echo ". /etc/bash_completion.d/git-prompt.sh" && echo "PS1='\[\033[01;32m\]\u\[\033[00m\] \[\033[01;34m\]\w\[\033[00m\]\$(__git_ps1 \" (%s)\") $ '" ; } >> .bashrc + +### Gitpod user (2) ### +# use sudo so that user does not get sudo usage info on (the first) login +# hadolint ignore=DL3004 +RUN sudo echo "Running 'sudo' for Gitpod: success" && \ + # create .bashrc.d folder and source it in the bashrc + mkdir -p /home/gitpod/.bashrc.d && \ + (echo; echo "for i in \$(ls -A \$HOME/.bashrc.d/); do source \$HOME/.bashrc.d/\$i; done"; echo) >> /home/gitpod/.bashrc diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/container-build-checks-1622209785.4616f4f/README.md new/container-build-checks-1639489705.a4c5a3a/README.md --- old/container-build-checks-1622209785.4616f4f/README.md 2021-05-28 15:49:45.000000000 +0200 +++ new/container-build-checks-1639489705.a4c5a3a/README.md 2021-12-14 14:48:25.000000000 +0100 @@ -70,3 +70,8 @@ `podman image inspect foo | jq '.[0]["Config"]["Labels"]' | sed 's/": /=/g;s/^ "/LABEL /g;s/,$//g'` Run `make test` (or just `make tests/foo/tested`) to see the output and `make test-regen` (or just `make tests/foo/regen`) to save it as `checks.out`. + +Editing in Gitpod +================== + +You can apply your edits directly from within your browser on [Gitpod](https://gitpod.io/#https://github.com/openSUSE/container-build-checks). \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/container-build-checks-1622209785.4616f4f/container-build-checks.py new/container-build-checks-1639489705.a4c5a3a/container-build-checks.py --- old/container-build-checks-1622209785.4616f4f/container-build-checks.py 2021-05-28 15:49:45.000000000 +0200 +++ new/container-build-checks-1639489705.a4c5a3a/container-build-checks.py 2021-12-14 14:48:25.000000000 +0100 @@ -67,7 +67,7 @@ if f"{repo}:{tag}" not in image.containerinfo["tags"]: tags = ", ".join(image.containerinfo["tags"]) result.warn(f"The org.opensuse.reference label ({value}) does not refer to an existing tag ({tags})") - elif image.containerinfo["release"] not in tag: + elif "release" in image.containerinfo and image.containerinfo["release"] not in tag: result.warn(f"The org.opensuse.reference label ({value}) does not refer " f"to a tag identifying a specific build") @@ -191,7 +191,11 @@ result.warn(f"Using manually defined repositories ({urls}) in the image. Only obsrepositories:/ is allowed.") # Make sure tags are namespaced and one of them contains the release - print(f"Release: {image.containerinfo['release']}") + if "release" in image.containerinfo: + print(f"Release: {image.containerinfo['release']}") + else: + print("No release information found. Is this a local osc build? Further analysis might be misleading") + releasetagfound = False allowed_tags = config["Tags"].getlist("Allowed") @@ -206,7 +210,7 @@ if blocked_pattern is not None: result.warn(f"Tag {tag} is not allowed (blocked by {blocked_pattern}).") - if image.containerinfo["release"] in tag: + if "release" in image.containerinfo and image.containerinfo["release"] in tag: releasetagfound = True if not releasetagfound: ++++++ container-build-checks.obsinfo ++++++ --- /var/tmp/diff_new_pack.FOYiEb/_old 2021-12-16 21:19:12.834518993 +0100 +++ /var/tmp/diff_new_pack.FOYiEb/_new 2021-12-16 21:19:12.838518995 +0100 @@ -1,6 +1,6 @@ name: container-build-checks -version: 1622209785.4616f4f -mtime: 1622209785 -commit: 4616f4f91f8fe7589e80e8ec2df0ae1aaff4c132 +version: 1639489705.a4c5a3a +mtime: 1639489705 +commit: a4c5a3ab2a756dc3ea582ae06dead246e514b136