Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-packager for openSUSE:Factory
checked in at 2022-01-21 01:25:06
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-packager (Old)
and /work/SRC/openSUSE:Factory/.yast2-packager.new.1938 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-packager"
Fri Jan 21 01:25:06 2022 rev:419 rq:947359 version:4.4.20
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-packager/yast2-packager.changes
2022-01-14 23:13:56.138658673 +0100
+++ /work/SRC/openSUSE:Factory/.yast2-packager.new.1938/yast2-packager.changes
2022-01-21 01:25:16.158649244 +0100
@@ -1,0 +2,6 @@
+Tue Jan 18 15:46:09 UTC 2022 - Ladislav Slez??k <lsle...@suse.cz>
+
+- Enabled RSpec verifying doubles (bsc#1194784)
+- 4.4.20
+
+-------------------------------------------------------------------
Old:
----
yast2-packager-4.4.19.tar.bz2
New:
----
yast2-packager-4.4.20.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-packager.spec ++++++
--- /var/tmp/diff_new_pack.wXfeLn/_old 2022-01-21 01:25:17.662638934 +0100
+++ /var/tmp/diff_new_pack.wXfeLn/_new 2022-01-21 01:25:17.670638879 +0100
@@ -17,7 +17,7 @@
Name: yast2-packager
-Version: 4.4.19
+Version: 4.4.20
Release: 0
Summary: YaST2 - Package Library
License: GPL-2.0-or-later
@@ -40,6 +40,8 @@
BuildRequires: yast2 >= 4.4.25
# raw_name
BuildRequires: yast2-pkg-bindings >= 4.2.8
+# yast/rspec/helpers.rb
+BuildRequires: yast2-ruby-bindings >= 4.4.7
# Augeas lenses
BuildRequires: augeas-lenses
BuildRequires: ruby-solv
++++++ yast2-packager-4.4.19.tar.bz2 -> yast2-packager-4.4.20.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-packager-4.4.19/package/yast2-packager.changes
new/yast2-packager-4.4.20/package/yast2-packager.changes
--- old/yast2-packager-4.4.19/package/yast2-packager.changes 2022-01-13
22:41:52.000000000 +0100
+++ new/yast2-packager-4.4.20/package/yast2-packager.changes 2022-01-19
09:48:25.000000000 +0100
@@ -1,4 +1,10 @@
-------------------------------------------------------------------
+Tue Jan 18 15:46:09 UTC 2022 - Ladislav Slez??k <lsle...@suse.cz>
+
+- Enabled RSpec verifying doubles (bsc#1194784)
+- 4.4.20
+
+-------------------------------------------------------------------
Wed Jan 12 11:52:12 UTC 2022 - Josef Reidinger <jreidin...@suse.com>
- Simplify slide show to support future parallel installations
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-packager-4.4.19/package/yast2-packager.spec
new/yast2-packager-4.4.20/package/yast2-packager.spec
--- old/yast2-packager-4.4.19/package/yast2-packager.spec 2022-01-13
22:41:52.000000000 +0100
+++ new/yast2-packager-4.4.20/package/yast2-packager.spec 2022-01-19
09:48:25.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2-packager
-Version: 4.4.19
+Version: 4.4.20
Release: 0
Summary: YaST2 - Package Library
License: GPL-2.0-or-later
@@ -40,6 +40,8 @@
BuildRequires: yast2 >= 4.4.25
# raw_name
BuildRequires: yast2-pkg-bindings >= 4.2.8
+# yast/rspec/helpers.rb
+BuildRequires: yast2-ruby-bindings >= 4.4.7
# Augeas lenses
BuildRequires: augeas-lenses
BuildRequires: ruby-solv
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-packager-4.4.19/src/modules/PackageSlideShow.rb
new/yast2-packager-4.4.20/src/modules/PackageSlideShow.rb
--- old/yast2-packager-4.4.19/src/modules/PackageSlideShow.rb 2022-01-13
22:41:52.000000000 +0100
+++ new/yast2-packager-4.4.20/src/modules/PackageSlideShow.rb 2022-01-19
09:48:25.000000000 +0100
@@ -322,7 +322,6 @@
publish variable: :total_size_to_install, type: "integer" # Used in
installation client
publish function: :GetPackageSummary, type: "map <string, any> ()"
publish function: :InitPkgData, type: "void (boolean)"
- publish function: :SetCurrentCdNo, type: "void (integer, integer)"
publish function: :UpdateCurrentPackageProgress, type: "void (integer)"
publish function: :UpdateCurrentPackageRateProgress, type: "void (integer,
integer, integer)"
publish function: :DisplayGlobalProgress, type: "void ()"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-packager-4.4.19/test/addon_product_test.rb
new/yast2-packager-4.4.20/test/addon_product_test.rb
--- old/yast2-packager-4.4.19/test/addon_product_test.rb 2022-01-13
22:41:52.000000000 +0100
+++ new/yast2-packager-4.4.20/test/addon_product_test.rb 2022-01-19
09:48:25.000000000 +0100
@@ -697,7 +697,6 @@
before do
allow(subject).to receive(:GetCachedFileFromSource)
- allow(subject).to receive(:IntegrateReleaseNotes)
allow(Yast::WorkflowManager).to receive(:GetCachedWorkflowFilename)
allow(Yast::WorkflowManager).to receive(:AddWorkflow)
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-packager-4.4.19/test/addon_selector_test.rb
new/yast2-packager-4.4.20/test/addon_selector_test.rb
--- old/yast2-packager-4.4.19/test/addon_selector_test.rb 2022-01-13
22:41:52.000000000 +0100
+++ new/yast2-packager-4.4.20/test/addon_selector_test.rb 2022-01-19
09:48:25.000000000 +0100
@@ -63,7 +63,8 @@
end
it "does not display any popup" do
- expect(Yast::Popup).to_not receive(:anything)
+ # stub empty Yast::Popup so any method call would raise an exception
+ stub_const("Yast::Popup", double)
subject.next_handler
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-packager-4.4.19/test/package_installation_test.rb
new/yast2-packager-4.4.20/test/package_installation_test.rb
--- old/yast2-packager-4.4.19/test/package_installation_test.rb 2022-01-13
22:41:52.000000000 +0100
+++ new/yast2-packager-4.4.20/test/package_installation_test.rb 2022-01-19
09:48:25.000000000 +0100
@@ -12,7 +12,6 @@
let(:result) { [1, [], [], [], []] }
before do
- allow(Yast::PackageSlideShow).to receive(:SetCurrentCdNo)
allow(Yast::Pkg).to receive(:Commit).with(config)
.and_return(result)
allow(Yast::PackagesUI).to receive(:show_update_messages)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-packager-4.4.19/test/packages_test.rb
new/yast2-packager-4.4.20/test/packages_test.rb
--- old/yast2-packager-4.4.19/test/packages_test.rb 2022-01-13
22:41:52.000000000 +0100
+++ new/yast2-packager-4.4.20/test/packages_test.rb 2022-01-19
09:48:25.000000000 +0100
@@ -41,12 +41,7 @@
end
describe "#kernelCmdLinePackages" do
- before(:each) do
- # default value
- allow(Yast::Product).to receive(:Product).and_return nil
- end
-
- context "when biosdevname behavior explicitly defined on the Kenel command
line" do
+ context "when biosdevname behavior explicitly defined on the Kernel
command line" do
context "when biosdevname=1" do
around do |example|
root = File.join(DATA_PATH, "cmdline-biosdevname_1")
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-packager-4.4.19/test/product_license_test.rb
new/yast2-packager-4.4.20/test/product_license_test.rb
--- old/yast2-packager-4.4.19/test/product_license_test.rb 2022-01-13
22:41:52.000000000 +0100
+++ new/yast2-packager-4.4.20/test/product_license_test.rb 2022-01-19
09:48:25.000000000 +0100
@@ -154,7 +154,7 @@
expect(Yast::ProductLicense).to
receive(:AllLicensesAccepted).and_return(false)
.at_least(:once)
# :halt case
- allow(Yast::ProductLicense).to
receive(:TimedOKCancel).and_return(true)
+ allow(Yast::Popup).to receive(:TimedOKCancel).and_return(true)
end
context "when cancel action is 'continue'" do
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-packager-4.4.19/test/test_helper.rb
new/yast2-packager-4.4.20/test/test_helper.rb
--- old/yast2-packager-4.4.19/test/test_helper.rb 2022-01-13
22:41:52.000000000 +0100
+++ new/yast2-packager-4.4.20/test/test_helper.rb 2022-01-19
09:48:25.000000000 +0100
@@ -18,6 +18,11 @@
RSpec.configure do |config|
config.extend Yast::I18n # available in context/describe
config.include Yast::I18n # available in it/let/before/...
+
+ config.mock_with :rspec do |c|
+ #
https://relishapp.com/rspec/rspec-mocks/v/3-0/docs/verifying-doubles/partial-doubles
+ c.verify_partial_doubles = true
+ end
end
RSpec::Matchers.define :array_not_including do |x|
@@ -28,19 +33,6 @@
end
end
-# stub module to prevent its Import
-# Useful for modules from different yast packages, to avoid build dependencies
-def stub_module(name)
- Yast.const_set(name.to_sym, Class.new { def self.fake_method; end })
-end
-
-stub_module("Language")
-stub_module("Proxy")
-stub_module("FTP")
-stub_module("HTTP")
-stub_module("NtpClient")
-stub_module("InstFunctions")
-
if ENV["COVERAGE"]
require "simplecov"
SimpleCov.start do
@@ -68,6 +60,22 @@
end
end
+# stub missing YaST modules from different yast packages to avoid build
dependencies
+
+# these are not used in the tests so we can just use an empty implementation
+Yast::RSpec::Helpers.define_yast_module("FTP")
+Yast::RSpec::Helpers.define_yast_module("HTTP")
+Yast::RSpec::Helpers.define_yast_module("NtpClient")
+Yast::RSpec::Helpers.define_yast_module("Proxy")
+
+# define missing modules with an API, these are used in the tests and need to
+# implement the *same* API as the real modules
+
+Yast::RSpec::Helpers.define_yast_module("InstFunctions", methods:
[:second_stage_required?])
+
+Yast::RSpec::Helpers.define_yast_module("Language",
+ methods: [:language, :supported_language?, :GetLanguagesMap])
+
# mock empty class to avoid build dependency on yast2-installation
module Installation
module Console
