Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package vncmanager for openSUSE:Factory checked in at 2022-02-09 22:04:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/vncmanager (Old) and /work/SRC/openSUSE:Factory/.vncmanager.new.1898 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "vncmanager" Wed Feb 9 22:04:13 2022 rev:13 rq:953006 version:1.0.2 Changes: -------- --- /work/SRC/openSUSE:Factory/vncmanager/vncmanager.changes 2020-09-03 01:19:15.588583201 +0200 +++ /work/SRC/openSUSE:Factory/.vncmanager.new.1898/vncmanager.changes 2022-02-09 22:04:14.685617938 +0100 @@ -1,0 +2,14 @@ +Wed Feb 9 13:57:51 UTC 2022 - Joan Torres <joan.tor...@suse.com> + +- u_Fix-Tight-Encoding-not-processing-pixel-format-prope.patch + * Consider different pixel format depths on Tight Encoding. + TightPixel was considering only pixels defined with 3 bytes. + (bsc#1189247) + +------------------------------------------------------------------- +Mon Jan 4 15:45:43 UTC 2021 - Stefan Dirsch <sndir...@suse.com> + +- added pkgconfig BuildRequires for zlib and bzip2 in order to fix + build against Tumbleweed/factory + +------------------------------------------------------------------- New: ---- u_Fix-Tight-Encoding-not-processing-pixel-format-prope.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ vncmanager.spec ++++++ --- /var/tmp/diff_new_pack.sMH3XH/_old 2022-02-09 22:04:15.329619342 +0100 +++ /var/tmp/diff_new_pack.sMH3XH/_new 2022-02-09 22:04:15.341619368 +0100 @@ -1,7 +1,7 @@ # # spec file for package vncmanager # -# Copyright (c) 2020 SUSE LLC +# Copyright (c) 2022 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -33,7 +33,9 @@ BuildRequires: libgnutls-devel BuildRequires: pkg-config BuildRequires: systemd-rpm-macros +BuildRequires: pkgconfig(bzip2) BuildRequires: pkgconfig(libsystemd) +BuildRequires: pkgconfig(zlib) Requires(post): xorg-x11-Xvnc Requires: vncmanager-greeter Requires: xorg-x11-Xvnc @@ -57,6 +59,7 @@ Patch8: u_Fix-PixelFormat-ntoh-and-PixelFormat-hton.patch Patch9: u_Fix-TightCompressionControl-definition-for-big-endian.patch Patch10: n_UsrEtc.patch +Patch11: u_Fix-Tight-Encoding-not-processing-pixel-format-prope.patch %description Session manager for VNC. It listens on VNC port and spawns Xvnc processes for incoming clients. @@ -86,6 +89,7 @@ %patch8 -p1 %patch9 -p1 %patch10 -p1 +%patch11 -p1 %build %cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_VERBOSE_MAKEFILE=ON ++++++ u_Fix-Tight-Encoding-not-processing-pixel-format-prope.patch ++++++ >From ea26a243314b3325f7789c520741af0cc7fe2497 Mon Sep 17 00:00:00 2001 From: Joan Torres <joan.tor...@suse.com> Date: Wed, 9 Feb 2022 13:54:59 +0100 Subject: [PATCH] Fix Tight Encoding not processing pixel format properly References: bsc#1189247 Upstream: merged Tight Encoding uses TightPixel structs which only considers pixel formats that are encoded using 3 bytes. Now it considers pixel formats defined with any depth. --- VncTunnel.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/VncTunnel.cpp b/VncTunnel.cpp index 66b92ff..718c339 100644 --- a/VncTunnel.cpp +++ b/VncTunnel.cpp @@ -596,7 +596,7 @@ void VncTunnel::processFramebufferUpdate() cFmt().send(c); if (c.isFillCompression()) { - sFmt().forward_directly(cStream(), sizeof(TightPixel)); + sFmt().forward_directly(cStream(), m_pixelFormat.depth / 8); } else if (c.isJpegCompression()) { @@ -616,7 +616,7 @@ void VncTunnel::processFramebufferUpdate() sFmt().forward(cStream(), paletteLength); int actualPaletteLength = paletteLength + 1; - sFmt().forward_directly(cStream(), sizeof(TightPixel) * actualPaletteLength); + sFmt().forward_directly(cStream(), m_pixelFormat.depth / 8 * actualPaletteLength); if (actualPaletteLength <= 2) { bpp = 1; -- 2.34.1