Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package llvm12 for openSUSE:Factory checked in at 2022-02-14 22:35:58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/llvm12 (Old) and /work/SRC/openSUSE:Factory/.llvm12.new.1956 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "llvm12" Mon Feb 14 22:35:58 2022 rev:9 rq:953953 version:12.0.1 Changes: -------- --- /work/SRC/openSUSE:Factory/llvm12/llvm12.changes 2021-12-28 12:26:05.380459990 +0100 +++ /work/SRC/openSUSE:Factory/.llvm12.new.1956/llvm12.changes 2022-02-14 22:36:06.745404505 +0100 @@ -1,0 +2,6 @@ +Thu Feb 3 21:56:28 UTC 2022 - Aaron Puchert <aaronpuch...@alice-dsl.net> + +- Drop RUNPATH from packaged binaries, instead set LD_LIBRARY_PATH + for building and testing to simulate behavior of actual package. + +------------------------------------------------------------------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ llvm12.spec ++++++ --- /var/tmp/diff_new_pack.DXBcXK/_old 2022-02-14 22:36:08.233408383 +0100 +++ /var/tmp/diff_new_pack.DXBcXK/_new 2022-02-14 22:36:08.241408403 +0100 @@ -1,7 +1,7 @@ # # spec file for package llvm12 # -# Copyright (c) 2021 SUSE LLC +# Copyright (c) 2022 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -706,7 +706,6 @@ -DCOMPILER_RT_BUILD_SANITIZERS:BOOL=OFF \ -DCOMPILER_RT_BUILD_XRAY:BOOL=OFF \ -DLLDB_DISABLE_PYTHON=ON \ - -DCMAKE_SKIP_RPATH:BOOL=OFF \ -DCMAKE_EXE_LINKER_FLAGS="-Wl,--as-needed -Wl,--no-keep-memory" \ -DCMAKE_MODULE_LINKER_FLAGS="-Wl,--as-needed -Wl,--no-keep-memory" \ -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--as-needed -Wl,--no-keep-memory" @@ -762,6 +761,9 @@ export CLANG_TABLEGEN=${PWD}/stage1/bin/clang-tblgen # Build is using absolute paths assuming the monorepo layout, so we need this. export CLANG_TOOLS_EXTRA_DIR=${PWD}/tools/clang/tools/extra +# The build occasionally uses tools linking against previously built +# libraries (mostly libLLVM.so), but we don't want to set RUNPATHs. +export LD_LIBRARY_PATH=${PWD}/build/%{_lib} # -z,now is breaking now, it needs to be fixed %cmake \ -DBUILD_SHARED_LIBS:BOOL=OFF \ @@ -815,7 +817,7 @@ %if %{without lldb_python} -DLLDB_DISABLE_PYTHON=ON \ %endif - -DCMAKE_SKIP_RPATH:BOOL=OFF \ + -DCMAKE_SKIP_RPATH:BOOL=ON \ -DCMAKE_EXE_LINKER_FLAGS="-Wl,--as-needed -Wl,--build-id=sha1" \ -DCMAKE_MODULE_LINKER_FLAGS="-Wl,--as-needed -Wl,--build-id=sha1" \ -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--as-needed -Wl,--build-id=sha1" \ @@ -840,6 +842,8 @@ cd .. %install +# Installation seems to build some files not contained in "all". +export LD_LIBRARY_PATH=${PWD}/build/%{_lib} %cmake_install # Remove files that won't be needed anymore. @@ -1076,6 +1080,9 @@ %fdupes %{_includedir}/%{name}/Host/ %check +# We don't want to set RUNPATHs, and running tests against installed libraries +# should be more representative of the actual behavior of the installed packages. +export LD_LIBRARY_PATH=%{buildroot}%{_libdir} # LLVM test suite is written in python and has troubles with encoding if # python 3 is used because it is written with assumption that python will # default to UTF-8 encoding. However, it only does if the current locale is