Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libgsasl for openSUSE:Factory checked in at 2022-02-17 00:29:59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libgsasl (Old) and /work/SRC/openSUSE:Factory/.libgsasl.new.1956 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libgsasl" Thu Feb 17 00:29:59 2022 rev:34 rq:954676 version:1.10.0 Changes: -------- --- /work/SRC/openSUSE:Factory/libgsasl/libgsasl.changes 2021-01-04 19:07:14.743261848 +0100 +++ /work/SRC/openSUSE:Factory/.libgsasl.new.1956/libgsasl.changes 2022-02-17 00:30:10.629436954 +0100 @@ -1,0 +2,5 @@ +Mon Jan 31 18:54:07 UTC 2022 - Dirk M??ller <dmuel...@suse.com> + +- add 0001-Fix-build-issues-with-GCC-12-s-Werror-address.patch + +------------------------------------------------------------------- New: ---- 0001-Fix-build-issues-with-GCC-12-s-Werror-address.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libgsasl.spec ++++++ --- /var/tmp/diff_new_pack.eFHcdt/_old 2022-02-17 00:30:11.757436760 +0100 +++ /var/tmp/diff_new_pack.eFHcdt/_new 2022-02-17 00:30:11.761436759 +0100 @@ -1,7 +1,7 @@ # # spec file for package libgsasl # -# Copyright (c) 2021 SUSE LLC +# Copyright (c) 2022 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -20,12 +20,14 @@ Version: 1.10.0 Release: 0 Summary: Implementation of the SASL framework and a few common SASL mechanisms -License: LGPL-2.1-or-later AND GPL-3.0-or-later +License: GPL-3.0-or-later AND LGPL-2.1-or-later Group: Development/Libraries/C and C++ URL: https://www.gnu.org/software/gsasl/ Source0: https://ftp.gnu.org/gnu/gsasl/%{name}-%{version}.tar.gz Source1: https://ftp.gnu.org/gnu/gsasl/%{name}-%{version}.tar.gz.sig Source2: https://josefsson.org/54265e8c.txt#/%{name}.keyring +# https://lists.gnu.org/archive/html/help-gsasl/2022-01/msg00002.html +Patch1: 0001-Fix-build-issues-with-GCC-12-s-Werror-address.patch BuildRequires: gcc-c++ BuildRequires: gettext-devel >= 0.19.8 BuildRequires: pkgconfig @@ -70,7 +72,7 @@ %lang_package %prep -%setup -q +%autosetup -p1 %build %configure \ ++++++ 0001-Fix-build-issues-with-GCC-12-s-Werror-address.patch ++++++ >From 27fbb4c1d6315e404b547dd9b50bdecc41a07eb5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dirk=20M=C3=BCller?= <dmuel...@suse.de> Date: Fri, 28 Jan 2022 20:47:37 +0100 Subject: [PATCH] Fix build issues with GCC 12's -Werror=address MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GCC 12 is able to detect that if(foo) when foo is a char foo[] is always true, and hence errors out: printerc:336:7: error: the comparison will always evaluate as 'true' for the address of 'response' will never be NULL 336 | if (r->response) | ^ In file included from printer.h:27, from printer.c:28: tokens.h:139:8: note: 'response' declared here 139 | char response[DIGEST_MD5_RESPONSE_LENGTH + 1]; | ^~~~~~~~ We can just remove those conditions. Signed-off-by: Dirk M??ller <dmuel...@suse.de> --- lib/digest-md5/printer.c | 11 +++++------ lib/digest-md5/validate.c | 3 --- 2 files changed, 5 insertions(+), 9 deletions(-) --- a/digest-md5/printer.c +++ b/digest-md5/printer.c @@ -333,12 +333,11 @@ digest_md5_print_response (digest_md5_response * r) return NULL; } - if (r->response) - if (comma_append (&out, "response", r->response, 0) < 0) - { - free (out); - return NULL; - } + if (comma_append (&out, "response", r->response, 0) < 0) + { + free (out); + return NULL; + } if (r->clientmaxbuf) { --- a/digest-md5/validate.c +++ b/digest-md5/validate.c @@ -102,9 +102,6 @@ digest_md5_validate_response (digest_md5_response * r) int digest_md5_validate_finish (digest_md5_finish * f) { - if (!f->rspauth) - return -1; - /* A string of 32 hex digits */ if (strlen (f->rspauth) != DIGEST_MD5_RESPONSE_LENGTH) return -1; -- 2.34.1
