Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package dictd for openSUSE:Factory checked in at 2022-02-21 17:46:16 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/dictd (Old) and /work/SRC/openSUSE:Factory/.dictd.new.1958 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "dictd" Mon Feb 21 17:46:16 2022 rev:6 rq:956237 version:1.13.1 Changes: -------- --- /work/SRC/openSUSE:Factory/dictd/dictd.changes 2021-09-14 21:15:17.128457789 +0200 +++ /work/SRC/openSUSE:Factory/.dictd.new.1958/dictd.changes 2022-02-21 17:46:49.467598034 +0100 @@ -1,0 +2,15 @@ +Sun Feb 20 23:12:10 UTC 2022 - Matej Cepl <mc...@suse.com> + +- Add dictd-rpmlintrc ... potential bashismus is completely + innocent (gh#cheusov/dictd#13). + +------------------------------------------------------------------- +Sun Feb 20 01:51:47 UTC 2022 - Matej Cepl <mc...@suse.com> + +- Update to 1.13.1: + - Remove the last call of gethostbyname(3) + - Fixes by Huy-Ngo in dictfmt help message. +- Remove ProtectHome from the systemd service file, because data + files can be stored in $HOME and indexes need to written to. + +------------------------------------------------------------------- Old: ---- dictd-1.13.0.tar.gz New: ---- dictd-1.13.1.tar.gz dictd-rpmlintrc ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ dictd.spec ++++++ --- /var/tmp/diff_new_pack.ZDPPbm/_old 2022-02-21 17:46:50.139598235 +0100 +++ /var/tmp/diff_new_pack.ZDPPbm/_new 2022-02-21 17:46:50.147598237 +0100 @@ -1,7 +1,7 @@ # # spec file for package dictd # -# Copyright (c) 2020 SUSE LLC +# Copyright (c) 2022 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: dictd -Version: 1.13.0 +Version: 1.13.1 Release: 0 Summary: DICT protocol (RFC 2229) server and command-line client License: GPL-1.0-or-later AND Zlib AND MIT @@ -26,6 +26,7 @@ Source0: https://github.com/cheusov/dictd/archive/%{version}.tar.gz#/dictd-%{version}.tar.gz Source1: colorit.conf Source2: dictd.service +Source99: dictd-rpmlintrc Patch0: dictd-1.12.1-unused-return.patch BuildRequires: autoconf BuildRequires: bison ++++++ dictd-1.13.0.tar.gz -> dictd-1.13.1.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/dictd-1.13.0/NEWS new/dictd-1.13.1/NEWS --- old/dictd-1.13.0/NEWS 2020-03-27 08:21:31.000000000 +0100 +++ new/dictd-1.13.1/NEWS 2021-11-21 13:49:10.000000000 +0100 @@ -1,4 +1,11 @@ ---------------------------------------------------------------------- +Version 1.13.1, by Aleksey Cheusov, Sun, 21 Nov 2021 15:46:08 +0300 + + Remove the last call of gethostbyname(3) + + Fixes by Huy-Ngo in dictfmt help message. + +---------------------------------------------------------------------- Version 1.13.0, by Aleksey Cheusov, Fri, 27 Mar 2020 09:58:48 +0300 dictd: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/dictd-1.13.0/configure.in new/dictd-1.13.1/configure.in --- old/dictd-1.13.0/configure.in 2020-03-27 08:21:31.000000000 +0100 +++ new/dictd-1.13.1/configure.in 2021-11-21 13:49:10.000000000 +0100 @@ -24,7 +24,7 @@ dnl LIBOBJS is an automatically-generated list of extra objects we need -define(VERSION, 1.13.0) +define(VERSION, 1.13.1) AC_PREREQ(2.53) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/dictd-1.13.0/dictfmt.c new/dictd-1.13.1/dictfmt.c --- old/dictd-1.13.0/dictfmt.c 2020-03-27 08:21:31.000000000 +0100 +++ new/dictd-1.13.1/dictfmt.c 2021-11-21 13:49:10.000000000 +0100 @@ -807,7 +807,7 @@ static const char *help_msg[] = { "Usage: dictfmt -c5|-t|-e|-f|-h|-j|-p [-u url] [-s name] [options] basename", " dictfmt -i|-I [options]", - "Create a dictionary databse and index file for use by a dictd server", + "Create a dictionary database and index file for use by a dictd server", "", "-c5 headwords are preceded by a line containing at least \n\ 5 underscore (_) characters", @@ -838,7 +838,7 @@ Example: autumn%%%fall can be used\n\ if '--headword-separator %%%' is supplied", "--index-data-separator <sep> sets index/data separator which allows\n\ - to explicitely set fourth column in .index file,\n\ + to explicitly set fourth column in .index file,\n\ the default is \"\\034\"", "--break-headwords multiple headwords will be written on separate lines\n\ in the .dict file. For use with '--headword-separator.", diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/dictd-1.13.0/net.c new/dictd-1.13.1/net.c --- old/dictd-1.13.0/net.c 2020-03-27 08:21:31.000000000 +0100 +++ new/dictd-1.13.1/net.c 2021-11-21 13:49:10.000000000 +0100 @@ -36,8 +36,6 @@ #define INADDR_NONE (-1) #endif -static char netHostname[MAXHOSTNAMELEN]; - const char *inet_ntopW (struct sockaddr *sa) { static char buf[40]; @@ -54,20 +52,17 @@ const char *net_hostname( void ) { - struct hostent *hostEntry; - static char *hostname = NULL; - - if (!netHostname[0]) { - memset( netHostname, 0, sizeof(netHostname) ); - gethostname( netHostname, sizeof(netHostname)-1 ); - - if ((hostEntry = gethostbyname(netHostname))) { - hostname = xstrdup(hostEntry->h_name); - } else { - hostname = xstrdup(netHostname); + static char hostname[128] = ""; + int err; + + if (!hostname[0]) { + if (err = gethostname(hostname, sizeof(hostname)), err != 0) { + fprintf(stderr, "getaddrinfo: %s\n", gai_strerror(err)); + exit(EXIT_FAILURE); } } - + + hostname[sizeof(hostname)-1] = '\0'; return hostname; } ++++++ dictd-rpmlintrc ++++++ # gh#martanne/vis#990 addFilter("potential-bashisms.*/usr/bin/dictfmt_index2.*") ++++++ dictd.service ++++++ --- /var/tmp/diff_new_pack.ZDPPbm/_old 2022-02-21 17:46:50.355598298 +0100 +++ /var/tmp/diff_new_pack.ZDPPbm/_new 2022-02-21 17:46:50.359598300 +0100 @@ -6,7 +6,6 @@ # added automatically, for details please see # https://en.opensuse.org/openSUSE:Security_Features#Systemd_hardening_effort ProtectSystem=full -ProtectHome=true PrivateDevices=true ProtectHostname=true ProtectClock=true
