Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package yast2-network for openSUSE:Factory checked in at 2022-02-23 16:25:51 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-network (Old) and /work/SRC/openSUSE:Factory/.yast2-network.new.1958 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-network" Wed Feb 23 16:25:51 2022 rev:474 rq:956688 version:4.4.40 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-network/yast2-network.changes 2022-02-11 23:06:50.562511399 +0100 +++ /work/SRC/openSUSE:Factory/.yast2-network.new.1958/yast2-network.changes 2022-02-23 16:26:18.819508538 +0100 @@ -1,0 +2,6 @@ +Tue Feb 22 11:34:20 UTC 2022 - Knut Anderssen <kanders...@suse.com> + +- Fixed active configuration detection (bsc#1196276, bsc#1194911) +- 4.4.40 + +------------------------------------------------------------------- Old: ---- yast2-network-4.4.39.tar.bz2 New: ---- yast2-network-4.4.40.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-network.spec ++++++ --- /var/tmp/diff_new_pack.FrgijS/_old 2022-02-23 16:26:22.227508659 +0100 +++ /var/tmp/diff_new_pack.FrgijS/_new 2022-02-23 16:26:22.231508660 +0100 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 4.4.39 +Version: 4.4.40 Release: 0 Summary: YaST2 - Network Configuration License: GPL-2.0-only ++++++ yast2-network-4.4.39.tar.bz2 -> yast2-network-4.4.40.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.4.39/package/yast2-network.changes new/yast2-network-4.4.40/package/yast2-network.changes --- old/yast2-network-4.4.39/package/yast2-network.changes 2022-02-10 19:38:56.000000000 +0100 +++ new/yast2-network-4.4.40/package/yast2-network.changes 2022-02-22 13:01:24.000000000 +0100 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Tue Feb 22 11:34:20 UTC 2022 - Knut Anderssen <kanders...@suse.com> + +- Fixed active configuration detection (bsc#1196276, bsc#1194911) +- 4.4.40 + +------------------------------------------------------------------- Thu Feb 10 18:01:05 UTC 2022 - Knut Anderssen <kanders...@suse.com> - Related to (bsc#1194911) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.4.39/package/yast2-network.spec new/yast2-network-4.4.40/package/yast2-network.spec --- old/yast2-network-4.4.39/package/yast2-network.spec 2022-02-10 19:38:56.000000000 +0100 +++ new/yast2-network-4.4.40/package/yast2-network.spec 2022-02-22 13:01:24.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 4.4.39 +Version: 4.4.40 Release: 0 Summary: YaST2 - Network Configuration License: GPL-2.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.4.39/src/lib/network/network_autoconfiguration.rb new/yast2-network-4.4.40/src/lib/network/network_autoconfiguration.rb --- old/yast2-network-4.4.39/src/lib/network/network_autoconfiguration.rb 2022-02-10 19:38:56.000000000 +0100 +++ new/yast2-network-4.4.40/src/lib/network/network_autoconfiguration.rb 2022-02-22 13:01:24.000000000 +0100 @@ -49,7 +49,7 @@ def any_iface_active? Yast::Lan.Read(:cache) config.interfaces.any? do |interface| - return false unless active_config?(interface.name) + next false unless active_config?(interface.name) config.connections.by_name(interface.name) || ibft_interfaces.include?(interface.name) end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.4.39/test/network_autoconfiguration_test.rb new/yast2-network-4.4.40/test/network_autoconfiguration_test.rb --- old/yast2-network-4.4.39/test/network_autoconfiguration_test.rb 2022-02-10 19:38:56.000000000 +0100 +++ new/yast2-network-4.4.40/test/network_autoconfiguration_test.rb 2022-02-22 13:01:24.000000000 +0100 @@ -87,17 +87,20 @@ describe "#any_iface_active?" do let(:active) { false } let(:ibft_interfaces) { [] } + let(:eth1) { Y2Network::Interface.new("eth1") } + let(:interfaces) { Y2Network::InterfacesCollection.new([eth1, eth0]) } before do + allow(instance).to receive(:active_config?).with("eth1").and_return(false) allow(instance).to receive(:active_config?).with("eth0").and_return(active) allow(instance).to receive(:ibft_interfaces).and_return(ibft_interfaces) end - it "returns false if the interface state is not UP" do + it "returns false if there is no interface UP" do expect(instance.any_iface_active?).to be false end - context "when the interface state is UP" do + context "when at least one interface is UP" do let(:active) { true } context "and the interface is configured through iBFT" do