Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package otpclient for openSUSE:Factory
checked in at 2022-02-28 19:43:47
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/otpclient (Old)
and /work/SRC/openSUSE:Factory/.otpclient.new.1958 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "otpclient"
Mon Feb 28 19:43:47 2022 rev:12 rq:958045 version:2.4.9.1
Changes:
--------
--- /work/SRC/openSUSE:Factory/otpclient/otpclient.changes 2022-02-18
23:03:47.765408845 +0100
+++ /work/SRC/openSUSE:Factory/.otpclient.new.1958/otpclient.changes
2022-02-28 19:44:15.561956817 +0100
@@ -1,0 +2,15 @@
+Mon Feb 28 12:52:16 UTC 2022 - Paolo Stivanin <i...@paolostivanin.com>
+
+- Update to 2.4.9.1:
+ * Fix a regression brought by the previous update (non-utf8 string
+ was incorrectly parsed). Now URIs are correctly parsed, whether
+ or not they contain utf-8 chars.
+
+-------------------------------------------------------------------
+Mon Feb 28 09:55:50 UTC 2022 - Paolo Stivanin <i...@paolostivanin.com>
+
+- Update to 2.4.9:
+ * fix an error when importing a QR code (issue #240)
+ * better error handling when importing a code
+
+-------------------------------------------------------------------
Old:
----
v2.4.8.tar.gz
v2.4.8.tar.gz.asc
New:
----
v2.4.9.1.tar.gz
v2.4.9.1.tar.gz.asc
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ otpclient.spec ++++++
--- /var/tmp/diff_new_pack.z7EWOV/_old 2022-02-28 19:44:16.177957048 +0100
+++ /var/tmp/diff_new_pack.z7EWOV/_new 2022-02-28 19:44:16.181957049 +0100
@@ -18,7 +18,7 @@
%define uclname OTPClient
Name: otpclient
-Version: 2.4.8
+Version: 2.4.9.1
Release: 0
Summary: Simple GTK+ client for managing TOTP and HOTP
License: GPL-3.0-or-later
++++++ v2.4.8.tar.gz -> v2.4.9.1.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.8/CMakeLists.txt
new/OTPClient-2.4.9.1/CMakeLists.txt
--- old/OTPClient-2.4.8/CMakeLists.txt 2022-02-18 14:26:46.000000000 +0100
+++ new/OTPClient-2.4.9.1/CMakeLists.txt 2022-02-28 13:48:49.000000000
+0100
@@ -1,5 +1,5 @@
cmake_minimum_required(VERSION 3.5)
-project(OTPClient VERSION "2.4.8" LANGUAGES "C")
+project(OTPClient VERSION "2.4.9.1" LANGUAGES "C")
configure_file("src/common/version.h.in" "version.h")
include_directories(${PROJECT_BINARY_DIR})
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/OTPClient-2.4.8/data/com.github.paolostivanin.OTPClient.appdata.xml
new/OTPClient-2.4.9.1/data/com.github.paolostivanin.OTPClient.appdata.xml
--- old/OTPClient-2.4.8/data/com.github.paolostivanin.OTPClient.appdata.xml
2022-02-18 14:26:46.000000000 +0100
+++ new/OTPClient-2.4.9.1/data/com.github.paolostivanin.OTPClient.appdata.xml
2022-02-28 13:48:49.000000000 +0100
@@ -83,6 +83,23 @@
</content_rating>
<releases>
+ <release version="2.4.9.1" date="2022-02-28">
+ <description>
+ <p>OTPClient 2.4.9.1 fix a regression</p>
+ <ul>
+ <li>fix importing QR code both when URI contains and doesn't contain
one or more UTF-8 chars.</li>
+ </ul>
+ </description>
+ </release>
+ <release version="2.4.9" date="2022-02-28">
+ <description>
+ <p>OTPClient 2.4.9 fix an import issue</p>
+ <ul>
+ <li>fix importing QR code (issue#240)</li>
+ <li>better error when importing a QR fails</li>
+ </ul>
+ </description>
+ </release>
<release version="2.4.8" date="2022-02-18">
<description>
<p>OTPClient 2.4.8 brings a couple of fixes</p>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.8/src/add-common.c
new/OTPClient-2.4.9.1/src/add-common.c
--- old/OTPClient-2.4.8/src/add-common.c 2022-02-18 14:26:46.000000000
+0100
+++ new/OTPClient-2.4.9.1/src/add-common.c 2022-02-28 13:48:49.000000000
+0100
@@ -40,10 +40,9 @@
return g_strdup ("Label can not be empty, otp not imported");
}
- if (otp->secret[0] == '\0') {
+ if (otp->secret == NULL || otp->secret[0] == '\0') {
return g_strdup ("Secret can not be empty, otp not imported");
}
-
if (g_ascii_strcasecmp (otp->type, "TOTP") == 0) {
if (otp->period < 10 || otp->period > 120) {
gchar *msg = g_strconcat("[INFO]: invalid period for '",
otp->account_name, "'. Defaulting back to 30 seconds.", NULL);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.8/src/parse-uri.c
new/OTPClient-2.4.9.1/src/parse-uri.c
--- old/OTPClient-2.4.8/src/parse-uri.c 2022-02-18 14:26:46.000000000 +0100
+++ new/OTPClient-2.4.9.1/src/parse-uri.c 2022-02-28 13:48:49.000000000
+0100
@@ -69,23 +69,23 @@
parse_parameters (const gchar *modified_uri,
otp_t *otp)
{
- const gchar *mod_uri_copy = modified_uri;
- gchar **tokens = g_strsplit (mod_uri_copy, "?", -1);
+ gchar **tokens = g_strsplit (modified_uri, "?", -1);
gchar *escaped_issuer_and_label = g_uri_unescape_string (tokens[0], NULL);
- mod_uri_copy += g_utf8_strlen (tokens[0], -1) + 1; // "issuer:label?"
+ gchar *mod_uri_copy_utf8 = g_utf8_offset_to_pointer(modified_uri,
g_utf8_strlen (tokens[0], -1) + 1);
g_strfreev (tokens);
tokens = g_strsplit (escaped_issuer_and_label, ":", -1);
if (tokens[0] && tokens[1]) {
otp->issuer = g_strdup (g_strstrip (tokens[0]));
otp->account_name = g_strdup (g_strstrip (tokens[1]));
+
} else {
otp->account_name = g_strdup (g_strstrip (tokens[0]));
}
g_free (escaped_issuer_and_label);
g_strfreev (tokens);
- tokens = g_strsplit (mod_uri_copy, "&", -1);
+ tokens = g_strsplit (mod_uri_copy_utf8, "&", -1);
gint i = 0;
while (tokens[i]) {
if (g_ascii_strncasecmp (tokens[i], "secret=", 7) == 0) {
