Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package atop for openSUSE:Factory checked in at 2022-03-01 17:03:29 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/atop (Old) and /work/SRC/openSUSE:Factory/.atop.new.1958 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "atop" Tue Mar 1 17:03:29 2022 rev:9 rq:958119 version:2.7.1 Changes: -------- --- /work/SRC/openSUSE:Factory/atop/atop.changes 2022-01-17 22:35:18.378293810 +0100 +++ /work/SRC/openSUSE:Factory/.atop.new.1958/atop.changes 2022-03-01 17:04:10.884343201 +0100 @@ -1,0 +2,7 @@ +Mon Feb 28 23:24:00 UTC 2022 - Michael Vetter <mvet...@suse.com> + +- Update to 2.7.1: + * Correct disk stats in atopsar (#182) + * Explicit type definition in atop.service (#180) + +------------------------------------------------------------------- Old: ---- atop-2.7.0.tar.gz atop-rpmlintrc New: ---- atop-2.7.1.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ atop.spec ++++++ --- /var/tmp/diff_new_pack.MKfhMs/_old 2022-03-01 17:04:11.464343355 +0100 +++ /var/tmp/diff_new_pack.MKfhMs/_new 2022-03-01 17:04:11.468343356 +0100 @@ -19,7 +19,7 @@ Name: atop -Version: 2.7.0 +Version: 2.7.1 Release: 0 Summary: Monitor for System Resources and Process Activity License: GPL-2.0-only @@ -27,7 +27,7 @@ Source0: https://www.atoptool.nl/download/atop-%{version}.tar.gz Source1: atop.desktop Source2: atop.default -Source99: atop-rpmlintrc +#Source99: atop-rpmlintrc Patch0: atop-makefile.patch Patch1: harden_atop-rotate.service.patch Patch2: harden_atop.service.patch ++++++ atop-2.7.0.tar.gz -> atop-2.7.1.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/atop-2.7.0/ChangeLog new/atop-2.7.1/ChangeLog --- old/atop-2.7.0/ChangeLog 2021-12-18 12:04:24.000000000 +0100 +++ new/atop-2.7.1/ChangeLog 2022-01-08 12:49:00.000000000 +0100 @@ -1,3 +1,66 @@ +commit 115b355cb52eee4b11ce00e5b01decde37796e90 +Author: Gerlof Langeveld <gerlof.langev...@atoptool.nl> +Date: Wed Jan 5 19:12:27 2022 +0100 + + Explicit type definition in atop.service (issue #180) + +M atop.service + +commit 9afc5ad3d714ea09f9ffdebd79b345fe223c7e20 +Author: Gerlof Langeveld <gerlof.langev...@atoptool.nl> +Date: Wed Jan 5 18:54:21 2022 +0100 + + Correct disk stats in atopsar (issue #182) + A wrong disk report is shown with the -d/-l/-f flags. + When the kernel supports the discard counter per disk, + output lines are empty in the disk report. + When the kernel doesnot support the discard counter per disk, + output lines often show a negative value for for the average + access time (avserv). + +M atopsar.c + +commit ffb30c62ad5a3e7844d3d9004c174af58eb3dc60 +Author: Gerlof Langeveld <gerlof.langev...@atoptool.nl> +Date: Sat Jan 1 14:37:18 2022 +0100 + + Add information about service activation to README file + +M README + +commit fdf3526bd35c1a84dd11bb73110c1a1f4148e39d +Author: Gerlof Langeveld <gerlof.langev...@atoptool.nl> +Date: Fri Dec 31 11:25:13 2021 +0100 + + Add directory to .gitignore + +M .gitignore + +commit 5dbe750eca1e468694dc4d4d0d251a485f58ad74 +Author: Gerlof Langeveld <gerlof.langev...@atoptool.nl> +Date: Fri Dec 31 11:25:04 2021 +0100 + + Clarify relation between atop/atopacctd in man page + +M man/atop.1 + +commit 1b4f7d6d2e14e768f310fc6041c05c5dcc69cee7 +Author: Gerlof Langeveld <gerlof.langev...@atoptool.nl> +Date: Fri Dec 31 11:24:00 2021 +0100 + + Added license info + +M atopgpud +M netlink.c + +commit a67368badc8b639f23268e636a1a3d8787ee90c5 +Author: Gerlof Langeveld <gerlof.langev...@atoptool.nl> +Date: Fri Dec 31 11:23:18 2021 +0100 + + Added generic license info to README #179 + +M README + commit c427419d975bd94f452aeabf5df0a5d4a6be241b Author: Gerlof Langeveld <gerlof.langev...@atoptool.nl> Date: Sat Dec 18 11:24:21 2021 +0100 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/atop-2.7.0/README new/atop-2.7.1/README --- old/atop-2.7.0/README 2021-12-18 12:04:24.000000000 +0100 +++ new/atop-2.7.1/README 2022-01-08 12:49:00.000000000 +0100 @@ -1,4 +1,12 @@ +COPYRIGHT NOTICE +---------------- +For all files that are not marked differently: + +Copyright Gerlof Langeveld 2007-2021 and licensed under the GPL v2 (or any later version). + + DEPENDENCIES +------------ Install the following packages to be able to build atop (package name can be different depending on the Linux distro): @@ -15,6 +23,7 @@ INSTALLING AND USING ATOP +------------------------- For interactive use, it is sufficient to install ATOP with the command (as root): @@ -90,5 +99,29 @@ https://lkml.org/lkml/2016/12/19/182 +SERVICE ACTIVATION AFTER INSTALLATION +------------------------------------- + +After the package has been installed, be sure that the related services +are activated. +To support handling of terminated processes using process accounting, +enable the atopacct service: + + systemctl enable --now atopacct + +Notice that this service should not be enabled when the package +psacct or acct (depends on the Linux distribution) has been installed +and enabled. In that case atop uses the daily process accounting file +created via that package. + +To support maintaining daily log files to keep track of long-term analysis +information, enable the atop service and the related timer: + + systemctl enable --now atop + systemctl enable --now atop-rotate.timer + + + + Gerlof Langeveld gerlof.langev...@atoptool.nl diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/atop-2.7.0/atop.service new/atop-2.7.1/atop.service --- old/atop-2.7.0/atop.service 2021-12-18 12:04:24.000000000 +0100 +++ new/atop-2.7.1/atop.service 2022-01-08 12:49:00.000000000 +0100 @@ -3,6 +3,7 @@ Documentation=man:atop(1) [Service] +Type=simple Environment="LOGOPTS=" Environment="LOGINTERVAL=600" Environment="LOGGENERATIONS=28" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/atop-2.7.0/atopgpud new/atop-2.7.1/atopgpud --- old/atop-2.7.0/atopgpud 2021-12-18 12:04:24.000000000 +0100 +++ new/atop-2.7.1/atopgpud 2022-01-08 12:49:00.000000000 +0100 @@ -24,6 +24,22 @@ # -------------------------------------------------------------- # Author: Gerlof Langeveld # Date: July 2018 (initial) +# +# Copyright (C) 2018 Gerlof Langeveld +# +# This program is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by the +# Free Software Foundation; either version 2, or (at your option) any +# later version. +# +# This program is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. +# See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA # ============================================================== import os diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/atop-2.7.0/atopsar.c new/atop-2.7.1/atopsar.c --- old/atop-2.7.0/atopsar.c 2021-12-18 12:04:24.000000000 +0100 +++ new/atop-2.7.1/atopsar.c 2022-01-08 12:49:00.000000000 +0100 @@ -1697,7 +1697,7 @@ int len; iotot = dp->nread + dp->nwrite + - dp->ndisc != -1 ? dp->ndisc : 0; + (dp->ndisc != -1 ? dp->ndisc : 0); if (iotot == 0 && !firstcall && !allresources) continue; /* no activity on this disk */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/atop-2.7.0/man/atop.1 new/atop-2.7.1/man/atop.1 --- old/atop-2.7.0/man/atop.1 2021-12-18 12:04:24.000000000 +0100 +++ new/atop-2.7.1/man/atop.1 2022-01-08 12:49:00.000000000 +0100 @@ -154,10 +154,25 @@ .br This way is preferred, because the .I atopacctd -daemon maintains full control of the sizes of the original process -accounting file (written by the kernel) and the shadow files (read by the +daemon maintains full control of the size of the original process +accounting file written by the kernel and the shadow files read by the .I atop -processes). For further information, refer to the +process(es). + +The +.I atopacct +service will be activated before the +.I atop +service to enable +.I atop +to detect that process accounting is managed by the +.I atopacctd +daemon. As a forking service, +.I atopacctd +takes care that all directories and files are initialized before the +parent process dies. The child process continues as the daemon process. + +For further information, refer to the .B atopacctd man page. .PP diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/atop-2.7.0/netlink.c new/atop-2.7.1/netlink.c --- old/atop-2.7.0/netlink.c 2021-12-18 12:04:24.000000000 +0100 +++ new/atop-2.7.1/netlink.c 2022-01-08 12:49:00.000000000 +0100 @@ -1,3 +1,21 @@ +/* +** Copyright (C) 2014 Gerlof Langeveld +** +** This program is free software; you can redistribute it and/or modify it +** under the terms of the GNU General Public License as published by the +** Free Software Foundation; either version 2, or (at your option) any +** later version. +** +** This program is distributed in the hope that it will be useful, but +** WITHOUT ANY WARRANTY; without even the implied warranty of +** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. +** See the GNU General Public License for more details. +** +** You should have received a copy of the GNU General Public License +** along with this program; if not, write to the Free Software +** Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +** -------------------------------------------------------------------------- +*/ #include <stdio.h> #include <stdlib.h> #include <errno.h> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/atop-2.7.0/versdate.h new/atop-2.7.1/versdate.h --- old/atop-2.7.0/versdate.h 2021-12-18 12:04:24.000000000 +0100 +++ new/atop-2.7.1/versdate.h 2022-01-08 12:49:00.000000000 +0100 @@ -1 +1 @@ -#define ATOPDATE "2021/12/18 11:22:29" +#define ATOPDATE "2022/01/08 12:48:36" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/atop-2.7.0/version.h new/atop-2.7.1/version.h --- old/atop-2.7.0/version.h 2021-12-18 12:04:24.000000000 +0100 +++ new/atop-2.7.1/version.h 2022-01-08 12:49:00.000000000 +0100 @@ -1 +1 @@ -#define ATOPVERS "2.7.0" +#define ATOPVERS "2.7.1" ++++++ harden_atop.service.patch ++++++ --- /var/tmp/diff_new_pack.MKfhMs/_old 2022-03-01 17:04:11.596343390 +0100 +++ /var/tmp/diff_new_pack.MKfhMs/_new 2022-03-01 17:04:11.600343391 +0100 @@ -1,24 +1,24 @@ -diff -urEbw atop-2.7.0/atop.service atop-2.7.0.new/atop.service ---- atop-2.7.0/atop.service 2021-12-18 12:04:24.000000000 +0100 -+++ atop-2.7.0.new/atop.service 2022-01-07 15:30:07.869528035 +0100 +diff -urEbw atop-2.7.1/atop.service atop-2.7.1.new/atop.service +--- atop-2.7.1/atop.service 2022-01-08 12:49:00.000000000 +0100 ++++ atop-2.7.1.new/atop.service 2022-03-01 00:21:11.621320262 +0100 @@ -3,6 +3,19 @@ Documentation=man:atop(1) [Service] -++# added automatically, for details please see -++# https://en.opensuse.org/openSUSE:Security_Features#Systemd_hardening_effort -++ProtectSystem=full -++ProtectHome=true -++PrivateDevices=true -++ProtectHostname=true -++ProtectClock=true -++ProtectKernelTunables=true -++ProtectKernelModules=true -++ProtectKernelLogs=true -++ProtectControlGroups=true -++RestrictRealtime=true -++# end of automatic additions ++# added automatically, for details please see ++# https://en.opensuse.org/openSUSE:Security_Features#Systemd_hardening_effort ++ProtectSystem=full ++ProtectHome=true ++PrivateDevices=true ++ProtectHostname=true ++ProtectClock=true ++ProtectKernelTunables=true ++ProtectKernelModules=true ++ProtectKernelLogs=true ++ProtectControlGroups=true ++RestrictRealtime=true ++# end of automatic additions + Type=simple Environment="LOGOPTS=" Environment="LOGINTERVAL=600" - Environment="LOGGENERATIONS=28"