Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package plasma5-phone-components for 
openSUSE:Factory checked in at 2022-04-01 21:35:27
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/plasma5-phone-components (Old)
 and      /work/SRC/openSUSE:Factory/.plasma5-phone-components.new.1900 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "plasma5-phone-components"

Fri Apr  1 21:35:27 2022 rev:26 rq:965925 version:5.24.4

Changes:
--------
--- 
/work/SRC/openSUSE:Factory/plasma5-phone-components/plasma5-phone-components.changes
        2022-03-12 17:15:54.190335180 +0100
+++ 
/work/SRC/openSUSE:Factory/.plasma5-phone-components.new.1900/plasma5-phone-components.changes
      2022-04-01 21:36:14.529407440 +0200
@@ -1,0 +2,10 @@
+Tue Mar 29 16:04:39 UTC 2022 - Fabian Vogt <fab...@ritter-vogt.de>
+
+- Update to 5.24.4
+  * New bugfix release
+  * For more details please see:
+  * https://kde.org/announcements/plasma/5/5.24.4
+- Changes since 5.24.3:
+  * mmplugin: set all connections to not autoconnect on 
setMobileDataEnabled(false) (#182)
+
+-------------------------------------------------------------------

Old:
----
  plasma-mobile-5.24.3.tar.xz
  plasma-mobile-5.24.3.tar.xz.sig

New:
----
  plasma-mobile-5.24.4.tar.xz
  plasma-mobile-5.24.4.tar.xz.sig

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ plasma5-phone-components.spec ++++++
--- /var/tmp/diff_new_pack.6Ed58e/_old  2022-04-01 21:36:15.101401167 +0200
+++ /var/tmp/diff_new_pack.6Ed58e/_new  2022-04-01 21:36:15.105401123 +0200
@@ -24,7 +24,7 @@
 
 %bcond_without released
 Name:           plasma5-phone-components
-Version:        5.24.3
+Version:        5.24.4
 Release:        0
 # Full Plasma 5 version (e.g. 5.9.3)
 %{!?_plasma5_bugfix: %define _plasma5_bugfix %{version}}

++++++ plasma-mobile-5.24.3.tar.xz -> plasma-mobile-5.24.4.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/plasma-mobile-5.24.3/bin/plasma-mobile.desktop.cmake 
new/plasma-mobile-5.24.4/bin/plasma-mobile.desktop.cmake
--- old/plasma-mobile-5.24.3/bin/plasma-mobile.desktop.cmake    2022-03-08 
12:29:08.000000000 +0100
+++ new/plasma-mobile-5.24.4/bin/plasma-mobile.desktop.cmake    2022-03-29 
13:30:33.000000000 +0200
@@ -37,7 +37,7 @@
 Name[sk]=Plasma Mobile
 Name[sl]=Plasma Mobile
 Name[sv]=Plasma mobil
-Name[tr]=Plasma Mobil
+Name[tr]=Plasma Mobile
 Name[uk]=???????????????? ????????????
 Name[x-test]=xxPlasma Mobilexx
 Name[zh_CN]=Plasma Mobile
@@ -74,7 +74,7 @@
 Comment[sk]=Plasma Mobile od KDE
 Comment[sl]=Plasma Mobile od KDE
 Comment[sv]=Plasma mobil av KDE
-Comment[tr]=KDE taraf??ndan yap??lan Plasma Mobil
+Comment[tr]=KDE taraf??ndan yap??lan Plasma Mobile
 Comment[uk]=???????????????? ???????????? ?????? KDE
 Comment[x-test]=xxPlasma Mobile by KDExx
 Comment[zh_CN]=KDE Plasma Mobile
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/plasma-mobile-5.24.3/components/mmplugin/signalindicator.cpp 
new/plasma-mobile-5.24.4/components/mmplugin/signalindicator.cpp
--- old/plasma-mobile-5.24.3/components/mmplugin/signalindicator.cpp    
2022-03-08 12:29:08.000000000 +0100
+++ new/plasma-mobile-5.24.4/components/mmplugin/signalindicator.cpp    
2022-03-29 13:30:33.000000000 +0200
@@ -47,11 +47,30 @@
 
 bool SignalIndicator::mobileDataEnabled() const
 {
+    // no modem -> no mobile data -> report disabled
     if (!m_nmModem) {
         return false;
     }
 
-    return m_nmModem->state() == NetworkManager::Device::Activated || 
m_nmModem->autoconnect();
+    // mobile data already activated -> report enabled
+    if (m_nmModem->state() == NetworkManager::Device::Activated) {
+        return true;
+    }
+
+    // autoconnect disabled on the entire modem -> report disabled
+    if (!m_nmModem->autoconnect()) {
+        return false;
+    }
+
+    // at least one connection set to autoconnect -> report enabled
+    for (NetworkManager::Connection::Ptr con : 
m_nmModem->availableConnections()) {
+        if (con->settings()->autoconnect()) {
+            return true;
+        }
+    }
+
+    // modem, but no connection, set to autoconnect -> report disabled (#182)
+    return false;
 }
 
 void SignalIndicator::setMobileDataEnabled(bool enabled)
@@ -59,30 +78,37 @@
     if (!m_nmModem) {
         return;
     }
-
     if (!enabled) {
         m_nmModem->setAutoconnect(false);
-
-        // before disconnecting, we ensure the current active connection is 
set to autoconnect
+        // we need to also set all connections to not autoconnect (#182)
         for (NetworkManager::Connection::Ptr con : 
m_nmModem->availableConnections()) {
-            if (con->uuid() == m_nmModem->activeConnection()->uuid()) {
-                con->settings()->setAutoconnect(true);
-            } else {
-                con->settings()->setAutoconnect(false);
-            }
+            con->settings()->setAutoconnect(false);
+            con->update(con->settings()->toMap());
         }
-
         m_nmModem->disconnectInterface().waitForFinished();
     } else {
         m_nmModem->setAutoconnect(true);
-
-        // activate the connection that is set to autoconnect
+        // activate the connection that was last used
+        QDateTime latestTimestamp;
+        NetworkManager::Connection::Ptr latestCon;
         for (NetworkManager::Connection::Ptr con : 
m_nmModem->availableConnections()) {
-            if (con->settings()->autoconnect()) {
-                NetworkManager::activateConnection(con->path(), 
m_nmModem->uni(), "");
-                break;
+            QDateTime timestamp = con->settings()->timestamp();
+            // if con was not used yet, skip it, otherwise:
+            // if we have no latestTimestamp yet, con is the latest
+            // otherwise, compare the timestamps
+            // in case of a tie, use the first connection that was found
+            if (!timestamp.isNull() && (latestTimestamp.isNull() || timestamp 
> latestTimestamp)) {
+                latestTimestamp = timestamp;
+                latestCon = con;
             }
         }
+        // if we found the last used connection
+        if (!latestCon.isNull()) {
+            // set it to autoconnect and connect it immediately
+            latestCon->settings()->setAutoconnect(true);
+            latestCon->update(latestCon->settings()->toMap());
+            NetworkManager::activateConnection(latestCon->path(), 
m_nmModem->uni(), "");
+        }
     }
 }
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/plasma-mobile-5.24.3/containments/panel/package/metadata.desktop 
new/plasma-mobile-5.24.4/containments/panel/package/metadata.desktop
--- old/plasma-mobile-5.24.3/containments/panel/package/metadata.desktop        
2022-03-08 12:29:08.000000000 +0100
+++ new/plasma-mobile-5.24.4/containments/panel/package/metadata.desktop        
2022-03-29 13:30:33.000000000 +0200
@@ -7,7 +7,7 @@
 Name=Phone Panel
 Name[ast]=Panel del tel??fonu
 Name[ca]=Plaf?? del tel??fon
-Name[ca@valencia]=Plaf?? del tel??fon
+Name[ca@valencia]=Quadre del tel??fon
 Name[cs]=Panel telefonu
 Name[da]=Panel til telefon
 Name[en_GB]=Phone Panel
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/plasma-mobile-5.24.3/containments/taskpanel/package/metadata.desktop 
new/plasma-mobile-5.24.4/containments/taskpanel/package/metadata.desktop
--- old/plasma-mobile-5.24.3/containments/taskpanel/package/metadata.desktop    
2022-03-08 12:29:08.000000000 +0100
+++ new/plasma-mobile-5.24.4/containments/taskpanel/package/metadata.desktop    
2022-03-29 13:30:33.000000000 +0200
@@ -7,7 +7,7 @@
 Name=Phone Task panel
 Name[ast]=Panel de xeres del tel??fonu
 Name[ca]=Plaf?? de tasques del tel??fon
-Name[ca@valencia]=Plaf?? de tasques del tel??fon
+Name[ca@valencia]=Quadre de tasques del tel??fon
 Name[da]=Opgavepanel til telefon
 Name[en_GB]=Phone Task panel
 Name[es]=Panel de tareas del tel??fono
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/plasma-mobile-5.24.3/look-and-feel/metadata.desktop 
new/plasma-mobile-5.24.4/look-and-feel/metadata.desktop
--- old/plasma-mobile-5.24.3/look-and-feel/metadata.desktop     2022-03-08 
12:29:08.000000000 +0100
+++ new/plasma-mobile-5.24.4/look-and-feel/metadata.desktop     2022-03-29 
13:30:33.000000000 +0200
@@ -5,7 +5,7 @@
 Name=Plasma Phone
 Name[ast]=Plasma Phone
 Name[ca]=Tel??fon del Plasma
-Name[ca@valencia]=Tel??fon del Plasma
+Name[ca@valencia]=Tel??fon de Plasma
 Name[cs]=Plasma Phone
 Name[da]=Plasma Phone
 Name[de]=Plasma Phone
@@ -42,7 +42,7 @@
 Comment=Plasma workspace for smartphones
 Comment[ast]=La estaya de trabayu de Plasma pa tel??fonos intelixentes
 Comment[ca]=Espai de treball del Plasma per a tel??fons intel??ligents
-Comment[ca@valencia]=Espai de treball del Plasma per a tel??fons intel??ligents
+Comment[ca@valencia]=Espai de treball de Plasma per a tel??fons intel??ligents
 Comment[da]=Plasma arbejdsomr??de til smartphones
 Comment[de]=Plasma-Arbeitsbereich f??r Smartphones
 Comment[en_GB]=Plasma workspace for smartphones

Reply via email to