Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-storage-ng for
openSUSE:Factory checked in at 2022-04-22 21:53:08
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-storage-ng (Old)
and /work/SRC/openSUSE:Factory/.yast2-storage-ng.new.1538 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-storage-ng"
Fri Apr 22 21:53:08 2022 rev:124 rq:971093 version:4.5.3
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-storage-ng/yast2-storage-ng.changes
2022-04-13 21:05:03.532569698 +0200
+++
/work/SRC/openSUSE:Factory/.yast2-storage-ng.new.1538/yast2-storage-ng.changes
2022-04-22 21:53:45.670772285 +0200
@@ -1,0 +2,7 @@
+Mon Apr 18 09:01:42 UTC 2022 - Martin Vidner <[email protected]>
+
+- Fix empty help in some Partitioner dialogs (bsc#1194274)
+ using the standard CWM mechanism.
+- 4.5.3
+
+-------------------------------------------------------------------
Old:
----
yast2-storage-ng-4.5.2.tar.bz2
New:
----
yast2-storage-ng-4.5.3.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-storage-ng.spec ++++++
--- /var/tmp/diff_new_pack.pVU6FI/_old 2022-04-22 21:53:46.166772851 +0200
+++ /var/tmp/diff_new_pack.pVU6FI/_new 2022-04-22 21:53:46.170772855 +0200
@@ -17,7 +17,7 @@
Name: yast2-storage-ng
-Version: 4.5.2
+Version: 4.5.3
Release: 0
Summary: YaST2 - Storage Configuration
License: GPL-2.0-only OR GPL-3.0-only
++++++ yast2-storage-ng-4.5.2.tar.bz2 -> yast2-storage-ng-4.5.3.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.5.2/package/yast2-storage-ng.changes
new/yast2-storage-ng-4.5.3/package/yast2-storage-ng.changes
--- old/yast2-storage-ng-4.5.2/package/yast2-storage-ng.changes 2022-04-12
13:38:25.000000000 +0200
+++ new/yast2-storage-ng-4.5.3/package/yast2-storage-ng.changes 2022-04-20
13:50:00.000000000 +0200
@@ -1,4 +1,11 @@
-------------------------------------------------------------------
+Mon Apr 18 09:01:42 UTC 2022 - Martin Vidner <[email protected]>
+
+- Fix empty help in some Partitioner dialogs (bsc#1194274)
+ using the standard CWM mechanism.
+- 4.5.3
+
+-------------------------------------------------------------------
Mon Apr 11 07:36:47 UTC 2022 - Jos?? Iv??n L??pez Gonz??lez <[email protected]>
- Release sources before probing during installation to avoid
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-storage-ng-4.5.2/package/yast2-storage-ng.spec
new/yast2-storage-ng-4.5.3/package/yast2-storage-ng.spec
--- old/yast2-storage-ng-4.5.2/package/yast2-storage-ng.spec 2022-04-12
13:38:25.000000000 +0200
+++ new/yast2-storage-ng-4.5.3/package/yast2-storage-ng.spec 2022-04-20
13:50:00.000000000 +0200
@@ -16,7 +16,7 @@
#
Name: yast2-storage-ng
-Version: 4.5.2
+Version: 4.5.3
Release: 0
Summary: YaST2 - Storage Configuration
License: GPL-2.0-only OR GPL-3.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.5.2/src/lib/y2partitioner/dialogs/popup.rb
new/yast2-storage-ng-4.5.3/src/lib/y2partitioner/dialogs/popup.rb
--- old/yast2-storage-ng-4.5.2/src/lib/y2partitioner/dialogs/popup.rb
2022-04-12 13:38:25.000000000 +0200
+++ new/yast2-storage-ng-4.5.3/src/lib/y2partitioner/dialogs/popup.rb
2022-04-20 13:50:00.000000000 +0200
@@ -26,7 +26,6 @@
class Popup < Base
def wizard_create_dialog(&block)
Yast::UI.OpenDialog(layout)
- set_help_text
block.call
ensure
Yast::UI.CloseDialog()
@@ -41,7 +40,9 @@
1, # left / right
0.45, # top / bottom
VBox(
- Id(:help_text_container),
+ # This Id makes the Help texts work because CWM will assign the
merged help texts
+ # of the individual widgets to that one, see Wizard.SetHelpText
+ Id(:WizardDialog),
Left(Heading(Id(:title), title)),
VSpacing(0.6),
VCenter(MinSize(min_width, min_height, ReplacePoint(Id(:contents),
Empty()))),
@@ -91,23 +92,6 @@
def cancel_button
PushButton(Id(:cancel), cancel_button_label)
end
-
- # Set the help text to the widget with ID help_text_container.
- #
- # For wizard dialogs, CWM handles this, but for popups, this does not
- # work. So use the UI's built-in help viewer with the predefined
- # HelpText widget property.
- def set_help_text
- return unless respond_to?(:help)
-
- help_text = help
- return if help_text.nil? || help_text.empty?
-
- # The UI handles help texts completely on its own if the HelpText
- # property is set: It opens a help viewer with the help text of the
- # topmost widget in the dialog that has one.
- Yast::UI.ChangeWidget(Id(:help_text_container), :HelpText, help_text)
- end
end
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.5.2/src/lib/y2partitioner/widgets/fstab_options.rb
new/yast2-storage-ng-4.5.3/src/lib/y2partitioner/widgets/fstab_options.rb
--- old/yast2-storage-ng-4.5.2/src/lib/y2partitioner/widgets/fstab_options.rb
2022-04-12 13:38:25.000000000 +0200
+++ new/yast2-storage-ng-4.5.3/src/lib/y2partitioner/widgets/fstab_options.rb
2022-04-20 13:50:00.000000000 +0200
@@ -188,22 +188,6 @@
disable if !supported_by_filesystem?
end
- # @macro seeAbstractWidget
- def handle(event)
- case event["ID"]
- when :help
- help = []
-
- widgets.each do |w|
- help << w.help if w.respond_to? "help"
- end
-
- Yast::Wizard.ShowHelp(help.join("\n"))
- end
-
- nil
- end
-
# @macro seeCustomWidget
def contents
@contents ||=
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.5.2/src/lib/y2partitioner/widgets/mkfs_options.rb
new/yast2-storage-ng-4.5.3/src/lib/y2partitioner/widgets/mkfs_options.rb
--- old/yast2-storage-ng-4.5.2/src/lib/y2partitioner/widgets/mkfs_options.rb
2022-04-12 13:38:25.000000000 +0200
+++ new/yast2-storage-ng-4.5.3/src/lib/y2partitioner/widgets/mkfs_options.rb
2022-04-20 13:50:00.000000000 +0200
@@ -100,32 +100,12 @@
self.handle_all_events = true
end
- # Help text.
- #
- # The text is a combination of help texts from all sub-widgets.
- #
- # @return [String]
- #
- def help
- Yast::CWM.widgets_in_contents(contents).find_all do |w|
- w.respond_to?(:help)
- end.map(&:help).join("\n")
- end
-
# @macro seeAbstractWidget
def opt
[:notify]
end
# @macro seeAbstractWidget
- def handle(event)
- case event["ID"]
- when :help
- Yast::Wizard.ShowHelp(help)
- end
- end
-
- # @macro seeAbstractWidget
def contents
# FIXME: add some VSpacing(1)?
# contents is called several times for each dialog, so cache it
