Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libnotify for openSUSE:Factory checked in at 2022-05-14 22:54:39 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libnotify (Old) and /work/SRC/openSUSE:Factory/.libnotify.new.1538 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libnotify" Sat May 14 22:54:39 2022 rev:42 rq:977008 version:0.7.12 Changes: -------- --- /work/SRC/openSUSE:Factory/libnotify/libnotify.changes 2022-05-08 21:52:37.527483735 +0200 +++ /work/SRC/openSUSE:Factory/.libnotify.new.1538/libnotify.changes 2022-05-14 22:54:44.083183817 +0200 @@ -1,0 +2,21 @@ +Fri May 13 09:56:10 UTC 2022 - Dominique Leuenberger <dims...@opensuse.org> + +- Drop libnotify-rpmlintrc: no longer needed, all rpmlint issues + are fixed. + +------------------------------------------------------------------- +Fri May 6 11:45:55 UTC 2022 - Emily Gonyer <emilyyr...@gmail.com> + +- Update to version 0.7.12: + + docs/notify-send: Add --transient option to manpage. + + notify-send: Move server capabilities check to a separate + function. + + notify-send: Add debug message about server not supporting + persistence. + + notification: Include sender-pid hint by default if not + provided. + + Delete unused notifynotification.xml. + + notification: Bookend calling NotifyActionCallback + with temporary reference. + +------------------------------------------------------------------- Old: ---- libnotify-0.7.11.tar.xz libnotify-rpmlintrc New: ---- libnotify-0.7.12.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libnotify.spec ++++++ --- /var/tmp/diff_new_pack.AOrA1e/_old 2022-05-14 22:54:44.563184416 +0200 +++ /var/tmp/diff_new_pack.AOrA1e/_new 2022-05-14 22:54:44.567184422 +0200 @@ -17,14 +17,13 @@ Name: libnotify -Version: 0.7.11 +Version: 0.7.12 Release: 0 Summary: Notifications Library License: LGPL-2.1-or-later Group: Development/Libraries/X11 URL: https://galago-project.org/ Source: https://download.gnome.org/sources/libnotify/0.7/%{name}-%{version}.tar.xz -Source98: libnotify-rpmlintrc Source99: baselibs.conf BuildRequires: docbook5-xsl-stylesheets BuildRequires: gobject-introspection-devel ++++++ libnotify-0.7.11.tar.xz -> libnotify-0.7.12.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libnotify-0.7.11/NEWS new/libnotify-0.7.12/NEWS --- old/libnotify-0.7.11/NEWS 2022-04-27 21:05:49.000000000 +0200 +++ new/libnotify-0.7.12/NEWS 2022-05-05 18:04:26.352672300 +0200 @@ -1,3 +1,18 @@ +New in 0.7.12 +============ + +* docs/notify-send: Add --transient option to manpage [Marco] +* notify-send: Move server capabilities check to a separate function [Marco] +* notify-send: Add debug message about server not supporting persistence + [Marco] +* notification: Include sender-pid hint by default if not provided [Marco] +* Delete unused notifynotification.xml [Patrick; !25] +* notification: Bookend calling NotifyActionCallback with temporary ref + [Logan; #25, !26] + +Contributors: + Marco Trevisan, Patrick Griffis, Logan Rathbone + New in 0.7.11 ============= * Fix potential build errors with old glib version we require diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libnotify-0.7.11/docs/notify-send.xml new/libnotify-0.7.12/docs/notify-send.xml --- old/libnotify-0.7.11/docs/notify-send.xml 2022-04-27 21:05:49.000000000 +0200 +++ new/libnotify-0.7.12/docs/notify-send.xml 2022-05-05 18:04:26.354672200 +0200 @@ -122,6 +122,12 @@ <para>Wait for the notification to be closed before exiting. If the <option>expire-time</option> is set, it will be used as the maximum waiting time.</para> </listitem> </varlistentry> + <varlistentry> + <term><option>-e</option>, <option>--transient</option></term> + <listitem> + <para>Show a transient notification. Transient notifications by-pass the server's persistence capability, if any. And so it won't be preserved until the user acknowledges it.</para> + </listitem> + </varlistentry> </variablelist> </refsection> <refsection> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libnotify-0.7.11/libnotify/notification.c new/libnotify-0.7.12/libnotify/notification.c --- old/libnotify-0.7.11/libnotify/notification.c 2022-04-27 21:05:49.000000000 +0200 +++ new/libnotify-0.7.12/libnotify/notification.c 2022-05-05 18:04:26.356672300 +0200 @@ -739,12 +739,19 @@ g_warning ("Received unknown action %s", action); } } else { + /* Some clients have assumed it is safe to unref the + * Notification at the end of their NotifyActionCallback + * so we add a temporary ref until we're done with it. + */ + g_object_ref (notification); + notification->priv->activating = TRUE; pair->cb (notification, (char *) action, pair->user_data); notification->priv->activating = FALSE; - g_free (notification->priv->activation_token); notification->priv->activation_token = NULL; + + g_object_unref (notification); } } else if (g_strcmp0 (signal_name, "ActivationToken") == 0 && g_variant_is_of_type (parameters, G_VARIANT_TYPE ("(us)"))) { @@ -819,6 +826,11 @@ g_variant_builder_add (&hints_builder, "{sv}", key, data); } + if (g_hash_table_lookup (priv->hints, "sender-pid") == NULL) { + g_variant_builder_add (&hints_builder, "{sv}", "sender-pid", + g_variant_new_int64 (getpid ())); + } + if (priv->snap_app && g_hash_table_lookup (priv->hints, "desktop-entry") == NULL) { gchar *snap_desktop; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libnotify-0.7.11/libnotify/notifynotification.xml new/libnotify-0.7.12/libnotify/notifynotification.xml --- old/libnotify-0.7.11/libnotify/notifynotification.xml 2022-04-27 21:05:49.000000000 +0200 +++ new/libnotify-0.7.12/libnotify/notifynotification.xml 1970-01-01 01:00:00.000000000 +0100 @@ -1,8 +0,0 @@ -<?xml version="1.0" encoding="UTF-8" ?> - -<node name="/org/freedesktop/Notification"> - - <interface name="org.freedesktop.NotificationListener"> - - </interface> -</node> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libnotify-0.7.11/libnotify.doap new/libnotify-0.7.12/libnotify.doap --- old/libnotify-0.7.11/libnotify.doap 2022-04-27 21:05:49.000000000 +0200 +++ new/libnotify-0.7.12/libnotify.doap 2022-05-05 18:04:26.355672400 +0200 @@ -8,18 +8,21 @@ <category rdf:resource="http://api.gnome.org/doap-extensions#core" /> <programming-language>C</programming-language> <shortdesc xml:lang="en">libnotify is a library for sending desktop notifications</shortdesc> + <description>Library to send desktop notifications that follows the FDO +specifications: + https://gitlab.freedesktop.org/xdg/xdg-specs/-/blob/master/notification/notification-spec.xml</description> <maintainer> <foaf:Person> - <foaf:name>Christian Hammond</foaf:name> - <foaf:mbox rdf:resource="mailto:chip...@chipx86.com" /> - <gnome:userid>chammond</gnome:userid> + <foaf:name>Marco Trevisan</foaf:name> + <foaf:mbox rdf:resource="mailto:m...@3v1n0.net" /> + <gnome:userid>marcotrevi</gnome:userid> </foaf:Person> </maintainer> <maintainer> <foaf:Person> - <foaf:name>William Jon McCann</foaf:name> - <foaf:mbox rdf:resource="mailto:william.jon.mcc...@gmail.com" /> - <gnome:userid>mccann</gnome:userid> + <foaf:name>Logan Rathbone</foaf:name> + <foaf:mbox rdf:resource="mailto:popro...@gmail.com" /> + <gnome:userid>larathbone</gnome:userid> </foaf:Person> </maintainer> </Project> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libnotify-0.7.11/meson.build new/libnotify-0.7.12/meson.build --- old/libnotify-0.7.11/meson.build 2022-04-27 21:05:49.000000000 +0200 +++ new/libnotify-0.7.12/meson.build 2022-05-05 18:04:26.360672200 +0200 @@ -1,6 +1,6 @@ project('libnotify', 'c', - version: '0.7.11', + version: '0.7.12', meson_version: '>= 0.47.0') gnome = import('gnome') diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libnotify-0.7.11/tools/notify-send.c new/libnotify-0.7.12/tools/notify-send.c --- old/libnotify-0.7.11/tools/notify-send.c 2022-04-27 21:05:49.000000000 +0200 +++ new/libnotify-0.7.12/tools/notify-send.c 2022-05-05 18:04:26.365672300 +0200 @@ -176,6 +176,22 @@ return FALSE; } +static gboolean +server_has_capability (const gchar *capability) +{ + GList *server_caps = notify_get_server_caps (); + gboolean supported; + + supported = !!g_list_find_custom (server_caps, + capability, + (GCompareFunc) g_ascii_strcasecmp); + + g_list_foreach (server_caps, (GFunc) g_free, NULL); + g_list_free (server_caps); + + return supported; +} + int main (int argc, char *argv[]) { @@ -309,6 +325,12 @@ if (transient) { notify_notification_set_hint (notify, "transient", g_variant_new_boolean (TRUE)); + + if (!server_has_capability ("persistence")) { + g_debug ("Persistence is not supported by the " + "notifications server. " + "All notifications are transient."); + } } g_free (body); @@ -350,19 +372,12 @@ } if (actions != NULL) { - GList *server_caps = notify_get_server_caps (); gint i = 0; char *action = NULL; gchar **spl = NULL; gboolean have_actions; - have_actions = - !!g_list_find_custom (server_caps, - "actions", - (GCompareFunc) g_ascii_strcasecmp); - g_list_foreach (server_caps, (GFunc) g_free, NULL); - g_list_free (server_caps); - + have_actions = server_has_capability ("actions"); if (!have_actions) { g_printerr (N_("Actions are not supported by this " "notifications server. "