Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package krunner for openSUSE:Factory checked in at 2022-05-16 18:07:10 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/krunner (Old) and /work/SRC/openSUSE:Factory/.krunner.new.1538 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "krunner" Mon May 16 18:07:10 2022 rev:100 rq:977198 version:5.94.0 Changes: -------- --- /work/SRC/openSUSE:Factory/krunner/krunner.changes 2022-04-11 23:48:56.743274578 +0200 +++ /work/SRC/openSUSE:Factory/.krunner.new.1538/krunner.changes 2022-05-16 18:09:12.437311100 +0200 @@ -1,0 +2,14 @@ +Tue May 10 08:18:09 UTC 2022 - Christophe Giboudeaux <christo...@krop.fr> + +- Update to 5.94.0 + * New feature release + * For more details please see: + * https://kde.org/announcements/frameworks/5/5.94.0 +- Changes since 5.93.0: + * Require unit tests to pass on CI + * Fix Qt6 build unit tests + * Fix FreeBSD runnercontexttest on GitlabCI + * Make Qt::Gui dependency for deprecation free builds internal + * Deprecate public KConfigGroup include of AbstractRunner class + +------------------------------------------------------------------- Old: ---- krunner-5.93.0.tar.xz krunner-5.93.0.tar.xz.sig New: ---- krunner-5.94.0.tar.xz krunner-5.94.0.tar.xz.sig ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ krunner.spec ++++++ --- /var/tmp/diff_new_pack.pqho10/_old 2022-05-16 18:09:13.005311552 +0200 +++ /var/tmp/diff_new_pack.pqho10/_new 2022-05-16 18:09:13.009311555 +0200 @@ -17,7 +17,7 @@ %define lname libKF5Runner5 -%define _tar_path 5.93 +%define _tar_path 5.94 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) @@ -25,7 +25,7 @@ # Only needed for the package signature condition %bcond_without released Name: krunner -Version: 5.93.0 +Version: 5.94.0 Release: 0 Summary: KDE Framework for providing different actions given a string query License: LGPL-2.1-or-later ++++++ krunner-5.93.0.tar.xz -> krunner-5.94.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/krunner-5.93.0/.gitlab-ci.yml new/krunner-5.94.0/.gitlab-ci.yml --- old/krunner-5.93.0/.gitlab-ci.yml 2022-04-02 12:03:17.000000000 +0200 +++ new/krunner-5.94.0/.gitlab-ci.yml 2022-05-04 21:27:45.000000000 +0200 @@ -4,4 +4,5 @@ include: - https://invent.kde.org/sysadmin/ci-utilities/raw/master/gitlab-templates/linux.yml - https://invent.kde.org/sysadmin/ci-utilities/raw/master/gitlab-templates/freebsd.yml + - https://invent.kde.org/sysadmin/ci-utilities/raw/master/gitlab-templates/linux-qt6.yml - https://invent.kde.org/sysadmin/ci-utilities/raw/master/gitlab-templates/reuse-lint.yml diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/krunner-5.93.0/.kde-ci.yml new/krunner-5.94.0/.kde-ci.yml --- old/krunner-5.93.0/.kde-ci.yml 2022-04-02 12:03:17.000000000 +0200 +++ new/krunner-5.94.0/.kde-ci.yml 2022-05-04 21:27:45.000000000 +0200 @@ -14,3 +14,4 @@ Options: test-before-installing: True + require-passing-tests-on: [ 'Linux', 'FreeBSD' ] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/krunner-5.93.0/CMakeLists.txt new/krunner-5.94.0/CMakeLists.txt --- old/krunner-5.93.0/CMakeLists.txt 2022-04-02 12:03:17.000000000 +0200 +++ new/krunner-5.94.0/CMakeLists.txt 2022-05-04 21:27:45.000000000 +0200 @@ -3,7 +3,7 @@ cmake_minimum_required(VERSION 3.16) -set(KF_VERSION "5.93.0") # handled by release scripts +set(KF_VERSION "5.94.0") # handled by release scripts set(KF_DEP_VERSION "5.93.0") # handled by release scripts project(KRunner VERSION ${KF_VERSION}) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/krunner-5.93.0/autotests/CMakeLists.txt new/krunner-5.94.0/autotests/CMakeLists.txt --- old/krunner-5.93.0/autotests/CMakeLists.txt 2022-04-02 12:03:17.000000000 +0200 +++ new/krunner-5.94.0/autotests/CMakeLists.txt 2022-05-04 21:27:45.000000000 +0200 @@ -36,12 +36,12 @@ ecm_add_tests( runnermanagersinglerunnermodetest.cpp - LINK_LIBRARIES Qt${QT_MAJOR_VERSION}::Test KF5Runner Qt${QT_MAJOR_VERSION}::Widgets Qt${QT_MAJOR_VERSION}::DBus + LINK_LIBRARIES Qt${QT_MAJOR_VERSION}::Test KF5Runner Qt${QT_MAJOR_VERSION}::Widgets Qt${QT_MAJOR_VERSION}::DBus KF5::ConfigCore ) ecm_add_tests( runnermanagertest.cpp - LINK_LIBRARIES Qt${QT_MAJOR_VERSION}::Test KF5Runner Qt${QT_MAJOR_VERSION}::Widgets Qt${QT_MAJOR_VERSION}::DBus + LINK_LIBRARIES Qt${QT_MAJOR_VERSION}::Test KF5Runner Qt${QT_MAJOR_VERSION}::Widgets Qt${QT_MAJOR_VERSION}::DBus KF5::ConfigCore ) add_executable(testremoterunner) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/krunner-5.93.0/autotests/runnercontexttest.cpp new/krunner-5.94.0/autotests/runnercontexttest.cpp --- old/krunner-5.93.0/autotests/runnercontexttest.cpp 2022-04-02 12:03:17.000000000 +0200 +++ new/krunner-5.94.0/autotests/runnercontexttest.cpp 2022-05-04 21:27:45.000000000 +0200 @@ -30,16 +30,16 @@ QTest::newRow("http without host") << "http://" << Plasma::RunnerContext::UnknownType; QTest::newRow("http without host") << "http://" << Plasma::RunnerContext::UnknownType; QTest::newRow("ftp with host") << "ftp://kde.org" << Plasma::RunnerContext::NetworkLocation; - QTest::newRow("file double slash") << "file://home" << Plasma::RunnerContext::Directory; - QTest::newRow("file triple slash") << "file:///home" << Plasma::RunnerContext::Directory; - QTest::newRow("file single slash") << "file:/home" << Plasma::RunnerContext::Directory; + QTest::newRow("file double slash") << "file:/" + QDir::homePath() << Plasma::RunnerContext::Directory; + QTest::newRow("file triple slash") << "file://" + QDir::homePath() << Plasma::RunnerContext::Directory; + QTest::newRow("file single slash") << "file:" + QDir::homePath() << Plasma::RunnerContext::Directory; QTest::newRow("file multiple path") << "file://usr/bin" << Plasma::RunnerContext::Directory; QTest::newRow("invalid file path") << "file://bad/path" << Plasma::RunnerContext::UnknownType; QTest::newRow("executable") << "ls" << Plasma::RunnerContext::Executable; QTest::newRow("executable with params") << "ls -R" << Plasma::RunnerContext::ShellCommand; QTest::newRow("full path executable") << "ls -R" << Plasma::RunnerContext::ShellCommand; QTest::newRow("full path executable with params") << "/bin/ls -R" << Plasma::RunnerContext::ShellCommand; - QTest::newRow("protocol-less path") << "/home" << Plasma::RunnerContext::Directory; + QTest::newRow("protocol-less path") << QDir::homePath() << Plasma::RunnerContext::Directory; QTest::newRow("protocol-less tilded") << "~" << Plasma::RunnerContext::Directory; const QString file = getSomeExistingFileInHomeDir(); if (!file.isEmpty()) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/krunner-5.93.0/autotests/runnermanagersinglerunnermodetest.cpp new/krunner-5.94.0/autotests/runnermanagersinglerunnermodetest.cpp --- old/krunner-5.93.0/autotests/runnermanagersinglerunnermodetest.cpp 2022-04-02 12:03:17.000000000 +0200 +++ new/krunner-5.94.0/autotests/runnermanagersinglerunnermodetest.cpp 2022-05-04 21:27:45.000000000 +0200 @@ -6,6 +6,7 @@ #include "fakerunner.h" #include "runnermanager.h" +#include <KConfigGroup> #include <KSharedConfig> #include <QAction> #include <QCoreApplication> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/krunner-5.93.0/src/CMakeLists.txt new/krunner-5.94.0/src/CMakeLists.txt --- old/krunner-5.93.0/src/CMakeLists.txt 2022-04-02 12:03:17.000000000 +0200 +++ new/krunner-5.94.0/src/CMakeLists.txt 2022-05-04 21:27:45.000000000 +0200 @@ -62,8 +62,6 @@ PUBLIC Qt${QT_MAJOR_VERSION}::Core KF5::I18n - KF5::ConfigCore - Qt${QT_MAJOR_VERSION}::Gui # QIcon KF5::CoreAddons # KPluginFactory PRIVATE Qt${QT_MAJOR_VERSION}::DBus @@ -80,6 +78,12 @@ KF5::KIOCore #KProtocolInfo ) endif() +if(NOT EXCLUDE_DEPRECATED_BEFORE_AND_AT STREQUAL "CURRENT" AND + EXCLUDE_DEPRECATED_BEFORE_AND_AT VERSION_LESS 5.94.0) + target_link_libraries(KF5Runner PUBLIC Qt${QT_MAJOR_VERSION}::Gui KF5::ConfigCore) +else() + target_link_libraries(KF5Runner PRIVATE Qt${QT_MAJOR_VERSION}::Gui KF5::ConfigCore) +endif() if(HAVE_KACTIVITIES) target_link_libraries(KF5Runner PRIVATE KF5::Activities) endif() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/krunner-5.93.0/src/abstractrunner.cpp new/krunner-5.94.0/src/abstractrunner.cpp --- old/krunner-5.93.0/src/abstractrunner.cpp 2022-04-02 12:03:17.000000000 +0200 +++ new/krunner-5.94.0/src/abstractrunner.cpp 2022-05-04 21:27:45.000000000 +0200 @@ -15,9 +15,11 @@ #include <QAction> #include <QElapsedTimer> #include <QHash> +#include <QIcon> #include <QMimeData> #include <QMutex> +#include <KConfigGroup> #include <KLocalizedString> #include <KSharedConfig> #if KRUNNER_BUILD_DEPRECATED_SINCE(5, 65) @@ -486,15 +488,15 @@ void AbstractRunnerPrivate::init() { + minLetterCount = runnerDescription.value(QStringLiteral("X-Plasma-Runner-Min-Letter-Count"), 0); if (runnerDescription.isValid()) { const auto rawData = runnerDescription.rawData(); - minLetterCount = rawData.value(QStringLiteral("X-Plasma-Runner-Min-Letter-Count")).toInt(); if (rawData.contains(QStringLiteral("X-Plasma-Runner-Match-Regex"))) { matchRegex = QRegularExpression(rawData.value(QStringLiteral("X-Plasma-Runner-Match-Regex")).toString()); hasMatchRegex = matchRegex.isValid() && !matchRegex.pattern().isEmpty(); } - hasUniqueResults = rawData.value(QStringLiteral("X-Plasma-Runner-Unique-Results")).toBool(); - hasWeakResults = rawData.value(QStringLiteral("X-Plasma-Runner-Weak-Results")).toBool(); + hasUniqueResults = runnerDescription.value(QStringLiteral("X-Plasma-Runner-Unique-Results"), false); + hasWeakResults = runnerDescription.value(QStringLiteral("X-Plasma-Runner-Weak-Results"), false); } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/krunner-5.93.0/src/abstractrunner.h new/krunner-5.94.0/src/abstractrunner.h --- old/krunner-5.93.0/src/abstractrunner.h 2022-04-02 12:03:17.000000000 +0200 +++ new/krunner-5.94.0/src/abstractrunner.h 2022-05-04 21:27:45.000000000 +0200 @@ -7,15 +7,20 @@ #ifndef PLASMA_ABSTRACTRUNNER_H #define PLASMA_ABSTRACTRUNNER_H -#include <QIcon> +#include "krunner_export.h" + #include <QObject> #include <QStringList> +#if KRUNNER_ENABLE_DEPRECATED_SINCE(5, 94) #include <KConfigGroup> +#include <QIcon> +#else +class KConfigGroup; +class QIcon; +#endif #include <KPluginMetaData> -#include "krunner_export.h" - #if KRUNNER_ENABLE_DEPRECATED_SINCE(5, 91) #include <KPluginInfo> #include <KService> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/krunner-5.93.0/src/dbusrunner.cpp new/krunner-5.94.0/src/dbusrunner.cpp --- old/krunner-5.93.0/src/dbusrunner.cpp 2022-04-02 12:03:17.000000000 +0200 +++ new/krunner-5.94.0/src/dbusrunner.cpp 2022-05-04 21:27:45.000000000 +0200 @@ -31,11 +31,11 @@ qDBusRegisterMetaType<RemoteAction>(); qDBusRegisterMetaType<RemoteActions>(); qDBusRegisterMetaType<RemoteImage>(); - qRegisterMetaType<QMap<QString, RemoteActions>>(); + qRegisterMetaType<QMap<QString, RemoteActions>>("QMap<QString, RemoteActions>"); QString requestedServiceName = pluginMetaData.value(QStringLiteral("X-Plasma-DBusRunner-Service")); m_path = pluginMetaData.value(QStringLiteral("X-Plasma-DBusRunner-Path")); - m_hasUniqueResults = pluginMetaData.rawData().value(QStringLiteral("X-Plasma-Runner-Unique-Results")).toBool(); + m_hasUniqueResults = pluginMetaData.value(QStringLiteral("X-Plasma-Runner-Unique-Results"), false); m_callLifecycleMethods = pluginMetaData.value(QStringLiteral("X-Plasma-API")) == QLatin1String("DBus2"); if (requestedServiceName.isEmpty() || m_path.isEmpty()) { @@ -80,12 +80,15 @@ m_matchingServices << requestedServiceName; } - m_requestActionsOnce = pluginMetaData.rawData().value(QStringLiteral("X-Plasma-Request-Actions-Once")).toVariant().toBool(); + m_requestActionsOnce = pluginMetaData.value(QStringLiteral("X-Plasma-Request-Actions-Once"), false); connect(this, &AbstractRunner::teardown, this, &DBusRunner::teardown); // Load the runner syntaxes - const QStringList syntaxes = pluginMetaData.rawData().value(QStringLiteral("X-Plasma-Runner-Syntaxes")).toVariant().toStringList(); - const QStringList syntaxDescriptions = pluginMetaData.rawData().value(QStringLiteral("X-Plasma-Runner-Syntax-Descriptions")).toVariant().toStringList(); + const QJsonValue syntaxesJson = pluginMetaData.rawData().value(QStringLiteral("X-Plasma-Runner-Syntaxes")); + const QStringList syntaxes = syntaxesJson.isArray() ? syntaxesJson.toVariant().toStringList() : syntaxesJson.toString().split(QLatin1Char(','), Qt::SkipEmptyParts); + const QJsonValue syntaxDescriptionsJson = pluginMetaData.rawData().value(QStringLiteral("X-Plasma-Runner-Syntax-Descriptions")); + const QStringList syntaxDescriptions = + syntaxDescriptionsJson.isArray() ? syntaxDescriptionsJson.toVariant().toStringList() : syntaxDescriptionsJson.toString().split(QLatin1Char(','), Qt::SkipEmptyParts); const int descriptionCount = syntaxDescriptions.count(); for (int i = 0; i < syntaxes.count(); ++i) { const QString &query = syntaxes.at(i);