Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package pcp for openSUSE:Factory checked in at 2022-05-19 22:48:56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/pcp (Old) and /work/SRC/openSUSE:Factory/.pcp.new.1538 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "pcp" Thu May 19 22:48:56 2022 rev:64 rq:977496 version:5.2.2 Changes: -------- --- /work/SRC/openSUSE:Factory/pcp/pcp.changes 2022-03-19 22:22:10.480895078 +0100 +++ /work/SRC/openSUSE:Factory/.pcp.new.1538/pcp.changes 2022-05-19 22:49:04.706316312 +0200 @@ -1,0 +2,15 @@ +Mon May 16 07:30:26 UTC 2022 - Dominique Leuenberger <dims...@opensuse.org> + +- Fix a few rpmlint errors (to at least get below the 1000 mark) + (boo#1199558): + + make libpcp-devel require libpcp_gui: the devel package + installs a symlink pointing to that library, so anything + willing to link it would fail + libpcp-devel.x86_64: E: no-library-dependency-on libpcp_gui2 /usr/lib64/libpcp_gui.so.2 + The package misses dependency on a package which file it links to. + + Call fdupes over /var/lib/pcp/testsuite to solve + pcp-testsuite.x86_64: W: files-duplicate + + W: macro-in-comment: escape the relevant macros using %% + + Filter out W: potential-bashisms for pcp-testsuite. + +------------------------------------------------------------------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ pcp.spec ++++++ --- /var/tmp/diff_new_pack.88wW5F/_old 2022-05-19 22:49:05.554317399 +0200 +++ /var/tmp/diff_new_pack.88wW5F/_new 2022-05-19 22:49:05.562317409 +0200 @@ -407,7 +407,7 @@ %global _hicolordir %{_datadir}/icons/hicolor %if 0%{?fedora} >= 20 || 0%{?rhel} >= 8 || 0%{?suse_version} -# FIXME: PCP defaults to using %{_datadir}/doc/pcp-doc +# FIXME: PCP defaults to using %%{_datadir}/doc/pcp-doc %global _with_doc --with-docdir=%{_docdir}/%{name} %endif %if !%{disable_systemd} @@ -624,6 +624,7 @@ Group: %{lib_devel_gr} URL: https://pcp.io Requires: %{lib_pkg} = %{version}-%{release} +Requires: libpcp_gui%{libpcp_gui_sover} = %{version} Conflicts: %{lib_devel_pkg_conflict} %if (0%{?suse_version} > 0) Provides: pcp-devel = %{version} @@ -888,7 +889,7 @@ %if !0%{?suse_version} Requires: %{lib_pkg} >= %{version}-%{release} %else -# this package nests files under %{_sysconfdir}/zabbix, which is provided by: +# this package nests files under %%{_sysconfdir}/zabbix, which is provided by: Requires: zabbix-server %endif @@ -1869,7 +1870,7 @@ summary instance per iSCSI target, which aggregates all LUN metrics within the target. #end pcp-pmda-lio -%endif # !%{disable_lio} +%endif # !%%{disable_lio} # # pcp-pmda-openmetrics @@ -1929,7 +1930,7 @@ collecting metrics from simple network checks. # end pcp-pmda-netcheck -%endif # !%{disable_python3} +%endif # !%%{disable_python3} %if !%{disable_mssql} # @@ -1970,7 +1971,7 @@ This package contains the PCP Performance Metrics Domain Agent (PMDA) for collecting metrics output in JSON. # end pcp-pmda-json -%endif # !%{disable_json} +%endif # !%%{disable_json} # # C pmdas @@ -2603,6 +2604,8 @@ %endif rm -f %{buildroot}/%{_localstatedir}/lib/pcp/testsuite/perfevent/perfevent_coverage # drop unreproducible file (boo#1040589) +%fdupes %{buildroot}%{_testsdir} + %if 0%{?suse_version} mkdir -p %{buildroot}/%{_tempsdir} @@ -2613,7 +2616,7 @@ ln -sf /sbin/service %{buildroot}/%{_sbindir}/rcpmlogger ln -sf /sbin/service %{buildroot}/%{_sbindir}/rcpmproxy -# SUSE requires use of %fillup_and_insserv +# SUSE requires use of %%fillup_and_insserv mkdir -p %{buildroot}/%{_fillupdir} for f in pmlogger pmproxy pmcd pmie_timers pmlogger_timers pmfind; do mv %{buildroot}/%{_sysconfdir}/sysconfig/${f} \ @@ -3484,7 +3487,7 @@ %{_pmdasexecdir}/netcheck %{_confdir}/netcheck -%endif # !%{disable_python3} +%endif # !%%{disable_python3} %if !%{disable_zabbix_agent} %files export-zabbix-agent ++++++ pcp-rpmlintrc ++++++ --- /var/tmp/diff_new_pack.88wW5F/_old 2022-05-19 22:49:05.626317491 +0200 +++ /var/tmp/diff_new_pack.88wW5F/_new 2022-05-19 22:49:05.630317496 +0200 @@ -7,4 +7,10 @@ # tmp files. it must be world writeable for PMDAs and client tools, which # may be run as anyone. #addFilter('E: permissions-world-writable') +# pcp-testsuite.x86_64: W: potential-bashisms /var/lib/pcp/testsuite/archives/mk.ipcs +# checkbashisms reported potential bashisms in a /bin/sh shell script, you might +# want to manually check this script for bashisms. +addFilter('pcp-testsuite.*W: potential-bashisms'); +# pcp-testsuite.x86_64: E: env-script-interpreter +addFilter('pcp-testsuite.*E: env-script-interpreter');