Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package gammu for openSUSE:Factory checked
in at 2022-06-20 15:38:37
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/gammu (Old)
and /work/SRC/openSUSE:Factory/.gammu.new.1548 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gammu"
Mon Jun 20 15:38:37 2022 rev:55 rq:983885 version:1.42.0
Changes:
--------
--- /work/SRC/openSUSE:Factory/gammu/gammu.changes 2021-12-29
21:10:58.606286518 +0100
+++ /work/SRC/openSUSE:Factory/.gammu.new.1548/gammu.changes 2022-06-20
15:39:23.427045079 +0200
@@ -1,0 +2,7 @@
+Mon May 23 19:38:16 UTC 2022 - Martin Li??ka <mli...@suse.cz>
+
+- Add fix-buffer-overflow-in-backup.patch in order to address
+ 0001-Fix-buffer-overflow-in-Backup.Creator.patch
+- Use autosetup.
+
+-------------------------------------------------------------------
New:
----
0001-Fix-buffer-overflow-in-Backup.Creator.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ gammu.spec ++++++
--- /var/tmp/diff_new_pack.8NdfX2/_old 2022-06-20 15:39:23.919045799 +0200
+++ /var/tmp/diff_new_pack.8NdfX2/_new 2022-06-20 15:39:23.923045804 +0200
@@ -1,7 +1,7 @@
#
# spec file for package gammu
#
-# Copyright (c) 2021 SUSE LLC
+# Copyright (c) 2022 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -32,6 +32,7 @@
Patch3: 0001-Update-Python-scripts-to-Python-3.patch
Patch4: 0001-Docs-Adjust-attributes-order-to-avoid-bugs-in-breath.patch
Patch5: harden_gammu-smsd.service.patch
+Patch6: 0001-Fix-buffer-overflow-in-Backup.Creator.patch
BuildRequires: cmake >= 2.8
BuildRequires: doxygen
BuildRequires: gettext
@@ -185,12 +186,7 @@
This package contains the Gammu SMS daemon shared library.
%prep
-%setup -q
-%patch1 -p1
-%patch2 -p1
-%patch3 -p1
-%patch4 -p1
-%patch5 -p1
+%autosetup -p1
# GPL-3.0 licensed files, bnc#775397
rm -rf contrib/sms-gammu2android
++++++ 0001-Fix-buffer-overflow-in-Backup.Creator.patch ++++++
>From ec7e2902c19a886578062979e2749372bfea0380 Mon Sep 17 00:00:00 2001
From: Martin Liska <mli...@suse.cz>
Date: Mon, 20 Jun 2022 10:24:13 +0200
Subject: [PATCH] Fix buffer overflow in Backup.Creator
I noticed that while testing the upcoming GCC 12 with -D_FORTIFY_SOURCE=3:
here I have
$1 = 0x7ffff7f0f940 <Buffer.1.lto_priv.1> "Linux, kernel 5.16.14-1-default (#1
SMP PREEMPT Fri Mar 11 12:33:34 UTC 2022 (80acc65))"
(gdb) p (int)strlen(GetOS())
$3 = 87
so GetOS() returns 87 chars while:
include/gammu-backup.h: char Creator[80];
Fixes: #701
---
include/gammu-backup.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/gammu-backup.h b/include/gammu-backup.h
index e7fbc6e74..d5574ea7a 100644
--- a/include/gammu-backup.h
+++ b/include/gammu-backup.h
@@ -218,7 +218,7 @@ typedef struct {
/**
* Name of program which created backup
*/
- char Creator[80];
+ char Creator[512];
/**
* Timestamp of backup
*/
--
2.36.1
