Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package build-compare for openSUSE:Factory checked in at 2022-06-23 10:22:05 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/build-compare (Old) and /work/SRC/openSUSE:Factory/.build-compare.new.1548 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "build-compare" Thu Jun 23 10:22:05 2022 rev:121 rq:984012 version:20220620T150329.a852498 Changes: -------- --- /work/SRC/openSUSE:Factory/build-compare/build-compare.changes 2022-03-11 11:40:44.534572361 +0100 +++ /work/SRC/openSUSE:Factory/.build-compare.new.1548/build-compare.changes 2022-06-23 10:22:09.991602824 +0200 @@ -1,0 +2,10 @@ +Mon Jun 20 12:34:56 UTC 2022 - o...@aepfle.de + +- fix objdump parsing for non-executable sections (#53) + +------------------------------------------------------------------- +Mon Jun 13 13:13:13 UTC 2022 - o...@aepfle.de + +- fix objdump parsing (#52) + +------------------------------------------------------------------- @@ -219 +229 @@ -- Remove warning about python mtime mismatch, a republish will not help +- Remove warning about python mtime mismatch, a republish will not help (bsc#915948) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ build-compare.spec ++++++ --- /var/tmp/diff_new_pack.HtABtF/_old 2022-06-23 10:22:10.599603485 +0200 +++ /var/tmp/diff_new_pack.HtABtF/_new 2022-06-23 10:22:10.599603485 +0200 @@ -21,7 +21,7 @@ License: GPL-2.0+ Group: Development/Tools/Building Url: https://github.com/openSUSE/build-compare -Version: 20220307T115648.b5abdde +Version: 20220620T150329.a852498 Release: 0 Source1: COPYING Source2: same-build-result.sh ++++++ pkg-diff.sh ++++++ --- /var/tmp/diff_new_pack.HtABtF/_old 2022-06-23 10:22:10.663603555 +0200 +++ /var/tmp/diff_new_pack.HtABtF/_new 2022-06-23 10:22:10.667603559 +0200 @@ -833,8 +833,7 @@ local ret=0 local i local failed - local objdump_failed - local elfdiff + local elfdiff elf_executable_sections local sections local -a pipestatus @@ -933,25 +932,17 @@ p } ')) - ($OBJDUMP -s ${sections[@]} old/$file | - sed -e "s,old/,," ; echo "${PIPESTATUS[@]}" > $file1 ) > old/$file.objdump & - ($OBJDUMP -s ${sections[@]} new/$file | - sed -e "s,new/,," ; echo "${PIPESTATUS[@]}" > $file2 ) > new/$file.objdump & + (cd old && exec $OBJDUMP -s ${sections[@]} ./$file ) > old/$file.objdump & + (cd new && exec $OBJDUMP -s ${sections[@]} ./$file ) > new/$file.objdump & wait - read i < ${file1} - pipestatus=( $i ) - objdump_failed="${pipestatus[0]}" - if [[ ${pipestatus[*]} =~ [1-9] ]] + if ! test -s old/$file.objdump then - wprint "ELF section: pipe command failed for old/$file" + wprint "ELF section: objdump failed for old/$file" elfdiff='failed' fi - read i < ${file2} - pipestatus=( $i ) - objdump_failed="${objdump_failed}${pipestatus[0]}" - if [[ ${pipestatus[*]} =~ [1-9] ]] + if ! test -s new/$file.objdump then - wprint "ELF section: pipe command failed for new/$file" + wprint "ELF section: objdump failed for new/$file" elfdiff='failed' fi if test -z "${elfdiff}" @@ -974,29 +965,26 @@ return 0 fi watchdog_touch - elfdiff= - ($OBJDUMP -d --no-show-raw-insn old/$file | filter_disasm | - sed -e "s,^old/[^:]\+,," ; echo "${PIPESTATUS[@]}" > $file1 ) > old/$file.objdump & - ($OBJDUMP -d --no-show-raw-insn new/$file | filter_disasm | - sed -e "s,^new/[^:]\+,," ; echo "${PIPESTATUS[@]}" > $file2 ) > new/$file.objdump & + (cd old && exec $OBJDUMP -d --no-show-raw-insn ./$file | filter_disasm + echo "${PIPESTATUS[@]}" > $file1 ) > old/$file.objdump & + (cd new && exec $OBJDUMP -d --no-show-raw-insn ./$file | filter_disasm + echo "${PIPESTATUS[@]}" > $file2 ) > new/$file.objdump & wait read i < ${file1} pipestatus=( $i ) - objdump_failed="${objdump_failed}${pipestatus[0]}" if [[ ${pipestatus[*]} =~ [1-9] ]] then wprint "ELF disassembly: pipe command failed for old/$file" - elfdiff='failed' + elf_executable_sections='failed' fi read i < ${file2} pipestatus=( $i ) - objdump_failed="${objdump_failed}${pipestatus[0]}" if [[ ${pipestatus[*]} =~ [1-9] ]] then wprint "ELF disassembly: pipe command failed for new/$file" - elfdiff='failed' + elf_executable_sections='failed' fi - if test ${objdump_failed} -gt 0 || test -n "${elfdiff}" + if test -n "${elf_executable_sections}" then # objdump had no idea how to handle it rm old/$file.objdump new/$file.objdump & @@ -1005,7 +993,6 @@ fi return 1 fi - elfdiff= diff --speed-large-files --unified \ --label "old $file (disasm)" \ --label "new $file (disasm)" \ @@ -1016,11 +1003,11 @@ then wprint "$file differs in assembler output" $buildcompare_head $dfile - elfdiff='elfdiff' + elf_executable_sections='elf_executable_sections' else watchdog_touch fi - if test -n "$elfdiff" + if test -n "$elfdiff" || test -n "$elf_executable_sections" then return 1 fi
