Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package gnome-remote-desktop for openSUSE:Factory checked in at 2022-07-04 11:49:05 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gnome-remote-desktop (Old) and /work/SRC/openSUSE:Factory/.gnome-remote-desktop.new.1548 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gnome-remote-desktop" Mon Jul 4 11:49:05 2022 rev:11 rq:986583 version:42.3 Changes: -------- --- /work/SRC/openSUSE:Factory/gnome-remote-desktop/gnome-remote-desktop.changes 2022-05-31 15:48:51.320046899 +0200 +++ /work/SRC/openSUSE:Factory/.gnome-remote-desktop.new.1548/gnome-remote-desktop.changes 2022-07-04 11:49:12.097211869 +0200 @@ -1,0 +2,10 @@ +Sun Jul 03 18:16:17 UTC 2022 - bjorn....@gmail.com + +- Update to version 42.3: + + egl-thread: Release EGL context before destroying it. + + rdp-graphics-pipeline: Fix uninitialized caps mutex. + + session-rdp: Use trivial boolean value for condition in + graphics thread. + + rdp/nw-auto: Turn assertion into normal conditional statement. + +------------------------------------------------------------------- Old: ---- gnome-remote-desktop-42.2.obscpio New: ---- gnome-remote-desktop-42.3.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-remote-desktop.spec ++++++ --- /var/tmp/diff_new_pack.Bxir3i/_old 2022-07-04 11:49:12.509212467 +0200 +++ /var/tmp/diff_new_pack.Bxir3i/_new 2022-07-04 11:49:12.513212473 +0200 @@ -21,7 +21,7 @@ %define freerdp_version 2.2.0 Name: gnome-remote-desktop -Version: 42.2 +Version: 42.3 Release: 0 Summary: GNOME Remote Desktop screen sharing service License: GPL-2.0-or-later ++++++ _service ++++++ --- /var/tmp/diff_new_pack.Bxir3i/_old 2022-07-04 11:49:12.541212513 +0200 +++ /var/tmp/diff_new_pack.Bxir3i/_new 2022-07-04 11:49:12.545212519 +0200 @@ -2,7 +2,7 @@ <service name="obs_scm" mode="disabled"> <param name="url">https://gitlab.gnome.org/GNOME/gnome-remote-desktop.git</param> <param name="scm">git</param> - <param name="revision">refs/tags/42.2</param> + <param name="revision">refs/tags/42.3</param> <param name="versionformat">@PARENT_TAG@</param> <param name="changesgenerate">enable</param> </service> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.Bxir3i/_old 2022-07-04 11:49:12.561212542 +0200 +++ /var/tmp/diff_new_pack.Bxir3i/_new 2022-07-04 11:49:12.565212548 +0200 @@ -1,6 +1,6 @@ <servicedata> <service name="tar_scm"> <param name="url">https://gitlab.gnome.org/GNOME/gnome-remote-desktop.git</param> - <param name="changesrevision">a5a962b923bf88d64793b43e0f3915e0eaa8acbe</param></service></servicedata> + <param name="changesrevision">73b9f00b31bc462de42e94054121052a106df521</param></service></servicedata> (No newline at EOF) ++++++ gnome-remote-desktop-42.2.obscpio -> gnome-remote-desktop-42.3.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-remote-desktop-42.2/meson.build new/gnome-remote-desktop-42.3/meson.build --- old/gnome-remote-desktop-42.2/meson.build 2022-05-29 18:27:40.000000000 +0200 +++ new/gnome-remote-desktop-42.3/meson.build 2022-07-03 16:13:18.000000000 +0200 @@ -1,5 +1,5 @@ project('gnome-remote-desktop', 'c', - version: '42.2', + version: '42.3', meson_version: '>= 0.47.0', default_options: ['warning_level=1', 'buildtype=debugoptimized']) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-remote-desktop-42.2/src/grd-egl-thread.c new/gnome-remote-desktop-42.3/src/grd-egl-thread.c --- old/gnome-remote-desktop-42.2/src/grd-egl-thread.c 2022-05-29 18:27:40.000000000 +0200 +++ new/gnome-remote-desktop-42.3/src/grd-egl-thread.c 2022-07-03 16:13:18.000000000 +0200 @@ -540,6 +540,8 @@ } g_async_queue_unref (egl_thread->task_queue); + eglMakeCurrent (egl_thread->impl.egl_display, + EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT); eglDestroyContext (egl_thread->impl.egl_display, egl_thread->impl.egl_context); eglTerminate (egl_thread->impl.egl_display); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-remote-desktop-42.2/src/grd-rdp-graphics-pipeline.c new/gnome-remote-desktop-42.3/src/grd-rdp-graphics-pipeline.c --- old/gnome-remote-desktop-42.2/src/grd-rdp-graphics-pipeline.c 2022-05-29 18:27:40.000000000 +0200 +++ new/gnome-remote-desktop-42.3/src/grd-rdp-graphics-pipeline.c 2022-07-03 16:13:18.000000000 +0200 @@ -1554,6 +1554,7 @@ GrdRdpGraphicsPipeline *graphics_pipeline = GRD_RDP_GRAPHICS_PIPELINE (object); g_mutex_clear (&graphics_pipeline->gfx_mutex); + g_mutex_clear (&graphics_pipeline->caps_mutex); G_OBJECT_CLASS (grd_rdp_graphics_pipeline_parent_class)->finalize (object); } @@ -1728,6 +1729,7 @@ graphics_pipeline->encoded_frames = g_queue_new (); graphics_pipeline->enc_times = g_queue_new (); + g_mutex_init (&graphics_pipeline->caps_mutex); g_mutex_init (&graphics_pipeline->gfx_mutex); protocol_reset_source = g_source_new (&protocol_reset_source_funcs, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-remote-desktop-42.2/src/grd-rdp-network-autodetection.c new/gnome-remote-desktop-42.3/src/grd-rdp-network-autodetection.c --- old/gnome-remote-desktop-42.2/src/grd-rdp-network-autodetection.c 2022-05-29 18:27:40.000000000 +0200 +++ new/gnome-remote-desktop-42.3/src/grd-rdp-network-autodetection.c 2022-07-03 16:13:18.000000000 +0200 @@ -303,14 +303,17 @@ grd_rdp_network_autodetection_bw_measure_stop (GrdRdpNetworkAutodetection *network_autodetection) { rdpAutoDetect *rdp_autodetect = network_autodetection->rdp_autodetect; + g_autoptr (GMutexLocker) locker = NULL; - g_mutex_lock (&network_autodetection->bw_measure_mutex); - g_assert (network_autodetection->bw_measure_state == BW_MEASURE_STATE_PENDING_STOP || - network_autodetection->bw_measure_state == BW_MEASURE_STATE_QUEUED_STOP); - + locker = g_mutex_locker_new (&network_autodetection->bw_measure_mutex); ResetEvent (network_autodetection->bw_measure_stop_event); + + if (network_autodetection->bw_measure_state != BW_MEASURE_STATE_PENDING_STOP && + network_autodetection->bw_measure_state != BW_MEASURE_STATE_QUEUED_STOP) + return; + network_autodetection->bw_measure_state = BW_MEASURE_STATE_PENDING_RESULTS; - g_mutex_unlock (&network_autodetection->bw_measure_mutex); + g_clear_pointer (&locker, g_mutex_locker_free); rdp_autodetect->BandwidthMeasureStop (network_autodetection->rdp_context, BW_MEASURE_SEQUENCE_NUMBER); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-remote-desktop-42.2/src/grd-session-rdp.c new/gnome-remote-desktop-42.3/src/grd-session-rdp.c --- old/gnome-remote-desktop-42.2/src/grd-session-rdp.c 2022-05-29 18:27:40.000000000 +0200 +++ new/gnome-remote-desktop-42.3/src/grd-session-rdp.c 2022-07-03 16:13:18.000000000 +0200 @@ -123,6 +123,7 @@ GrdRdpSAMFile *sam_file; uint32_t rdp_error_info; GrdRdpScreenShareMode screen_share_mode; + gboolean session_stopped; GMutex rdp_flags_mutex; RdpPeerFlag rdp_flags; @@ -2111,7 +2112,7 @@ if (session_rdp->hwaccel_nvidia) grd_hwaccel_nvidia_push_cuda_context (session_rdp->hwaccel_nvidia); - while (WaitForSingleObject (session_rdp->stop_event, 0) == WAIT_TIMEOUT) + while (!session_rdp->session_stopped) g_main_context_iteration (session_rdp->graphics_context, TRUE); if (session_rdp->hwaccel_nvidia) @@ -2202,6 +2203,8 @@ g_debug ("Stopping RDP session"); unset_rdp_peer_flag (session_rdp, RDP_PEER_ACTIVATED); + session_rdp->session_stopped = TRUE; + if (WaitForSingleObject (session_rdp->stop_event, 0) == WAIT_TIMEOUT) { freerdp_set_error_info (peer->context->rdp, @@ -2222,12 +2225,8 @@ if (session_rdp->graphics_thread) { - uint32_t status; - g_assert (session_rdp->graphics_context); - - status = WaitForSingleObject (session_rdp->stop_event, 0); - g_assert (status != WAIT_TIMEOUT); + g_assert (session_rdp->session_stopped); g_main_context_wakeup (session_rdp->graphics_context); g_clear_pointer (&session_rdp->graphics_thread, g_thread_join); ++++++ gnome-remote-desktop.obsinfo ++++++ --- /var/tmp/diff_new_pack.Bxir3i/_old 2022-07-04 11:49:12.737212798 +0200 +++ /var/tmp/diff_new_pack.Bxir3i/_new 2022-07-04 11:49:12.741212804 +0200 @@ -1,5 +1,5 @@ name: gnome-remote-desktop -version: 42.2 -mtime: 1653841660 -commit: a5a962b923bf88d64793b43e0f3915e0eaa8acbe +version: 42.3 +mtime: 1656857598 +commit: 73b9f00b31bc462de42e94054121052a106df521