Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package lxqt-build-tools for
openSUSE:Factory checked in at 2022-08-30 14:49:44
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/lxqt-build-tools (Old)
and /work/SRC/openSUSE:Factory/.lxqt-build-tools.new.2083 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "lxqt-build-tools"
Tue Aug 30 14:49:44 2022 rev:11 rq:1000065 version:0.11.0
Changes:
--------
--- /work/SRC/openSUSE:Factory/lxqt-build-tools/lxqt-build-tools.changes
2022-05-01 18:54:17.231201853 +0200
+++
/work/SRC/openSUSE:Factory/.lxqt-build-tools.new.2083/lxqt-build-tools.changes
2022-08-30 14:50:18.256246618 +0200
@@ -1,0 +2,6 @@
+Mon Aug 29 14:23:55 UTC 2022 - Michael Vetter <mvet...@suse.com>
+
+- bsc#1195421: Add lxqt-build-tools-symbolic.patch
+ Thanks to Fabian Vogt
+
+-------------------------------------------------------------------
New:
----
lxqt-build-tools-symbolic.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ lxqt-build-tools.spec ++++++
--- /var/tmp/diff_new_pack.712NCw/_old 2022-08-30 14:50:18.640247597 +0200
+++ /var/tmp/diff_new_pack.712NCw/_new 2022-08-30 14:50:18.648247617 +0200
@@ -25,6 +25,8 @@
URL: http://www.lxqt.org
Source:
https://github.com/lxqt/%{name}/releases/download/%{version}/%{name}-%{version}.tar.xz
Source1:
https://github.com/lxqt/%{name}/releases/download/%{version}/%{name}-%{version}.tar.xz.asc
+# PATCH-FIX-UPSTREAM lxqt-build-tools-symbolic.patch [bsc#1195421]
+Patch0: lxqt-build-tools-symbolic.patch
BuildRequires: cmake >= 3.1.0
BuildRequires: pkgconfig
BuildRequires: pkgconfig(Qt5Core) >= 5.15
@@ -47,6 +49,7 @@
%prep
%setup -q
+%patch0 -p1
%build
%cmake -DPULL_TRANSLATIONS=No
++++++ lxqt-build-tools-symbolic.patch ++++++
>From fd449e28e30886522c32df610c77124fb7be4b37 Mon Sep 17 00:00:00 2001
From: Fabian Vogt <fv...@suse.de>
Date: Mon, 29 Aug 2022 16:07:20 +0200
Subject: [PATCH] LXQtCompilerSettings: Drop use of -Bsymbolic
The use of "copy relocations" in ELF executables makes this rather dangerous,
as that moves the definition of the symbol from the library to the executable,
but the library still uses its own definition with -Bsymbolic.
In particular, this led to pcmanfm-qt not saving settings properly
(https://bugzilla.opensuse.org/show_bug.cgi?id=1195421), but can also cause
worse issues like just crashing on startup.
See https://bugreports.qt.io/browse/QTBUG-86173 and
https://bugzilla.opensuse.org/show_bug.cgi?id=1175278 for some details and
discussion about issues with -Bsymbolic.
---
cmake/modules/LXQtCompilerSettings.cmake | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmake/modules/LXQtCompilerSettings.cmake
b/cmake/modules/LXQtCompilerSettings.cmake
index dfb0eaa..a8cb16d 100644
--- a/cmake/modules/LXQtCompilerSettings.cmake
+++ b/cmake/modules/LXQtCompilerSettings.cmake
@@ -164,7 +164,7 @@ if (CMAKE_COMPILER_IS_GNUCXX OR LXQT_COMPILER_IS_CLANGCXX)
set(NO_UNDEFINED_FLAGS "-Wl,--no-undefined")
# -Bsymbolic-functions: replace dynamic symbols used internally in
# shared libs with direct addresses.
- set(SYMBOLIC_FLAGS "-Wl,-Bsymbolic-functions -Wl,-Bsymbolic")
+ set(SYMBOLIC_FLAGS "-Wl,-Bsymbolic-functions")
endif()
set(CMAKE_SHARED_LINKER_FLAGS
