Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package poedit for openSUSE:Factory checked in at 2022-10-22 18:25:38 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/poedit (Old) and /work/SRC/openSUSE:Factory/.poedit.new.2275 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "poedit" Sat Oct 22 18:25:38 2022 rev:68 rq:1030518 version:3.2 Changes: -------- --- /work/SRC/openSUSE:Factory/poedit/poedit.changes 2022-07-09 17:05:42.940938111 +0200 +++ /work/SRC/openSUSE:Factory/.poedit.new.2275/poedit.changes 2022-10-22 18:25:38.828454975 +0200 @@ -1,0 +2,11 @@ +Fri Oct 21 20:30:45 UTC 2022 - Antoine Belvire <antoine.belv...@opensuse.org> + +- Poedit 3.2: + * Added QA warnings about incorrect use of placeholders. + * Added format string highlighting for Objective-C, Qt, KDE, Lua, C# and + Pascal. + * Bugfixes. +- Add poedit-3.2-fix-file-save.patch: Fix wrong error displayed on file save + (gh#vslavik/poedit!772). + +------------------------------------------------------------------- Old: ---- poedit-3.1.1.tar.gz New: ---- poedit-3.2-fix-file-save.patch poedit-3.2.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ poedit.spec ++++++ --- /var/tmp/diff_new_pack.VRJAx6/_old 2022-10-22 18:25:39.540456080 +0200 +++ /var/tmp/diff_new_pack.VRJAx6/_new 2022-10-22 18:25:39.544456087 +0200 @@ -20,13 +20,15 @@ %bcond_without crowdin_integration %bcond_with bundled_deps Name: poedit -Version: 3.1.1 +Version: 3.2 Release: 0 Summary: Gettext Catalog Editing Tool License: MIT Group: Development/Tools/Other URL: https://poedit.net/ Source: https://github.com/vslavik/poedit/releases/download/v%{version}-oss/%{name}-%{version}.tar.gz +# PATCH-FIX-UPSTREAM poedit-3.2-fix-file-save.patch -- Fix wrong error displayed on file save (gh#vslavik/poedit!772) +Patch0: poedit-3.2-fix-file-save.patch BuildRequires: fdupes BuildRequires: gcc-c++ BuildRequires: libboost_iostreams-devel >= 1.60 ++++++ poedit-3.2-fix-file-save.patch ++++++ >From aa44afe0e9346fc2addd84136da800e5902a0f12 Mon Sep 17 00:00:00 2001 From: Antoine Belvire <antoine.belv...@opensuse.org> Date: Sat, 22 Oct 2022 11:19:59 +0200 Subject: [PATCH] Fix chmod/chown return code verification logic On Linux, TempOutputFileFor::ReplaceFile returns a wrong status, indicating the replacement has failed when it has not. This leads to a misleading error message displayed to user on every po file save. The cause is in the verification of the return codes of chown/chmod. chown and chmod return a non-zero integer value when an error occurs. A non-zero value is considered as a boolean 'true'. This commit fixes the logic error; It explicitly compares the returned integer value to another integer to avoid confusion. --- src/utility.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/utility.cpp b/src/utility.cpp index 546c143b9..cf2144702 100644 --- a/src/utility.cpp +++ b/src/utility.cpp @@ -302,9 +302,9 @@ bool TempOutputFileFor::ReplaceFile(const wxString& temp, const wxString& dest) #ifdef __UNIX__ if (overwrite) { - if (!chown(destPath, st.st_uid, st.st_gid)) + if (chown(destPath, st.st_uid, st.st_gid) != 0) return false; - if (!chmod(destPath, st.st_mode)) + if (chmod(destPath, st.st_mode) != 0) return false; } #endif -- 2.38.0 ++++++ poedit-3.1.1.tar.gz -> poedit-3.2.tar.gz ++++++ ++++ 7788 lines of diff (skipped)
