Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package python-PySDL2 for openSUSE:Factory 
checked in at 2022-11-27 12:53:01
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/python-PySDL2 (Old)
 and      /work/SRC/openSUSE:Factory/.python-PySDL2.new.1597 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "python-PySDL2"

Sun Nov 27 12:53:01 2022 rev:11 rq:1038364 version:0.9.14

Changes:
--------
--- /work/SRC/openSUSE:Factory/python-PySDL2/python-PySDL2.changes      
2022-11-02 14:19:50.501278929 +0100
+++ /work/SRC/openSUSE:Factory/.python-PySDL2.new.1597/python-PySDL2.changes    
2022-11-27 12:53:13.967277838 +0100
@@ -1,0 +2,7 @@
+Sat Nov 26 14:51:13 UTC 2022 - mun...@googlemail.com
+
+- Add fix-version_test.patch (gh#py-sdl/py-sdl2#248):
+  Don't assert that SDL_GetRevision() starts with http
+- Skip rpmlint error python-tests-in-package
+
+-------------------------------------------------------------------

New:
----
  fix-version_test.patch
  python-PySDL2.rpmlintrc

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ python-PySDL2.spec ++++++
--- /var/tmp/diff_new_pack.CnrEr1/_old  2022-11-27 12:53:14.583281412 +0100
+++ /var/tmp/diff_new_pack.CnrEr1/_new  2022-11-27 12:53:14.587281435 +0100
@@ -24,8 +24,11 @@
 License:        SUSE-Public-Domain
 URL:            https://github.com/py-sdl/py-sdl2
 Source:         
https://files.pythonhosted.org/packages/source/P/PySDL2/PySDL2-%{version}.tar.gz
+Source99:       python-PySDL2.rpmlintrc
 # PATCH-FIX-OPENSUSE fix-tests.patch to make test work in chroot env without 
access to /dev/input
 Patch0:         fix-tests.patch
+# PATCH-FIX-UPSTREAM fix-version_test.patch gh#py-sdl/py-sdl2#248
+Patch1:         fix-version_test.patch
 BuildRequires:  %{python_module pip}
 BuildRequires:  %{python_module setuptools}
 BuildRequires:  %{python_module wheel}

++++++ fix-version_test.patch ++++++
>From ffa8853517cc72afefc8205db675fdf44d519159 Mon Sep 17 00:00:00 2001
From: Simon McVittie <s...@collabora.com>
Date: Wed, 2 Nov 2022 23:21:54 +0000
Subject: [PATCH] version_test: Don't assert that SDL_GetRevision() starts with
 http (#249)

The default format is going to change in 2.25.x, and in git main it
currently starts with "SDL-".

SDL specifically documents the result of this function as "not intended
to be reliable in any way", so it seems wrong to have pysdl2's tests fail
whenever the format changes. To address that, turn unexpected formats
into an xfail, so that they're flagged as something to investigate but
do not make the unit tests fail when used as a QA gate.

Closes: https://github.com/py-sdl/py-sdl2/issues/248
Signed-off-by: Simon McVittie <s...@collabora.com>

Signed-off-by: Simon McVittie <s...@collabora.com>
---
 sdl2/test/version_test.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sdl2/test/version_test.py b/sdl2/test/version_test.py
index 8a327e1..4c4f54c 100644
--- a/sdl2/test/version_test.py
+++ b/sdl2/test/version_test.py
@@ -57,7 +57,8 @@ def test_SDL_GetRevision():
     # If revision not empty string (e.g. Conda), test the prefix
     if len(rev):
         if dll.version_tuple >= (2, 0, 16):
-            assert rev[0:4] == b"http"
+            if rev[0:4] not in (b"http", b"SDL-"):
+                pytest.xfail("no API guarantee about the format of this 
string")
         else:
             assert rev[0:3] == b"hg-"
 

++++++ python-PySDL2.rpmlintrc ++++++
addFilter("E: python-tests-in-package.*/usr/lib/.*/site-packages/sdl2/test")

Reply via email to