Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package g810-led for openSUSE:Factory
checked in at 2022-12-10 21:18:35
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/g810-led (Old)
and /work/SRC/openSUSE:Factory/.g810-led.new.1835 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "g810-led"
Sat Dec 10 21:18:35 2022 rev:7 rq:1041933 version:0.4.3
Changes:
--------
--- /work/SRC/openSUSE:Factory/g810-led/g810-led.changes 2021-10-16
22:48:15.648723295 +0200
+++ /work/SRC/openSUSE:Factory/.g810-led.new.1835/g810-led.changes
2022-12-10 21:18:40.609854163 +0100
@@ -1,0 +2,8 @@
+Mon Dec 5 15:26:10 UTC 2022 - Dirk Müller <dmuel...@suse.com>
+
+- update to 0.4.3:
+ * Rely on uaccess to control device access
+ * Add error context to failures to open devices
+ * Add new key for ABNT keyboards
+
+-------------------------------------------------------------------
Old:
----
g810-led-0.4.2.tar.gz
New:
----
g810-led-0.4.3.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ g810-led.spec ++++++
--- /var/tmp/diff_new_pack.mGyDpH/_old 2022-12-10 21:18:41.041856689 +0100
+++ /var/tmp/diff_new_pack.mGyDpH/_new 2022-12-10 21:18:41.045856712 +0100
@@ -1,7 +1,7 @@
#
# spec file for package g810-led
#
-# Copyright (c) 2020 SUSE LLC
+# Copyright (c) 2022 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
Name: g810-led
-Version: 0.4.2
+Version: 0.4.3
Release: 0
Summary: Controller for Logitech LED keyboards
License: GPL-3.0-only
++++++ g810-led-0.4.2.tar.gz -> g810-led-0.4.3.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/g810-led-0.4.2/INSTALL.md
new/g810-led-0.4.3/INSTALL.md
--- old/g810-led-0.4.2/INSTALL.md 2020-05-19 23:44:50.000000000 +0200
+++ new/g810-led-0.4.3/INSTALL.md 2022-11-30 19:52:57.000000000 +0100
@@ -29,7 +29,7 @@
`emerge app-misc/g810-led`<br/>
Debian (unstable, and 10 or later), Ubuntu 19.04 or later :<br/>
-`apt install g810-led`
+`sudo apt install g810-led`
Solus :<br/>
`sudo eopkg install g810-led`<br/>
@@ -65,4 +65,4 @@
Same as install, but your profile and reboot files are preserved.</br>
## Uninstall :</br>
-`sudo make uninstall`</br>
\ No newline at end of file
+`sudo make uninstall`</br>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/g810-led-0.4.2/makefile new/g810-led-0.4.3/makefile
--- old/g810-led-0.4.2/makefile 2020-05-19 23:44:50.000000000 +0200
+++ new/g810-led-0.4.3/makefile 2022-11-30 19:52:57.000000000 +0100
@@ -18,7 +18,7 @@
PROGN=g810-led
MAJOR=0
MINOR=4
-MICRO=2
+MICRO=3
CXXFLAGS+=-std=gnu++11 -DVERSION=\"$(MAJOR).$(MINOR).$(MICRO)\"
APPSRCS=src/main.cpp src/helpers/*.cpp
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/g810-led-0.4.2/src/classes/Keyboard.cpp
new/g810-led-0.4.3/src/classes/Keyboard.cpp
--- old/g810-led-0.4.2/src/classes/Keyboard.cpp 2020-05-19 23:44:50.000000000
+0200
+++ new/g810-led-0.4.3/src/classes/Keyboard.cpp 2022-11-30 19:52:57.000000000
+0100
@@ -20,6 +20,7 @@
#include <unistd.h>
#include <vector>
#include <map>
+#include <cerrno>
#if defined(hidapi)
#include <locale>
@@ -200,6 +201,8 @@
if (! dev) {
currentDevice.model = KeyboardModel::unknown;
+ errno = ENODEV;
+
hid_exit();
return false;
}
@@ -209,6 +212,7 @@
if(m_hidHandle == 0) {
hid_exit();
+ errno = EACCES;
return false;
}
@@ -294,6 +298,7 @@
if (currentDevice.model == KeyboardModel::unknown) {
libusb_exit(m_ctx);
+ errno = ENODEV;
m_ctx = NULL;
return false;
}
@@ -303,6 +308,7 @@
if(m_hidHandle == NULL) {
libusb_exit(m_ctx);
+ errno = EACCES;
m_ctx = NULL;
return false;
}
@@ -310,6 +316,7 @@
if(libusb_kernel_driver_active(m_hidHandle, 1) == 1) {
if(libusb_detach_kernel_driver(m_hidHandle, 1) != 0) {
libusb_exit(m_ctx);
+ errno = EACCES;
m_ctx = NULL;
return false;
}
@@ -322,6 +329,7 @@
m_isKernellDetached = false;
}
libusb_exit(m_ctx);
+ errno = EACCES;
m_ctx = NULL;
return false;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/g810-led-0.4.2/src/classes/Keyboard.h
new/g810-led-0.4.3/src/classes/Keyboard.h
--- old/g810-led-0.4.2/src/classes/Keyboard.h 2020-05-19 23:44:50.000000000
+0200
+++ new/g810-led-0.4.3/src/classes/Keyboard.h 2022-11-30 19:52:57.000000000
+0100
@@ -152,6 +152,8 @@
num_minus, num_plus, num_enter,
num_1, num_2, num_3, num_4, num_5, num_6, num_7, num_8,
num_9, num_0,
num_dot, intl_backslash, menu,
+
+ abnt_slash =
static_cast<uint8_t>(KeyAddressGroup::keys) << 8 | 0x87,
ctrl_left = static_cast<uint8_t>(KeyAddressGroup::keys)
<< 8 | 0xe0,
shift_left, alt_left, win_left,
@@ -248,7 +250,7 @@
Key::n1, Key::n2, Key::n3, Key::n4, Key::n5, Key::n6,
Key::n7, Key::n8, Key::n9, Key::n0,
Key::enter, Key::backspace, Key::tab, Key::space,
Key::minus, Key::equal,
Key::open_bracket, Key::close_bracket, Key::backslash,
Key::dollar, Key::semicolon, Key::quote, Key::tilde,
- Key::comma, Key::period, Key::slash, Key::caps_lock,
Key::intl_backslash
+ Key::comma, Key::period, Key::slash, Key::caps_lock,
Key::intl_backslash, Key::abnt_slash
};
bool m_isOpen = false;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/g810-led-0.4.2/src/helpers/help.cpp
new/g810-led-0.4.3/src/helpers/help.cpp
--- old/g810-led-0.4.2/src/helpers/help.cpp 2020-05-19 23:44:50.000000000
+0200
+++ new/g810-led-0.4.3/src/helpers/help.cpp 2022-11-30 19:52:57.000000000
+0100
@@ -262,6 +262,7 @@
cout<<" comma"<<endl;
cout<<" period"<<endl;
cout<<" slash"<<endl;
+ cout<<" abnt_slash"<<endl;
}
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/g810-led-0.4.2/src/helpers/utils.cpp
new/g810-led-0.4.3/src/helpers/utils.cpp
--- old/g810-led-0.4.2/src/helpers/utils.cpp 2020-05-19 23:44:50.000000000
+0200
+++ new/g810-led-0.4.3/src/helpers/utils.cpp 2022-11-30 19:52:57.000000000
+0100
@@ -178,6 +178,7 @@
else if (val == "num." || val == "num_period" || val ==
"numperiod") key = LedKeyboard::Key::num_dot;
else if (val == "intl_backslash" || val == "<") key =
LedKeyboard::Key::intl_backslash;
else if (val == "menu") key = LedKeyboard::Key::menu;
+ else if (val == "abnt_slash" || val == "abnt_c1") key =
LedKeyboard::Key::abnt_slash;
else if (val == "ctrl_left" || val == "ctrlleft" || val ==
"ctrll") key = LedKeyboard::Key::ctrl_left;
else if (val == "shift_left" || val == "shiftleft" || val ==
"shiftl") key = LedKeyboard::Key::shift_left;
else if (val == "alt_left" || val == "altleft" || val ==
"altl") key = LedKeyboard::Key::alt_left;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/g810-led-0.4.2/src/main.cpp
new/g810-led-0.4.3/src/main.cpp
--- old/g810-led-0.4.2/src/main.cpp 2020-05-19 23:44:50.000000000 +0200
+++ new/g810-led-0.4.3/src/main.cpp 2022-11-30 19:52:57.000000000 +0100
@@ -323,7 +323,17 @@
//Initialize the device for use
if (!kbd.open(vendorID, productID, serial)) {
- std::cout << "Matching or compatible device not found
!" << std::endl;
+ switch (errno)
+ {
+ case ENODEV:
+ std::cout << "Matching or compatible
device not found" << std::endl;
+ break;
+ case EACCES:
+ std::cout << "Access denied: Check
device access permissions or run as a privileged user (root/sudo)" << std::endl;
+ break;
+ default:
+ std::cout << "Unknown error: errno=" <<
errno << std::endl;
+ }
return 2;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/g810-led-0.4.2/udev/g810-led.rules
new/g810-led-0.4.3/udev/g810-led.rules
--- old/g810-led-0.4.2/udev/g810-led.rules 2020-05-19 23:44:50.000000000
+0200
+++ new/g810-led-0.4.3/udev/g810-led.rules 2022-11-30 19:52:57.000000000
+0100
@@ -1,25 +1,25 @@
-ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c336", MODE="666" RUN+="/usr/bin/g213-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c330", MODE="666" RUN+="/usr/bin/g410-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c33a", MODE="666" RUN+="/usr/bin/g413-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c342", MODE="666" RUN+="/usr/bin/g512-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c33c", MODE="666" RUN+="/usr/bin/g513-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c333", MODE="666" RUN+="/usr/bin/g610-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c338", MODE="666" RUN+="/usr/bin/g610-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c331", MODE="666" RUN+="/usr/bin/g810-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c337", MODE="666" RUN+="/usr/bin/g810-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c33f", MODE="666" RUN+="/usr/bin/g815-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c32b", MODE="666" RUN+="/usr/bin/g910-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c335", MODE="666" RUN+="/usr/bin/g910-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c339", MODE="666" RUN+="/usr/bin/gpro-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c336", MODE="666" RUN+="/usr/bin/g213-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c330", MODE="666" RUN+="/usr/bin/g410-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c33a", MODE="666" RUN+="/usr/bin/g413-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c342", MODE="666" RUN+="/usr/bin/g512-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c33c", MODE="666" RUN+="/usr/bin/g513-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c333", MODE="666" RUN+="/usr/bin/g610-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c338", MODE="666" RUN+="/usr/bin/g610-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c331", MODE="666" RUN+="/usr/bin/g810-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c337", MODE="666" RUN+="/usr/bin/g810-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c32b", MODE="666" RUN+="/usr/bin/g910-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c335", MODE="666" RUN+="/usr/bin/g910-led -p
/etc/g810-led/profile"
-ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c339", MODE="666" RUN+="/usr/bin/gpro-led -p
/etc/g810-led/profile"
+ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c336", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g213-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c330", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g410-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c33a", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g413-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c342", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g512-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c33c", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g513-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c333", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g610-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c338", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g610-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c331", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g810-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c337", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g810-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c33f", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g815-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c32b", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g910-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c335", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g910-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEMS=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c339", MODE="660", TAG+="uaccess", RUN+="/usr/bin/gpro-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c336", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g213-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c330", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g410-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c33a", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g413-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c342", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g512-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c33c", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g513-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c333", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g610-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c338", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g610-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c331", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g810-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c337", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g810-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c32b", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g910-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c335", MODE="660", TAG+="uaccess", RUN+="/usr/bin/g910-led
-p /etc/g810-led/profile"
+ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="046d",
ATTRS{idProduct}=="c339", MODE="660", TAG+="uaccess", RUN+="/usr/bin/gpro-led
-p /etc/g810-led/profile"
