Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package pan for openSUSE:Factory checked in at 2023-01-26 13:59:01 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/pan (Old) and /work/SRC/openSUSE:Factory/.pan.new.32243 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "pan" Thu Jan 26 13:59:01 2023 rev:19 rq:1061156 version:0.154 Changes: -------- --- /work/SRC/openSUSE:Factory/pan/pan.changes 2023-01-19 16:44:31.625869859 +0100 +++ /work/SRC/openSUSE:Factory/.pan.new.32243/pan.changes 2023-01-26 14:05:03.946430806 +0100 @@ -1,0 +2,6 @@ +Thu Jan 26 08:41:14 UTC 2023 - John Paul Adrian Glaubitz <adrian.glaub...@suse.com> + +- Add patch to fix crash when password storage is enabled + * 0001-Fix-crash-in-on_socket_created-when-password-storage.patch + +------------------------------------------------------------------- New: ---- 0001-Fix-crash-in-on_socket_created-when-password-storage.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ pan.spec ++++++ --- /var/tmp/diff_new_pack.x5tgRn/_old 2023-01-26 14:05:04.378433117 +0100 +++ /var/tmp/diff_new_pack.x5tgRn/_new 2023-01-26 14:05:04.382433138 +0100 @@ -24,7 +24,8 @@ Group: Productivity/Networking/News/Clients URL: http://pan.rebelbase.com/ Source0: https://gitlab.gnome.org/GNOME/pan/-/archive/v%{version}/%{name}-v%{version}.tar.bz2 - +# PATCH-FIX-UPSTREAM https://gitlab.gnome.org/GNOME/pan/-/merge_requests/43 +Patch0: 0001-Fix-crash-in-on_socket_created-when-password-storage.patch BuildRequires: fdupes BuildRequires: gcc-c++ BuildRequires: gettext >= 0.21 ++++++ 0001-Fix-crash-in-on_socket_created-when-password-storage.patch ++++++ >From ca4929c77b9923e357900703f0a3861ebcbc1306 Mon Sep 17 00:00:00 2001 From: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de> Date: Thu, 26 Jan 2023 09:29:29 +0100 Subject: [PATCH] Fix crash in on_socket_created() when password storage is enabled Fixes #164 --- pan/tasks/nntp-pool.cc | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/pan/tasks/nntp-pool.cc b/pan/tasks/nntp-pool.cc index 434881f..ece1c5f 100644 --- a/pan/tasks/nntp-pool.cc +++ b/pan/tasks/nntp-pool.cc @@ -187,16 +187,10 @@ NNTP_Pool :: on_socket_created (const StringView & host, // okay, we at least established a connection. // now try to handshake and pass the buck to on_nntp_done(). NNTP * nntp; - if (!_prefs.get_flag("use-password-storage", false)) - { - std::string pw (pass ? pass : ""); - if (pass) g_free(pass); - nntp = new NNTP (_server, user, pw, _server_info, socket); - } - else - { - nntp = new NNTP ( _server, user, pass, _server_info, socket); - } + std::string pw (pass ? pass : ""); + nntp = new NNTP (_server, user, pw, _server_info, socket); + if (!_prefs.get_flag("use-password-storage", false) && pass) + g_free(pass); nntp->handshake (this); } } -- 2.30.2
