Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package smartmontools for openSUSE:Factory checked in at 2023-03-08 14:52:10 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/smartmontools (Old) and /work/SRC/openSUSE:Factory/.smartmontools.new.31432 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "smartmontools" Wed Mar 8 14:52:10 2023 rev:89 rq:1069957 version:7.3 Changes: -------- --- /work/SRC/openSUSE:Factory/smartmontools/smartmontools.changes 2023-02-05 19:20:17.319586750 +0100 +++ /work/SRC/openSUSE:Factory/.smartmontools.new.31432/smartmontools.changes 2023-03-08 14:52:11.546551839 +0100 @@ -1,0 +2,8 @@ +Tue Mar 7 13:07:41 UTC 2023 - pgaj...@suse.com + +- fix smartctl crash for an NVMe on big endian systems [bsc#1208905] +- added patches + fix https://www.smartmontools.org/changeset/5448 + + smartmontools-smartctl-NVMe-big-endian.patch + +------------------------------------------------------------------- New: ---- smartmontools-smartctl-NVMe-big-endian.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ smartmontools.spec ++++++ --- /var/tmp/diff_new_pack.fPvq1i/_old 2023-03-08 14:52:12.138555063 +0100 +++ /var/tmp/diff_new_pack.fPvq1i/_new 2023-03-08 14:52:12.146555106 +0100 @@ -42,6 +42,8 @@ # PATCH-FIX-OPENSUSE smartmontools-var-lock-subsys.patch sbra...@suse.cz -- Do not use unsupported /var/lock/subsys. Patch10: smartmontools-var-lock-subsys.patch Patch11: harden_smartd.service.patch +# https://www.smartmontools.org/changeset/5448 +Patch12: smartmontools-smartctl-NVMe-big-endian.patch Requires(pre): %fillup_prereq # Needed by generate_smartd_opt: Requires(pre): coreutils @@ -78,6 +80,7 @@ %patch4 %patch10 -p1 %patch11 -p1 +%patch12 -p1 # # PATCH-FEATURE-OPENSUSE (sed on smartd.service.in) sbra...@suse.cz -- Use generated smartd_opts (from SUSE sysconfig file). Systemd smartd.service cannot be smart enough to parse SUSE sysconfig file and generate smartd_opts on fly. And we do not want to launch shell just for it in every boot. sed "s:/usr/local/etc/sysconfig/smartmontools:%{_localstatedir}/lib/smartmontools/smartd_opts:" <smartd.service.in >smartd.service.in.new ++++++ smartmontools-smartctl-NVMe-big-endian.patch ++++++ --- a/nvmecmds.cpp +++ b/nvmecmds.cpp @@ -229,6 +229,7 @@ num_entries * sizeof(*error_log), lpo_sup); - if (isbigendian()) { - for (unsigned i = 0; i < n; i++) { + unsigned read_entries = n / sizeof(*error_log); + if (isbigendian()) { + for (unsigned i = 0; i < read_entries; i++) { swapx(&error_log[i].error_count); swapx(&error_log[i].sqid); @@ -241,5 +242,5 @@ } - return n / sizeof(*error_log); + return read_entries; }
