Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-storage-ng for
openSUSE:Factory checked in at 2023-03-24 15:15:44
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-storage-ng (Old)
and /work/SRC/openSUSE:Factory/.yast2-storage-ng.new.31432 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-storage-ng"
Fri Mar 24 15:15:44 2023 rev:138 rq:1073346 version:4.6.2
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-storage-ng/yast2-storage-ng.changes
2023-03-14 18:15:52.275483753 +0100
+++
/work/SRC/openSUSE:Factory/.yast2-storage-ng.new.31432/yast2-storage-ng.changes
2023-03-24 15:15:45.969415918 +0100
@@ -1,0 +2,7 @@
+Mon Mar 20 16:42:45 UTC 2023 - Ladislav Slezák <lsle...@suse.com>
+
+- Fixed crash in the proposal code when the requested candidate
+ device does not exist (bsc#1209523)
+- 4.6.2
+
+-------------------------------------------------------------------
Old:
----
yast2-storage-ng-4.6.1.tar.bz2
New:
----
yast2-storage-ng-4.6.2.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-storage-ng.spec ++++++
--- /var/tmp/diff_new_pack.lY0bju/_old 2023-03-24 15:15:48.025426893 +0100
+++ /var/tmp/diff_new_pack.lY0bju/_new 2023-03-24 15:15:48.029426914 +0100
@@ -17,7 +17,7 @@
Name: yast2-storage-ng
-Version: 4.6.1
+Version: 4.6.2
Release: 0
Summary: YaST2 - Storage Configuration
License: GPL-2.0-only OR GPL-3.0-only
++++++ yast2-storage-ng-4.6.1.tar.bz2 -> yast2-storage-ng-4.6.2.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.6.1/package/yast2-storage-ng.changes
new/yast2-storage-ng-4.6.2/package/yast2-storage-ng.changes
--- old/yast2-storage-ng-4.6.1/package/yast2-storage-ng.changes 2023-03-13
13:20:06.000000000 +0100
+++ new/yast2-storage-ng-4.6.2/package/yast2-storage-ng.changes 2023-03-20
18:42:53.000000000 +0100
@@ -1,4 +1,11 @@
-------------------------------------------------------------------
+Mon Mar 20 16:42:45 UTC 2023 - Ladislav Slezák <lsle...@suse.com>
+
+- Fixed crash in the proposal code when the requested candidate
+ device does not exist (bsc#1209523)
+- 4.6.2
+
+-------------------------------------------------------------------
Mon Mar 13 12:04:07 UTC 2023 - Ladislav Slezák <lsle...@suse.com>
- Removed unnecessary executable flags from files (bsc#1209094)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-storage-ng-4.6.1/package/yast2-storage-ng.spec
new/yast2-storage-ng-4.6.2/package/yast2-storage-ng.spec
--- old/yast2-storage-ng-4.6.1/package/yast2-storage-ng.spec 2023-03-13
13:20:06.000000000 +0100
+++ new/yast2-storage-ng-4.6.2/package/yast2-storage-ng.spec 2023-03-20
18:42:53.000000000 +0100
@@ -16,7 +16,7 @@
#
Name: yast2-storage-ng
-Version: 4.6.1
+Version: 4.6.2
Release: 0
Summary: YaST2 - Storage Configuration
License: GPL-2.0-only OR GPL-3.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.6.1/src/lib/y2storage/guided_proposal.rb
new/yast2-storage-ng-4.6.2/src/lib/y2storage/guided_proposal.rb
--- old/yast2-storage-ng-4.6.1/src/lib/y2storage/guided_proposal.rb
2023-03-13 13:20:06.000000000 +0100
+++ new/yast2-storage-ng-4.6.2/src/lib/y2storage/guided_proposal.rb
2023-03-20 18:42:53.000000000 +0100
@@ -270,7 +270,7 @@
# @return [Array<Y2Storage::BlkDevice>]
def candidate_devices_with_empty_partition_table(devicegraph)
device_names = settings.candidate_devices
- devices = device_names.map { |n| devicegraph.find_by_name(n) }
+ devices = device_names.map { |n| devicegraph.find_by_name(n) }.compact
devices.select { |d| d.partition_table && d.partitions.empty? }
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.6.1/test/y2storage/guided_proposal_test.rb
new/yast2-storage-ng-4.6.2/test/y2storage/guided_proposal_test.rb
--- old/yast2-storage-ng-4.6.1/test/y2storage/guided_proposal_test.rb
2023-03-13 13:20:06.000000000 +0100
+++ new/yast2-storage-ng-4.6.2/test/y2storage/guided_proposal_test.rb
2023-03-20 18:42:53.000000000 +0100
@@ -112,6 +112,16 @@
end
end
+ context "when the candidate devices are invalid" do
+ include_context "candidate devices"
+
+ let(:candidate_devices) { ["/dev/invalid_device"] }
+
+ it "raises Y2Storage::NoDiskSpaceError exception" do
+ expect { proposal.propose }.to raise_error(Y2Storage::NoDiskSpaceError)
+ end
+ end
+
context "when the candidate devices are not given" do
include_context "candidate devices"
