Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package epiphany for openSUSE:Factory
checked in at 2023-04-21 14:17:34
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/epiphany (Old)
and /work/SRC/openSUSE:Factory/.epiphany.new.1533 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "epiphany"
Fri Apr 21 14:17:34 2023 rev:200 rq:1081097 version:44.2
Changes:
--------
--- /work/SRC/openSUSE:Factory/epiphany/epiphany.changes 2023-04-03
17:46:37.312636303 +0200
+++ /work/SRC/openSUSE:Factory/.epiphany.new.1533/epiphany.changes
2023-04-21 14:17:41.710810666 +0200
@@ -1,0 +2,8 @@
+Thu Apr 20 17:54:27 UTC 2023 - Bjørn Lie <bjorn....@gmail.com>
+
+- Update to version 44.2:
+ + Fix invalid characters in screenshot suggested filename.
+ + Relocate and fix Sync Now button in Firefox Sync dialog.
+ + Fix crash when closing window and discarding modified forms.
+
+-------------------------------------------------------------------
Old:
----
epiphany-44.1.tar.xz
New:
----
epiphany-44.2.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ epiphany.spec ++++++
--- /var/tmp/diff_new_pack.medhNJ/_old 2023-04-21 14:17:42.354814277 +0200
+++ /var/tmp/diff_new_pack.medhNJ/_new 2023-04-21 14:17:42.358814299 +0200
@@ -17,7 +17,7 @@
Name: epiphany
-Version: 44.1
+Version: 44.2
Release: 0
Summary: GNOME Web Browser
License: GPL-3.0-or-later
++++++ epiphany-44.1.tar.xz -> epiphany-44.2.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/epiphany-44.1/NEWS new/epiphany-44.2/NEWS
--- old/epiphany-44.1/NEWS 2023-04-02 16:14:45.000000000 +0200
+++ new/epiphany-44.2/NEWS 2023-04-20 17:57:36.000000000 +0200
@@ -1,3 +1,10 @@
+44.2 - April 20, 2023
+=====================
+
+ * Fix invalid characters in screenshot suggested filename (#2013, Cleo
Menezes Jr.)
+ * Relocate and fix Sync Now button in Firefox Sync dialog (#2042)
+ * Fix crash when closing window and discarding modified forms (#2043)
+
44.1 - April 2, 2023
====================
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/epiphany-44.1/data/org.gnome.Epiphany.appdata.xml.in.in
new/epiphany-44.2/data/org.gnome.Epiphany.appdata.xml.in.in
--- old/epiphany-44.1/data/org.gnome.Epiphany.appdata.xml.in.in 2023-04-02
16:14:45.000000000 +0200
+++ new/epiphany-44.2/data/org.gnome.Epiphany.appdata.xml.in.in 2023-04-20
17:57:36.000000000 +0200
@@ -55,6 +55,7 @@
<display_length compare="ge">360</display_length>
</requires>
<releases>
+ <release date="2023-04-20" version="44.2"/>
<release date="2023-04-02" version="44.1"/>
<release date="2023-03-17" version="44.0"/>
<release date="2023-03-03" version="44~rc"/>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/epiphany-44.1/meson.build
new/epiphany-44.2/meson.build
--- old/epiphany-44.1/meson.build 2023-04-02 16:14:45.000000000 +0200
+++ new/epiphany-44.2/meson.build 2023-04-20 17:57:36.000000000 +0200
@@ -1,6 +1,6 @@
project('epiphany', 'c',
license: 'GPL3+',
- version: '44.1',
+ version: '44.2',
meson_version: '>= 0.59.0',
default_options: ['c_std=gnu11',
'warning_level=2']
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/epiphany-44.1/src/ephy-window.c
new/epiphany-44.2/src/ephy-window.c
--- old/epiphany-44.1/src/ephy-window.c 2023-04-02 16:14:45.000000000 +0200
+++ new/epiphany-44.2/src/ephy-window.c 2023-04-20 17:57:36.000000000 +0200
@@ -4386,6 +4386,13 @@
g_free (data);
}
+static gboolean
+destroy_window_cb (GtkWindow *window)
+{
+ gtk_window_destroy (window);
+ return G_SOURCE_REMOVE;
+}
+
static void
finish_window_close_after_modified_forms_check (WindowHasModifiedFormsData
*data)
{
@@ -4394,8 +4401,13 @@
data->window->force_close = TRUE;
should_close = ephy_window_close (data->window);
data->window->force_close = FALSE;
+
+ /* Need to schedule future destruction of the EphyWindow to ensure its child
+ * AdwMessageDialog that's displaying the close confirmation warning gets
+ * destroyed first.
+ */
if (should_close)
- gtk_window_destroy (GTK_WINDOW (data->window));
+ g_idle_add (G_SOURCE_FUNC (destroy_window_cb), data->window);
window_has_modified_forms_data_free (data);
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/epiphany-44.1/src/resources/gtk/firefox-sync-dialog.ui
new/epiphany-44.2/src/resources/gtk/firefox-sync-dialog.ui
--- old/epiphany-44.1/src/resources/gtk/firefox-sync-dialog.ui 2023-04-02
16:14:45.000000000 +0200
+++ new/epiphany-44.2/src/resources/gtk/firefox-sync-dialog.ui 2023-04-20
17:57:36.000000000 +0200
@@ -8,7 +8,20 @@
<property name="destroy-with-parent">True</property>
<property name="title" translatable="yes">Firefox Sync</property>
<child type="titlebar">
- <object class="GtkHeaderBar"/>
+ <object class="GtkHeaderBar">
+ <child>
+ <object class="GtkButton" id="sync_now_button">
+ <property name="child">
+ <object class="AdwButtonContent">
+ <property
name="icon-name">emblem-synchronizing-symbolic</property>
+ <property name="label" translatable="yes">Sync _now</property>
+ <property name="use-underline">True</property>
+ </object>
+ </property>
+ <signal name="clicked" handler="on_sync_sync_now_button_clicked"/>
+ </object>
+ </child>
+ </object>
</child>
<child>
<object class="AdwPreferencesPage">
@@ -113,20 +126,6 @@
<property name="expression">
<closure type="gchararray"
function="get_sync_frequency_minutes_name"/>
</property>
- <child>
- <object class="GtkSeparator">
- <property name="margin_bottom">8</property>
- <property name="margin_top">8</property>
- </object>
- </child>
- <child>
- <object class="GtkButton" id="sync_now_button">
- <property name="label" translatable="yes">Sync
_now</property>
- <property name="use-underline">True</property>
- <property name="valign">center</property>
- <signal name="clicked"
handler="on_sync_sync_now_button_clicked"/>
- </object>
- </child>
</object>
</child>
<child>
@@ -181,7 +180,6 @@
<widgets>
<widget name="sync_sign_out_button"/>
<widget name="synced_tabs_button"/>
- <widget name="sync_now_button"/>
<widget name="sync_device_name_change_button"/>
</widgets>
</object>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/epiphany-44.1/src/window-commands.c
new/epiphany-44.2/src/window-commands.c
--- old/epiphany-44.1/src/window-commands.c 2023-04-02 16:14:45.000000000
+0200
+++ new/epiphany-44.2/src/window-commands.c 2023-04-20 17:57:36.000000000
+0200
@@ -1987,24 +1987,29 @@
}
static char *
-get_suggested_filename (EphyEmbed *embed)
+get_suggested_filename (EphyEmbed *embed,
+ const char *file_extension)
{
EphyWebView *view;
const char *suggested_filename;
const char *mimetype;
+ const char *page_title;
WebKitURIResponse *response;
WebKitWebResource *web_resource;
g_autoptr (GUri) uri = NULL;
+ g_autofree char *filename = NULL;
view = ephy_embed_get_web_view (embed);
web_resource = webkit_web_view_get_main_resource (WEBKIT_WEB_VIEW (view));
response = webkit_web_resource_get_response (web_resource);
mimetype = webkit_uri_response_get_mime_type (response);
uri = g_uri_parse (webkit_web_resource_get_uri (web_resource),
G_URI_FLAGS_SCHEME_NORMALIZE, NULL);
+ page_title = ephy_embed_get_title (embed);
+ filename = g_strconcat (page_title, file_extension, NULL);
if (g_ascii_strncasecmp (mimetype, "text/html", 9) == 0 && g_strcmp0
(g_uri_get_scheme (uri), EPHY_VIEW_SOURCE_SCHEME) != 0) {
/* Web Title will be used as suggested filename */
- return g_strconcat (ephy_embed_get_title (embed), ".mhtml", NULL);
+ return g_steal_pointer (&filename);
}
suggested_filename = webkit_uri_response_get_suggested_filename (response);
@@ -2018,7 +2023,7 @@
return g_strdup (path);
}
- return suggested_filename ? g_strdup (suggested_filename) : g_strdup
("index.html");
+ return suggested_filename ? g_strdup (suggested_filename) : g_steal_pointer
(&filename);
}
@@ -2138,7 +2143,7 @@
g_list_store_append (filters, mthtml_filter);
gtk_file_dialog_set_filters (dialog, G_LIST_MODEL (filters));
- suggested_filename = ephy_sanitize_filename (get_suggested_filename (embed));
+ suggested_filename = ephy_sanitize_filename (get_suggested_filename (embed,
".mhtml"));
gtk_file_dialog_set_initial_name (dialog, suggested_filename);
gtk_file_dialog_save (dialog,
@@ -2183,7 +2188,7 @@
g_list_store_append (filters, filter);
gtk_file_dialog_set_filters (dialog, G_LIST_MODEL (filters));
- suggested_filename = g_strconcat (ephy_embed_get_title (embed), ".png",
NULL);
+ suggested_filename = ephy_sanitize_filename (get_suggested_filename (embed,
".png"));
gtk_file_dialog_set_initial_name (dialog, suggested_filename);
gtk_file_dialog_save (dialog,
