Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package libstorage-ng for openSUSE:Factory
checked in at 2023-05-03 12:56:25
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/libstorage-ng (Old)
and /work/SRC/openSUSE:Factory/.libstorage-ng.new.1533 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libstorage-ng"
Wed May 3 12:56:25 2023 rev:217 rq:1083996 version:4.5.101
Changes:
--------
--- /work/SRC/openSUSE:Factory/libstorage-ng/libstorage-ng.changes
2023-04-28 16:22:51.761833148 +0200
+++ /work/SRC/openSUSE:Factory/.libstorage-ng.new.1533/libstorage-ng.changes
2023-05-03 12:56:29.591556075 +0200
@@ -1,0 +2,7 @@
+Tue May 2 09:53:49 UTC 2023 - aschn...@suse.com
+
+- merge gh#openSUSE/libstorage-ng#928
+- add color attribute to Action class
+- 4.5.101
+
+--------------------------------------------------------------------
Old:
----
libstorage-ng-4.5.100.tar.xz
New:
----
libstorage-ng-4.5.101.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ libstorage-ng.spec ++++++
--- /var/tmp/diff_new_pack.TOjdL2/_old 2023-05-03 12:56:30.267560047 +0200
+++ /var/tmp/diff_new_pack.TOjdL2/_new 2023-05-03 12:56:30.271560070 +0200
@@ -18,7 +18,7 @@
%define libname %{name}1
Name: libstorage-ng
-Version: 4.5.100
+Version: 4.5.101
Release: 0
Summary: Library for storage management
License: GPL-2.0-only
++++++ libstorage-ng-4.5.100.tar.xz -> libstorage-ng-4.5.101.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.100/LIBVERSION
new/libstorage-ng-4.5.101/LIBVERSION
--- old/libstorage-ng-4.5.100/LIBVERSION 2023-04-27 10:48:32.000000000
+0200
+++ new/libstorage-ng-4.5.101/LIBVERSION 2023-05-02 11:53:49.000000000
+0200
@@ -1 +1 @@
-1.86.1
+1.87.0
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.100/VERSION
new/libstorage-ng-4.5.101/VERSION
--- old/libstorage-ng-4.5.100/VERSION 2023-04-27 10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/VERSION 2023-05-02 11:53:49.000000000 +0200
@@ -1 +1 @@
-4.5.100
+4.5.101
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.100/storage/Actions/ActivateImpl.h
new/libstorage-ng-4.5.101/storage/Actions/ActivateImpl.h
--- old/libstorage-ng-4.5.100/storage/Actions/ActivateImpl.h 2023-04-27
10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/ActivateImpl.h 2023-05-02
11:53:49.000000000 +0200
@@ -41,6 +41,7 @@
Activate(sid_t sid) : Modify(sid) {}
virtual Text text(const CommitData& commit_data) const override;
+ virtual Color color() const override { return Color::GREEN; }
virtual void commit(CommitData& commit_data, const CommitOptions&
commit_options) const override;
virtual uf_t used_features(const Actiongraph::Impl& actiongraph)
const override;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libstorage-ng-4.5.100/storage/Actions/AddToEtcCrypttabImpl.h
new/libstorage-ng-4.5.101/storage/Actions/AddToEtcCrypttabImpl.h
--- old/libstorage-ng-4.5.100/storage/Actions/AddToEtcCrypttabImpl.h
2023-04-27 10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/AddToEtcCrypttabImpl.h
2023-05-02 11:53:49.000000000 +0200
@@ -40,6 +40,7 @@
AddToEtcCrypttab(sid_t sid) : Modify(sid) {}
virtual Text text(const CommitData& commit_data) const override;
+ virtual Color color() const override { return Color::GREEN; }
virtual void commit(CommitData& commit_data, const CommitOptions&
commit_options) const override;
virtual void add_dependencies(Actiongraph::Impl::vertex_descriptor
vertex,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libstorage-ng-4.5.100/storage/Actions/AddToEtcFstabImpl.h
new/libstorage-ng-4.5.101/storage/Actions/AddToEtcFstabImpl.h
--- old/libstorage-ng-4.5.100/storage/Actions/AddToEtcFstabImpl.h
2023-04-27 10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/AddToEtcFstabImpl.h
2023-05-02 11:53:49.000000000 +0200
@@ -41,6 +41,7 @@
AddToEtcFstab(sid_t sid) : Modify(sid) {}
virtual Text text(const CommitData& commit_data) const override;
+ virtual Color color() const override { return Color::GREEN; }
virtual void commit(CommitData& commit_data, const CommitOptions&
commit_options) const override;
FsType get_fs_type(const Actiongraph::Impl& actiongraph) const;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libstorage-ng-4.5.100/storage/Actions/AddToEtcMdadmImpl.h
new/libstorage-ng-4.5.101/storage/Actions/AddToEtcMdadmImpl.h
--- old/libstorage-ng-4.5.100/storage/Actions/AddToEtcMdadmImpl.h
2023-04-27 10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/AddToEtcMdadmImpl.h
2023-05-02 11:53:49.000000000 +0200
@@ -41,6 +41,7 @@
AddToEtcMdadm(sid_t sid) : Modify(sid) {}
virtual Text text(const CommitData& commit_data) const override;
+ virtual Color color() const override { return Color::GREEN; }
virtual void commit(CommitData& commit_data, const CommitOptions&
commit_options) const override;
virtual void add_dependencies(Actiongraph::Impl::vertex_descriptor
vertex,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libstorage-ng-4.5.100/storage/Actions/AttachBcacheCsetImpl.h
new/libstorage-ng-4.5.101/storage/Actions/AttachBcacheCsetImpl.h
--- old/libstorage-ng-4.5.100/storage/Actions/AttachBcacheCsetImpl.h
2023-04-27 10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/AttachBcacheCsetImpl.h
2023-05-02 11:53:49.000000000 +0200
@@ -40,6 +40,7 @@
AttachBcacheCset(sid_t sid) : Modify(sid) {}
virtual Text text(const CommitData& commit_data) const override;
+ virtual Color color() const override { return Color::GREEN; }
virtual void commit(CommitData& commit_data, const CommitOptions&
commit_options) const override;
};
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.100/storage/Actions/Base.cc
new/libstorage-ng-4.5.101/storage/Actions/Base.cc
--- old/libstorage-ng-4.5.100/storage/Actions/Base.cc 2023-04-27
10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/Base.cc 2023-05-02
11:53:49.000000000 +0200
@@ -38,4 +38,11 @@
return action->text(commit_data).translated;
}
+
+ Color
+ get_color(const Actiongraph* actiongraph, const Action::Base* action)
+ {
+ return action->color();
+ }
+
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.100/storage/Actions/Base.h
new/libstorage-ng-4.5.101/storage/Actions/Base.h
--- old/libstorage-ng-4.5.100/storage/Actions/Base.h 2023-04-27
10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/Base.h 2023-05-02
11:53:49.000000000 +0200
@@ -41,7 +41,24 @@
/**
- * Get the commit message from an action.
+ * A color suggestion for commit messages.
+ *
+ * In general the color is green for action that create, mount or activate
something,
+ * red for action that delete, unmount or deactivate something and black
otherwise.
+ *
+ * The color of an action is not set in stone and may change in the
future. It must
+ * only be used to displaying messages. Not for any other logic!
+ *
+ * @see get_color()
+ */
+ enum class Color
+ {
+ GREEN, BLACK, RED
+ };
+
+
+ /**
+ * Get the commit message of an action.
*
* TODO: This should be a member function of Action::Base but that is not
available in
* the API in all details.
@@ -49,6 +66,15 @@
std::string
get_string(const Actiongraph* actiongraph, const Action::Base* action);
+
+ /**
+ * Get the color for the commit message of an action.
+ *
+ * @see Color
+ */
+ Color
+ get_color(const Actiongraph* actiongraph, const Action::Base* action);
+
}
#endif
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.100/storage/Actions/BaseImpl.h
new/libstorage-ng-4.5.101/storage/Actions/BaseImpl.h
--- old/libstorage-ng-4.5.100/storage/Actions/BaseImpl.h 2023-04-27
10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/BaseImpl.h 2023-05-02
11:53:49.000000000 +0200
@@ -1,6 +1,6 @@
/*
* Copyright (c) [2014-2015] Novell, Inc.
- * Copyright (c) [2016-2020] SUSE LLC
+ * Copyright (c) [2016-2023] SUSE LLC
*
* All Rights Reserved.
*
@@ -30,6 +30,7 @@
#include "storage/ActiongraphImpl.h"
#include "storage/DevicegraphImpl.h"
#include "storage/CommitOptions.h"
+#include "storage/Actions/Base.h"
namespace storage
@@ -57,6 +58,7 @@
virtual ~Base() {}
virtual Text text(const CommitData& commit_data) const = 0;
+ virtual Color color() const { return Color::BLACK; }
virtual void commit(CommitData& commit_data, const CommitOptions&
commit_options) const = 0;
virtual uf_t used_features(const Actiongraph::Impl& actiongraph)
const { return 0; }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.100/storage/Actions/CreateImpl.h
new/libstorage-ng-4.5.101/storage/Actions/CreateImpl.h
--- old/libstorage-ng-4.5.100/storage/Actions/CreateImpl.h 2023-04-27
10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/CreateImpl.h 2023-05-02
11:53:49.000000000 +0200
@@ -46,6 +46,7 @@
: Base(sid_pair, only_sync, nop) {}
virtual Text text(const CommitData& commit_data) const override;
+ virtual Color color() const override { return Color::GREEN; }
virtual void commit(CommitData& commit_data, const CommitOptions&
commit_options) const override;
virtual uf_t used_features(const Actiongraph::Impl& actiongraph)
const override;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libstorage-ng-4.5.100/storage/Actions/DeactivateImpl.h
new/libstorage-ng-4.5.101/storage/Actions/DeactivateImpl.h
--- old/libstorage-ng-4.5.100/storage/Actions/DeactivateImpl.h 2023-04-27
10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/DeactivateImpl.h 2023-05-02
11:53:49.000000000 +0200
@@ -41,6 +41,7 @@
Deactivate(sid_t sid) : Modify(sid) {}
virtual Text text(const CommitData& commit_data) const override;
+ virtual Color color() const override { return Color::RED; }
virtual void commit(CommitData& commit_data, const CommitOptions&
commit_options) const override;
virtual uf_t used_features(const Actiongraph::Impl& actiongraph)
const override;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.100/storage/Actions/DeleteImpl.h
new/libstorage-ng-4.5.101/storage/Actions/DeleteImpl.h
--- old/libstorage-ng-4.5.100/storage/Actions/DeleteImpl.h 2023-04-27
10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/DeleteImpl.h 2023-05-02
11:53:49.000000000 +0200
@@ -46,6 +46,7 @@
: Base(sid_pair, only_sync, nop) {}
virtual Text text(const CommitData& commit_data) const override;
+ virtual Color color() const override { return Color::RED; }
virtual void commit(CommitData& commit_data, const CommitOptions&
commit_options) const override;
virtual uf_t used_features(const Actiongraph::Impl& actiongraph)
const override;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libstorage-ng-4.5.100/storage/Actions/DetachBcacheCsetImpl.h
new/libstorage-ng-4.5.101/storage/Actions/DetachBcacheCsetImpl.h
--- old/libstorage-ng-4.5.100/storage/Actions/DetachBcacheCsetImpl.h
2023-04-27 10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/DetachBcacheCsetImpl.h
2023-05-02 11:53:49.000000000 +0200
@@ -42,6 +42,7 @@
: Modify(sid), bcache_cset(bcache_cset) {}
virtual Text text(const CommitData& commit_data) const override;
+ virtual Color color() const override { return Color::RED; }
virtual void commit(CommitData& commit_data, const CommitOptions&
commit_options) const override;
const BcacheCset* get_bcache_cset() const { return bcache_cset; }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libstorage-ng-4.5.100/storage/Actions/RemoveFromEtcCrypttabImpl.h
new/libstorage-ng-4.5.101/storage/Actions/RemoveFromEtcCrypttabImpl.h
--- old/libstorage-ng-4.5.100/storage/Actions/RemoveFromEtcCrypttabImpl.h
2023-04-27 10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/RemoveFromEtcCrypttabImpl.h
2023-05-02 11:53:49.000000000 +0200
@@ -40,6 +40,7 @@
RemoveFromEtcCrypttab(sid_t sid) : Modify(sid) {}
virtual Text text(const CommitData& commit_data) const override;
+ virtual Color color() const override { return Color::RED; }
virtual void commit(CommitData& commit_data, const CommitOptions&
commit_options) const override;
};
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libstorage-ng-4.5.100/storage/Actions/RemoveFromEtcFstabImpl.h
new/libstorage-ng-4.5.101/storage/Actions/RemoveFromEtcFstabImpl.h
--- old/libstorage-ng-4.5.100/storage/Actions/RemoveFromEtcFstabImpl.h
2023-04-27 10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/RemoveFromEtcFstabImpl.h
2023-05-02 11:53:49.000000000 +0200
@@ -40,6 +40,7 @@
RemoveFromEtcFstab(sid_t sid) : Modify(sid) {}
virtual Text text(const CommitData& commit_data) const override;
+ virtual Color color() const override { return Color::RED; }
virtual void commit(CommitData& commit_data, const CommitOptions&
commit_options) const override;
};
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libstorage-ng-4.5.100/storage/Actions/RemoveFromEtcMdadmImpl.h
new/libstorage-ng-4.5.101/storage/Actions/RemoveFromEtcMdadmImpl.h
--- old/libstorage-ng-4.5.100/storage/Actions/RemoveFromEtcMdadmImpl.h
2023-04-27 10:48:32.000000000 +0200
+++ new/libstorage-ng-4.5.101/storage/Actions/RemoveFromEtcMdadmImpl.h
2023-05-02 11:53:49.000000000 +0200
@@ -41,6 +41,7 @@
RemoveFromEtcMdadm(sid_t sid) : Modify(sid) {}
virtual Text text(const CommitData& commit_data) const override;
+ virtual Color color() const override { return Color::RED; }
virtual void commit(CommitData& commit_data, const CommitOptions&
commit_options) const override;
};
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.100/storage/Storage.h
new/libstorage-ng-4.5.101/storage/Storage.h
--- old/libstorage-ng-4.5.100/storage/Storage.h 2023-04-27 10:48:32.000000000
+0200
+++ new/libstorage-ng-4.5.101/storage/Storage.h 2023-05-02 11:53:49.000000000
+0200
@@ -437,6 +437,7 @@
};
+
//! The main entry point to libstorage.
class Storage : private boost::noncopyable
{
