Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package at-spi2-core for openSUSE:Factory checked in at 2023-05-30 22:01:07 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/at-spi2-core (Old) and /work/SRC/openSUSE:Factory/.at-spi2-core.new.1533 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "at-spi2-core" Tue May 30 22:01:07 2023 rev:103 rq:1089511 version:2.48.3 Changes: -------- --- /work/SRC/openSUSE:Factory/at-spi2-core/at-spi2-core.changes 2023-05-12 20:32:47.412604381 +0200 +++ /work/SRC/openSUSE:Factory/.at-spi2-core.new.1533/at-spi2-core.changes 2023-05-30 22:01:12.846575944 +0200 @@ -1,0 +2,9 @@ +Sun May 28 09:12:49 UTC 2023 - Bjørn Lie <bjorn....@gmail.com> + +- Update to version 2.48.3: + + Fix the build when dbus-broker is not set to be used by + default. + + Fix a couple of use after frees when finalizing devices. + + atk-adaptor: Fix handling of sockets in impl_GetChildren. + +------------------------------------------------------------------- Old: ---- at-spi2-core-2.48.2.tar.xz New: ---- at-spi2-core-2.48.3.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ at-spi2-core.spec ++++++ --- /var/tmp/diff_new_pack.OileHv/_old 2023-05-30 22:01:13.454579528 +0200 +++ /var/tmp/diff_new_pack.OileHv/_new 2023-05-30 22:01:13.458579552 +0200 @@ -17,7 +17,7 @@ Name: at-spi2-core -Version: 2.48.2 +Version: 2.48.3 Release: 0 Summary: Assistive Technology Service Provider Interface - D-Bus based implementation License: LGPL-2.1-or-later ++++++ at-spi2-core-2.48.2.tar.xz -> at-spi2-core-2.48.3.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-core-2.48.2/NEWS new/at-spi2-core-2.48.3/NEWS --- old/at-spi2-core-2.48.2/NEWS 2023-05-11 19:23:22.000000000 +0200 +++ new/at-spi2-core-2.48.3/NEWS 2023-05-27 17:00:48.000000000 +0200 @@ -1,3 +1,11 @@ +What's new in at-spi2-core 2.48.3: + +* Fix the build when dbus-broker is not set to be used by default. + +* Fix a couple of use after frees when finalizing devices. + +* atk-adaptor: Fix handling of sockets in impl_GetChildren. + What's new in at-spi2-core 2.48.2: * Fixed a regression in 2.48.1 where the bus launcher would fail if diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-core-2.48.2/atk-adaptor/adaptors/accessible-adaptor.c new/at-spi2-core-2.48.3/atk-adaptor/adaptors/accessible-adaptor.c --- old/at-spi2-core-2.48.2/atk-adaptor/adaptors/accessible-adaptor.c 2023-05-11 19:23:22.000000000 +0200 +++ new/at-spi2-core-2.48.3/atk-adaptor/adaptors/accessible-adaptor.c 2023-05-27 17:00:48.000000000 +0200 @@ -223,7 +223,7 @@ &iter_struct); dbus_message_iter_append_basic (&iter_struct, DBUS_TYPE_STRING, &child_name); - dbus_message_iter_append_basic (&iter_struct, DBUS_TYPE_STRING, + dbus_message_iter_append_basic (&iter_struct, DBUS_TYPE_OBJECT_PATH, &child_path); dbus_message_iter_close_container (&iter_array, &iter_struct); g_free (child_name); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-core-2.48.2/atspi/atspi-device-legacy.c new/at-spi2-core-2.48.3/atspi/atspi-device-legacy.c --- old/at-spi2-core-2.48.2/atspi/atspi-device-legacy.c 2023-05-11 19:23:22.000000000 +0200 +++ new/at-spi2-core-2.48.3/atspi/atspi-device-legacy.c 2023-05-27 17:00:48.000000000 +0200 @@ -90,6 +90,7 @@ gboolean ret = priv->keyboard_grabbed; guint modifiers; + g_object_ref (legacy_device); set_virtual_modifier (legacy_device, event->hw_code, event->type == (AtspiEventType) ATSPI_KEY_PRESS); @@ -104,6 +105,7 @@ event->event_string); g_boxed_free (ATSPI_TYPE_DEVICE_EVENT, event); + g_object_unref (legacy_device); return ret; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-core-2.48.2/atspi/atspi-device-x11.c new/at-spi2-core-2.48.3/atspi/atspi-device-x11.c --- old/at-spi2-core-2.48.2/atspi/atspi-device-x11.c 2023-05-11 19:23:22.000000000 +0200 +++ new/at-spi2-core-2.48.3/atspi/atspi-device-x11.c 2023-05-27 17:00:48.000000000 +0200 @@ -330,6 +330,7 @@ XComposeStatus status; guint modifiers; + g_object_ref (device); while (XPending (display)) { XNextEvent (display, &xevent); @@ -392,6 +393,8 @@ continue; } } + + g_object_unref (device); return TRUE; } @@ -617,17 +620,15 @@ { AtspiDeviceX11 *device = ATSPI_DEVICE_X11 (object); AtspiDeviceX11Private *priv = atspi_device_x11_get_instance_private (device); - GSList *l; - for (l = priv->key_grabs; l; l = l->next) + while (priv->key_grabs) { - AtspiX11KeyGrab *grab = l->data; + AtspiX11KeyGrab *grab = priv->key_grabs->data; disable_key_grab (device, grab); g_boxed_free (ATSPI_TYPE_KEY_DEFINITION, grab->kd); g_free (grab); + priv->key_grabs = g_slist_remove (priv->key_grabs, grab); } - g_slist_free (priv->key_grabs); - priv->key_grabs = NULL; g_slist_free_full (priv->modifiers, g_free); priv->modifiers = NULL; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-core-2.48.2/bus/meson.build new/at-spi2-core-2.48.3/bus/meson.build --- old/at-spi2-core-2.48.2/bus/meson.build 2023-05-11 19:23:22.000000000 +0200 +++ new/at-spi2-core-2.48.3/bus/meson.build 2023-05-27 17:00:48.000000000 +0200 @@ -46,8 +46,9 @@ '-DDATADIR="@0@"'.format(atspi_datadir), ] +dbus_daemon_arg = '' if get_option('dbus_daemon') != 'default' - launcher_args += '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon')) + dbus_daemon_arg = '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon')) else dbus_daemon = find_program('dbus-daemon', '/sbin/dbus-daemon', @@ -58,37 +59,57 @@ '/usr/pkg/bin/dbus-daemon', required: false) if dbus_daemon.found() - launcher_args += '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path()) + dbus_daemon_arg = '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path()) endif endif +dbus_broker_arg = '' needs_systemd = false if get_option('dbus_broker') != 'default' - launcher_args += '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker')) - if get_option('default_bus') != 'dbus-daemon' - needs_systemd = true - endif + dbus_broker_arg = '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker')) + needs_systemd = true else dbus_broker = find_program('dbus-broker-launch', required: false) if dbus_broker.found() - launcher_args += '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path()) + dbus_broker_arg = '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path()) if get_option('default_bus') != 'dbus-daemon' needs_systemd = true endif endif endif -if get_option('default_bus') == 'dbus-broker' - launcher_args += '-DWANT_DBUS_BROKER' +if not get_option('use_systemd') + if needs_systemd + error('Systemd is required for dbus-broker, but use_systemd is set to false.') + endif + dbus_broker_arg = '' endif -if needs_systemd - systemd_dep = dependency('libsystemd') +if dbus_broker_arg != '' + if needs_systemd + systemd_dep = dependency('libsystemd') + else + systemd_dep = dependency('libsystemd', required: false) + if not systemd_dep.found() + dbus_broker_arg = '' + endif + endif else systemd_dep = dependency('', required: false) endif +if dbus_daemon_arg != '' + launcher_args += dbus_daemon_arg +endif +if dbus_broker_arg != '' + launcher_args += dbus_broker_arg +endif + +if get_option('default_bus') == 'dbus-broker' + launcher_args += '-DWANT_DBUS_BROKER' +endif + executable('at-spi-bus-launcher', 'at-spi-bus-launcher.c', include_directories: [ root_inc, include_directories('.') ], dependencies: [ gio_dep, systemd_dep, x11_deps ], diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-core-2.48.2/meson.build new/at-spi2-core-2.48.3/meson.build --- old/at-spi2-core-2.48.2/meson.build 2023-05-11 19:23:22.000000000 +0200 +++ new/at-spi2-core-2.48.3/meson.build 2023-05-27 17:00:48.000000000 +0200 @@ -1,5 +1,5 @@ project('at-spi2-core', 'c', - version: '2.48.2', + version: '2.48.3', license: 'LGPLv2.1+', default_options: [ 'buildtype=debugoptimized', diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-core-2.48.2/meson_options.txt new/at-spi2-core-2.48.3/meson_options.txt --- old/at-spi2-core-2.48.2/meson_options.txt 2023-05-11 19:23:22.000000000 +0200 +++ new/at-spi2-core-2.48.3/meson_options.txt 2023-05-27 17:00:48.000000000 +0200 @@ -15,6 +15,10 @@ type: 'combo', choices: ['dbus-daemon', 'dbus-broker'], value: 'dbus-daemon') +option('use_systemd', + description: 'Use systemd if available (needed for dbus-broker)', + type: 'boolean', + value: true) option('systemd_user_dir', description: 'Location of the systemd user services', type: 'string',