Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package yast2-storage-ng for openSUSE:Factory checked in at 2023-06-08 21:41:50 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-storage-ng (Old) and /work/SRC/openSUSE:Factory/.yast2-storage-ng.new.15902 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-storage-ng" Thu Jun 8 21:41:50 2023 rev:145 rq:1091235 version:4.6.11 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-storage-ng/yast2-storage-ng.changes 2023-05-23 14:53:20.002053576 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-storage-ng.new.15902/yast2-storage-ng.changes 2023-06-08 21:41:50.989739173 +0200 @@ -1,0 +2,7 @@ +Wed Jun 7 08:03:52 UTC 2023 - Stefan Hundhammer <shundham...@suse.com> + +- Prevent setting the volume label for a mounted btrfs or swap + (bsc#1211337) +- 4.6.11 + +------------------------------------------------------------------- Old: ---- yast2-storage-ng-4.6.10.tar.bz2 New: ---- yast2-storage-ng-4.6.11.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-storage-ng.spec ++++++ --- /var/tmp/diff_new_pack.Vw2Eg6/_old 2023-06-08 21:41:51.797743935 +0200 +++ /var/tmp/diff_new_pack.Vw2Eg6/_new 2023-06-08 21:41:51.805743982 +0200 @@ -17,7 +17,7 @@ Name: yast2-storage-ng -Version: 4.6.10 +Version: 4.6.11 Release: 0 Summary: YaST2 - Storage Configuration License: GPL-2.0-only OR GPL-3.0-only ++++++ yast2-storage-ng-4.6.10.tar.bz2 -> yast2-storage-ng-4.6.11.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-ng-4.6.10/package/yast2-storage-ng.changes new/yast2-storage-ng-4.6.11/package/yast2-storage-ng.changes --- old/yast2-storage-ng-4.6.10/package/yast2-storage-ng.changes 2023-05-22 10:30:50.000000000 +0200 +++ new/yast2-storage-ng-4.6.11/package/yast2-storage-ng.changes 2023-06-07 11:34:17.000000000 +0200 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Wed Jun 7 08:03:52 UTC 2023 - Stefan Hundhammer <shundham...@suse.com> + +- Prevent setting the volume label for a mounted btrfs or swap + (bsc#1211337) +- 4.6.11 + +------------------------------------------------------------------- Fri May 19 15:36:55 UTC 2023 - José Iván López González <jlo...@suse.com> - Add bus_id for DASD (gh#yast/yast-storage-ng#1339, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-ng-4.6.10/package/yast2-storage-ng.spec new/yast2-storage-ng-4.6.11/package/yast2-storage-ng.spec --- old/yast2-storage-ng-4.6.10/package/yast2-storage-ng.spec 2023-05-22 10:30:50.000000000 +0200 +++ new/yast2-storage-ng-4.6.11/package/yast2-storage-ng.spec 2023-06-07 11:34:17.000000000 +0200 @@ -16,7 +16,7 @@ # Name: yast2-storage-ng -Version: 4.6.10 +Version: 4.6.11 Release: 0 Summary: YaST2 - Storage Configuration License: GPL-2.0-only OR GPL-3.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-ng-4.6.10/src/lib/y2partitioner/actions/controllers/filesystem.rb new/yast2-storage-ng-4.6.11/src/lib/y2partitioner/actions/controllers/filesystem.rb --- old/yast2-storage-ng-4.6.10/src/lib/y2partitioner/actions/controllers/filesystem.rb 2023-05-22 10:30:50.000000000 +0200 +++ new/yast2-storage-ng-4.6.11/src/lib/y2partitioner/actions/controllers/filesystem.rb 2023-06-07 11:34:17.000000000 +0200 @@ -175,6 +175,14 @@ mount_point.path end + # Check if the filesystem is currently mounted in the system device graph. + # + # @return [Boolean] + def mounted_in_system_graph? + sys_fs = system_device(filesystem) + sys_fs&.active_mount_point? + end + # Partition id of the block device if it is a partition # # @return [Y2Storage::PartitionId, nil] nil if there is no block device or the diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-ng-4.6.10/src/lib/y2partitioner/widgets/fstab_options.rb new/yast2-storage-ng-4.6.11/src/lib/y2partitioner/widgets/fstab_options.rb --- old/yast2-storage-ng-4.6.10/src/lib/y2partitioner/widgets/fstab_options.rb 2023-05-22 10:30:50.000000000 +0200 +++ new/yast2-storage-ng-4.6.11/src/lib/y2partitioner/widgets/fstab_options.rb 2023-06-07 11:34:17.000000000 +0200 @@ -263,6 +263,7 @@ self.value = filesystem.label Yast::UI.ChangeWidget(Id(widget_id), :ValidChars, valid_chars) Yast::UI.ChangeWidget(Id(widget_id), :InputMaxLength, input_max_length) + disable unless can_set_volume_label? end # Validates uniqueness of the given label. The presence of the label is also @@ -280,6 +281,27 @@ # @return [Widgets::FstabOptions] attr_reader :parent_widget + # Check if the volume label can be set. + # + # @return [Boolean] + def can_set_volume_label? + return true unless @controller.mounted_in_system_graph? + + blk_dev = @controller.blk_device_name + fs_type = @controller.filesystem_type + log.info("#{blk_dev} type #{fs_type} is mounted") + # Can't change the volume label for a mounted Btrfs or swap (bsc#1211337) + !btrfs? && !swap? + end + + def btrfs? + @controller.filesystem_type.is?(:btrfs) + end + + def swap? + @controller.filesystem_type.is?(:swap) + end + # Checks whether a label is given when the filesystem is mounted by label # # @note An error popup is presented when the filesystem is mounted by label