Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package sbd for openSUSE:Factory checked in
at 2023-06-20 16:48:55
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/sbd (Old)
and /work/SRC/openSUSE:Factory/.sbd.new.15902 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "sbd"
Tue Jun 20 16:48:55 2023 rev:47 rq:1093863 version:1.5.2+20230316.5ec38cf
Changes:
--------
--- /work/SRC/openSUSE:Factory/sbd/sbd.changes 2022-12-12 17:42:11.285957806
+0100
+++ /work/SRC/openSUSE:Factory/.sbd.new.15902/sbd.changes 2023-06-20
16:49:04.835621851 +0200
@@ -1,0 +2,11 @@
+Tue Jun 20 04:16:55 UTC 2023 - Yan Gao <y...@suse.com>
+
+- Update to version 1.5.2+20230316.5ec38cf:
+- query-watchdog: avoid issues on heap allocation failing
(gh#ClusterLabs/sbd#147)
+
+-------------------------------------------------------------------
+Tue Jun 20 04:14:49 UTC 2023 - Yan Gao <y...@suse.com>
+
+- Update to version 1.5.2+20230109.cf5c220 (v1.5.2):
+
+-------------------------------------------------------------------
Old:
----
sbd-1.5.1+20221128.8ec8e01.tar.xz
New:
----
sbd-1.5.2+20230316.5ec38cf.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ sbd.spec ++++++
--- /var/tmp/diff_new_pack.IdI8bp/_old 2023-06-20 16:49:05.451625553 +0200
+++ /var/tmp/diff_new_pack.IdI8bp/_new 2023-06-20 16:49:05.455625576 +0200
@@ -1,7 +1,7 @@
#
# spec file for package sbd
#
-# Copyright (c) 2022 SUSE LLC
+# Copyright (c) 2023 SUSE LLC
# Copyright (c) 2013 Lars Marowsky-Bree
#
# All modifications and additions to the file contributed by third parties
@@ -47,7 +47,7 @@
%global sync_resource_startup_sysconfig ""
Name: sbd
-Version: 1.5.1+20221128.8ec8e01
+Version: 1.5.2+20230316.5ec38cf
Release: 0
Summary: Storage-based death
License: GPL-2.0-or-later
++++++ _service ++++++
--- /var/tmp/diff_new_pack.IdI8bp/_old 2023-06-20 16:49:05.487625769 +0200
+++ /var/tmp/diff_new_pack.IdI8bp/_new 2023-06-20 16:49:05.495625817 +0200
@@ -4,7 +4,7 @@
<param name="exclude">.git</param>
<param name="url">https://github.com/ClusterLabs/sbd.git</param>
<param name="revision">main</param>
- <param name="versionformat">1.5.1+%cd.%h</param>
+ <param name="versionformat">1.5.2+%cd.%h</param>
<param name="changesgenerate">enable</param>
</service>
++++++ _servicedata ++++++
--- /var/tmp/diff_new_pack.IdI8bp/_old 2023-06-20 16:49:05.519625962 +0200
+++ /var/tmp/diff_new_pack.IdI8bp/_new 2023-06-20 16:49:05.519625962 +0200
@@ -1,7 +1,7 @@
<servicedata>
<service name="tar_scm">
<param name="url">https://github.com/ClusterLabs/sbd.git</param>
- <param
name="changesrevision">bacb6e78a9bd06448cc82959b195db8e3ff98d7d</param>
+ <param
name="changesrevision">0e4534ebdfe8d7a37beb0028e604e560a5674891</param>
</service>
</servicedata>
(No newline at EOF)
++++++ sbd-1.5.1+20221128.8ec8e01.tar.xz -> sbd-1.5.2+20230316.5ec38cf.tar.xz
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/sbd-1.5.1+20221128.8ec8e01/configure.ac
new/sbd-1.5.2+20230316.5ec38cf/configure.ac
--- old/sbd-1.5.1+20221128.8ec8e01/configure.ac 2022-11-28 16:17:49.000000000
+0100
+++ new/sbd-1.5.2+20230316.5ec38cf/configure.ac 2023-03-16 16:34:56.000000000
+0100
@@ -20,7 +20,7 @@
dnl checks for system services
AC_INIT([sbd],
- [1.5.1],
+ [1.5.2],
[l...@suse.com])
m4_include([tests-opt.m4])
AC_CANONICAL_HOST
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/sbd-1.5.1+20221128.8ec8e01/sbd.spec
new/sbd-1.5.2+20230316.5ec38cf/sbd.spec
--- old/sbd-1.5.1+20221128.8ec8e01/sbd.spec 2022-11-28 16:17:49.000000000
+0100
+++ new/sbd-1.5.2+20230316.5ec38cf/sbd.spec 2023-03-16 16:34:56.000000000
+0100
@@ -49,9 +49,9 @@
Name: sbd
Summary: Storage-based death
-License: GPLv2+
+License: GPL-2.0-or-later
Group: System Environment/Daemons
-Version: 1.5.1
+Version: 1.5.2
Release: 99.%{buildnum}.%{shortcommit}.%{modified}git%{?dist}
Url: https://github.com/%{github_owner}/%{name}
Source0:
https://github.com/%{github_owner}/%{name}/archive/%{longcommit}/%{name}-%{longcommit}.tar.gz
@@ -95,7 +95,7 @@
%package tests
Summary: Storage-based death environment for regression tests
-License: GPLv2+
+License: GPL-2.0-or-later
Group: System Environment/Daemons
%description tests
@@ -177,6 +177,34 @@
%{_libdir}/libsbdtestbed*
%changelog
+* Thu Jan 5 2023 <klaus.wennin...@aon.at> - 1.5.2-99.0.8ec8e011.git
+- fail startup if pacemaker integration is disabled while
+ SBD_SYNC_RESOURCE_STARTUP is conflicting (+ hint to overcome)
+- improve logs
+ - when logging state of SBD_PACEMAKER tell it is just that as
+ this might still be overridden via cmdline options
+ - log a warning if SBD_PACEMAKER is overridden by -P or -PP option
+ - do not warn about startup syncing with pacemaker integration disabled
+ - when watchdog-device is busy give a hint on who is hogging it
+- improve build environment
+ - have --with-runstatedir overrule --runstatedir
+ - use new package name for pacemaker devel on opensuse
+ - make config location configurable for man-page-creation
+ - reverse alloc/de-alloc order to make gcc-12 static analysis happy
+- improve test environment
+ - have image-files in /dev/shm to assure they are in memory and
+ sbd opening the files with O_SYNC doesn't trigger unnecessary
+ syncs on a heavily loaded test-machine
+ fallback to /tmp if /dev/shm doesn't exist
+ - wrapping away libaio and usage of device-mapper for block-device
+ simulation can now be passed into make via
+ SBD_USE_DM & SBD_TRANSLATE_AIO
+ - have variables that configure test-environment be printed
+ out prior to running tests
+ - finally assure we clean environment when interrupted by a
+ signal (bash should have done it with just setting EXIT handler -
+ but avoiding bashism might come handy one day)
+
* Mon Nov 15 2021 <klaus.wennin...@aon.at> - 1.5.1-99.0.7bcdf695.git
- improve/fix cmdline handling
- tell the actual watchdog device specified with -w
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/sbd-1.5.1+20221128.8ec8e01/src/sbd-common.c
new/sbd-1.5.2+20230316.5ec38cf/src/sbd-common.c
--- old/sbd-1.5.1+20221128.8ec8e01/src/sbd-common.c 2022-11-28
16:17:49.000000000 +0100
+++ new/sbd-1.5.2+20230316.5ec38cf/src/sbd-common.c 2023-03-16
16:34:56.000000000 +0100
@@ -385,8 +385,17 @@
struct link_list_item *lli =
calloc(1, sizeof(struct link_list_item));
+ if (lli == NULL) {
+ break;
+ }
lli->dev_node = strdup(buf);
lli->link_name = strdup(entry_name);
+ if ((lli->dev_node == NULL) || (lli->link_name == NULL)) {
+ free(lli->dev_node);
+ free(lli->link_name);
+ free(lli);
+ break;
+ }
lli->next = link_list;
link_list = lli;
}
@@ -404,18 +413,27 @@
if(!stat(entry_name, &statbuf) && S_ISCHR(statbuf.st_mode) &&
is_watchdog(statbuf.st_rdev)) {
- int wdfd = watchdog_init_fd(entry_name, -1);
+ int wdfd;
struct watchdog_list_item *wdg =
calloc(1, sizeof(struct watchdog_list_item));
int len;
struct link_list_item *tmp_list = NULL;
+ if (wdg == NULL) {
+ break;
+ }
+
wdg->dev = statbuf.st_rdev;
wdg->dev_node = strdup(entry_name);
+ if (wdg->dev_node == NULL) {
+ free(wdg);
+ break;
+ }
wdg->next = watchdog_list;
watchdog_list = wdg;
watchdog_list_items++;
+ wdfd = watchdog_init_fd(entry_name, -1);
if (wdfd >= 0) {
struct watchdog_info ident;
@@ -450,11 +468,18 @@
struct watchdog_list_item *dupe_wdg =
calloc(1, sizeof(struct watchdog_list_item));
+ if (dupe_wdg == NULL) {
+ break;
+ }
/* as long as we never purge watchdog_list
* there is no need to dupe strings
*/
*dupe_wdg = *wdg;
dupe_wdg->dev_node = strdup(tmp_list->link_name);
+ if (dupe_wdg->dev_node == NULL) {
+ free(dupe_wdg);
+ break;
+ }
dupe_wdg->next = watchdog_list;
watchdog_list = dupe_wdg;
watchdog_list_items++;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/sbd-1.5.1+20221128.8ec8e01/src/sbd-md.c
new/sbd-1.5.2+20230316.5ec38cf/src/sbd-md.c
--- old/sbd-1.5.1+20221128.8ec8e01/src/sbd-md.c 2022-11-28 16:17:49.000000000
+0100
+++ new/sbd-1.5.2+20230316.5ec38cf/src/sbd-md.c 2023-03-16 16:34:56.000000000
+0100
@@ -441,9 +441,9 @@
}
}
-out: free(s_node);
+out: free(s_mbox);
+ free(s_node);
free(s_header);
- free(s_mbox);
return(rc);
}
@@ -556,9 +556,9 @@
}
}
-out: free(s_node);
+out: free(s_mbox);
+ free(s_node);
free(s_header);
- free(s_mbox);
return(rc);
}
@@ -1279,11 +1279,10 @@
}
}
out:
- free(s_header);
free(s_node);
free(s_mbox);
+ free(s_header);
close_device(st);
exit(rc);
}
-
