Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package yast2-network for openSUSE:Factory checked in at 2023-06-21 22:37:04 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-network (Old) and /work/SRC/openSUSE:Factory/.yast2-network.new.15902 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-network" Wed Jun 21 22:37:04 2023 rev:500 rq:1093970 version:4.6.4 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-network/yast2-network.changes 2023-05-11 12:31:59.974264693 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-network.new.15902/yast2-network.changes 2023-06-21 22:37:16.141435895 +0200 @@ -1,0 +2,8 @@ +Tue Jun 13 12:11:42 UTC 2023 - Michal Filka <mfi...@suse.com> + +- bsc#1211431 + - Do not crash installation when storing vlan configuration into + NetworkManager +- 4.6.4 + +------------------------------------------------------------------- Old: ---- yast2-network-4.6.3.tar.bz2 New: ---- yast2-network-4.6.4.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-network.spec ++++++ --- /var/tmp/diff_new_pack.DXh5YU/_old 2023-06-21 22:37:16.997441046 +0200 +++ /var/tmp/diff_new_pack.DXh5YU/_new 2023-06-21 22:37:17.001441070 +0200 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 4.6.3 +Version: 4.6.4 Release: 0 Summary: YaST2 - Network Configuration License: GPL-2.0-only ++++++ yast2-network-4.6.3.tar.bz2 -> yast2-network-4.6.4.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.6.3/package/yast2-network.changes new/yast2-network-4.6.4/package/yast2-network.changes --- old/yast2-network-4.6.3/package/yast2-network.changes 2023-05-10 11:36:34.000000000 +0200 +++ new/yast2-network-4.6.4/package/yast2-network.changes 2023-06-20 13:25:28.000000000 +0200 @@ -1,4 +1,12 @@ ------------------------------------------------------------------- +Tue Jun 13 12:11:42 UTC 2023 - Michal Filka <mfi...@suse.com> + +- bsc#1211431 + - Do not crash installation when storing vlan configuration into + NetworkManager +- 4.6.4 + +------------------------------------------------------------------- Wed May 10 07:29:32 UTC 2023 - Knut Anderssen <kanders...@suse.com> - Do not write the EAP auth attribute when writing a wireless diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.6.3/package/yast2-network.spec new/yast2-network-4.6.4/package/yast2-network.spec --- old/yast2-network-4.6.3/package/yast2-network.spec 2023-05-10 11:36:34.000000000 +0200 +++ new/yast2-network-4.6.4/package/yast2-network.spec 2023-06-20 13:25:28.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 4.6.3 +Version: 4.6.4 Release: 0 Summary: YaST2 - Network Configuration License: GPL-2.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.6.3/src/lib/y2network/network_manager/connection_config_writers/vlan.rb new/yast2-network-4.6.4/src/lib/y2network/network_manager/connection_config_writers/vlan.rb --- old/yast2-network-4.6.3/src/lib/y2network/network_manager/connection_config_writers/vlan.rb 2023-05-10 11:36:34.000000000 +0200 +++ new/yast2-network-4.6.4/src/lib/y2network/network_manager/connection_config_writers/vlan.rb 2023-06-20 13:25:28.000000000 +0200 @@ -28,7 +28,7 @@ # @see Y2Network::ConnectionConfigWriters::Base#update_file # @param conn [Y2Network::ConnectionConfig::Vlan] Configuration to write def update_file(conn) - file.vlan["id"] = conn.vlan_id + file.vlan["id"] = conn.vlan_id.to_s file.vlan["parent"] = conn.parent_device file.vlan["type"] = "vlan" end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.6.3/test/y2network/network_manager/connection_config_writers/vlan_test.rb new/yast2-network-4.6.4/test/y2network/network_manager/connection_config_writers/vlan_test.rb --- old/yast2-network-4.6.3/test/y2network/network_manager/connection_config_writers/vlan_test.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/yast2-network-4.6.4/test/y2network/network_manager/connection_config_writers/vlan_test.rb 2023-06-20 13:25:28.000000000 +0200 @@ -0,0 +1,45 @@ +# Copyright (c) [2021] SUSE LLC +# +# All Rights Reserved. +# +# This program is free software; you can redistribute it and/or modify it +# under the terms of version 2 of the GNU General Public License as published +# by the Free Software Foundation. +# +# This program is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for +# more details. +# +# You should have received a copy of the GNU General Public License along +# with this program; if not, contact SUSE LLC. +# +# To contact SUSE LLC about this file by physical or electronic mail, you may +# find current contact information at www.suse.com. + +require_relative "../../../test_helper" +require "y2network/network_manager/connection_config_writers/vlan" +require "cfa/nm_connection" +require "y2network/connection_config/vlan" + +describe Y2Network::NetworkManager::ConnectionConfigWriters::Vlan do + subject(:handler) { described_class.new(file) } + let(:file) { CFA::NmConnection.new("vlan1006.nm_connection") } + + let(:conn) do + Y2Network::ConnectionConfig::Vlan.new.tap do |c| + c.interface = "eth0.1006" + c.vlan_id = 1006 + c.parent_device = "eth0" + end + end + + describe "#write" do + it "sets VLAN device attributes" do + handler.write(conn) + expect(file.vlan["id"]).to eql("1006") + expect(file.vlan["parent"]).to eql("eth0") + expect(file.vlan["type"]).to eql("vlan") + end + end +end