Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package yast2-kdump for openSUSE:Factory checked in at 2023-06-27 23:16:20 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-kdump (Old) and /work/SRC/openSUSE:Factory/.yast2-kdump.new.15902 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-kdump" Tue Jun 27 23:16:20 2023 rev:117 rq:1095636 version:4.6.1 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-kdump/yast2-kdump.changes 2023-03-04 22:43:18.855780539 +0100 +++ /work/SRC/openSUSE:Factory/.yast2-kdump.new.15902/yast2-kdump.changes 2023-06-27 23:16:28.959326638 +0200 @@ -1,0 +2,12 @@ +Fri Jun 23 12:00:54 CEST 2023 - Jiri Bohac <jbo...@suse.cz> + +- adapt for version kdump versions 1.9+ (bsc#1212646) +- call mkdumprd directly, not through tu-rebuild-kdump-initrd +- update initrd even in non-fadump case +- remove KDUMP_COPY_KERNEL and KDUMPTOOL_FLAGS options +- update default config values according to kdump defaults +- unify config boolean variables to "true" or "false" +- support the snappy, zstd and raw dump formats +- 4.6.1 + +------------------------------------------------------------------- Old: ---- yast2-kdump-4.6.0.tar.bz2 New: ---- yast2-kdump-4.6.1.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-kdump.spec ++++++ --- /var/tmp/diff_new_pack.YSQvnE/_old 2023-06-27 23:16:29.739331229 +0200 +++ /var/tmp/diff_new_pack.YSQvnE/_new 2023-06-27 23:16:29.743331252 +0200 @@ -17,7 +17,7 @@ Name: yast2-kdump -Version: 4.6.0 +Version: 4.6.1 Release: 0 Summary: Configuration of kdump License: GPL-2.0-only ++++++ yast2-kdump-4.6.0.tar.bz2 -> yast2-kdump-4.6.1.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-4.6.0/package/yast2-kdump.changes new/yast2-kdump-4.6.1/package/yast2-kdump.changes --- old/yast2-kdump-4.6.0/package/yast2-kdump.changes 2023-03-03 15:54:29.000000000 +0100 +++ new/yast2-kdump-4.6.1/package/yast2-kdump.changes 2023-06-27 15:57:45.000000000 +0200 @@ -1,4 +1,16 @@ ------------------------------------------------------------------- +Fri Jun 23 12:00:54 CEST 2023 - Jiri Bohac <jbo...@suse.cz> + +- adapt for version kdump versions 1.9+ (bsc#1212646) +- call mkdumprd directly, not through tu-rebuild-kdump-initrd +- update initrd even in non-fadump case +- remove KDUMP_COPY_KERNEL and KDUMPTOOL_FLAGS options +- update default config values according to kdump defaults +- unify config boolean variables to "true" or "false" +- support the snappy, zstd and raw dump formats +- 4.6.1 + +------------------------------------------------------------------- Fri Mar 03 14:44:07 UTC 2023 - Ladislav Slezák <lsle...@suse.cz> - Bump version to 4.6.0 (bsc#1208913) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-4.6.0/package/yast2-kdump.spec new/yast2-kdump-4.6.1/package/yast2-kdump.spec --- old/yast2-kdump-4.6.0/package/yast2-kdump.spec 2023-03-03 15:54:29.000000000 +0100 +++ new/yast2-kdump-4.6.1/package/yast2-kdump.spec 2023-06-27 15:57:45.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-kdump -Version: 4.6.0 +Version: 4.6.1 Release: 0 Summary: Configuration of kdump License: GPL-2.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-4.6.0/src/autoyast-rnc/kdump.rnc new/yast2-kdump-4.6.1/src/autoyast-rnc/kdump.rnc --- old/yast2-kdump-4.6.0/src/autoyast-rnc/kdump.rnc 2023-03-03 15:54:29.000000000 +0100 +++ new/yast2-kdump-4.6.1/src/autoyast-rnc/kdump.rnc 2023-06-27 15:57:45.000000000 +0200 @@ -41,10 +41,8 @@ element KDUMP_REQUIRED_PROGRAMS { STRING }? & element KDUMP_PRESCRIPT { STRING }? & element KDUMP_POSTSCRIPT { STRING }? & - element KDUMPTOOL_FLAGS { STRING }? & element KDUMP_NETCONFIG { STRING }? & element KDUMP_NET_TIMEOUT { STRING }? & - element KDUMP_COPY_KERNEL { STRING }? & element KEXEC_OPTIONS { STRING }? & element KDUMP_RUNLEVEL { STRING }? & element KDUMP_IMMEDIATE_REBOOT { STRING }? & diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-4.6.0/src/include/kdump/dialogs.rb new/yast2-kdump-4.6.1/src/include/kdump/dialogs.rb --- old/yast2-kdump-4.6.0/src/include/kdump/dialogs.rb 2023-03-03 15:54:29.000000000 +0100 +++ new/yast2-kdump-4.6.1/src/include/kdump/dialogs.rb 2023-06-27 15:57:45.000000000 +0200 @@ -171,7 +171,10 @@ ["none_format", _("&No Dump")], ["elf_format", _("&ELF Format")], ["compressed_format", _("C&ompressed Format")], - ["lzo_format", _("&LZO Compressed Format")] + ["lzo_format", _("&LZO Compressed Format")], + ["snappy_format", _("&Snappy Compressed Format")], + ["zstd_format", _("Zstandard Compressed Format")], + ["raw_format", _("Raw copy of /proc/vmcore")] ], "orientation" => :horizontal, "init" => fun_ref( @@ -347,20 +350,6 @@ ), "help" => HelpKdump("EnableReboot") }, - "EnableCopyKernel" => { - # TRANSLATORS: CheckBox Label - "label" => _( - "Enable Copy Ke&rnel into the Dump Directory" - ), - "widget" => :checkbox, - "init" => fun_ref(method(:InitEnableCopyKernel), "void (string)"), - # "handle" : - "store" => fun_ref( - method(:StoreEnableCopyKernel), - "void (string, map)" - ), - "help" => HelpKdump("EnableCopyKernel") - }, "EnableDeleteImages" => { # TRANSLATORS: CheckBox Label "label" => _( @@ -498,8 +487,7 @@ VBox( Left("EnableDeleteImages"), Left("NumberDumps"), - Left("EnableReboot"), - Left("EnableCopyKernel") + Left("EnableReboot") ) ) ), @@ -515,8 +503,7 @@ "NumberDumps", "InitrdKernel", "SelectKernel", - "EnableReboot", - "EnableCopyKernel" + "EnableReboot" ] } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-4.6.0/src/include/kdump/helps.rb new/yast2-kdump-4.6.1/src/include/kdump/helps.rb --- old/yast2-kdump-4.6.0/src/include/kdump/helps.rb 2023-03-03 15:54:29.000000000 +0100 +++ new/yast2-kdump-4.6.1/src/include/kdump/helps.rb 2023-06-27 15:57:45.000000000 +0200 @@ -74,7 +74,10 @@ " <i>No Dump</i> - Only save the kernel log.<br>\n" \ " <i>ELF Format</i> - Create dump file in ELF format.<br>\n" \ " <i>Compressed Format</i> - Compress dump data by each page with gzip.<br>\n" \ - " <i>LZO Compressed Format</i> - Slightly bigger files but much faster.<br>\n</p>" + " <i>LZO Compressed Format</i> - Slightly bigger files but much faster.<br>\n</p>" \ + " <i>Snappy Compressed Format</i> - Considerably faster, 64-bit optimized.<br>\n</p>" \ + " <i>Zstandard Compressed Format</i> - Smaller files, slower.<br>\n</p>" \ + " <i>Raw copy of /proc/vmcore</i> - does not use makedumpfile.<br>\n</p>" ), # Dump Format - RadioButtons 1/7 "TargetKdump" => _( @@ -161,14 +164,6 @@ " Enable Delete Old Dump Images. If the number of dump files in \n" \ " <i>Number of Old Dumps</i> exceeds this number, older dumps are removed.<br></p>" ), - # Enable Copy Ke&rnel into the Dump Directory - CheckBox 1/1 - "EnableCopyKernel" => _( - "<p><b>Enable Copy Kernel into the Dump Directory</b> - \n" \ - " If this option is selected, the kernel and the\n" \ - " debugging information (if installed) are copied into the dump\n" \ - " directory. The default is \"off\". It is useful to have\n" \ - " everything in place for debugging.<br></p>\n" - ), # SMTP Server "SMTPServer" => _( "<p><b>SMTP Server</b> used for sending a notification email after a dump.</p>" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-4.6.0/src/include/kdump/uifunctions.rb new/yast2-kdump-4.6.1/src/include/kdump/uifunctions.rb --- old/yast2-kdump-4.6.0/src/include/kdump/uifunctions.rb 2023-03-03 15:54:29.000000000 +0100 +++ new/yast2-kdump-4.6.1/src/include/kdump/uifunctions.rb 2023-06-27 15:57:45.000000000 +0200 @@ -1125,7 +1125,7 @@ UI.ChangeWidget( Id("EnableReboot"), :Value, - Ops.get(Kdump.KDUMP_SETTINGS, "KDUMP_IMMEDIATE_REBOOT") == "yes" ? true : false + ["yes", "true", "1"].include?(Ops.get(Kdump.KDUMP_SETTINGS, "KDUMP_IMMEDIATE_REBOOT")) ) nil @@ -1138,7 +1138,7 @@ Ops.set( Kdump.KDUMP_SETTINGS, "KDUMP_IMMEDIATE_REBOOT", - Convert.to_boolean(UI.QueryWidget(Id("EnableReboot"), :Value)) ? "yes" : "no" + Convert.to_boolean(UI.QueryWidget(Id("EnableReboot"), :Value)) ? "true" : "false" ) nil @@ -1349,7 +1349,7 @@ UI.ChangeWidget(Id(:auto_resize), :Enabled, false) auto_resize = false else - auto_resize = Kdump.KDUMP_SETTINGS["KDUMP_AUTO_RESIZE"] == "yes" + auto_resize = ["yes", "true", "1"].include?(Kdump.KDUMP_SETTINGS["KDUMP_AUTO_RESIZE"]) end UI.ChangeWidget(Id(:auto_resize), :Value, auto_resize) if Kdump.total_memory > 0 @@ -1420,7 +1420,7 @@ # "KdumpMemory" def StoreKdumpMemory(_key, _event) Kdump.KDUMP_SETTINGS["KDUMP_AUTO_RESIZE"] = - UI.QueryWidget(Id(:auto_resize), :Value) ? "yes" : "no" + UI.QueryWidget(Id(:auto_resize), :Value) ? "true" : "false" Kdump.allocated_memory[:low] = Builtins.tostring( UI.QueryWidget(Id("allocated_low_memory"), :Value) ) @@ -1509,12 +1509,19 @@ # "Dump Format" def InitDumpFormat(_key) - if Ops.get(Kdump.KDUMP_SETTINGS, "KDUMP_DUMPFORMAT") == "ELF" + case Ops.get(Kdump.KDUMP_SETTINGS, "KDUMP_DUMPFORMAT") + when "ELF" UI.ChangeWidget(Id("DumpFormat"), :Value, "elf_format") - elsif Ops.get(Kdump.KDUMP_SETTINGS, "KDUMP_DUMPFORMAT") == "compressed" + when "compressed" UI.ChangeWidget(Id("DumpFormat"), :Value, "compressed_format") - elsif Ops.get(Kdump.KDUMP_SETTINGS, "KDUMP_DUMPFORMAT") == "lzo" + when "lzo" UI.ChangeWidget(Id("DumpFormat"), :Value, "lzo_format") + when "snappy" + UI.ChangeWidget(Id("DumpFormat"), :Value, "snappy_format") + when "zstd" + UI.ChangeWidget(Id("DumpFormat"), :Value, "zstd_format") + when "raw" + UI.ChangeWidget(Id("DumpFormat"), :Value, "raw_format") else UI.ChangeWidget(Id("DumpFormat"), :Value, "none_format") end @@ -1530,7 +1537,7 @@ result = true value = Builtins.tostring(UI.QueryWidget(Id("DumpFormat"), :Value)) - if value != "elf_format" || value.nil? + if value != "raw_format" || value.nil? if Mode.installation || Mode.autoinst Kdump.kdump_packages = Builtins.add( Kdump.kdump_packages, @@ -1578,6 +1585,12 @@ Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_DUMPFORMAT", "compressed") elsif value == "lzo_format" Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_DUMPFORMAT", "lzo") + elsif value == "snappy_format" + Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_DUMPFORMAT", "snappy") + elsif value == "zstd_format" + Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_DUMPFORMAT", "zstd") + elsif value == "raw_format" + Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_DUMPFORMAT", "raw") else Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_DUMPFORMAT", "none") end @@ -1639,33 +1652,6 @@ nil end - - # Function initializes option - # "Enable Copy Kernel into the Dump Directory" - - def InitEnableCopyKernel(_key) - if Ops.get(Kdump.KDUMP_SETTINGS, "KDUMP_COPY_KERNEL", "no") == "yes" - UI.ChangeWidget(Id("EnableCopyKernel"), :Value, true) - else - UI.ChangeWidget(Id("EnableCopyKernel"), :Value, false) - end - - nil - end - - # Function stores option - # "Enable Copy Kernel into the Dump Directory" - - def StoreEnableCopyKernel(_key, _event) - value = Convert.to_boolean(UI.QueryWidget(Id("EnableCopyKernel"), :Value)) - if !value - Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_COPY_KERNEL", "no") - else - Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_COPY_KERNEL", "yes") - end - - nil - end # Function initializes option # "SMTP Server" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-4.6.0/src/lib/kdump/clients/kdump.rb new/yast2-kdump-4.6.1/src/lib/kdump/clients/kdump.rb --- old/yast2-kdump-4.6.0/src/lib/kdump/clients/kdump.rb 2023-03-03 15:54:29.000000000 +0100 +++ new/yast2-kdump-4.6.1/src/lib/kdump/clients/kdump.rb 2023-06-27 15:57:45.000000000 +0200 @@ -80,7 +80,7 @@ "handler" => fun_ref(method(:cmdKdumpDumpFormat), "boolean (map)"), # TRANSLATORS: CommandLine help "help" => _( - "Dump format for dump image: none/ELF/compressed/lzo" + "Dump format for dump image: none/ELF/compressed/lzo/snappy/zstd/raw" ), "example" => [ "dumpformat dump_format=none", @@ -145,14 +145,6 @@ ), "example" => ["immediatereboot enable", "immediatereboot disable"] }, - "copykernel" => { - "handler" => fun_ref(method(:cmdKdumpCopyKernel), "boolean (map)"), - # TRANSLATORS: CommandLine help - "help" => _( - "Copy kernel into dump directory." - ), - "example" => ["copykernel enable", "copykernel disable"] - }, "keepolddumps" => { "handler" => fun_ref(method(:cmdKdumpKeepOldDumps), "boolean (map)"), # TRANSLATORS: CommandLine help @@ -239,7 +231,7 @@ "type" => "string", # TRANSLATORS: CommandLine help "help" => _( - "Dump format can be none, ELF, compressed or lzo" + "Dump format can be none, ELF, compressed, lzo, snappy, zstd, or raw" ) }, "target" => { @@ -639,7 +631,7 @@ CommandLine.Print( Builtins.sformat( _("Kdump immediate reboots: %1"), - if Ops.get(Kdump.KDUMP_SETTINGS, "KDUMP_IMMEDIATE_REBOOT") == "yes" + if ["yes", "true", "1"].include?(Ops.get(Kdump.KDUMP_SETTINGS, "KDUMP_IMMEDIATE_REBOOT")) _("Enabled") else _("Disabled") @@ -794,8 +786,7 @@ def cmdKdumpDumpFormat(options) options = deep_copy(options) if Ops.get(options, "dump_format") - if Ops.get(options, "dump_format") == "ELF" || - Ops.get(options, "dump_format") == "compressed" + if ["none", "ELF", "compressed", "lzo", "snappy", "zstd", "raw"].include?(Ops.get(options, "dump_format")) Ops.set( Kdump.KDUMP_SETTINGS, "KDUMP_DUMPFORMAT", @@ -809,7 +800,7 @@ CommandLine.Error(_("Wrong value of option.")) # TRANSLATORS: CommandLine printed text help CommandLine.Print( - _("Option can include only \"none\", \"ELF\", \"compressed\" or \"lzo\" value.") + _("Option can include only \"none\", \"ELF\", \"compressed\", \"lzo\", \"snappy\", \"zstd\" or \"raw\" value.") ) return false end @@ -1101,25 +1092,10 @@ def cmdKdumpImmediateReboot(options) options = deep_copy(options) if Ops.get(options, "enable") - Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_IMMEDIATE_REBOOT", "yes") - return true - elsif Ops.get(options, "disable") - Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_IMMEDIATE_REBOOT", "no") - return true - else - # TRANSLATORS: CommandLine error message - CommandLine.Error(_("Wrong options were used.")) - return false - end - end - - def cmdKdumpCopyKernel(options) - options = deep_copy(options) - if Ops.get(options, "enable") - Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_COPY_KERNEL", "yes") + Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_IMMEDIATE_REBOOT", "true") return true elsif Ops.get(options, "disable") - Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_COPY_KERNEL", "no") + Ops.set(Kdump.KDUMP_SETTINGS, "KDUMP_IMMEDIATE_REBOOT", "false") return true else # TRANSLATORS: CommandLine error message diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-4.6.0/src/modules/Kdump.rb new/yast2-kdump-4.6.1/src/modules/Kdump.rb --- old/yast2-kdump-4.6.0/src/modules/Kdump.rb 2023-03-03 15:54:29.000000000 +0100 +++ new/yast2-kdump-4.6.1/src/modules/Kdump.rb 2023-06-27 15:57:45.000000000 +0200 @@ -147,25 +147,23 @@ @DEFAULT_CONFIG = { "KDUMP_KERNELVER" => "", - "KDUMP_CPUS" => "", + "KDUMP_CPUS" => "1", "KDUMP_COMMANDLINE" => "", "KDUMP_COMMANDLINE_APPEND" => "", - "KDUMP_AUTO_RESIZE" => "no", + "KDUMP_AUTO_RESIZE" => "false", "KEXEC_OPTIONS" => "", - "KDUMP_IMMEDIATE_REBOOT" => "yes", - "KDUMP_COPY_KERNEL" => "yes", + "KDUMP_IMMEDIATE_REBOOT" => "true", "KDUMP_TRANSFER" => "", "KDUMP_SAVEDIR" => "file:///var/crash", - "KDUMP_KEEP_OLD_DUMPS" => "5", + "KDUMP_KEEP_OLD_DUMPS" => "0", "KDUMP_FREE_DISK_SIZE" => "64", - "KDUMP_VERBOSE" => "3", + "KDUMP_VERBOSE" => "0", "KDUMP_DUMPLEVEL" => "31", - "KDUMP_DUMPFORMAT" => "lzo", + "KDUMP_DUMPFORMAT" => "compressed", "KDUMP_CONTINUE_ON_ERROR" => "true", "KDUMP_REQUIRED_PROGRAMS" => "", "KDUMP_PRESCRIPT" => "", "KDUMP_POSTSCRIPT" => "", - "KDUMPTOOL_FLAGS" => "", "KDUMP_NETCONFIG" => "auto", "KDUMP_NET_TIMEOUT" => "30", "KDUMP_SMTP_SERVER" => "", @@ -409,18 +407,9 @@ # around if Package.IsTransactionalSystem return update_initrd_with("transactional-update --continue kdump") + else + return update_initrd_with("mkdumprd") end - - # For CaaSP we need an explicit initrd rebuild before the - # first boot, when the root filesystem becomes read only. - rebuild_cmd = "/usr/sbin/tu-rebuild-kdump-initrd" - # part of transactional-update.rpm - update_initrd_with("if test -x #{rebuild_cmd}; then #{rebuild_cmd}; fi") - - return true unless using_fadump_changed? - - update_command = "/usr/sbin/mkdumprd -f" - update_initrd_with(update_command) end # @param update_command [String] a command for .target.bash @@ -1023,7 +1012,7 @@ return false end - @KDUMP_SETTINGS[FADUMP_KEY] = (new_value ? "yes" : "no") + @KDUMP_SETTINGS[FADUMP_KEY] = (new_value ? "true" : "false") true end @@ -1031,7 +1020,7 @@ # # @return [Boolean] currently in use def using_fadump? - @KDUMP_SETTINGS[FADUMP_KEY] == "yes" + ["yes", "true", "1"].include?(@KDUMP_SETTINGS[FADUMP_KEY]) end # Has the using_fadump? been changed? @@ -1155,7 +1144,7 @@ end result = [] - if @KDUMP_SETTINGS["KDUMP_AUTO_RESIZE"] == "yes" + if ["yes", "true", "1"].include?(@KDUMP_SETTINGS["KDUMP_AUTO_RESIZE"]) maxsize = total_memory / 2 if high_memory_supported? low = memory_limits[:default_low] @@ -1193,7 +1182,7 @@ end result = [] - if @KDUMP_SETTINGS["KDUMP_AUTO_RESIZE"] == "yes" + if ["yes", "true", "1"].include?(@KDUMP_SETTINGS["KDUMP_AUTO_RESIZE"]) high = memory_limits[:default_high] low = memory_limits[:default_low] else diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-kdump-4.6.0/test/kdump_test.rb new/yast2-kdump-4.6.1/test/kdump_test.rb --- old/yast2-kdump-4.6.0/test/kdump_test.rb 2023-03-03 15:54:29.000000000 +0100 +++ new/yast2-kdump-4.6.1/test/kdump_test.rb 2023-06-27 15:57:45.000000000 +0200 @@ -498,7 +498,7 @@ end context "if kdump is requested, no value for crashkernel is supplied, and auto-resize is disabled" do - let(:profile) { { "add_crash_kernel" => true, "general" => { "KDUMP_AUTO_RESIZE" => "no" } } } + let(:profile) { { "add_crash_kernel" => true, "general" => { "KDUMP_AUTO_RESIZE" => "false" } } } it "writes a proposed crashkernel in the bootloader and enables the service" do expect(Yast::Bootloader) @@ -612,7 +612,7 @@ end context "if kdump is requested, no value for crashkernel is supplied, and auto-resize is disabled" do - let(:profile) { { "add_crash_kernel" => true, "general" => { "KDUMP_AUTO_RESIZE" => "no" } } } + let(:profile) { { "add_crash_kernel" => true, "general" => { "KDUMP_AUTO_RESIZE" => "false" } } } it "rewrites the bootloader crashkernel settings and enables the service" do expect(Yast::Bootloader) @@ -930,7 +930,7 @@ "crash_kernel" => "256M", "general" => { "KDUMP_SAVEDIR" => "file:///var/dummy", - "KDUMP_AUTO_RESIZE" => "no" + "KDUMP_AUTO_RESIZE" => "false" } } end