Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package postsrsd for openSUSE:Factory checked in at 2023-06-27 23:16:43 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/postsrsd (Old) and /work/SRC/openSUSE:Factory/.postsrsd.new.15902 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "postsrsd" Tue Jun 27 23:16:43 2023 rev:9 rq:1095506 version:2.0.5 Changes: -------- --- /work/SRC/openSUSE:Factory/postsrsd/postsrsd.changes 2023-05-04 17:11:12.408587075 +0200 +++ /work/SRC/openSUSE:Factory/.postsrsd.new.15902/postsrsd.changes 2023-06-27 23:17:00.463512038 +0200 @@ -1,0 +2,6 @@ +Tue Jun 27 04:49:49 UTC 2023 - Jan Engelhardt <jeng...@inai.de> + +- Update to release 2.0.5 + * Do not try to set Keep-Alive on Redis unix sockets + +------------------------------------------------------------------- Old: ---- 2.0.4.tar.gz New: ---- 2.0.5.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ postsrsd.spec ++++++ --- /var/tmp/diff_new_pack.ZR2NiI/_old 2023-06-27 23:17:01.031515380 +0200 +++ /var/tmp/diff_new_pack.ZR2NiI/_new 2023-06-27 23:17:01.035515405 +0200 @@ -17,7 +17,7 @@ Name: postsrsd -Version: 2.0.4 +Version: 2.0.5 Release: 0 Summary: Sender Rewriting Support for postfix License: GPL-2.0-only ++++++ 2.0.4.tar.gz -> 2.0.5.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/postsrsd-2.0.4/CHANGELOG.rst new/postsrsd-2.0.5/CHANGELOG.rst --- old/postsrsd-2.0.4/CHANGELOG.rst 2023-05-03 23:12:26.000000000 +0200 +++ new/postsrsd-2.0.5/CHANGELOG.rst 2023-06-26 21:56:02.000000000 +0200 @@ -7,6 +7,15 @@ Changelog ######### +2.0.5 +===== + +Fixed +----- + +* Do not try to set Keep-Alive on Redis unix sockets + (`#146 <https://github.com/roehling/postsrsd/issues/146>`_) + 2.0.4 ===== diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/postsrsd-2.0.4/CMakeLists.txt new/postsrsd-2.0.5/CMakeLists.txt --- old/postsrsd-2.0.4/CMakeLists.txt 2023-05-03 23:12:26.000000000 +0200 +++ new/postsrsd-2.0.5/CMakeLists.txt 2023-06-26 21:56:02.000000000 +0200 @@ -14,10 +14,10 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. # -cmake_minimum_required(VERSION 3.14...3.25) +cmake_minimum_required(VERSION 3.14...3.26) project( postsrsd - VERSION 2.0.4 + VERSION 2.0.5 LANGUAGES C DESCRIPTION "Sender Rewriting Scheme daemon for Postfix" HOMEPAGE_URL "https://github.com/roehling/postsrsd"; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/postsrsd-2.0.4/README.rst new/postsrsd-2.0.5/README.rst --- old/postsrsd-2.0.4/README.rst 2023-05-03 23:12:26.000000000 +0200 +++ new/postsrsd-2.0.5/README.rst 2023-06-26 21:56:02.000000000 +0200 @@ -32,8 +32,9 @@ it! Unless you need a specific new feature or bugfix from a newer version, it will be much less of a maintenance burden. -If you are looking to package PostSRSd for a Linux distribution, have a look -at the packaging_ notes. +If you are interested in packaging PostSRSd for a Linux distribution, have a +look at the packaging_ notes. In particular, we are currently looking for a new +Debian maintainer (`#145 <https://github.com/roehling/postsrsd/issues/145>`_). .. _packaging: doc/packaging.rst diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/postsrsd-2.0.4/src/database.c new/postsrsd-2.0.5/src/database.c --- old/postsrsd-2.0.4/src/database.c 2023-05-03 23:12:26.000000000 +0200 +++ new/postsrsd-2.0.5/src/database.c 2023-06-26 21:56:02.000000000 +0200 @@ -183,6 +183,11 @@ snprintf(buffer, sizeof(buffer), "PostSRSd/%s", key); redisContext* handle = (redisContext*)db->handle; redisReply* reply = redisCommand(handle, "GET %s", buffer); + if (!reply) + { + log_warn("redis connection failure: %s", handle->errstr); + return NULL; + } char* value = NULL; if (reply->type == REDIS_REPLY_ERROR) { @@ -205,6 +210,11 @@ bool success = true; redisReply* reply = redisCommand(handle, "SETEX %s %u %s", buffer, lifetime, value); + if (!reply) + { + log_warn("redis connection failure: %s", handle->errstr); + return false; + } if (reply->type == REDIS_REPLY_ERROR) { log_warn("redis write error: %s", reply->str); @@ -226,29 +236,35 @@ if (port > 0) { handle = redisConnect(hostname, port); + if (!handle) + goto alloc_fail; + if (handle->err) + goto conn_fail; + redisEnableKeepAlive(handle); } else { handle = redisConnectUnix(hostname); - } - if (!handle) - { - log_error("failed to allocate redis handle"); - return false; + if (!handle) + goto alloc_fail; } if (handle->err) - { - log_error("failed to connect to redis instance: %s", handle->errstr); - redisFree(handle); - return false; - } - redisEnableKeepAlive(handle); + goto conn_fail; db->handle = handle; db->read = db_redis_read; db->write = db_redis_write; db->expire = NULL; db->disconnect = db_redis_disconnect; return true; + +conn_fail: + log_error("failed to connect to redis instance: %s", handle->errstr); + redisFree(handle); + return false; + +alloc_fail: + log_error("failed to allocate redis handle"); + return false; } #endif
