Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libtommath for openSUSE:Factory checked in at 2023-06-30 19:57:57 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libtommath (Old) and /work/SRC/openSUSE:Factory/.libtommath.new.13546 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libtommath" Fri Jun 30 19:57:57 2023 rev:5 rq:1095881 version:1.2.0 Changes: -------- --- /work/SRC/openSUSE:Factory/libtommath/libtommath.changes 2023-03-11 18:24:33.447042406 +0100 +++ /work/SRC/openSUSE:Factory/.libtommath.new.13546/libtommath.changes 2023-06-30 19:58:01.341340170 +0200 @@ -1,0 +2,19 @@ +Wed Jun 28 15:07:14 UTC 2023 - Michal Kubecek <mkube...@suse.cz> + +- handle rpmlint warnings/errors: + * update rpmlintrc to address new Factory warnings + * make libtommath-examples noarch + * make shared library executable + +------------------------------------------------------------------- +Wed Jun 28 14:53:06 UTC 2023 - Michal Kubecek <mkube...@suse.cz> + +- specfile style changes enforced by hard to avoid format_spec_file + service + +------------------------------------------------------------------- +Wed Jun 28 12:58:35 UTC 2023 - Dominique Leuenberger <dims...@opensuse.org> + +- Add 546.patch: Fix possible integer overflow. + +------------------------------------------------------------------- New: ---- 546.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libtommath.spec ++++++ --- /var/tmp/diff_new_pack.4t9QPu/_old 2023-06-30 19:58:02.053344405 +0200 +++ /var/tmp/diff_new_pack.4t9QPu/_new 2023-06-30 19:58:02.061344452 +0200 @@ -1,7 +1,7 @@ # # spec file for package libtommath # -# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2023 SUSE LLC # Copyright (c) 2009 Exata T.I., Maringa, PR, Brasil. # # All modifications and additions to the file contributed by third parties @@ -24,12 +24,13 @@ Summary: Routines For a Integer Based Number Theoretic Applications License: Unlicense Group: System/Libraries -Url: https://github.com/libtom/libtommath +URL: https://github.com/libtom/libtommath Source: https://github.com/libtom/libtommath/releases/download/v%{version}/ltm-%{version}.tar.xz Source2: https://github.com/libtom/libtommath/releases/download/v%{version}/ltm-%{version}.tar.xz.asc Source3: %{name}.keyring Source4: baselibs.conf Source5: libtommath-rpmlintrc +Patch1: https://patch-diff.githubusercontent.com/raw/libtom/libtommath/pull/546.patch BuildRequires: dos2unix BuildRequires: libtool BuildRequires: pkg-config @@ -44,7 +45,6 @@ can be used to write one [Used in LibTomCrypt for RSA, DH and ECC public key routines]. - %package -n %{libsoname} Summary: Routines For a Integer Based Number Theoretic Applications Group: System/Libraries @@ -56,7 +56,6 @@ can be used to write one [Used in LibTomCrypt for RSA, DH and ECC public key routines]. - %package devel Summary: Development files for LibTomMath Group: Development/Libraries/C and C++ @@ -73,12 +72,12 @@ can be used to write one [Used in LibTomCrypt for RSA, DH and ECC public key routines]. - %package examples Summary: Example files for LibTomMath Group: Development/Libraries/Other Provides: libtommath0-examples = %{version} Obsoletes: libtommath0-examples < 1 +BuildArch: noarch %description examples Demo *.c files showing how to use TomMath library. @@ -89,9 +88,9 @@ can be used to write one [Used in LibTomCrypt for RSA, DH and ECC public key routines]. - %prep %setup -q +%patch1 -p1 %build export CFLAGS="%{optflags}" @@ -107,6 +106,7 @@ make DESTDIR=%{buildroot} LIBPATH=%{_libdir} INCPATH=%{_includedir} %{?_smp_mflags} -f makefile.shared install # we don't want to ship any static libraries or .la files find %{buildroot} -type f \( -name '*.a' -o -name '*.la' \) -delete -print +chmod +x %{buildroot}%{_libdir}/libtommath.so.* %post -n %{libsoname} -p /sbin/ldconfig ++++++ 546.patch ++++++ >From beba892bc0d4e4ded4d667ab1d2a94f4d75109a9 Mon Sep 17 00:00:00 2001 From: czurnieden <czurnie...@gmx.de> Date: Tue, 9 May 2023 17:17:12 +0200 Subject: [PATCH] Fix possible integer overflow --- bn_mp_2expt.c | 4 ++++ bn_mp_grow.c | 4 ++++ bn_mp_init_size.c | 5 +++++ bn_mp_mul_2d.c | 4 ++++ bn_s_mp_mul_digs.c | 4 ++++ bn_s_mp_mul_digs_fast.c | 4 ++++ bn_s_mp_mul_high_digs.c | 4 ++++ bn_s_mp_mul_high_digs_fast.c | 4 ++++ 8 files changed, 33 insertions(+) diff --git a/bn_mp_2expt.c b/bn_mp_2expt.c index 0ae3df1bf..23de0c3c5 100644 --- a/bn_mp_2expt.c +++ b/bn_mp_2expt.c @@ -12,6 +12,10 @@ mp_err mp_2expt(mp_int *a, int b) { mp_err err; + if (b < 0) { + return MP_VAL; + } + /* zero a as per default */ mp_zero(a); diff --git a/bn_mp_grow.c b/bn_mp_grow.c index 9e904c547..2b1682651 100644 --- a/bn_mp_grow.c +++ b/bn_mp_grow.c @@ -9,6 +9,10 @@ mp_err mp_grow(mp_int *a, int size) int i; mp_digit *tmp; + if (size < 0) { + return MP_VAL; + } + /* if the alloc size is smaller alloc more ram */ if (a->alloc < size) { /* reallocate the array a->dp diff --git a/bn_mp_init_size.c b/bn_mp_init_size.c index d62268721..99573833f 100644 --- a/bn_mp_init_size.c +++ b/bn_mp_init_size.c @@ -6,6 +6,11 @@ /* init an mp_init for a given size */ mp_err mp_init_size(mp_int *a, int size) { + + if (size < 0) { + return MP_VAL; + } + size = MP_MAX(MP_MIN_PREC, size); /* alloc mem */ diff --git a/bn_mp_mul_2d.c b/bn_mp_mul_2d.c index 87354de20..bfeaf2eb2 100644 --- a/bn_mp_mul_2d.c +++ b/bn_mp_mul_2d.c @@ -9,6 +9,10 @@ mp_err mp_mul_2d(const mp_int *a, int b, mp_int *c) mp_digit d; mp_err err; + if (b < 0) { + return MP_VAL; + } + /* copy */ if (a != c) { if ((err = mp_copy(a, c)) != MP_OKAY) { diff --git a/bn_s_mp_mul_digs.c b/bn_s_mp_mul_digs.c index 64509d4cb..3682b4980 100644 --- a/bn_s_mp_mul_digs.c +++ b/bn_s_mp_mul_digs.c @@ -16,6 +16,10 @@ mp_err s_mp_mul_digs(const mp_int *a, const mp_int *b, mp_int *c, int digs) mp_word r; mp_digit tmpx, *tmpt, *tmpy; + if (digs < 0) { + return MP_VAL; + } + /* can we use the fast multiplier? */ if ((digs < MP_WARRAY) && (MP_MIN(a->used, b->used) < MP_MAXFAST)) { diff --git a/bn_s_mp_mul_digs_fast.c b/bn_s_mp_mul_digs_fast.c index b2a287b02..3c4176a87 100644 --- a/bn_s_mp_mul_digs_fast.c +++ b/bn_s_mp_mul_digs_fast.c @@ -26,6 +26,10 @@ mp_err s_mp_mul_digs_fast(const mp_int *a, const mp_int *b, mp_int *c, int digs) mp_digit W[MP_WARRAY]; mp_word _W; + if (digs < 0) { + return MP_VAL; + } + /* grow the destination as required */ if (c->alloc < digs) { if ((err = mp_grow(c, digs)) != MP_OKAY) { diff --git a/bn_s_mp_mul_high_digs.c b/bn_s_mp_mul_high_digs.c index 2bb2a5098..c9dd355f8 100644 --- a/bn_s_mp_mul_high_digs.c +++ b/bn_s_mp_mul_high_digs.c @@ -15,6 +15,10 @@ mp_err s_mp_mul_high_digs(const mp_int *a, const mp_int *b, mp_int *c, int digs) mp_word r; mp_digit tmpx, *tmpt, *tmpy; + if (digs < 0) { + return MP_VAL; + } + /* can we use the fast multiplier? */ if (MP_HAS(S_MP_MUL_HIGH_DIGS_FAST) && ((a->used + b->used + 1) < MP_WARRAY) diff --git a/bn_s_mp_mul_high_digs_fast.c b/bn_s_mp_mul_high_digs_fast.c index a2c4fb692..4ce7f590c 100644 --- a/bn_s_mp_mul_high_digs_fast.c +++ b/bn_s_mp_mul_high_digs_fast.c @@ -19,6 +19,10 @@ mp_err s_mp_mul_high_digs_fast(const mp_int *a, const mp_int *b, mp_int *c, int mp_digit W[MP_WARRAY]; mp_word _W; + if (digs < 0) { + return MP_VAL; + } + /* grow the destination as required */ pa = a->used + b->used; if (c->alloc < pa) { ++++++ libtommath-rpmlintrc ++++++ --- /var/tmp/diff_new_pack.4t9QPu/_old 2023-06-30 19:58:02.125344833 +0200 +++ /var/tmp/diff_new_pack.4t9QPu/_new 2023-06-30 19:58:02.129344857 +0200 @@ -1,3 +1,4 @@ addFilter("libtommath-examples\.[^:]*: W: shlib-policy-nonversioned-dir") addFilter("libtommath-examples\.[^:]*: W: shlib-policy-missing-lib") +addFilter("libtommath-examples\.[^:]*: W: package-with-huge-docs")
