Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package otpclient for openSUSE:Factory checked in at 2023-07-03 17:44:27 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/otpclient (Old) and /work/SRC/openSUSE:Factory/.otpclient.new.13546 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "otpclient" Mon Jul 3 17:44:27 2023 rev:28 rq:1096606 version:3.1.9 Changes: -------- --- /work/SRC/openSUSE:Factory/otpclient/otpclient.changes 2023-06-16 16:55:25.405912464 +0200 +++ /work/SRC/openSUSE:Factory/.otpclient.new.13546/otpclient.changes 2023-07-03 17:44:47.157425257 +0200 @@ -1,0 +2,7 @@ +Mon Jul 3 14:28:57 UTC 2023 - Paolo Stivanin <i...@paolostivanin.com> + +- Update to 3.1.9: + * Fix db corruption when symbols are used (#301). + * Fix crash when user changes db multiple times. + +------------------------------------------------------------------- Old: ---- v3.1.8.tar.gz v3.1.8.tar.gz.asc New: ---- v3.1.9.tar.gz v3.1.9.tar.gz.asc ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ otpclient.spec ++++++ --- /var/tmp/diff_new_pack.dCPYbg/_old 2023-07-03 17:44:47.869429449 +0200 +++ /var/tmp/diff_new_pack.dCPYbg/_new 2023-07-03 17:44:47.873429473 +0200 @@ -18,7 +18,7 @@ %define uclname OTPClient Name: otpclient -Version: 3.1.8 +Version: 3.1.9 Release: 0 Summary: Simple GTK+ client for managing TOTP and HOTP License: GPL-3.0-or-later ++++++ v3.1.8.tar.gz -> v3.1.9.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/OTPClient-3.1.8/CMakeLists.txt new/OTPClient-3.1.9/CMakeLists.txt --- old/OTPClient-3.1.8/CMakeLists.txt 2023-06-14 11:53:50.000000000 +0200 +++ new/OTPClient-3.1.9/CMakeLists.txt 2023-07-03 15:34:59.000000000 +0200 @@ -1,5 +1,5 @@ cmake_minimum_required(VERSION 3.16) -project(OTPClient VERSION "3.1.8" LANGUAGES "C") +project(OTPClient VERSION "3.1.9" LANGUAGES "C") include(GNUInstallDirs) configure_file("src/common/version.h.in" "version.h") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/OTPClient-3.1.8/data/com.github.paolostivanin.OTPClient.appdata.xml new/OTPClient-3.1.9/data/com.github.paolostivanin.OTPClient.appdata.xml --- old/OTPClient-3.1.8/data/com.github.paolostivanin.OTPClient.appdata.xml 2023-06-14 11:53:50.000000000 +0200 +++ new/OTPClient-3.1.9/data/com.github.paolostivanin.OTPClient.appdata.xml 2023-07-03 15:34:59.000000000 +0200 @@ -84,6 +84,15 @@ </content_rating> <releases> + <release version="3.1.9" date="2023-07-03"> + <description> + <p>OTPClient 3.1.9 brings a couple of fixes:</p> + <ul> + <li>fix db corruption (#301)</li> + <li>fix crash when user changes db multiple times</li> + </ul> + </description> + </release> <release version="3.1.8" date="2023-06-14"> <description> <p>OTPClient 3.1.8 brings a single fix</p> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/OTPClient-3.1.8/src/change-file-cb.c new/OTPClient-3.1.9/src/change-file-cb.c --- old/OTPClient-3.1.8/src/change-file-cb.c 2023-06-14 11:53:50.000000000 +0200 +++ new/OTPClient-3.1.9/src/change-file-cb.c 2023-07-03 15:34:59.000000000 +0200 @@ -62,7 +62,7 @@ default: break; } - gtk_widget_destroy (diag_changefile); + gtk_widget_hide (diag_changefile); return res; } \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/OTPClient-3.1.8/src/common/andotp.c new/OTPClient-3.1.9/src/common/andotp.c --- old/OTPClient-3.1.8/src/common/andotp.c 2023-06-14 11:53:50.000000000 +0200 +++ new/OTPClient-3.1.9/src/common/andotp.c 2023-07-03 15:34:59.000000000 +0200 @@ -239,7 +239,7 @@ g_set_error (&err, generic_error_gquark (), GENERIC_ERRCODE, "couldn't dump json data"); goto end; } - gsize json_data_size = g_utf8_strlen (json_data, -1); + gsize json_data_size = strlen (json_data); // https://github.com/andOTP/andOTP/blob/bb01bbd242ace1a2e2620263d950d9852772f051/app/src/main/java/org/shadowice/flocke/andotp/Utilities/Constants.java#L109-L110 guint32 le_iterations = (g_random_int () % (PBKDF2_MAX_BACKUP_ITERATIONS - PBKDF2_MIN_BACKUP_ITERATIONS + 1)) + PBKDF2_MIN_BACKUP_ITERATIONS; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/OTPClient-3.1.8/src/common/common.c new/OTPClient-3.1.9/src/common/common.c --- old/OTPClient-3.1.8/src/common/common.c 2023-06-14 11:53:50.000000000 +0200 +++ new/OTPClient-3.1.9/src/common/common.c 2023-07-03 15:34:59.000000000 +0200 @@ -101,7 +101,7 @@ } } - guint32 hash = jenkins_one_at_a_time_hash (tmp_string, g_utf8_strlen (tmp_string, -1) + 1); + guint32 hash = jenkins_one_at_a_time_hash (tmp_string, strlen (tmp_string) + 1); gcry_free (tmp_string); @@ -111,8 +111,8 @@ gchar * secure_strdup (const gchar *src) { - gchar *sec_buf = gcry_calloc_secure (g_utf8_strlen (src, -1) + 1, 1); - memcpy (sec_buf, src, g_utf8_strlen (src, -1) + 1); + gchar *sec_buf = gcry_calloc_secure (strlen (src) + 1, 1); + memcpy (sec_buf, src, strlen (src) + 1); return sec_buf; } @@ -124,7 +124,7 @@ if (g_utf8_strlen (str, -1) == 0) { return NULL; } - gchar *sec_buf = gcry_calloc_secure (g_utf8_strlen (str, -1) + 1, 1); + gchar *sec_buf = gcry_calloc_secure (strlen (str) + 1, 1); int pos = 0; for (int i = 0; str[i]; i++) { if (str[i] != ' ') { @@ -132,7 +132,7 @@ } } sec_buf[pos] = '\0'; - gchar *secubf_newpos = (gchar *)gcry_realloc (sec_buf, g_utf8_strlen(sec_buf, -1) + 1); + gchar *secubf_newpos = (gchar *)gcry_realloc (sec_buf, strlen (sec_buf) + 1); return secubf_newpos; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/OTPClient-3.1.8/src/common/freeotp.c new/OTPClient-3.1.9/src/common/freeotp.c --- old/OTPClient-3.1.8/src/common/freeotp.c 2023-06-14 11:53:50.000000000 +0200 +++ new/OTPClient-3.1.9/src/common/freeotp.c 2023-07-03 15:34:59.000000000 +0200 @@ -45,7 +45,7 @@ json_array_foreach (json_db_data, index, db_obj) { gchar *uri = get_otpauth_uri (NULL, db_obj); - fwrite (uri, g_utf8_strlen (uri, -1), 1, fp); + fwrite (uri, strlen (uri), 1, fp); g_free (uri); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/OTPClient-3.1.8/src/db-misc.c new/OTPClient-3.1.9/src/db-misc.c --- old/OTPClient-3.1.8/src/db-misc.c 2023-06-14 11:53:50.000000000 +0200 +++ new/OTPClient-3.1.9/src/db-misc.c 2023-07-03 15:34:59.000000000 +0200 @@ -230,7 +230,7 @@ return (gpointer)derived_key; } - gsize input_data_len = g_utf8_strlen (in_memory_json, -1) + 1; + gsize input_data_len = strlen (in_memory_json) + 1; guchar *enc_buffer = g_malloc0 (input_data_len); gcry_cipher_hd_t hd = open_cipher_and_set_data (derived_key, header_data->iv, IV_SIZE); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/OTPClient-3.1.8/src/parse-uri.c new/OTPClient-3.1.9/src/parse-uri.c --- old/OTPClient-3.1.8/src/parse-uri.c 2023-06-14 11:53:50.000000000 +0200 +++ new/OTPClient-3.1.9/src/parse-uri.c 2023-07-03 15:34:59.000000000 +0200 @@ -153,7 +153,7 @@ { gchar **tokens = g_strsplit (modified_uri, "?", -1); gchar *escaped_issuer_and_label = g_uri_unescape_string (tokens[0], NULL); - gchar *mod_uri_copy_utf8 = g_utf8_offset_to_pointer(modified_uri, g_utf8_strlen (tokens[0], -1) + 1); + gchar *mod_uri_copy_utf8 = g_utf8_offset_to_pointer (modified_uri, g_utf8_strlen (tokens[0], -1) + 1); g_strfreev (tokens); tokens = g_strsplit (escaped_issuer_and_label, ":", -1);