Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package glusterfs for openSUSE:Factory 
checked in at 2023-07-17 19:22:54
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/glusterfs (Old)
 and      /work/SRC/openSUSE:Factory/.glusterfs.new.3193 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "glusterfs"

Mon Jul 17 19:22:54 2023 rev:37 rq:1098829 version:11.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/glusterfs/glusterfs.changes      2023-06-19 
22:50:04.541391151 +0200
+++ /work/SRC/openSUSE:Factory/.glusterfs.new.3193/glusterfs.changes    
2023-07-17 19:23:04.465663744 +0200
@@ -1,0 +2,5 @@
+Wed Jul  5 09:28:08 UTC 2023 - Jan Engelhardt <jeng...@inai.de>
+
+- Add 0001-glusterfs-fix-heap-buffer-overflow-on-startup.patch
+
+-------------------------------------------------------------------

New:
----
  0001-glusterfs-fix-heap-buffer-overflow-on-startup.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ glusterfs.spec ++++++
--- /var/tmp/diff_new_pack.HN2kJD/_old  2023-07-17 19:23:05.165667799 +0200
+++ /var/tmp/diff_new_pack.HN2kJD/_new  2023-07-17 19:23:05.169667822 +0200
@@ -28,6 +28,7 @@
 #Git-Clone:    https://github.com/fvzwieten/lsgvt
 Source:         
https://download.gluster.org/pub/gluster/glusterfs/11/%version/glusterfs-%version.tar.gz
 Patch1:         0001-socket-only-issue-IPPROTO_IPV6-setsockopt-calls-on-A.patch
+Patch2:         0001-glusterfs-fix-heap-buffer-overflow-on-startup.patch
 BuildRequires:  acl-devel
 BuildRequires:  autoconf
 BuildRequires:  automake
@@ -150,7 +151,6 @@
 %build
 %define _lto_cflags %nil
 ./autogen.sh
-# https://github.com/gluster/glusterfs/issues/3947
 %configure \
        --without-tcmalloc \
        --disable-linux-io_uring \

++++++ 0001-glusterfs-fix-heap-buffer-overflow-on-startup.patch ++++++
>From 5d0533d0858194ed6d365f1080db7ab10d0e3d11 Mon Sep 17 00:00:00 2001
From: Jan Engelhardt <jeng...@inai.de>
Date: Wed, 5 Jul 2023 18:15:22 +0900
Subject: [PATCH] glusterfs: fix heap-buffer-overflow on startup
References: https://github.com/gluster/glusterfs/issues/4192

==4418==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x613000000190
at pc 0x7f028cd2341c bp 0x7ffd9c5ba7e0 sp 0x7ffd9c5ba7d8
WRITE of size 8 at 0x613000000190 thread T0
    f0 in mem_get_pool_list ~/libglusterfs/src/mem-pool.c:786

0x613000000190 is located 0 bytes after 336-byte region 
[0x613000000040,0x613000000190)
allocated by thread T0 here:
    f0 in malloc (/usr/lib64/libasan.so.8+0xdc04f) (BuildId: 
44194dcf14c212b57346030492309d59d5379ae1)
    f1 in __gf_default_malloc glusterfs/mem-pool.h:112
    f2 in mem_get_pool_list ~/libglusterfs/src/mem-pool.c:778

``NPOOLS-1`` is just wrong. ``per_thread_pool_list_t`` does not include one free
``per_thread_pool_t``.

Fixes: https://github.com/gluster/glusterfs/issues/4192
Fixes: v11dev-211-g1cfff6e6ec ("Use flexible array members (#3411)")
Signed-off-by: Jan Engelhardt <jeng...@inai.de>
---
 libglusterfs/src/mem-pool.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/libglusterfs/src/mem-pool.c b/libglusterfs/src/mem-pool.c
index f053fdceae..e258758158 100644
--- a/libglusterfs/src/mem-pool.c
+++ b/libglusterfs/src/mem-pool.c
@@ -589,8 +589,7 @@ mem_pools_preinit(void)
     }
 
     pool_list_size = sizeof(per_thread_pool_list_t) +
-                     sizeof(per_thread_pool_t) * (NPOOLS - 1);
-
+                     sizeof(per_thread_pool_t) * NPOOLS;
     init_done = GF_MEMPOOL_INIT_EARLY;
 }
 
-- 
2.41.0

Reply via email to