Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package crash for openSUSE:Factory checked
in at 2023-08-17 19:42:56
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/crash (Old)
and /work/SRC/openSUSE:Factory/.crash.new.1766 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "crash"
Thu Aug 17 19:42:56 2023 rev:188 rq:1104092 version:8.0.3
Changes:
--------
--- /work/SRC/openSUSE:Factory/crash/crash.changes 2023-05-05
15:57:25.324132210 +0200
+++ /work/SRC/openSUSE:Factory/.crash.new.1766/crash.changes 2023-08-17
19:43:07.322741854 +0200
@@ -1,0 +2,14 @@
+Tue Aug 15 18:47:26 UTC 2023 - David Mair <dm...@suse.com>
+
+- crash has it's own definitions of some glibc functions, including
+ strlcpy(), length limited string copy. In glibc 2.38 the second
+ argument is const char *, in crash it is char *. The argument is
+ the source string to copy from and shouldn't be modified. crash
+ uses the glibc version in some places, it's own in others and the
+ declarations are incompatible resulting in build errors. Added
+ * crash-fix-glibc-redefs.patch
+ to make the crash declaration of strlcpy() match the glibc 2.38
+ version. It may also need to be made product version conditional
+ but it should fix Factory.
+
+-------------------------------------------------------------------
New:
----
crash-fix-glibc-redefs.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ crash.spec ++++++
--- /var/tmp/diff_new_pack.fm9c7s/_old 2023-08-17 19:43:10.822748402 +0200
+++ /var/tmp/diff_new_pack.fm9c7s/_new 2023-08-17 19:43:10.870748491 +0200
@@ -92,7 +92,8 @@
Patch23:
%{name}-SLE15-SP1-With-Linux-4.19-rc1-up-MAX_PHYSMEM_BITS-to-128TB.patch
Patch24:
%{name}-SLE15-SP1-Fix-for-PPC64-kernel-virtual-address-translation-in.patch
Patch30: %{name}-enable-zstd-support.patch
-Patch31: %{name}-extensions-rule-for-defs.patch
+Patch31: %{name}-fix-glibc-redefs.patch
+Patch32: %{name}-extensions-rule-for-defs.patch
Patch90: %{name}-sial-ps-2.6.29.diff
Patch99: %{name}-usrmerge.patch
BuildRequires: bison
@@ -256,6 +257,7 @@
done
%patch31 -p1
+%patch32 -p1
## SIAL patches
cd sial-scripts-%{scripts_version}
++++++ crash-fix-glibc-redefs.patch ++++++
Index: b/defs.h
===================================================================
--- a/defs.h
+++ b/defs.h
@@ -5514,7 +5514,7 @@ uint32_t swap32(uint32_t, int);
uint64_t swap64(uint64_t, int);
ulong *get_cpumask_buf(void);
int make_cpumask(char *, ulong *, int, int *);
-size_t strlcpy(char *, char *, size_t);
+size_t strlcpy(char *, const char *, size_t);
struct rb_node *rb_first(struct rb_root *);
struct rb_node *rb_parent(struct rb_node *, struct rb_node *);
struct rb_node *rb_right(struct rb_node *, struct rb_node *);
Index: b/tools.c
===================================================================
--- a/tools.c
+++ b/tools.c
@@ -6795,7 +6795,7 @@ make_cpumask_error:
* always be NULL-terminated.
*/
size_t
-strlcpy(char *dest, char *src, size_t size)
+strlcpy(char *dest, const char *src, size_t size)
{
size_t ret = strlen(src);
