Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package GraphicsMagick for openSUSE:Factory checked in at 2023-08-30 10:17:59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/GraphicsMagick (Old) and /work/SRC/openSUSE:Factory/.GraphicsMagick.new.1766 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "GraphicsMagick" Wed Aug 30 10:17:59 2023 rev:86 rq:1107391 version:1.3.41 Changes: -------- --- /work/SRC/openSUSE:Factory/GraphicsMagick/GraphicsMagick.changes 2023-08-12 15:05:43.786324380 +0200 +++ /work/SRC/openSUSE:Factory/.GraphicsMagick.new.1766/GraphicsMagick.changes 2023-08-30 10:19:18.769641565 +0200 @@ -1,0 +2,66 @@ +Mon Aug 28 12:41:40 UTC 2023 - pgaj...@suse.com + +- fix regression in 1.3.41 + https://sourceforge.net/p/graphicsmagick/bugs/722/ +- added patches + fix 17179:91afa18a6161 + + GraphicsMagick-fix-regression-NULL-instead-of-empty-string.patch + fix 17180:bb42cd90ce6f + + GraphicsMagick-name-key-return-input-file-base-name.patch + +------------------------------------------------------------------- +Thu Aug 24 11:54:37 UTC 2023 - pgaj...@suse.com + +- version update to 1.3.41 + Bug fixes: + * Blob: Immediately reject attempts to write blobs to formats which + can not support blobs. + * TranslateTextEx(): An empty string argument should return an empty + string rather than a NULL string. + * SetImageAttribute(): Fix bounds issue when concatenating string. + * JPEG: Do not set image resolution if the values provided are outside + of the valid range. + * Fixes for NaN when reading formats based on floating point. + * HEIF: Fix reading images with rotation/transformation. + * BMP: Do not decode primaries or gamma unless colorspace is + LCS_CALIBRATED_RGB. Add/correct bmp_info.size "biSize" logic which + decides if header chunks are present (or invalid). + * MNG: Fixes for resizing using X_method 5. + * GM command (convert, montage, mogrify): Many command-line parser + fixes/checks for invalid command line syntax which causes unexpected + behavior, or core dumps. + + * TopoL: Given that a writer is now provided, issues found in the + reader (and writer) due to continual fuzz-testing have been fixed, + as encountered. + * GetImageClippingPathAttribute(): Check for and use clipping path + name (ID=2999) to get the real attribute name. + * ReadIPTCProfile(): Fix malformed IPTC data parsing. + New Features: + * TopoL: Now provides a writer. + * WPG: Now provides a writer. + * gm batch: Implement simple Test Anything Protocol (TAP) test + counting and "ok N"/"not ok N" messaging. + * TIFF: Support '-define tiff:photometric=minisblack' and '-define + tiff:photometric=miniswhite' to be able to adjust the sense used + when writing bilevel TIFF images. + * TIFF: Require that TIFFTAG_EXTRASAMPLES be used appropriately to + indicate the intention of extra channels. + * utilities/tests/gen-tiff-images/genimages: Script for writing (and + then reading) thousands (5568 permutations) of TIFF format variants. + * EXIF and PNG: Retrieve image orientation from EXIF (if present) and + store in image. + * HEIF: Retrieve image orientation from EXIF and store in image. + Behavior Changes: + * The ability to extend existing image attribute text by calling + SetImageAttribute() multiple times with the same key is now + deprecated, and will soon be removed. In the mean time, the + annoying message "SetImageAttribute: Extending attribute value text + is deprecated!" is printed to the standard error output to help + expose code which is using this feature. +- modified patches + % GraphicsMagick-disable-insecure-coders.patch (refreshed) +- deleted patches + - strlcpy-wrong-sizing.patch (upstreamed) + +------------------------------------------------------------------- Old: ---- GraphicsMagick-1.3.40.tar.xz strlcpy-wrong-sizing.patch New: ---- GraphicsMagick-1.3.41.tar.xz GraphicsMagick-fix-regression-NULL-instead-of-empty-string.patch GraphicsMagick-name-key-return-input-file-base-name.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ GraphicsMagick.spec ++++++ --- /var/tmp/diff_new_pack.ogZoTo/_old 2023-08-30 10:19:20.561705519 +0200 +++ /var/tmp/diff_new_pack.ogZoTo/_new 2023-08-30 10:19:20.569705805 +0200 @@ -24,7 +24,7 @@ %define pp_so_ver 12 %define wand_so_ver 2 Name: GraphicsMagick -Version: 1.3.40 +Version: 1.3.41 Release: 0 Summary: Viewer and Converter for Images License: MIT @@ -33,7 +33,10 @@ Source: https://downloads.sourceforge.net/project/graphicsmagick/graphicsmagick/%{version}/%{name}-%{version}.tar.xz Patch0: GraphicsMagick-perl-linkage.patch Patch1: GraphicsMagick-disable-insecure-coders.patch -Patch2: strlcpy-wrong-sizing.patch +# 17179:91afa18a6161 +Patch2: GraphicsMagick-fix-regression-NULL-instead-of-empty-string.patch +# 17180:bb42cd90ce6f +Patch3: GraphicsMagick-name-key-return-input-file-base-name.patch BuildRequires: cups-client BuildRequires: dcraw BuildRequires: gcc-c++ ++++++ GraphicsMagick-1.3.40.tar.xz -> GraphicsMagick-1.3.41.tar.xz ++++++ ++++ 24893 lines of diff (skipped) ++++++ GraphicsMagick-disable-insecure-coders.patch ++++++ --- /var/tmp/diff_new_pack.ogZoTo/_old 2023-08-30 10:19:21.901753342 +0200 +++ /var/tmp/diff_new_pack.ogZoTo/_new 2023-08-30 10:19:21.905753484 +0200 @@ -1,7 +1,7 @@ -Index: GraphicsMagick-1.3.40/coders/pdf.c +Index: GraphicsMagick-1.3.41/coders/pdf.c =================================================================== ---- GraphicsMagick-1.3.40.orig/coders/pdf.c -+++ GraphicsMagick-1.3.40/coders/pdf.c +--- GraphicsMagick-1.3.41.orig/coders/pdf.c ++++ GraphicsMagick-1.3.41/coders/pdf.c @@ -499,7 +499,7 @@ ModuleExport void RegisterPDFImage(void) entry->seekable_stream=True; entry->description="Encapsulated Portable Document Format"; @@ -20,10 +20,10 @@ (void) RegisterMagickInfo(entry); } -Index: GraphicsMagick-1.3.40/coders/ps.c +Index: GraphicsMagick-1.3.41/coders/ps.c =================================================================== ---- GraphicsMagick-1.3.40.orig/coders/ps.c -+++ GraphicsMagick-1.3.40/coders/ps.c +--- GraphicsMagick-1.3.41.orig/coders/ps.c ++++ GraphicsMagick-1.3.41/coders/ps.c @@ -456,7 +456,7 @@ ModuleExport void RegisterPSImage(void) entry->adjoin=False; entry->description="Adobe Encapsulated PostScript Interchange format"; @@ -69,10 +69,10 @@ (void) RegisterMagickInfo(entry); } -Index: GraphicsMagick-1.3.40/coders/ps2.c +Index: GraphicsMagick-1.3.41/coders/ps2.c =================================================================== ---- GraphicsMagick-1.3.40.orig/coders/ps2.c -+++ GraphicsMagick-1.3.40/coders/ps2.c +--- GraphicsMagick-1.3.41.orig/coders/ps2.c ++++ GraphicsMagick-1.3.41/coders/ps2.c @@ -252,7 +252,7 @@ ModuleExport void RegisterPS2Image(void) entry->seekable_stream=True; entry->description="Adobe Level II Encapsulated PostScript"; @@ -91,10 +91,10 @@ (void) RegisterMagickInfo(entry); } -Index: GraphicsMagick-1.3.40/coders/ps3.c +Index: GraphicsMagick-1.3.41/coders/ps3.c =================================================================== ---- GraphicsMagick-1.3.40.orig/coders/ps3.c -+++ GraphicsMagick-1.3.40/coders/ps3.c +--- GraphicsMagick-1.3.41.orig/coders/ps3.c ++++ GraphicsMagick-1.3.41/coders/ps3.c @@ -394,7 +394,7 @@ ModuleExport void RegisterPS3Image(void) entry->description="Adobe Level III Encapsulated PostScript"; entry->seekable_stream=MagickTrue; @@ -113,10 +113,10 @@ (void) RegisterMagickInfo(entry); } -Index: GraphicsMagick-1.3.40/config/delegates.mgk.in +Index: GraphicsMagick-1.3.41/config/delegates.mgk.in =================================================================== ---- GraphicsMagick-1.3.40.orig/config/delegates.mgk.in -+++ GraphicsMagick-1.3.40/config/delegates.mgk.in +--- GraphicsMagick-1.3.41.orig/config/delegates.mgk.in ++++ GraphicsMagick-1.3.41/config/delegates.mgk.in @@ -76,27 +76,27 @@ <delegate decode="dot" command='"@DOTDecodeDelegate@" -Tps "%i" -o "%o"' /> <delegate decode="dvi" command='"@DVIDecodeDelegate@" -q -o "%o" "%i"' /> @@ -170,11 +170,11 @@ <delegate decode="ps" encode="print" mode="encode" command='"@PrintDelegate@" "%i"' /> <!-- Read HTML file --> <delegate decode="shtml" command='"@HTMLDecodeDelegate@" -U -o "%o" "%i"' /> -Index: GraphicsMagick-1.3.40/Makefile.in +Index: GraphicsMagick-1.3.41/Makefile.in =================================================================== ---- GraphicsMagick-1.3.40.orig/Makefile.in -+++ GraphicsMagick-1.3.40/Makefile.in -@@ -4326,7 +4326,6 @@ TESTS_TESTS = \ +--- GraphicsMagick-1.3.41.orig/Makefile.in ++++ GraphicsMagick-1.3.41/Makefile.in +@@ -4336,7 +4336,6 @@ TESTS_TESTS = \ tests/rwfile.tap \ tests/rwfile_sized.tap \ tests/rwfile_miff.tap \ @@ -182,16 +182,16 @@ tests/rwfile_deep.tap TESTS_EXTRA_DIST = \ -Index: GraphicsMagick-1.3.40/tests/rwblob.tap +Index: GraphicsMagick-1.3.41/tests/rwblob.tap =================================================================== ---- GraphicsMagick-1.3.40.orig/tests/rwblob.tap -+++ GraphicsMagick-1.3.40/tests/rwblob.tap +--- GraphicsMagick-1.3.41.orig/tests/rwblob.tap ++++ GraphicsMagick-1.3.41/tests/rwblob.tap @@ -10,7 +10,7 @@ rwblob=./rwblob check_types='bilevel gray pallette truecolor' # Number of tests we plan to run --test_plan_fn 209 -+test_plan_fn 201 +-test_plan_fn 213 ++test_plan_fn 205 # ART format for type in ${check_types} @@ -214,16 +214,16 @@ # FAX format for type in ${check_types} do -Index: GraphicsMagick-1.3.40/tests/rwfile.tap +Index: GraphicsMagick-1.3.41/tests/rwfile.tap =================================================================== ---- GraphicsMagick-1.3.40.orig/tests/rwfile.tap -+++ GraphicsMagick-1.3.40/tests/rwfile.tap +--- GraphicsMagick-1.3.41.orig/tests/rwfile.tap ++++ GraphicsMagick-1.3.41/tests/rwfile.tap @@ -12,7 +12,7 @@ check_types='bilevel gray pallette truec check_types_noone='bilevel gray pallette truecolor' # Number of tests we plan to run --test_plan_fn 818 # 820 -+test_plan_fn 768 # 820 +-test_plan_fn 838 # 828 ++test_plan_fn 788 # 828 # ART format for type in ${check_types} ++++++ GraphicsMagick-fix-regression-NULL-instead-of-empty-string.patch ++++++ diff -r 12de9f7ed9ac -r 91afa18a6161 magick/utility.c --- a/magick/utility.c Tue Aug 22 17:21:30 2023 -0500 +++ b/magick/utility.c Sun Aug 27 13:08:31 2023 -0500 @@ -6218,8 +6218,9 @@ % % A description of each parameter follows: % -% o translated_text: Method TranslateText returns the translated -% text string. +% o translated_text: Method TranslateText returns a new allocation +% containing the translated text string. If the translated text +% string would be empty, a NULL pointer is returned instead. % % o image_info: The imageInfo (may be NULL!). % @@ -6307,8 +6308,9 @@ % % A description of each parameter follows: % -% o translated_text: Method TranslateText returns the translated -% text string. +% o translated_text: Method TranslateTextEx returns a new allocation +% containing the translated text string. If the translated text +% string would be empty, a NULL pointer is returned instead. % % o image_info: The imageInfo (may be NULL!). % @@ -6345,23 +6347,19 @@ offset; assert(image != (Image *) NULL); - if (formatted_text == (const char *) NULL) + if ((formatted_text == (const char *) NULL) || (*formatted_text == '\0')) return((char *) NULL); - if (*formatted_text == '\0') - return AcquireString(formatted_text); text=(char *) formatted_text; /* Translate any embedded format characters. */ - length=strlen(text)+MaxTextExtent; - translated_text=MagickAllocateMemory(char *,length); + length=strlen(text); + translated_text=MagickAllocateMemory(char *,length+MaxTextExtent); if (translated_text == (char *) NULL) return NULL; - /* - FIXME: Overlapping memory detected here where memory should not be overlapping. - */ - (void) strlcpy(translated_text,text,length); - /* (void) memmove(translated_text,text,strlen(text)+1); */ + (void) memcpy(translated_text,text,length); + translated_text[length]='\0'; + length=length+MaxTextExtent; p=text; for (q=translated_text; *p != '\0'; p++) { ++++++ GraphicsMagick-name-key-return-input-file-base-name.patch ++++++ diff -r 91afa18a6161 -r bb42cd90ce6f magick/attribute.c --- a/magick/attribute.c Sun Aug 27 13:08:31 2023 -0500 +++ b/magick/attribute.c Sun Aug 27 19:51:44 2023 -0500 @@ -2665,6 +2665,8 @@ { if (LocaleNCompare("name",key,2) == 0) { + /* What should this really be? */ + GetPathComponent(image->magick_filename,BasePath,filename); (void) strlcpy(attribute,filename,MaxTextExtent); break; }
