Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package konsole for openSUSE:Factory checked in at 2023-09-06 18:55:59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/konsole (Old) and /work/SRC/openSUSE:Factory/.konsole.new.1766 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "konsole" Wed Sep 6 18:55:59 2023 rev:171 rq:1108941 version:23.08.0 Changes: -------- --- /work/SRC/openSUSE:Factory/konsole/konsole.changes 2023-08-31 13:45:10.619063073 +0200 +++ /work/SRC/openSUSE:Factory/.konsole.new.1766/konsole.changes 2023-09-06 18:56:59.504988783 +0200 @@ -1,0 +2,6 @@ +Mon Sep 4 17:33:34 UTC 2023 - Christophe Marin <christo...@krop.fr> + +- Add upstream crash fix (kde#473043) + * 0001-Fix-crashes-in-testTerminalInterface.patch + +------------------------------------------------------------------- New: ---- 0001-Fix-crashes-in-testTerminalInterface.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ konsole.spec ++++++ --- /var/tmp/diff_new_pack.DhMEH3/_old 2023-09-06 18:57:01.193048959 +0200 +++ /var/tmp/diff_new_pack.DhMEH3/_new 2023-09-06 18:57:01.197049102 +0200 @@ -28,6 +28,8 @@ Source1: https://download.kde.org/stable/release-service/%{version}/src/%{name}-%{version}.tar.xz.sig Source2: applications.keyring %endif +# PATCH-FIX-UPSTREAM +Patch0: 0001-Fix-crashes-in-testTerminalInterface.patch Source3: Root_Shell.profile Source4: konsolesu.desktop Source21: utilities-terminal-su-16.png ++++++ 0001-Fix-crashes-in-testTerminalInterface.patch ++++++ >From d1393cf591a17230b263b55d2ce890e3020f13ef Mon Sep 17 00:00:00 2001 From: Antonio Rojas <aro...@archlinux.org> Date: Thu, 31 Aug 2023 23:13:58 +0000 Subject: [PATCH] Fix crashes in testTerminalInterface Certain user profiles crash here from /lib/x86_64-linux-gnu/libQt5Widgets.so.5 this=0x5555557c8da0, name=..., visible=true) at src/konsole/src/session/SessionController.cpp:2206 mode=1) at src/konsole/src/Screen.cpp:2395 at src/konsole/src/Vt102Emulation.cpp:1071 this=0x555555dc2a30, cc=7) BUG: 473043 (cherry picked from commit 5bda57405e2f64e92a1142fb0898ff8ba5fafd3c) --- src/session/SessionController.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/session/SessionController.cpp b/src/session/SessionController.cpp index 1070c962f..914793402 100644 --- a/src/session/SessionController.cpp +++ b/src/session/SessionController.cpp @@ -2191,5 +2191,11 @@ bool SessionController::isValid() const void SessionController::setVisible(QString name, bool visible) { + /* For certain user profiles, testTerminalInterface crashes + in QAction::setVisible() without this check. + */ + if (!actionCollection()->action(name)) { + return; + } actionCollection()->action(name)->setVisible(visible); } -- 2.42.0
