Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package qpwgraph for openSUSE:Factory checked in at 2023-10-30 22:10:19 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/qpwgraph (Old) and /work/SRC/openSUSE:Factory/.qpwgraph.new.17445 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "qpwgraph" Mon Oct 30 22:10:19 2023 rev:19 rq:1121013 version:0.5.3 Changes: -------- --- /work/SRC/openSUSE:Factory/qpwgraph/qpwgraph.changes 2023-07-26 13:25:02.756398697 +0200 +++ /work/SRC/openSUSE:Factory/.qpwgraph.new.17445/qpwgraph.changes 2023-10-30 22:10:31.595643869 +0100 @@ -1,0 +2,13 @@ +Sun Oct 29 16:06:59 UTC 2023 - Dirk Müller <dmuel...@suse.com> + +- update to 0.5.3: + * Added user contributed documentation: How To Use The + Patchbay. + * Fix condition for saving node name aliases. + * Ctrl+left or middle-button click-dragging for panning, is now + a lot smoother, hopefully. + * Click-dragging with the mouse middle-button is for panning + only, not to start a selection anymore. + * Add Ctrl+Q to Quit action + +------------------------------------------------------------------- Old: ---- qpwgraph-v0.5.1.tar.bz2 New: ---- qpwgraph-v0.5.3.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ qpwgraph.spec ++++++ --- /var/tmp/diff_new_pack.s8rTKZ/_old 2023-10-30 22:10:32.231667332 +0100 +++ /var/tmp/diff_new_pack.s8rTKZ/_new 2023-10-30 22:10:32.231667332 +0100 @@ -17,7 +17,7 @@ Name: qpwgraph -Version: 0.5.1 +Version: 0.5.3 Release: 0 Summary: PipeWire Graph Qt GUI Interface License: GPL-2.0-or-later ++++++ qpwgraph-v0.5.1.tar.bz2 -> qpwgraph-v0.5.3.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/CMakeLists.txt new/qpwgraph-v0.5.3/CMakeLists.txt --- old/qpwgraph-v0.5.1/CMakeLists.txt 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/CMakeLists.txt 2023-09-08 11:02:03.000000000 +0200 @@ -1,7 +1,7 @@ cmake_minimum_required (VERSION 3.15) project(qpwgraph - VERSION 0.5.1 + VERSION 0.5.3 DESCRIPTION "A PipeWire Graph Qt GUI Interface" HOMEPAGE_URL "https://gitlab.freedesktop.org/rncbc/qpwgraph"; LANGUAGES C CXX) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/ChangeLog new/qpwgraph-v0.5.3/ChangeLog --- old/qpwgraph-v0.5.1/ChangeLog 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/ChangeLog 2023-09-08 11:02:03.000000000 +0200 @@ -2,6 +2,21 @@ -------------------------------------------- +0.5.3 2023-09-08 An end-of-summer'23 release. + +- Added user contributed documentation: How To Use The Patchbay. +- Fix condition for saving node name aliases. + + +0.5.2 2023-08-05 A high-summer'23 release. + +- Ctrl+left or middle-button click-dragging for panning, is now a + lot smoother, hopefully. +- Click-dragging with the mouse middle-button is for panning only, + not to start a selection anymore. +- Add Ctrl+Q to Quit action + + 0.5.1 2023-07-17 A summer'23 hot-fix release. - Fixed segfault on initialization that was affecting Qt5 builds. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/README.md new/qpwgraph-v0.5.3/README.md --- old/qpwgraph-v0.5.1/README.md 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/README.md 2023-09-08 11:02:03.000000000 +0200 @@ -1,6 +1,6 @@ # qpwgraph - A PipeWire Graph Qt GUI Interface - + **qpwgraph** is a graph manager dedicated to [PipeWire](https://pipewire.org), using the [Qt C++ framework](https://qt.io), based and pretty much like the @@ -44,13 +44,17 @@ Enjoy. +## Documentation + + [How To Use The Patchbay](docs/qpwgraph_patchbay-user_manual.md) + ## License **qpwgraph** is free, open-source software, distributed under the terms of the GNU General Public License ([GPL](https://www.gnu.org/copyleft/gpl.html)) version 2 or later. - ## Copyright Copyright (C) 2021-2023, rncbc aka Rui Nuno Capela. All rights reserved. + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/debian/changelog new/qpwgraph-v0.5.3/debian/changelog --- old/qpwgraph-v0.5.1/debian/changelog 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/debian/changelog 2023-09-08 11:02:03.000000000 +0200 @@ -1,3 +1,15 @@ +qpwgraph (0.5.3-31.1) unstable; urgency=low + + * A end-of-summer'23 release. + + -- Rui Nuno Capela <rn...@rncbc.org> Fri, 8 Sep 2023 18:00:00 +0100 + +qpwgraph (0.5.2-30.1) unstable; urgency=low + + * A high-summer'23 release. + + -- Rui Nuno Capela <rn...@rncbc.org> Sat, 5 Aug 2023 16:00:00 +0100 + qpwgraph (0.5.1-29.1) unstable; urgency=low * A summer'23 hot-fix release. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/debian/control new/qpwgraph-v0.5.3/debian/control --- old/qpwgraph-v0.5.1/debian/control 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/debian/control 2023-09-08 11:02:03.000000000 +0200 @@ -1,6 +1,6 @@ Source: qpwgraph -Section: contrib/sound -Priority: extra +Section: sound +Priority: optional Maintainer: Rui Nuno Capela <rn...@rncbc.org> Build-Depends: debhelper (>= 11), cmake, pkg-config, build-essential, g++ (>= 8), g++-11 | g++-10 | g++-9 | g++-8, @@ -9,9 +9,11 @@ qt6-tools-dev (>= 6.1) | qttools5-dev (>= 5.1), qt6-tools-dev-tools (>= 6.1) | qttools5-dev-tools (>= 5.1), qt6-l10n-tools (>= 6.1) | base-files (<< 12), - qt6-svg-dev | libqt6svg6-dev | libqt5svg5-dev, libgl-dev, + qt6-svg-dev | libqt6svg6-dev | libqt5svg5-dev, + libxkbcommon-dev, libgl-dev, libasound2-dev, libpipewire-0.3-dev -Standards-Version: 3.9.7 +Standards-Version: 4.6.2 +Rules-Requires-Root: no Package: qpwgraph Architecture: any diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/debian/copyright new/qpwgraph-v0.5.3/debian/copyright --- old/qpwgraph-v0.5.1/debian/copyright 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/debian/copyright 2023-09-08 11:02:03.000000000 +0200 @@ -1,33 +1,28 @@ -This package was debianized by Rui Nuno Capela <rn...@rncbc.org> on -Mon, 6 Dec 2021 20:00:00 +0000. - -It was downloaded from https://gitlab.freedesktop.org/rncbc/qpwgraph - -Upstream Author: Rui Nuno Capela <rn...@rncbc.org> - -Copyright: - - Copyright (C) 2021-2023, rncbc aka Rui Nuno Capela. All rights reserved. - -License: - - This program is free software; you can redistribute it and/or - modify it under the terms of the GNU General Public License - as published by the Free Software Foundation; either version 2 - of the License, or (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - - You should have received a copy of the GNU General Public License along - with this program; if not, write to the Free Software Foundation, Inc., - 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - -On Debian systems, the complete text of the GNU General -Public License can be found in `/usr/share/common-licenses/GPL'. - -The Debian packaging is (C) 2021-2023, Rui Nuno Capela <rn...@rncbc.org> and -is licensed under the GPL, see above. - +Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ +Upstream-Name: qpwgraph +Upstream-Contact: Rui Nuno Capela <rn...@rncbc.org> +Source: https://gitlab.freedesktop.org/rncbc/qpwgraph + +Files: * +Copyright: 2021-2023 Rui Nuno Capela <rn...@rncbc.org> +License: GPL-2+ + This package is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or (at + your option) any later version. + . + This package is distributed in the hope that it will be useful, but + WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + General Public License for more details. + . + On Debian systems, the complete text of the GNU General Public + License can be found in /usr/share/common-licenses/GPL-2. + +Files: src/appdata/* +Copyright: 2021-2023 Rui Nuno Capela <rn...@rncbc.org> +License: FSFAP + Copying and distribution of this file, with or without modification, + are permitted in any medium without royalty provided the copyright + notice and this notice are preserved. This file is offered as-is, + without any warranty. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/debian/docs new/qpwgraph-v0.5.3/debian/docs --- old/qpwgraph-v0.5.1/debian/docs 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/debian/docs 2023-09-08 11:02:03.000000000 +0200 @@ -1,3 +1,2 @@ README.md -LICENSE.md ChangeLog diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/docs/qpwgraph_patchbay-user_manual.md new/qpwgraph-v0.5.3/docs/qpwgraph_patchbay-user_manual.md --- old/qpwgraph-v0.5.1/docs/qpwgraph_patchbay-user_manual.md 1970-01-01 01:00:00.000000000 +0100 +++ new/qpwgraph-v0.5.3/docs/qpwgraph_patchbay-user_manual.md 2023-09-08 11:02:03.000000000 +0200 @@ -0,0 +1,31 @@ +# How To Use The Patchbay  + +Once a connection patchbay established, it is possible to store those connections in a patchbay configuration that can be then restored when loaded back. + +## *Activated* button  + +The *Activated* button is simply to activate or not the loaded patchbay. The patchbay must be activated in order to access all the other functionalities. + +If checked, connections stored in the loaded patchbay will be restored. All other connections will stay as they were before the load of the patchbay. If unchecked, no connection change at all. + +## *Exclusive* button  + +The *Exclusive* button goal it to determine if the connections stored in the loaded and activated patchbay will be the only active connections or if previous connections are allowed. + +If checked, connections not stored in the loaded and activated patchbay will be removed. If unchecked, the loaded and activated patchbay will only create the stored connections. + +## *Edit* button  + +If checked, the buttons *Pin* and *Unpin* are available. Those functions are only for connections, so at least one connection (line between an input and an output) has to be selected. + +### *Pin* button  + +Makes the connection persistant in the currently loaded and activated patchbay. + +### *Unpin* button  + +Used to make the connection temporary. The unpinned connection will disappear forever if another patchbay is loaded. + + +--- +Credits: @Lootre (a.k.a. Thomas Lachat). diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/rpm/qpwgraph.spec new/qpwgraph-v0.5.3/rpm/qpwgraph.spec --- old/qpwgraph-v0.5.1/rpm/qpwgraph.spec 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/rpm/qpwgraph.spec 2023-09-08 11:02:03.000000000 +0200 @@ -16,8 +16,8 @@ # %define name qpwgraph -%define version 0.5.1 -%define release 29.1 +%define version 0.5.3 +%define release 31.1 %define _prefix /usr @@ -141,6 +141,10 @@ %changelog +* Fri Sep 8 2023 Rui Nuno Capela <rn...@rncbc.org> 0.5.3 +- An end-of-summer'23 release. +* Sat Aug 5 2023 Rui Nuno Capela <rn...@rncbc.org> 0.5.2 +- A high-summer'23 release. * Mon Jul 17 2023 Rui Nuno Capela <rn...@rncbc.org> 0.5.1 - A summer'23 hot-fix release. * Sun Jul 16 2023 Rui Nuno Capela <rn...@rncbc.org> 0.5.0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/src/appdata/org.rncbc.qpwgraph.metainfo.xml new/qpwgraph-v0.5.3/src/appdata/org.rncbc.qpwgraph.metainfo.xml --- old/qpwgraph-v0.5.1/src/appdata/org.rncbc.qpwgraph.metainfo.xml 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/src/appdata/org.rncbc.qpwgraph.metainfo.xml 2023-09-08 11:02:03.000000000 +0200 @@ -7,9 +7,9 @@ <name>qpwgraph</name> <summary>A PipeWire Graph Qt GUI Interface</summary> <description> - <p>qpwgraph is a graph manager dedicated to PipeWire (https://pipewire.org), - using the Qt C++ framework (https://qt.io), based and pretty much like the - same of QjackCtl (https://qjackctl.sourceforge.io).</p> + <p>qpwgraph is a graph manager dedicated to PipeWire (https\://pipewire.org), + using the Qt C++ framework (https\://qt.io), based and pretty much like the + same of QjackCtl (https\://qjackctl.sourceforge.io).</p> </description> <launchable type="desktop-id">org.rncbc.qpwgraph.desktop</launchable> <provides> @@ -18,11 +18,11 @@ <screenshots> <screenshot type="default"> <image>https://gitlab.freedesktop.org/rncbc/qpwgraph/-/raw/main/src/images/qpwgraph_screenshot-1.png</image> - <caption>The main screenshot showing the application in action</caption> + <caption>The main application window in action</caption> </screenshot> <screenshot> <image>https://gitlab.freedesktop.org/rncbc/qpwgraph/-/raw/main/src/images/qpwgraph.svg</image> - <caption>The official system tray icon showing the application in action</caption> + <caption>The official system tray icon</caption> </screenshot> </screenshots> <keywords> @@ -37,7 +37,7 @@ <developer_name>rncbc aka. Rui Nuno Capela</developer_name> <update_contact>rn...@rncbc.org</update_contact> <releases> - <release version="0.5.1" date="2023-07-17" urgency="low" /> + <release version="0.5.3" date="2023-09-08" urgency="low" /> </releases> <content_rating type="oars-1.0"/> </component> Binary files old/qpwgraph-v0.5.1/src/images/qpwgraph_screenshot-1.png and new/qpwgraph-v0.5.3/src/images/qpwgraph_screenshot-1.png differ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/src/qpwgraph.cpp new/qpwgraph-v0.5.3/src/qpwgraph.cpp --- old/qpwgraph-v0.5.1/src/qpwgraph.cpp 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/src/qpwgraph.cpp 2023-09-08 11:02:03.000000000 +0200 @@ -149,19 +149,13 @@ #if QT_VERSION >= QT_VERSION_CHECK(6, 6, 0) const QNativeIpcKey native_key = QSharedMemory::legacyNativeKey(m_unique); -#endif -#if defined(Q_OS_UNIX) -#if QT_VERSION >= QT_VERSION_CHECK(6, 6, 0) m_memory = new QSharedMemory(native_key); #else +#if defined(Q_OS_UNIX) m_memory = new QSharedMemory(m_unique); -#endif m_memory->attach(); delete m_memory; #endif -#if QT_VERSION >= QT_VERSION_CHECK(6, 6, 0) - m_memory = new QSharedMemory(native_key); -#else m_memory = new QSharedMemory(m_unique); #endif bool is_server = false; @@ -233,8 +227,7 @@ form->apply_args(this); // Just make it always shows up fine... if (m_widget && !m_start_minimized) { - m_widget->hide(); - m_widget->show(); + m_widget->showNormal(); m_widget->raise(); m_widget->activateWindow(); } @@ -255,11 +248,6 @@ #if defined(Q_OS_LINUX) && !defined(CONFIG_WAYLAND) ::setenv("QT_QPA_PLATFORM", "xcb", 0); #endif -#if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0) - QGuiApplication::setHighDpiScaleFactorRoundingPolicy( - Qt::HighDpiScaleFactorRoundingPolicy::RoundPreferFloor); -#endif - qpwgraph_application app(argc, argv); if (!app.parse_args(app.arguments())) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/src/qpwgraph_canvas.cpp new/qpwgraph-v0.5.3/src/qpwgraph_canvas.cpp --- old/qpwgraph-v0.5.1/src/qpwgraph_canvas.cpp 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/src/qpwgraph_canvas.cpp 2023-09-08 11:02:03.000000000 +0200 @@ -612,20 +612,32 @@ m_item = nullptr; m_pos = QGraphicsView::mapToScene(event->pos()); - qpwgraph_item *item = itemAt(m_pos); - if (item && item->type() >= QGraphicsItem::UserType) - m_item = static_cast<qpwgraph_item *> (item); - - if (event->button() == Qt::LeftButton || - event->button() == Qt::MiddleButton) + if (event->button() == Qt::LeftButton) { + m_item = itemAt(m_pos); m_state = DragStart; + } - if (m_state == DragStart && m_item == nullptr + if (m_item == nullptr && (((event->button() == Qt::LeftButton) && (event->modifiers() & Qt::ControlModifier)) || (event->button() == Qt::MiddleButton)) && m_scene->selectedItems().isEmpty()) { - QGraphicsView::setCursor(Qt::ClosedHandCursor); + #if 1//NEW_DRAG_SCROLL_MODE + // HACK: When about to drag-scroll, + // always fake a left-button press... + QGraphicsView::setDragMode(ScrollHandDrag); + QMouseEvent event2(event->type(), + #if QT_VERSION >= QT_VERSION_CHECK(6, 1, 0) + event->position(), event->globalPosition(), + #else + event->localPos(), event->globalPos(), + #endif + Qt::LeftButton, Qt::LeftButton, + event->modifiers() | Qt::ControlModifier); + QGraphicsView::mousePressEvent(&event2); + #else + QGraphicsView::setCursor(Qt::ClosedHandCursor) + #endif m_state = DragScroll; } } @@ -774,12 +786,16 @@ } break; case DragScroll: { + #if 1//NEW_DRAG_SCROLL_MODE + QGraphicsView::mouseMoveEvent(event); + #else QScrollBar *hbar = QGraphicsView::horizontalScrollBar(); QScrollBar *vbar = QGraphicsView::verticalScrollBar(); const QPoint delta = (pos - m_pos).toPoint(); hbar->setValue(hbar->value() - delta.x()); vbar->setValue(vbar->value() - delta.y()); m_pos = pos; + #endif break; } default: @@ -893,6 +909,12 @@ break; } +#if 1//NEW_DRAG_SCROLL_MODE + if (QGraphicsView::dragMode() == ScrollHandDrag) { + QGraphicsView::mouseReleaseEvent(event); + QGraphicsView::setDragMode(NoDrag); + } +#endif m_state = DragNone; m_item = nullptr; @@ -1406,7 +1428,7 @@ m_settings->setValue('/' + node_key, node->pos()); m_settings->endGroup(); m_settings->beginGroup(NodeAliasesGroup); - if (node->nodeName() != node->nodeTitle()) + if (node->nodeNameLabel() != node->nodeTitle()) m_settings->setValue('/' + node_key, node->nodeTitle()); else m_settings->remove('/' + node_key); @@ -1420,7 +1442,7 @@ if (port) { const QString& port_key = portKey(port); m_settings->beginGroup(PortAliasesGroup); - if (port && port->portName() != port->portTitle()) + if (port && port->portNameLabel() != port->portTitle()) m_settings->setValue('/' + port_key, port->portTitle()); else m_settings->remove('/' + port_key); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/src/qpwgraph_canvas.h new/qpwgraph-v0.5.3/src/qpwgraph_canvas.h --- old/qpwgraph-v0.5.1/src/qpwgraph_canvas.h 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/src/qpwgraph_canvas.h 2023-09-08 11:02:03.000000000 +0200 @@ -50,7 +50,7 @@ // Define if cleanup of legacy node names is needed (v0.5.0)... -#define CONFIG_CLEANUP_NODE_NAMES 1 +#undef CONFIG_CLEANUP_NODE_NAMES //---------------------------------------------------------------------------- diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/src/qpwgraph_form.ui new/qpwgraph-v0.5.3/src/qpwgraph_form.ui --- old/qpwgraph-v0.5.1/src/qpwgraph_form.ui 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/src/qpwgraph_form.ui 2023-09-08 11:02:03.000000000 +0200 @@ -495,7 +495,7 @@ <string>Quit this application program</string> </property> <property name="shortcut"> - <string/> + <string>Ctrl+Q</string> </property> </action> <action name="editSelectAllAction"> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qpwgraph-v0.5.1/src/qpwgraph_port.cpp new/qpwgraph-v0.5.3/src/qpwgraph_port.cpp --- old/qpwgraph-v0.5.1/src/qpwgraph_port.cpp 2023-07-17 11:59:55.000000000 +0200 +++ new/qpwgraph-v0.5.3/src/qpwgraph_port.cpp 2023-09-08 11:02:03.000000000 +0200 @@ -168,9 +168,10 @@ void qpwgraph_port::setPortTitle ( const QString& title ) { - QGraphicsPathItem::setToolTip(portNameLabel()); + const QString& name_label = portNameLabel(); + QGraphicsPathItem::setToolTip(name_label); - m_title = (title.isEmpty() ? m_name : title); + m_title = (title.isEmpty() ? name_label : title); static const int MAX_TITLE_LENGTH = 29; static const QString ellipsis(3, '.');
