Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package pappl for openSUSE:Factory checked in at 2023-11-16 20:28:23 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/pappl (Old) and /work/SRC/openSUSE:Factory/.pappl.new.2521 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "pappl" Thu Nov 16 20:28:23 2023 rev:5 rq:1126726 version:1.4.3 Changes: -------- --- /work/SRC/openSUSE:Factory/pappl/pappl.changes 2023-10-17 20:25:13.139745475 +0200 +++ /work/SRC/openSUSE:Factory/.pappl.new.2521/pappl.changes 2023-11-16 20:28:28.828189874 +0100 @@ -1,0 +2,9 @@ +Wed Nov 15 16:59:04 UTC 2023 - Jan Engelhardt <jeng...@inai.de> + +- Update to release 1.4.3 + * Added "smi55357-device-uri" and "smi55357-driver" Printer + Status attributes to Get-Printer-Attributes responses + * Fixed missing mutex unlock in DNS-SD code + * Fixed DNS-SD device list crash + +------------------------------------------------------------------- Old: ---- pappl-1.4.2.tar.gz pappl-1.4.2.tar.gz.sig New: ---- pappl-1.4.3.tar.gz pappl-1.4.3.tar.gz.sig ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ pappl.spec ++++++ --- /var/tmp/diff_new_pack.GKkwYE/_old 2023-11-16 20:28:29.412211407 +0100 +++ /var/tmp/diff_new_pack.GKkwYE/_new 2023-11-16 20:28:29.412211407 +0100 @@ -18,7 +18,7 @@ Name: pappl %define lname libpappl1 -Version: 1.4.2 +Version: 1.4.3 Release: 0 Summary: A printer application framework License: Apache-2.0 ++++++ pappl-1.4.2.tar.gz -> pappl-1.4.3.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/pappl-1.4.2/CHANGES.md new/pappl-1.4.3/CHANGES.md --- old/pappl-1.4.2/CHANGES.md 2023-10-16 16:53:14.000000000 +0200 +++ new/pappl-1.4.3/CHANGES.md 2023-11-15 16:41:09.000000000 +0100 @@ -2,6 +2,19 @@ ================ +Changes in v1.4.3 +----------------- + +- Added "smi55357-device-uri" and "smi55357-driver" Printer Status attributes + to Get-Printer-Attributes responses. +- Fixed missing mutex unlock in DNS-SD code (Issue #299) +- Fixed "printer-id" value for new printers (Issue #301) +- Fixed DNS-SD device list crash (Issue #302) +- Fixed Set-Printer-Attributes for "output-bin-default" and "sides-default" + (Issue #305) +- Fixed default "copies" value with `papplJobCreateWithFile`. + + Changes in v1.4.2 ----------------- diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/pappl-1.4.2/configure new/pappl-1.4.3/configure --- old/pappl-1.4.2/configure 2023-10-16 16:53:14.000000000 +0200 +++ new/pappl-1.4.3/configure 2023-11-15 16:41:09.000000000 +0100 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.71 for pappl 1.4.2. +# Generated by GNU Autoconf 2.71 for pappl 1.4.3. # # Report bugs to <https://github.com/michaelrsweet/pappl/issues>. # @@ -610,8 +610,8 @@ # Identity of this package. PACKAGE_NAME='pappl' PACKAGE_TARNAME='pappl' -PACKAGE_VERSION='1.4.2' -PACKAGE_STRING='pappl 1.4.2' +PACKAGE_VERSION='1.4.3' +PACKAGE_STRING='pappl 1.4.3' PACKAGE_BUGREPORT='https://github.com/michaelrsweet/pappl/issues' PACKAGE_URL='https://www.msweet.org/pappl' @@ -1310,7 +1310,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures pappl 1.4.2 to adapt to many kinds of systems. +\`configure' configures pappl 1.4.3 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1376,7 +1376,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of pappl 1.4.2:";; + short | recursive ) echo "Configuration of pappl 1.4.3:";; esac cat <<\_ACEOF @@ -1485,7 +1485,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -pappl configure 1.4.2 +pappl configure 1.4.3 generated by GNU Autoconf 2.71 Copyright (C) 2021 Free Software Foundation, Inc. @@ -1703,7 +1703,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by pappl $as_me 1.4.2, which was +It was created by pappl $as_me 1.4.3, which was generated by GNU Autoconf 2.71. Invocation command line was $ $0$ac_configure_args_raw @@ -2461,9 +2461,9 @@ ac_config_headers="$ac_config_headers config.h" -PAPPL_VERSION="1.4.2" -PAPPL_VERSION_MAJOR="`echo 1.4.2 | awk -F. '{print $1}'`" -PAPPL_VERSION_MINOR="`echo 1.4.2 | awk -F. '{printf("%d\n",$2);}'`" +PAPPL_VERSION="1.4.3" +PAPPL_VERSION_MAJOR="`echo 1.4.3 | awk -F. '{print $1}'`" +PAPPL_VERSION_MINOR="`echo 1.4.3 | awk -F. '{printf("%d\n",$2);}'`" @@ -5962,7 +5962,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by pappl $as_me 1.4.2, which was +This file was extended by pappl $as_me 1.4.3, which was generated by GNU Autoconf 2.71. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -6027,7 +6027,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config='$ac_cs_config_escaped' ac_cs_version="\\ -pappl config.status 1.4.2 +pappl config.status 1.4.3 configured by $0, generated by GNU Autoconf 2.71, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/pappl-1.4.2/configure.ac new/pappl-1.4.3/configure.ac --- old/pappl-1.4.2/configure.ac 2023-10-16 16:53:14.000000000 +0200 +++ new/pappl-1.4.3/configure.ac 2023-11-15 16:41:09.000000000 +0100 @@ -21,7 +21,7 @@ dnl Package name and version... -AC_INIT([pappl], [1.4.2], [https://github.com/michaelrsweet/pappl/issues], [pappl], [https://www.msweet.org/pappl]) +AC_INIT([pappl], [1.4.3], [https://github.com/michaelrsweet/pappl/issues], [pappl], [https://www.msweet.org/pappl]) AC_CONFIG_HEADERS([config.h]) PAPPL_VERSION="AC_PACKAGE_VERSION" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/pappl-1.4.2/pappl/device-network.c new/pappl-1.4.3/pappl/device-network.c --- old/pappl-1.4.2/pappl/device-network.c 2023-10-16 16:53:14.000000000 +0200 +++ new/pappl-1.4.3/pappl/device-network.c 2023-11-15 16:41:09.000000000 +0100 @@ -8,10 +8,6 @@ // information. // -// -// Include necessary headers... -// - #include "device-private.h" #include "dnssd-private.h" #include "snmp-private.h" @@ -315,6 +311,20 @@ free(d->device_id); free(d->uuid); pthread_mutex_destroy(&d->mutex); + +#ifdef HAVE_MDNSRESPONDER + if (d->ref) + DNSServiceRefDeallocate(d->ref); + +#elif defined(HAVE_AVAHI) + if (d->ref) + { + _papplDNSSDLock(); + avahi_record_browser_free(d->ref); + _papplDNSSDUnlock(); + } +#endif // HAVE_MDNSRESPONDER + free(d); } @@ -450,6 +460,7 @@ { _papplDeviceError(err_cb, err_data, "Unable to create service browser: %s (%d).", _papplDNSSDStrError(error), error); cupsArrayDelete(devices); + _papplDNSSDUnlock(); return (ret); } @@ -460,6 +471,7 @@ { _papplDeviceError(err_cb, err_data, "Unable to create service browser."); cupsArrayDelete(devices); + _papplDNSSDUnlock(); return (ret); } # endif // HAVE_MDNSRESPONDER diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/pappl-1.4.2/pappl/job.c new/pappl-1.4.3/pappl/job.c --- old/pappl-1.4.2/pappl/job.c 2023-10-16 16:53:14.000000000 +0200 +++ new/pappl-1.4.3/pappl/job.c 2023-11-15 16:41:09.000000000 +0100 @@ -105,6 +105,7 @@ job->state = IPP_JSTATE_HELD; job->system = printer->system; job->created = time(NULL); + job->copies = 1; if (attrs) { @@ -122,8 +123,6 @@ if ((attr = ippFindAttribute(job->attrs, "copies", IPP_TAG_INTEGER)) != NULL) job->copies = ippGetInteger(attr, 0); - else - job->copies = 1; hold_until = ippGetString(ippFindAttribute(attrs, "job-hold-until", IPP_TAG_KEYWORD), 0, NULL); hold_until_time = ippDateToTime(ippGetDate(ippFindAttribute(attrs, "job-hold-until-time", IPP_TAG_DATE), 0)); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/pappl-1.4.2/pappl/printer-ipp.c new/pappl-1.4.3/pappl/printer-ipp.c --- old/pappl-1.4.2/pappl/printer-ipp.c 2023-10-16 16:53:14.000000000 +0200 +++ new/pappl-1.4.3/pappl/printer-ipp.c 2023-11-15 16:41:09.000000000 +0100 @@ -970,6 +970,7 @@ { "media-default", IPP_TAG_KEYWORD, 1 }, { "media-ready", IPP_TAG_KEYWORD, PAPPL_MAX_SOURCE }, { "orientation-requested-default", IPP_TAG_ENUM, 1 }, + { "output-bin-default", IPP_TAG_KEYWORD, 1 }, { "print-color-mode-default", IPP_TAG_KEYWORD, 1 }, { "print-content-optimize-default", IPP_TAG_KEYWORD, 1 }, { "print-darkness-default", IPP_TAG_INTEGER, 1 }, @@ -983,7 +984,8 @@ { "printer-organizational-unit", IPP_TAG_TEXT, 1 }, { "printer-resolution-default", IPP_TAG_RESOLUTION, 1 }, { "printer-wifi-password", IPP_TAG_STRING, 1 }, - { "printer-wifi-ssid", IPP_TAG_NAME, 1 } + { "printer-wifi-ssid", IPP_TAG_NAME, 1 }, + { "sides-default", IPP_TAG_KEYWORD, 1 } }; @@ -1119,6 +1121,25 @@ driver_data.orient_default = (ipp_orient_t)ippGetInteger(rattr, 0); do_defaults = true; } + else if (!strcmp(name, "output-bin-default")) + { + const char *keyword = ippGetString(rattr, 0, NULL); + // Keyword value + + for (i = 0; i < driver_data.num_bin; i ++) + { + if (!strcmp(keyword, driver_data.bin[i])) + { + driver_data.bin_default = i; + break; + } + } + + if (i >= driver_data.num_bin) + papplClientRespondIPP(client, IPP_STATUS_ERROR_ATTRIBUTES_OR_VALUES, "Unsupported \"output-bin-default\" value '%s'.", keyword); + else + do_defaults = true; + } else if (!strcmp(name, "print-color-mode-default")) { driver_data.color_default = _papplColorModeValue(ippGetString(rattr, 0, NULL)); @@ -1208,6 +1229,21 @@ papplCopyString(wifi_ssid, ippGetString(rattr, 0, NULL), sizeof(wifi_ssid)); do_wifi = true; } + else if (!strcmp(name, "sides-default")) + { + pappl_sides_t sides_default = _papplSidesValue(ippGetString(rattr, 0, NULL)); + // Sides value + + if (!sides_default || !(driver_data.sides_supported & sides_default)) + { + papplClientRespondIPP(client, IPP_STATUS_ERROR_ATTRIBUTES_OR_VALUES, "Unsupported \"sides-default\" value '%s'.", ippGetString(rattr, 0, NULL)); + } + else + { + driver_data.sides_default = sides_default; + do_defaults = true; + } + } } if (ippGetStatusCode(client->response) != IPP_STATUS_OK) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/pappl-1.4.2/pappl/printer.c new/pappl-1.4.3/pappl/printer.c --- old/pappl-1.4.2/pappl/printer.c 2023-10-16 16:53:14.000000000 +0200 +++ new/pappl-1.4.3/pappl/printer.c 2023-11-15 16:41:09.000000000 +0100 @@ -525,9 +525,6 @@ // printer-get-attributes-supported ippAddString(printer->attrs, IPP_TAG_PRINTER, IPP_CONST_TAG(IPP_TAG_KEYWORD), "printer-get-attributes-supported", NULL, "document-format"); - // printer-id - ippAddInteger(printer->attrs, IPP_TAG_PRINTER, IPP_TAG_INTEGER, "printer-id", printer_id); - // printer-info ippAddString(printer->attrs, IPP_TAG_PRINTER, IPP_TAG_TEXT, "printer-info", NULL, printer_name); @@ -540,6 +537,12 @@ // requesting-user-uri-supported ippAddBoolean(printer->attrs, IPP_TAG_PRINTER, "requesting-user-uri-supported", 1); + // smi55357-device-uri + ippAddString(printer->attrs, IPP_TAG_PRINTER, IPP_TAG_URI, "smi55357-device-uri", NULL, printer->device_uri); + + // smi55357-driver + ippAddString(printer->attrs, IPP_TAG_PRINTER, IPP_TAG_KEYWORD, "smi55357-driver", NULL, printer->driver_name); + // uri-security-supported if (system->options & PAPPL_SOPTIONS_NO_TLS) ippAddString(printer->attrs, IPP_TAG_PRINTER, IPP_CONST_TAG(IPP_TAG_KEYWORD), "uri-security-supported", NULL, "none"); @@ -568,6 +571,11 @@ // Add the printer to the system... _papplSystemAddPrinter(system, printer, printer_id); + // printer-id + _papplRWLockWrite(printer); + ippAddInteger(printer->attrs, IPP_TAG_PRINTER, IPP_TAG_INTEGER, "printer-id", printer->printer_id); + _papplRWUnlock(printer); + // Do any post-creation work... if (system->create_cb) (system->create_cb)(printer, system->driver_cbdata); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/pappl-1.4.2/testsuite/testpappl.c new/pappl-1.4.3/testsuite/testpappl.c --- old/pappl-1.4.2/testsuite/testpappl.c 2023-10-16 16:53:14.000000000 +0200 +++ new/pappl-1.4.3/testsuite/testpappl.c 2023-11-15 16:41:09.000000000 +0100 @@ -226,7 +226,7 @@ }; static pappl_version_t versions[1] = // Software versions { - { "Test System", "", "1.3 build 42", { 1, 3, 0, 42 } } + { "Test System", "", "1.4 build 42", { 1, 4, 0, 42 } } }; @@ -2157,9 +2157,9 @@ testEndMessage(false, "got %d versions, expected 1", get_nvers); pass = false; } - else if (strcmp(get_vers[0].name, "Test System") || strcmp(get_vers[0].sversion, "1.3 build 42")) + else if (strcmp(get_vers[0].name, "Test System") || strcmp(get_vers[0].sversion, "1.4 build 42")) { - testEndMessage(false, "got '%s v%s', expected 'Test System v1.3 build 42'", get_vers[0].name, get_vers[0].sversion); + testEndMessage(false, "got '%s v%s', expected 'Test System v1.4 build 42'", get_vers[0].name, get_vers[0].sversion); pass = false; } else diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/pappl-1.4.2/vcnet/config.h new/pappl-1.4.3/vcnet/config.h --- old/pappl-1.4.2/vcnet/config.h 2023-10-16 16:53:14.000000000 +0200 +++ new/pappl-1.4.3/vcnet/config.h 2023-11-15 16:41:09.000000000 +0100 @@ -107,7 +107,7 @@ // Version numbers -#define PAPPL_VERSION "1.4.2" +#define PAPPL_VERSION "1.4.3" #define PAPPL_VERSION_MAJOR 1 #define PAPPL_VERSION_MINOR 4 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/pappl-1.4.2/vcnet/libpappl1_native.nuspec new/pappl-1.4.3/vcnet/libpappl1_native.nuspec --- old/pappl-1.4.2/vcnet/libpappl1_native.nuspec 2023-10-16 16:53:14.000000000 +0200 +++ new/pappl-1.4.3/vcnet/libpappl1_native.nuspec 2023-11-15 16:41:09.000000000 +0100 @@ -3,7 +3,7 @@ <metadata> <id>libpappl1_native</id> <title>Printer Application Framework (PAPPL) for VS2019+</title> - <version>1.4.2.0</version> + <version>1.4.3.0</version> <authors>Michael R Sweet</authors> <owners>michaelrsweet</owners> <projectUrl>https://github.com/michaelrsweet/pappl</projectUrl> @@ -18,7 +18,7 @@ <tags>airprint everywhere http ipp mopria native</tags> <dependencies> <dependency id="libcups2_native" version="2.4.7" /> - <dependency id="libpappl1_native.redist" version="1.4.2.0" /> + <dependency id="libpappl1_native.redist" version="1.4.3.0" /> </dependencies> </metadata> <files> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/pappl-1.4.2/vcnet/libpappl1_native.redist.nuspec new/pappl-1.4.3/vcnet/libpappl1_native.redist.nuspec --- old/pappl-1.4.2/vcnet/libpappl1_native.redist.nuspec 2023-10-16 16:53:14.000000000 +0200 +++ new/pappl-1.4.3/vcnet/libpappl1_native.redist.nuspec 2023-11-15 16:41:09.000000000 +0100 @@ -3,7 +3,7 @@ <metadata> <id>libpappl1_native.redist</id> <title>Printer Application Framework (PAPPL) for VS2019+ Redist</title> - <version>1.4.2.0</version> + <version>1.4.3.0</version> <authors>Michael R Sweet</authors> <owners>michaelrsweet</owners> <projectUrl>https://github.com/michaelrsweet/pappl</projectUrl> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/pappl-1.4.2/xcode/config.h new/pappl-1.4.3/xcode/config.h --- old/pappl-1.4.2/xcode/config.h 2023-10-16 16:53:14.000000000 +0200 +++ new/pappl-1.4.3/xcode/config.h 2023-11-15 16:41:09.000000000 +0100 @@ -8,7 +8,7 @@ // // Version numbers -#define PAPPL_VERSION "1.4.2" +#define PAPPL_VERSION "1.4.3" #define PAPPL_VERSION_MAJOR 1 #define PAPPL_VERSION_MINOR 4
